GNU bug report logs - #30096
Update ocaml-findlib; Add ocaml-tsdl and dependencies

Previous Next

Full log

Message #50 received at 30096 <at> debbugs.gnu.org (full text, mbox):

From: Peter Kreye <kreyepr <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 30096 <at> debbugs.gnu.org
Subject: Re: [bug#30096] [PATCH 2/6] gnu: Add ocaml-integers.
Date: Thu, 18 Jan 2018 23:32:48 -0600

[Message part 1 (text/plain, inline)]

Julien,

Thank you for all of the feedback, it is much appreciated.

Julien Lepiller writes:

> Actually, I forgot to ask, why disable tests?
>
> That's the same question for the rest of your patches too.

This package doesn't have any tests, which seems to be causing the 'check
phase to fail. Would it be better to use "#:tests? #f" or to delete the
'check phase?

> You don't need to replace the 'build phase. ocaml-build-system can find
> pkg/pkg.ml. You just need to use #:build-flags (list "build") to add
> arguments.
>
> That applies also to the rest of your patches.

Thank you for this info. I'll make sure to do this from now on.

> It's probably better to use "#:findlib ,ocaml-findlib-1.7.3" in the
> arguments list.

Same.

--

[0001-gnu-Add-ocaml-integers.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.