Subject: [bug#30096] [PATCH 5/6] gnu: Add ocaml-tsdl.

From: Julien Lepiller <[email-masked]>
Date: Sat, 13 Jan 2018 14:16:43 +0100

Le Sat, 13 Jan 2018 05:26:37 -0600,
Peter Kreye <[email-masked]> a écrit :

> * gnu/packages/ocaml.scm (ocaml-tsdl): New variable.
> ---
>  gnu/packages/ocaml.scm | 44
> +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43
> insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
> index a60922c02..34458be28 100644
> --- a/gnu/packages/ocaml.scm
> +++ b/gnu/packages/ocaml.scm
> @@ -52,6 +52,7 @@
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages protobuf)
>    #:use-module (gnu packages python)
> +  #:use-module (gnu packages sdl)
>    #:use-module (gnu packages tex)
>    #:use-module (gnu packages texinfo)
>    #:use-module (gnu packages time)
> @@ -3842,14 +3843,55 @@ without writing or generating any C!")
>     (inputs
>      `(("findlib" ,ocaml-findlib-1.7.3)
>        ("topkg" ,ocaml-topkg)
> -      ("astring" ,ocaml-astring)
>        ("opam", opam)))
> +   (propagated-inputs
> +    `(("astring" ,ocaml-astring)))
This needs to be in the commit message.

>     (synopsis "OCamlbuild plugin for C stubs")
>     (description "Ocb-stubblr is about ten lines of code that you
> need to repeat over, over, over and over again if you are using
> ocamlbuild to build OCaml projects that contain C stubs.")
>     (license license:isc)))
>  
> +(define-public ocaml-tsdl
> +  (package
> +    (name "ocaml-tsdl")
> +    (version "0.9.1")
> +    (home-page "http://erratique.ch/software/tsdl")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append home-page "/releases/tsdl-"
> +                                  version ".tbz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "08bb97fhvz829fb0sgjn2p20mp7b04v98zy2qxpk2w390a6c4b34"))))
> +    (build-system ocaml-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (replace 'build
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((libdir (string-append (assoc-ref %build-inputs
> "findlib")
> +                                          "/lib/ocaml/site-lib")))
> +
> +               (zero? (system* "ocaml" "-I" libdir "pkg/pkg.ml"
> "build" "--tests" "false")))))
Don't replace the 'build phase and delete 'check: you just need
#:build-flags (list "build") and #:tests? #f. I don't think you need to
disable test building. Why not run tests?

> +         (delete 'check))))
> +    (native-inputs
> +     `(("opam" ,opam)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("findlib" ,ocaml-findlib-1.7.3)
> +       ("topkg" ,ocaml-topkg)
> +       ("result" ,ocaml-result)
> +       ("sdl2" ,sdl2)
> +       ("integers" ,ocaml-integers)
> +       ("ctypes" ,ocaml-ctypes)))
> +    (synopsis "Thin bindings to SDL for OCaml")
> +    (description "Tsdl is an OCaml library providing thin bindings
> to the +cross-platform SDL C library.")
The description has a line that's too long

> +    (license license:isc)))
> +
>  (define-public coq-flocq
>    (package
>      (name "coq-flocq")