Subject: Re: [bug#30096] [PATCH 2/6] gnu: Add ocaml-integers.

From: Julien Lepiller <[email-masked]>
Date: Sat, 13 Jan 2018 14:08:45 +0100

Le Sat, 13 Jan 2018 05:14:55 -0600,
Peter Kreye <[email-masked]> a écrit :

> User-agent: mu4e 0.9.18; emacs 25.3.1
> 
> * gnu/packages/ocaml.scm (ocaml-integes): New variable.
> ---
>  gnu/packages/ocaml.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
> index e70316cd7..61398d3f2 100644
> --- a/gnu/packages/ocaml.scm
> +++ b/gnu/packages/ocaml.scm
> @@ -3739,6 +3739,42 @@ terminal or in Emacs.  It supports line
> editing, history, real-time and context sensitive completion, colors,
> and more.") (license license:bsd-3)))
>  
> +(define-public ocaml-integers
> +  (package
> +    (name "ocaml-integers")
> +    (version "0.2.2")
> +    (home-page "https://github.com/ocamllabs/ocaml-integers")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append home-page
> +
> "/releases/download/v0.2.2/integers-"
> +                                  version ".tbz"))
> +              (file-name (string-append name "-" version ".tbz"))
> +              (sha256
> +               (base32
> +
> "08b1ljw88ny3l0mdq6xmffjk8anfc77igryva5jz1p6f4f746ywk"))))
> +    (build-system ocaml-build-system)
> +    (arguments
> +     `(#:tests? #f
Actually, I forgot to ask, why disable tests?

That's the same question for the rest of your patches too.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (replace 'build
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((libdir (string-append
> +                            (assoc-ref %build-inputs "findlib")
> +                            "/lib/ocaml/site-lib")))
> +               (zero? (system* "ocaml" "-I" libdir "pkg/pkg.ml"
> "build"))))))))
You don't need to replace the 'build phase. ocaml-build-system can find
pkg/pkg.ml. You just need to use #:build-flags (list "build") to add
arguments.

That applies also to the rest of your patches.

> +    (inputs
> +     `(("findlib" ,ocaml-findlib-1.7.3)
> +       ("topkg" ,ocaml-topkg)
> +       ("opam", opam)))
> +    (synopsis "Various signed and unsigned integer types for OCaml")
> +    (description "The ocaml-integers library provides a number of
> 8-, 16-, 32- +and 64-bit signed and unsigned integer types, together
> with aliases such as +long and size_t whose sizes depend on the host
> platform.")
> +    (license license:expat)))
> +
>  (define-public coq-flocq
>    (package
>      (name "coq-flocq")