GNU bug report logs - #30079
26.0.90; comint commands killing pending input

Previous Next

Package: emacs;

Reported by: charles <at> aurox.ch (Charles A. Roelli)

Date: Thu, 11 Jan 2018 20:32:02 UTC

Severity: normal

Found in version 26.0.90

Done: charles <at> aurox.ch (Charles A. Roelli)

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: charles <at> aurox.ch (Charles A. Roelli)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#30079: closed (26.0.90; comint commands killing pending input)
Date: Mon, 15 Jan 2018 20:16:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 15 Jan 2018 21:21:37 +0100
with message-id <m2fu76dga6.fsf <at> aurox.ch>
and subject line Re: bug#30079: 26.0.90; comint commands killing pending input
has caused the debbugs.gnu.org bug report #30079,
regarding 26.0.90; comint commands killing pending input
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
30079: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30079
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: charles <at> aurox.ch (Charles A. Roelli)
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90; comint commands killing pending input
Date: Thu, 11 Jan 2018 21:37:07 +0100
The following four commands all claim to "kill the pending input",
which they don't actually seem to do.  Should the documentation or
implementation be changed?


(defun comint-interrupt-subjob ()
  "Interrupt the current subjob.
This command also kills the pending input
between the process mark and point."
  (interactive)
  (comint-skip-input)
  (interrupt-process nil comint-ptyp)
  ;; (process-send-string nil "\n")
  )

(defun comint-kill-subjob ()
  "Send kill signal to the current subjob.
This command also kills the pending input
between the process mark and point."
  (interactive)
  (comint-skip-input)
  (kill-process nil comint-ptyp))

(defun comint-quit-subjob ()
  "Send quit signal to the current subjob.
This command also kills the pending input
between the process mark and point."
  (interactive)
  (comint-skip-input)
  (quit-process nil comint-ptyp))

(defun comint-stop-subjob ()
  "Stop the current subjob.
This command also kills the pending input
between the process mark and point.

WARNING: if there is no current subjob, you can end up suspending
the top-level process running in the buffer.  If you accidentally do
this, use \\[comint-continue-subjob] to resume the process.  (This
is not a problem with most shells, since they ignore this signal.)"
  (interactive)
  (comint-skip-input)
  (stop-process nil comint-ptyp))


[Message part 3 (message/rfc822, inline)]
From: charles <at> aurox.ch (Charles A. Roelli)
To: 30079-done <at> debbugs.gnu.org
Subject: Re: bug#30079: 26.0.90; comint commands killing pending input
Date: Mon, 15 Jan 2018 21:21:37 +0100
> Date: Thu, 11 Jan 2018 21:37:07 +0100
> From: charles <at> aurox.ch (Charles A. Roelli)
> 
> The following four commands all claim to "kill the pending input",
> which they don't actually seem to do.  Should the documentation or
> implementation be changed?
> 
> 
> (defun comint-interrupt-subjob ()
>   "Interrupt the current subjob.
> This command also kills the pending input
> between the process mark and point."
>   (interactive)
>   (comint-skip-input)
>   (interrupt-process nil comint-ptyp)
>   ;; (process-send-string nil "\n")
>   )
> 
> (defun comint-kill-subjob ()
>   "Send kill signal to the current subjob.
> This command also kills the pending input
> between the process mark and point."
>   (interactive)
>   (comint-skip-input)
>   (kill-process nil comint-ptyp))
> 
> (defun comint-quit-subjob ()
>   "Send quit signal to the current subjob.
> This command also kills the pending input
> between the process mark and point."
>   (interactive)
>   (comint-skip-input)
>   (quit-process nil comint-ptyp))
> 
> (defun comint-stop-subjob ()
>   "Stop the current subjob.
> This command also kills the pending input
> between the process mark and point.
> 
> WARNING: if there is no current subjob, you can end up suspending
> the top-level process running in the buffer.  If you accidentally do
> this, use \\[comint-continue-subjob] to resume the process.  (This
> is not a problem with most shells, since they ignore this signal.)"
>   (interactive)
>   (comint-skip-input)
>   (stop-process nil comint-ptyp))

I pushed a documentation fix to emacs-26:

  commit 98e5fb9bf3b49bea82a4d3e38be20415bd7f7684
  Author: Charles A. Roelli <charles <at> aurox.ch>
  Date:   Mon Jan 15 21:14:05 2018 +0100

    Remove incorrect documentation in comint.el

    * lisp/comint.el (comint-interrupt-subjob, comint-kill-subjob)
    (comint-quit-subjob, comint-stop-subjob): Remove incorrect
    documentation.  (Bug#30079)

If there's any interest in reinstating the old, documented (but
unimplemented) behavior in the master branch, please reopen.


This bug report was last modified 7 years and 179 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.