From unknown Sun Jun 22 03:57:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2018 13:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30063@debbugs.gnu.org, stefan@merten-home.de X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, stefan@merten-home.de Received: via spool by submit@debbugs.gnu.org id=B.151559266227380 (code B ref -1); Wed, 10 Jan 2018 13:58:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Jan 2018 13:57:42 +0000 Received: from localhost ([127.0.0.1]:50361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZGsw-00077Y-0c for submit@debbugs.gnu.org; Wed, 10 Jan 2018 08:57:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZGst-00077I-V3 for submit@debbugs.gnu.org; Wed, 10 Jan 2018 08:57:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZGsl-0004At-OY for submit@debbugs.gnu.org; Wed, 10 Jan 2018 08:57:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37063) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eZGsl-0004Ah-LQ for submit@debbugs.gnu.org; Wed, 10 Jan 2018 08:57:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZGsf-0007OQ-Ty for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2018 08:57:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZGsc-00045T-R1 for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2018 08:57:26 -0500 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:36375) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZGsc-00044W-Ip for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2018 08:57:22 -0500 Received: by mail-lf0-x22d.google.com with SMTP id e203so5165225lfg.3 for ; Wed, 10 Jan 2018 05:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=pOhxMw3fZfjBnRhn2OGwdqk97BvW2c2PR6PYObNFlqM=; b=mIb68TvHr1hPbliYKtNOE9e+lbvzGk63PLRFZoP2uXn5o1ww6CwF6YuhuHmtBrQlWZ 3HGnF9wywO9CiBtkgeFeP/GZjqdCPowAkOYS2lzXZ/od2Amy8VqkSauBIBEXM3JCysr1 1OJS/ImVd9lfDdO11SGpopKqSlbtjjrzWGzJuMPhJjCEl08LPlvEMjytS5ZYzGxpG2eZ sA+caOn84Gu/1i2tNyxAnA6lu/bCfOtVgUr2uCcFHkgTXGKsyEP6YBRXxR81jTBXF+Fa dXZrDB/jH7hHePT0QFC8SaK2zpKioyUz43Ee7V90FRnxTatXJRZnZ4OSKGhGxFjPbl2x vMyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=pOhxMw3fZfjBnRhn2OGwdqk97BvW2c2PR6PYObNFlqM=; b=DR4FWyltn9kXNPqvf7eJmVVLDwxe1PkxAhc5QpzDPt86VlIvsuBb0m5FehKm36s99e HXbiItYzXWVcPbIANhGKIaWwrxt9iEGUa67HD5UgacLt4NNm5cbMjQuT1JoOpz5GsyYg VWdB5OVl2FicMOevMe1bipjP1+lnc5mCZzGcBgCm02FjVVukJ6ME+qOigxudlc6TcJxe KR1SCc0GU4jZdXLbOrEP0ggbY+e6WKGmYxmioFwMrEebwLp96hD/8Eyo9jTqSAcu1QCJ q1A99SK4TGEy9pmTUvTo3FMAfZEvo11ainN2mSsJX2UGg9Sh+U201WF4oZw8x3eLqS75 i0NQ== X-Gm-Message-State: AKGB3mLiJqjrcYTw23tQctatzm6O4FZhYKg8AMQoG+vsFd5Umxr1SyaH zrHK5pfpBJR4sRK4mOX5PkEhEA== X-Google-Smtp-Source: ACJfBovdsCaOv5poqCXoY/X0BfMrYgQY/YKz7RIap2MlpKLFNMP39bwaH2quy6QTgXcYccIJ3fPf4w== X-Received: by 10.46.36.15 with SMTP id k15mr11507720ljk.34.1515592641056; Wed, 10 Jan 2018 05:57:21 -0800 (PST) Received: from x240 ([77.40.215.202]) by smtp.gmail.com with ESMTPSA id h71sm953315lfi.91.2018.01.10.05.57.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Jan 2018 05:57:19 -0800 (PST) From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Date: Wed, 10 Jan 2018 14:57:18 +0100 Message-ID: <87o9m14y0x.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) If either of the `xpdf' or `rst2pdf' programs are missing, `rst-compile-pdf-preview' fails without leaving any message. It would be useful if the command informed the user what's stopping it from working. -- Simen From unknown Sun Jun 22 03:57:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jan 2018 12:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30063@debbugs.gnu.org, stefan@merten-home.de Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.151705440617101 (code B ref 30063); Sat, 27 Jan 2018 12:01:01 +0000 Received: (at 30063) by debbugs.gnu.org; 27 Jan 2018 12:00:06 +0000 Received: from localhost ([127.0.0.1]:44418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efP9S-0004RG-B0 for submit@debbugs.gnu.org; Sat, 27 Jan 2018 07:00:06 -0500 Received: from mail-lf0-f52.google.com ([209.85.215.52]:36266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efP9Q-0004Q0-Rl for 30063@debbugs.gnu.org; Sat, 27 Jan 2018 07:00:05 -0500 Received: by mail-lf0-f52.google.com with SMTP id t79so3837535lfe.3 for <30063@debbugs.gnu.org>; Sat, 27 Jan 2018 04:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:message-id:in-reply-to:references:mime-version; bh=23BNgF+zAUHRSsTHaK8qZO2iu41PRdxrmXVTqFyQFyk=; b=B+aY/olIFRKieL/j7N14Oq5xxMP8pyGb6l+2hFzDrVJcgJs97VljeJvtw7S9uiPSeh w5X9AomyfbbmKEXJTchC5r67kOz1nDGJa166d4H0nuuXQJbx0eyz7YH5HC5Q0Vqw2hhU 3DfSfn13iZtRlSr41eBrInqlX/NzlQzflyWjZaciUlyW57YZ6rPHolUrXCSQ5PtPuXtl uyL7UjbMILIvjdPoHVRN5IgQ5CcHORkQ2U7aWR+qqo2KDPivplksvyc98MEaESShZNbd EtgOaU3yNkEgID+19Szf/4Y8Dt3hjzDkRRhHnjnSiM8IMUYnrxMNFMy4NT9Evn0YuXln nIpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:message-id:in-reply-to :references:mime-version; bh=23BNgF+zAUHRSsTHaK8qZO2iu41PRdxrmXVTqFyQFyk=; b=AyQyLlcnUkHF8m7DqtiiLxnwZ4V50Jny8aewJd9wAiVHqBBwD1v9B1ViIIUWOp6NL2 VYEkaCHx6pM8MUsQQQNtHJZvPCLgjXNHhGfgvKhNwOBK+ahxN0USA5HFG3Eb9mQTxC0y C+Qd6kl38Ka5vZKynzcG0EYAOoxEvDlyrSfZQ7E3EtVIZfkKPN4o6mo6UCLwwtAuhIiL ZVRK9uzU+4nT2WhuQBg9RhlKzpNLH2zSxX6YVHUQvW57etbgFUOU96A1VqrNe7Gra/Dv EVFmOC7vIuX/Q8ArBrTXqjjI3or0e7LpPnPnP1GnM8ONlSN+cJ3hS8oKfgPA1bQkXpGV gWzQ== X-Gm-Message-State: AKwxytfFZnxIQVISYjPxcn7iReBgHsBJEHmVu7e+ta1vXIv7FQ7DnhDA DADoofEXPfIVw20pYUhg69Qtkg== X-Google-Smtp-Source: AH8x227SKEYN+wsO0CbDmuyban9VjL0Pxh+strfGkHwyKmFfohREUXJxRjwQZ30XbRW3EC80EYwxBw== X-Received: by 10.25.160.129 with SMTP id j123mr10006073lfe.136.1517054398458; Sat, 27 Jan 2018 03:59:58 -0800 (PST) Received: from [192.168.100.3] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id o68sm1902631lfc.61.2018.01.27.03.59.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 Jan 2018 03:59:57 -0800 (PST) Date: Sat, 27 Jan 2018 12:59:55 +0100 From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Message-Id: <1517054395.9954.0@smtp.gmail.com> In-Reply-To: <87o9m14y0x.fsf@gmail.com> References: <87o9m14y0x.fsf@gmail.com> X-Mailer: geary/0.12-dev MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-8VkI/VZXcNUeirq3AdPK" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-8VkI/VZXcNUeirq3AdPK Content-Type: multipart/alternative; boundary="=-21JcaY3CQY63Y4wBFU1J" --=-21JcaY3CQY63Y4wBFU1J Content-Type: text/plain; charset=us-ascii; format=flowed How about something like the attached patch? -- Simen --=-21JcaY3CQY63Y4wBFU1J Content-Type: text/html; charset=us-ascii
How about something like the attached patch?

-- Simen
--=-21JcaY3CQY63Y4wBFU1J-- --=-8VkI/VZXcNUeirq3AdPK Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Warn-about-missing-executables-in-RST-PDF-preview.patch Content-Transfer-Encoding: quoted-printable >From 11bb53e567588539c92a520db321a5a9b746df58 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Simen=3D20Heggest=3DC3=3DB8yl?=3D Date: Sat, 27 Jan 2018 12:18:40 +0100 Subject: [PATCH] Warn about missing executables in RST PDF preview * lisp/textmodes/rst.el (rst-compile-pdf-preview): Warn about missing executables when attempting to compile and preview an RST file as PDF. (Bug#30218) --- lisp/textmodes/rst.el | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/rst.el b/lisp/textmodes/rst.el index c93e4e474c..a16d5bca3a 100644 --- a/lisp/textmodes/rst.el +++ b/lisp/textmodes/rst.el @@ -4382,10 +4382,15 @@ rst-compile-pdf-preview "Convert the document to a PDF file and launch a preview program." (interactive) (let* ((tmp-filename (make-temp-file "rst_el" nil ".pdf")) + (pdf-compile-program (cadr (assq 'pdf rst-compile-toolsets))) (command (format "%s %s %s && %s %s ; rm %s" - (cadr (assq 'pdf rst-compile-toolsets)) + pdf-compile-program buffer-file-name tmp-filename rst-pdf-program tmp-filename tmp-filename))) + (unless (executable-find pdf-compile-program) + (error "Cannot find executable `%s'" pdf-compile-program)) + (unless (executable-find rst-pdf-program) + (error "Cannot find executable `%s'" rst-pdf-program)) (start-process-shell-command "rst-pdf-preview" nil command) ;; Note: you could also use (compile command) to view the compilation ;; output. --=20 2.15.1 = --=-8VkI/VZXcNUeirq3AdPK-- From unknown Sun Jun 22 03:57:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jan 2018 18:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Cc: stefan@merten-home.de, 30063@debbugs.gnu.org Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.151716310424577 (code B ref 30063); Sun, 28 Jan 2018 18:12:01 +0000 Received: (at 30063) by debbugs.gnu.org; 28 Jan 2018 18:11:44 +0000 Received: from localhost ([127.0.0.1]:46442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efrQe-0006OL-3t for submit@debbugs.gnu.org; Sun, 28 Jan 2018 13:11:44 -0500 Received: from mail-io0-f179.google.com ([209.85.223.179]:36648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efrQc-0006O7-DC for 30063@debbugs.gnu.org; Sun, 28 Jan 2018 13:11:42 -0500 Received: by mail-io0-f179.google.com with SMTP id l17so5273785ioc.3 for <30063@debbugs.gnu.org>; Sun, 28 Jan 2018 10:11:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=0MTXDBhksJUwVeWsp9h8fCRM58YgjskpspQh3Vj5GC0=; b=VEwlfF7ceV2uG5wilsvrpEgaSFz3JOlbgdapQvVv4/jGqWP8JyNoZ2N+qDESar94ie /zeyRqlVfsaip0lk4mS8NSr01rTOsiYdhktpsUkzBcp72Eu9U9g64RTQyZ/GFHsE9EAq /a4XMNEpGoLwmohZIGyw1XXfNnyCp27+VIG0JhNBjnFW1HUgpb/t6BgY/ID6yZ1x15Yx GUpc19dRm0nbnS++NIhyxgCrNOIRVsGWNXcsboGxSQzt08IOKcw/MGIZYoD6SI38+tQO KBI1jnBKJNicc2lg36QCcyV+4bamrYj685qKCdW6RBlnbtr0nqDzxJIlD7KGOxtNS0p5 llzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=0MTXDBhksJUwVeWsp9h8fCRM58YgjskpspQh3Vj5GC0=; b=ip3Y6oxXsaOG1s0Ais6akp0vKem3JCmEvJHABN0iGdGPyS1JrykgoPtWS82F0ezX0n JnswMqbblwdP3DA4jwGJVBPp7YhviG66Y8nVMoMDA5NLS8LhwzxG6mApNFVpGSzdN0cL JMvx5zGKjcz8hGuhCKqZbzghY4p5iOGt8E400P21FQqfbYjOKu80BCvCJmsQz6F6ZyuC SUVD1E7bPoYdpuGIohTYLvUjOdBDh78G1IpuhUXUI17jhuMtQFbua7UvwODmPCu5edIg cOptFj8N1oft2INf1DNHk9EMGfl6UmrAGD5ZW14DkVnlXonuVMaIjBshUc6JIWT80AYU 5TpQ== X-Gm-Message-State: AKwxytfbYhVMmlO7puu+xNRmSaHVzkZ6/S830PaIuvplAbhZIoRRsLk4 mcJo5LXVsdALsbKKujjRL74= X-Google-Smtp-Source: AH8x227hsDf8Om3ExKaeUpPuTw9s8ir6otqR1d2I/gLEXINeqmIwRN1ljxFmCFTRAFq5amvyISesLQ== X-Received: by 10.107.97.18 with SMTP id v18mr22595672iob.7.1517163096759; Sun, 28 Jan 2018 10:11:36 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o73sm6443196ito.4.2018.01.28.10.11.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Jan 2018 10:11:35 -0800 (PST) From: Noam Postavsky References: <87o9m14y0x.fsf@gmail.com> <1517054395.9954.0@smtp.gmail.com> Date: Sun, 28 Jan 2018 13:11:34 -0500 In-Reply-To: <1517054395.9954.0@smtp.gmail.com> ("Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Sat, 27 Jan 2018 12:59:55 +0100") Message-ID: <87k1w1lup5.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Simen Heggest=C3=B8yl writes: > (command (format "%s %s %s && %s %s ; rm %s" > + pdf-compile-program > buffer-file-name tmp-filename > rst-pdf-program tmp-filename tmp-filename))) > + (unless (executable-find pdf-compile-program) > + (error "Cannot find executable `%s'" pdf-compile-program)) > + (unless (executable-find rst-pdf-program) > + (error "Cannot find executable `%s'" rst-pdf-program)) It's possible to have PATH and exec-path desynchronized, such that the above code could throw an error even though the start-process-shell-command call later would succeed. Maybe we should should just consider that a misconfiguration on the user's part though. From unknown Sun Jun 22 03:57:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jan 2018 17:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Noam Postavsky Cc: stefan@merten-home.de, 30063@debbugs.gnu.org, Simen =?UTF-8?Q?Heggest=C3=B8yl?= Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.15172478412759 (code B ref 30063); Mon, 29 Jan 2018 17:44:01 +0000 Received: (at 30063) by debbugs.gnu.org; 29 Jan 2018 17:44:01 +0000 Received: from localhost ([127.0.0.1]:48184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egDTM-0000iR-Rr for submit@debbugs.gnu.org; Mon, 29 Jan 2018 12:44:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egDTL-0000iA-Dl for 30063@debbugs.gnu.org; Mon, 29 Jan 2018 12:43:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egDTF-00058P-Ae for 30063@debbugs.gnu.org; Mon, 29 Jan 2018 12:43:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egDT3-00051S-W8; Mon, 29 Jan 2018 12:43:42 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1egDT1-0006AO-SD; Mon, 29 Jan 2018 12:43:39 -0500 From: Glenn Morris References: <87o9m14y0x.fsf@gmail.com> <1517054395.9954.0@smtp.gmail.com> <87k1w1lup5.fsf@users.sourceforge.net> X-Spook: Avian event security Blowfish wire transfer Critical X-Ran: a'OYuB>,,/(Zncr:vKi^'c#N^F|}{E;QIWuf[-$rQ|~:)MAYS)e7r$Ll`&5[!]&098Ky)M X-Hue: green X-Attribution: GM Date: Mon, 29 Jan 2018 12:43:39 -0500 In-Reply-To: <87k1w1lup5.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sun, 28 Jan 2018 13:11:34 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Noam Postavsky wrote: > Simen Heggest=C3=B8yl writes: > >> (command (format "%s %s %s && %s %s ; rm %s" >> + pdf-compile-program >> buffer-file-name tmp-filename >> rst-pdf-program tmp-filename tmp-filename))) >> + (unless (executable-find pdf-compile-program) >> + (error "Cannot find executable `%s'" pdf-compile-program)) >> + (unless (executable-find rst-pdf-program) >> + (error "Cannot find executable `%s'" rst-pdf-program)) > > It's possible to have PATH and exec-path desynchronized, such that the > above code could throw an error even though the > start-process-shell-command call later would succeed. Maybe we should > should just consider that a misconfiguration on the user's part though. Yes, I think PATH !=3D exec-path is a user error. BTW what happens with the above if the program is present, but fails for some reason? Is nothing still shown to the user in that case? Also, does it actually need to go through the shell? From unknown Sun Jun 22 03:57:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2018 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Noam Postavsky Cc: stefan@merten-home.de, 30063@debbugs.gnu.org, simenheg@gmail.com Reply-To: Eli Zaretskii Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.15173201874614 (code B ref 30063); Tue, 30 Jan 2018 13:50:02 +0000 Received: (at 30063) by debbugs.gnu.org; 30 Jan 2018 13:49:47 +0000 Received: from localhost ([127.0.0.1]:48676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egWIF-0001CM-G1 for submit@debbugs.gnu.org; Tue, 30 Jan 2018 08:49:47 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egWID-0001CA-80 for 30063@debbugs.gnu.org; Tue, 30 Jan 2018 08:49:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egWI5-0006Hw-38 for 30063@debbugs.gnu.org; Tue, 30 Jan 2018 08:49:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egWI4-0006Ho-VP; Tue, 30 Jan 2018 08:49:37 -0500 Received: from [176.228.60.248] (port=2910 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1egWI4-0003aR-Ay; Tue, 30 Jan 2018 08:49:36 -0500 Date: Tue, 30 Jan 2018 15:49:47 +0200 Message-Id: <83lggfh2x0.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87k1w1lup5.fsf@users.sourceforge.net> (message from Noam Postavsky on Sun, 28 Jan 2018 13:11:34 -0500) References: <87o9m14y0x.fsf@gmail.com> <1517054395.9954.0@smtp.gmail.com> <87k1w1lup5.fsf@users.sourceforge.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Sun, 28 Jan 2018 13:11:34 -0500 > Cc: stefan@merten-home.de, 30063@debbugs.gnu.org > > Simen Heggestøyl writes: > > > (command (format "%s %s %s && %s %s ; rm %s" > > + pdf-compile-program > > buffer-file-name tmp-filename > > rst-pdf-program tmp-filename tmp-filename))) > > + (unless (executable-find pdf-compile-program) > > + (error "Cannot find executable `%s'" pdf-compile-program)) > > + (unless (executable-find rst-pdf-program) > > + (error "Cannot find executable `%s'" rst-pdf-program)) > > It's possible to have PATH and exec-path desynchronized, such that the > above code could throw an error even though the > start-process-shell-command call later would succeed. Maybe we should > should just consider that a misconfiguration on the user's part though. Yes, we could do that. But can we signal an error only when the command fails? That should minimize false negatives. Also please note that the shell command as written is unportable: the ";" part will not work on MS-Windows, we need to use "&" instead. But that's a separate issue. From unknown Sun Jun 22 03:57:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2018 14:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: stefan@merten-home.de, 30063@debbugs.gnu.org, Simen =?UTF-8?Q?Heggest=C3=B8yl?= Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.15173226398296 (code B ref 30063); Tue, 30 Jan 2018 14:31:01 +0000 Received: (at 30063) by debbugs.gnu.org; 30 Jan 2018 14:30:39 +0000 Received: from localhost ([127.0.0.1]:48705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egWvm-00029i-UL for submit@debbugs.gnu.org; Tue, 30 Jan 2018 09:30:39 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:35594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egWvk-00029V-8x for 30063@debbugs.gnu.org; Tue, 30 Jan 2018 09:30:36 -0500 Received: by mail-wm0-f54.google.com with SMTP id r78so1577070wme.0 for <30063@debbugs.gnu.org>; Tue, 30 Jan 2018 06:30:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=5hiMz5vC5kon1G1qLRwzSHcz2zdMG4x6+22rLcen15I=; b=kLG06oi/Q1fgwViUW+u4MwBB2+wS+w3JI4kKndVdzErw4/pfJStaXKFbczPP6jB09V yCVQ8LoqSO3bkkOQzgb05ZRAJbMRqQ/k4fYilZZ+A72BDZc8JEZ9M4iNrBFO+3r/N/5e hCMyxw95f+veOxb4CUAQBQg/LxDVrHdgVkeGyQSfksvziCncTU6z+5jPwZmiArRf4m3Y ZNH58ktxzG188lv5vPSEy9oNl8PUvi70/Yx0j7n7WBRLlhFRLgMZAXTMvNAGTjOHpIk7 NOos+33dx2ubnue9O43AD60NhQ4WeAnAfd+QEebCu3/adDgFczSUtjXHNsWNN1TmKrSa bu9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=5hiMz5vC5kon1G1qLRwzSHcz2zdMG4x6+22rLcen15I=; b=NMn2SRfOFLYZWUE8iIWC+e3+pVZl0hiHVMgpkkIN5wHbLmZYXn2Vz51+01wMK34XqF IYVpAWZfTiaec/sPMbF3Rff3LQbXNHf/T0X+JYM8pXd5FgTb4A1U52KlnLMUMsGqK8CZ MApLxKYigrcqZFXLiXuhXaKs8orkWSDXCDpvvsR5ywQ24VSlwxeQ6/sYMXsLT7fdZpVb RYHYFBdnUiE9O+GfGzMUbjHiC85afguQZcGz8agSDYY1JZNJNIpsyS/zkfVdy5+IvoJZ XUPjDwQzfE7swIHIP1E9oiPfEFnat7GpRxwMYHAktc7KRorYffdbOIcHPolyLJ35BrgC Youg== X-Gm-Message-State: AKwxytfG4fg6UYzbJ3yeov2HPEd38Sl1/wYRbCG1OoF1HCNMwEXeCcng ua4xjraMo94v8SNVQoZCYUPgJ8GF3prNP5Q1/Io= X-Google-Smtp-Source: AH8x224ynKXCwITixtIjJSF9A8RjXTGYobIQqizW3ZuvrpaK6xiw/v8y5rFZWE5Bu59oVSAbBxUujyApp1Tko7+/BRE= X-Received: by 10.28.157.206 with SMTP id g197mr20614040wme.96.1517322630379; Tue, 30 Jan 2018 06:30:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.182.77 with HTTP; Tue, 30 Jan 2018 06:30:30 -0800 (PST) In-Reply-To: <83lggfh2x0.fsf@gnu.org> References: <87o9m14y0x.fsf@gmail.com> <1517054395.9954.0@smtp.gmail.com> <87k1w1lup5.fsf@users.sourceforge.net> <83lggfh2x0.fsf@gnu.org> From: Noam Postavsky Date: Tue, 30 Jan 2018 09:30:30 -0500 X-Google-Sender-Auth: 011czANNnHyjpua6AykO0klIeX0 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Tue, Jan 30, 2018 at 8:49 AM, Eli Zaretskii wrote: > Yes, we could do that. But can we signal an error only when the > command fails? That should minimize false negatives. I think it's a bit tricky due to being asynchronous, though it should be doable. > Also please note that the shell command as written is unportable: the > ";" part will not work on MS-Windows, we need to use "&" instead. But > that's a separate issue. "&" would do the wrong thing for a POSIX sh compatible shell, so the only way to fix that would be to avoid the shell entirely like Glenn hinted at. From unknown Sun Jun 22 03:57:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2018 15:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Noam Postavsky Cc: stefan@merten-home.de, 30063@debbugs.gnu.org, simenheg@gmail.com Reply-To: Eli Zaretskii Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.151732685815268 (code B ref 30063); Tue, 30 Jan 2018 15:41:02 +0000 Received: (at 30063) by debbugs.gnu.org; 30 Jan 2018 15:40:58 +0000 Received: from localhost ([127.0.0.1]:49722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egY1q-0003yC-5r for submit@debbugs.gnu.org; Tue, 30 Jan 2018 10:40:58 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egY1p-0003y1-8B for 30063@debbugs.gnu.org; Tue, 30 Jan 2018 10:40:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egY1g-0000B0-8x for 30063@debbugs.gnu.org; Tue, 30 Jan 2018 10:40:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egY1g-0000Ap-5B; Tue, 30 Jan 2018 10:40:48 -0500 Received: from [176.228.60.248] (port=3079 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1egY1f-0000RP-LK; Tue, 30 Jan 2018 10:40:48 -0500 Date: Tue, 30 Jan 2018 17:40:58 +0200 Message-Id: <831si7gxrp.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Noam Postavsky on Tue, 30 Jan 2018 09:30:30 -0500) References: <87o9m14y0x.fsf@gmail.com> <1517054395.9954.0@smtp.gmail.com> <87k1w1lup5.fsf@users.sourceforge.net> <83lggfh2x0.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Tue, 30 Jan 2018 09:30:30 -0500 > Cc: Simen Heggestøyl , > stefan@merten-home.de, 30063@debbugs.gnu.org > > > Also please note that the shell command as written is unportable: the > > ";" part will not work on MS-Windows, we need to use "&" instead. But > > that's a separate issue. > > "&" would do the wrong thing for a POSIX sh compatible shell I meant to leave ";" on Posix, and use "&" on Windows. From unknown Sun Jun 22 03:57:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2019 12:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Cc: stefan@merten-home.de, 30063@debbugs.gnu.org Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.156975895210660 (code B ref 30063); Sun, 29 Sep 2019 12:10:01 +0000 Received: (at 30063) by debbugs.gnu.org; 29 Sep 2019 12:09:12 +0000 Received: from localhost ([127.0.0.1]:52490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEY0l-0002ls-O5 for submit@debbugs.gnu.org; Sun, 29 Sep 2019 08:09:11 -0400 Received: from quimby.gnus.org ([80.91.231.51]:52952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEY0k-0002ll-LV for 30063@debbugs.gnu.org; Sun, 29 Sep 2019 08:09:11 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEY0h-0000KK-6E; Sun, 29 Sep 2019 14:09:09 +0200 From: Lars Ingebrigtsen References: <87o9m14y0x.fsf@gmail.com> <1517054395.9954.0@smtp.gmail.com> Date: Sun, 29 Sep 2019 14:09:06 +0200 In-Reply-To: <1517054395.9954.0@smtp.gmail.com> ("Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Sat, 27 Jan 2018 12:59:55 +0100") Message-ID: <87o8z3mhi5.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Simen =?UTF-8?Q?Heggest=C3=B8yl?= writes: > * lisp/textmodes/rst.el (rst-compile-pdf-preview): Warn about missing > executables when attempting to compile and preview an RST file as PDF. > (Bug#30218) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Simen Heggest=C3=B8yl writes: > * lisp/textmodes/rst.el (rst-compile-pdf-preview): Warn about missing > executables when attempting to compile and preview an RST file as PDF. > (Bug#30218) [...] > + (unless (executable-find pdf-compile-program) > + (error "Cannot find executable `%s'" pdf-compile-program)) > + (unless (executable-find rst-pdf-program) > + (error "Cannot find executable `%s'" rst-pdf-program)) Others pointed out that it might be nice to report error messages back from the pdf commands, and that's true, but I think this patch makes sense, too, because it gives good, early feedback on a likely problem, so I think it should be applied. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 03:57:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Resent-From: Stefan Merten Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2019 21:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 30063@debbugs.gnu.org, Simen =?UTF-8?Q?Heggest=C3=B8yl?= Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.15701370464331 (code B ref 30063); Thu, 03 Oct 2019 21:11:02 +0000 Received: (at 30063) by debbugs.gnu.org; 3 Oct 2019 21:10:46 +0000 Received: from localhost ([127.0.0.1]:41364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG8N2-00017j-2p for submit@debbugs.gnu.org; Thu, 03 Oct 2019 17:10:44 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:55517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG86p-0000gY-7k for 30063@debbugs.gnu.org; Thu, 03 Oct 2019 16:53:59 -0400 Received: from eskebo.homelinux.merten-home.de ([5.40.155.5]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1M8hIl-1iBzEl15Sz-004fxv; Thu, 03 Oct 2019 22:53:50 +0200 Received: by eskebo.homelinux.merten-home.de (Postfix, from userid 1000) id D6BC2C015E; Thu, 3 Oct 2019 22:53:48 +0200 (CEST) From: Stefan Merten In-reply-to: <87o8z3mhi5.fsf@gnus.org> References: <87o9m14y0x.fsf@gmail.com> <1517054395.9954.0@smtp.gmail.com> <87o8z3mhi5.fsf@gnus.org> Comments: In-reply-to Lars Ingebrigtsen message dated "Sun, 29 Sep 2019 14:09:06 +0200." X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Date: Thu, 03 Oct 2019 22:53:43 +0200 Message-ID: <5960.1570136023@eskebo> X-Provags-ID: V03:K1:0yclGBEr5FcG+WrQjtOoK66KUbY7YjDsFf9f/WZSYv+US6gd0hM +iJMR2JRsGyfyZXML9qBQFZtoCe3XqianrL/vWde4QfZlGuw7h0n1kVvlACqNnFNgmCjPSd 6kueN59+Iw+CNe/oSsBE65Nto07eQpLYLu9OjtJmzhPwl9wKjHRejoseaNuxQ4EC7sdB/gw jpKVAeK6mNdSwujsZ4G/A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:4p67hREUObM=:7UAY+V89Qm5+KUK+eKamQj J+4mDByH5C867S7Pug0XnwWre3TBiHGXx3p4aaCg4kzGNQQ4gTDYpV64emkbbMnEDXITRPNNE /7BXwdPxnR7e9qJeea/VBxhkIXAemFrnf+GQzzMTqYU/y1YBKizE6l37Hw2700bnFwsIOhern 3I7uAnDpMtLIxr7upliQiu/i10xUPy78BEF5UliRYsjs3qrf5NPhjojtKlgpLRNah8WDwJVyZ +KGYOXp4TM6AGbherp441duMBQPAXXa2x3SVNiZCJmTPU3XotPvWaW+t8Y2h6iD7EGvxIrJy3 jLqFuouWSUeNg2OkyprUmiyP5518RtVeRn9ulsibaBvuXrPxJ7zIsXQCN1db6bSUW2JX5iTRh 7G6vLFIeCD1t8PAeG+GM9wDjQXZY6FFA90xz7V5ZjAIjiCd5QqmjTGWTC7/2/Kb7Y12ltB4UE 6cprhlyNgo2KmGAqHgKf3nBBYte2ugQ3pf7UK6z2sjikzL30X1kM+ELCp+JNkUr7byg5sXX7a /FH8nZXtuwOqGwQC0TZPSiuNK9AAhUJ6V9E2skB5WBdwoByUqdI/TcZ4MRfT2uJ8utO8AjT7t RB/xF7IJWicw68TKj90F/Kk7PE9ehj0A8Y7MjwZyzD+KJ3RKGnUgpmsvE154ppL5x92PASijg 0OL6TzuB/R+UNp7SEgRDLq/QqpyzGc1rUw4rBj9fEDVkafNEq9h/KCbHplTJ7kW2DRdssU+Rx FYYL7ncBWaiq6ZXEIhon3wBS4+tME/IHyR/Cn6Lx9jPYabaHE2FW6wutA7Vip9zzVEN6H/lE+ ceiW2goyXXKSMYOosZ/gWWKdaK0XfweFow0NfZHjGurXLFifR9YcsnAvRF/KAloga5Mw/i4SZ TNKbFuFFAyjs9jA+fYo8WQLMzi5PS82tWIDd7fW6E= X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Thu, 03 Oct 2019 17:10:42 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi all! Sorry for not looking into this for so long. This whole part of `rst.el' needs a couple of improvements. I did not write this code and frankly did not care much about it - besides adding some FIXMEs. 4 days ago Lars Ingebrigtsen wrote: > Simen Heggest=F8yl writes: >=20 >> * lisp/textmodes/rst.el (rst-compile-pdf-preview): Warn about missing >> executables when attempting to compile and preview an RST file as PDF. >> (Bug#30218) >=20 > [...] >=20 >> + (unless (executable-find pdf-compile-program) >> + (error "Cannot find executable `%s'" pdf-compile-program)) >> + (unless (executable-find rst-pdf-program) >> + (error "Cannot find executable `%s'" rst-pdf-program)) >=20 > Others pointed out that it might be nice to report error messages back > from the pdf commands, and that's true, but I think this patch makes > sense, too, because it gives good, early feedback on a likely problem, > so I think it should be applied. Well, IMHO this patch would be less than optimal. There is already (defcustom rst-compile-toolsets ...) There is an `executable-find' already for the default values. Although it only takes an alternative if it doesn't find the first guess. This is also less than optimal :-( . `rst-pdf-program' on the other hand is not yet integrated in `rst-compile-toolsets'. This is a necessary improvement. A good solution IMHO would be to have a reasonable list of defaults for (all) the executables in `rst-compile-toolsets', then check this list of defaults for executability and then set the default customization accordingly. If none of the defaults is found the customization for the respective symbol should be set to nil and the error should appear when the executable is to be used. [...browsing through the code...] Ok, a sensible solution would need quite an effort. So it's probably best to apply this patch now and when at any point in the future I come up with a more general solution it will do something equivalent or rather something better. Gr=FC=DFe Stefan From unknown Sun Jun 22 03:57:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Oct 2019 03:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Merten Cc: 30063@debbugs.gnu.org, Simen =?UTF-8?Q?Heggest=C3=B8yl?= Received: via spool by 30063-submit@debbugs.gnu.org id=B30063.15704187653309 (code B ref 30063); Mon, 07 Oct 2019 03:27:02 +0000 Received: (at 30063) by debbugs.gnu.org; 7 Oct 2019 03:26:05 +0000 Received: from localhost ([127.0.0.1]:47101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHJev-0000rJ-0W for submit@debbugs.gnu.org; Sun, 06 Oct 2019 23:26:05 -0400 Received: from quimby.gnus.org ([80.91.231.51]:54650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHJes-0000r9-9V for 30063@debbugs.gnu.org; Sun, 06 Oct 2019 23:26:03 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHJeo-00050a-TT; Mon, 07 Oct 2019 05:26:01 +0200 From: Lars Ingebrigtsen References: <87o9m14y0x.fsf@gmail.com> <1517054395.9954.0@smtp.gmail.com> <87o8z3mhi5.fsf@gnus.org> <5960.1570136023@eskebo> Date: Mon, 07 Oct 2019 05:25:58 +0200 In-Reply-To: <5960.1570136023@eskebo> (Stefan Merten's message of "Thu, 03 Oct 2019 22:53:43 +0200") Message-ID: <87zhidb5ix.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Merten writes: > A good solution IMHO would be to have a reasonable list of defaults > for (all) the executables in `rst-compile-toolsets', then check this > list of defaults for executability and then set the defau [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Merten writes: > A good solution IMHO would be to have a reasonable list of defaults > for (all) the executables in `rst-compile-toolsets', then check this > list of defaults for executability and then set the default > customization accordingly. If none of the defaults is found the > customization for the respective symbol should be set to nil and the > error should appear when the executable is to be used. Yeah, that sounds like a good thing. > [...browsing through the code...] > > Ok, a sensible solution would need quite an effort. So it's probably > best to apply this patch now and when at any point in the future I > come up with a more general solution it will do something equivalent > or rather something better. OK, Simen -- I think you should just apply the patch and close the bug report, and we can hope that further improvements arrive in the future. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 03:57:47 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Subject: bug#30063: closed (Re: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview') Message-ID: References: <5d9e0730.1c69fb81.346a9.2b3d@mx.google.com> <87o9m14y0x.fsf@gmail.com> X-Gnu-PR-Message: they-closed 30063 X-Gnu-PR-Package: emacs Reply-To: 30063@debbugs.gnu.org Date: Wed, 09 Oct 2019 16:14:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1570637642-28489-1" This is a multi-part message in MIME format... ------------=_1570637642-28489-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 30063@debbugs.gnu.org. --=20 30063: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30063 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1570637642-28489-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 30063-done) by debbugs.gnu.org; 9 Oct 2019 16:13:49 +0000 Received: from localhost ([127.0.0.1]:53904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIEaz-0007Oy-4r for submit@debbugs.gnu.org; Wed, 09 Oct 2019 12:13:49 -0400 Received: from mail-lj1-f176.google.com ([209.85.208.176]:38161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIEau-0007Oe-OE for 30063-done@debbugs.gnu.org; Wed, 09 Oct 2019 12:13:45 -0400 Received: by mail-lj1-f176.google.com with SMTP id b20so3096851ljj.5 for <30063-done@debbugs.gnu.org>; Wed, 09 Oct 2019 09:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:in-reply-to:date:mime-version; bh=ljTbUslfrJ/G4AMDXKdpSKvojRfCSo+SNTdzWEek8Po=; b=Sply7YnBw5FCOVNrhJOPpEuGvzkvDvmdZoxMrZgPJh3KPYsI4VRlL3qtHTPpZBhEh7 y1ACGnAysOtcaoa9W3KgM9zZ8ZiJDqm+iPXhzX3ukm2PbG0PI1kgBxvVKNcWp3jt8bWG 2eGuLWf/r6cHBDOE6rzSmFTj0dwS/5LRsqm59NjYcHIB3IJvntsI/KrWcAhGYl+8L2Ps 8Z3sT9T37TYpSdkIXDEiFmO4vGwxgXdf1SZwbgrwU4yidvC+jtw959HWPLz9fzzxHl2F 81pORlvWIjC5qihzzHqmgFFGdtIMm3o8PKOWvw+27FVQ+T63z8Mr0Xl2KT685WhpehMf V69w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:in-reply-to:date :mime-version; bh=ljTbUslfrJ/G4AMDXKdpSKvojRfCSo+SNTdzWEek8Po=; b=C9D8wAhEkhCgduJ1zXuwnn5qP2i9OYWg8CgEXGpB5OXIr8fwtJH8M3h5vqSU66iNyq YmfMl24aR9CntwEfNLJna+f0EiPJnWX/xdcmyWdDuZjQ5dgi38OToujlhNo++Wuru64T FOWQeQSK80cUYS1thXnflI2PjelNPQpIeG29Tf1WNKZCI/jSSaToPBZ/Zk7wyq7cL79M nsv+ORVXDjlum7ReTVouY1vbYaXyPvAcYNyD/lyRhFDIMswp6QTjjA5mniYXSpULuks0 e06kKH+WpeB3xAWUxt970cUMj8IE+rWDgnRSRpqtfgwoyfnpvuahHi4Ve/E97VX3Wc7u TI8w== X-Gm-Message-State: APjAAAVzJJ9SZdmc427U3KVY6u8jtSaQrSDD2l5QrjMpt+nCl9xEqodE b2b903hjaQi9KCVw8JDwEMiqaHGH X-Google-Smtp-Source: APXvYqz9m2QbwunRRq8WROR+ZR6PUToX46pyM8byhFcoK7DbQLYtrAsiGOmcgERINQQCtDyFSvNrVA== X-Received: by 2002:a2e:8908:: with SMTP id d8mr2874734lji.197.1570637617357; Wed, 09 Oct 2019 09:13:37 -0700 (PDT) Received: from ae25 (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id d25sm579521lfj.15.2019.10.09.09.13.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 09:13:36 -0700 (PDT) Message-ID: <5d9e0730.1c69fb81.346a9.2b3d@mx.google.com> X-Google-Original-Message-ID: <87y2xtgamo.fsf@simenheg@gmail.com> From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: Lars Ingebrigtsen Subject: Re: bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview' In-Reply-To: <87zhidb5ix.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 07 Oct 2019 05:25:58 +0200) Date: Wed, 09 Oct 2019 18:13:35 +0200 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30063-done Cc: stefan@merten-home.de, 30063-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > OK, Simen -- I think you should just apply the patch and close the bug > report, and we can hope that further improvements arrive in the future. > :-) Alright, applied! -- Simen ------------=_1570637642-28489-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 10 Jan 2018 13:57:42 +0000 Received: from localhost ([127.0.0.1]:50361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZGsw-00077Y-0c for submit@debbugs.gnu.org; Wed, 10 Jan 2018 08:57:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZGst-00077I-V3 for submit@debbugs.gnu.org; Wed, 10 Jan 2018 08:57:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZGsl-0004At-OY for submit@debbugs.gnu.org; Wed, 10 Jan 2018 08:57:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37063) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eZGsl-0004Ah-LQ for submit@debbugs.gnu.org; Wed, 10 Jan 2018 08:57:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZGsf-0007OQ-Ty for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2018 08:57:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZGsc-00045T-R1 for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2018 08:57:26 -0500 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:36375) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZGsc-00044W-Ip for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2018 08:57:22 -0500 Received: by mail-lf0-x22d.google.com with SMTP id e203so5165225lfg.3 for ; Wed, 10 Jan 2018 05:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=pOhxMw3fZfjBnRhn2OGwdqk97BvW2c2PR6PYObNFlqM=; b=mIb68TvHr1hPbliYKtNOE9e+lbvzGk63PLRFZoP2uXn5o1ww6CwF6YuhuHmtBrQlWZ 3HGnF9wywO9CiBtkgeFeP/GZjqdCPowAkOYS2lzXZ/od2Amy8VqkSauBIBEXM3JCysr1 1OJS/ImVd9lfDdO11SGpopKqSlbtjjrzWGzJuMPhJjCEl08LPlvEMjytS5ZYzGxpG2eZ sA+caOn84Gu/1i2tNyxAnA6lu/bCfOtVgUr2uCcFHkgTXGKsyEP6YBRXxR81jTBXF+Fa dXZrDB/jH7hHePT0QFC8SaK2zpKioyUz43Ee7V90FRnxTatXJRZnZ4OSKGhGxFjPbl2x vMyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=pOhxMw3fZfjBnRhn2OGwdqk97BvW2c2PR6PYObNFlqM=; b=DR4FWyltn9kXNPqvf7eJmVVLDwxe1PkxAhc5QpzDPt86VlIvsuBb0m5FehKm36s99e HXbiItYzXWVcPbIANhGKIaWwrxt9iEGUa67HD5UgacLt4NNm5cbMjQuT1JoOpz5GsyYg VWdB5OVl2FicMOevMe1bipjP1+lnc5mCZzGcBgCm02FjVVukJ6ME+qOigxudlc6TcJxe KR1SCc0GU4jZdXLbOrEP0ggbY+e6WKGmYxmioFwMrEebwLp96hD/8Eyo9jTqSAcu1QCJ q1A99SK4TGEy9pmTUvTo3FMAfZEvo11ainN2mSsJX2UGg9Sh+U201WF4oZw8x3eLqS75 i0NQ== X-Gm-Message-State: AKGB3mLiJqjrcYTw23tQctatzm6O4FZhYKg8AMQoG+vsFd5Umxr1SyaH zrHK5pfpBJR4sRK4mOX5PkEhEA== X-Google-Smtp-Source: ACJfBovdsCaOv5poqCXoY/X0BfMrYgQY/YKz7RIap2MlpKLFNMP39bwaH2quy6QTgXcYccIJ3fPf4w== X-Received: by 10.46.36.15 with SMTP id k15mr11507720ljk.34.1515592641056; Wed, 10 Jan 2018 05:57:21 -0800 (PST) Received: from x240 ([77.40.215.202]) by smtp.gmail.com with ESMTPSA id h71sm953315lfi.91.2018.01.10.05.57.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Jan 2018 05:57:19 -0800 (PST) From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: bug-gnu-emacs@gnu.org, stefan@merten-home.de Subject: 26.0.90; Silent fail with `rst-compile-pdf-preview' Date: Wed, 10 Jan 2018 14:57:18 +0100 Message-ID: <87o9m14y0x.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) If either of the `xpdf' or `rst2pdf' programs are missing, `rst-compile-pdf-preview' fails without leaving any message. It would be useful if the command informed the user what's stopping it from working. -- Simen ------------=_1570637642-28489-1--