GNU bug report logs - #30060
mh-send-letter coding-system selection

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30060 in the body.
You can then email your comments to 30060 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: mh-send-letter coding-system selection
Date: Wed, 10 Jan 2018 01:50:53 -0500

Package: emacs,mh-e
Version: 26.0.90
Severity: minor

mh-send-letter contains the following for selecting a coding system:

        (coding-system-for-write
         (if (and (local-variable-p 'buffer-file-coding-system
                                    (current-buffer)) ;XEmacs needs two args
                  ;; We're not sure why, but buffer-file-coding-system
                  ;; tends to get set to undecided-unix.
                  (not (memq buffer-file-coding-system
                             '(undecided undecided-unix undecided-dos))))
             buffer-file-coding-system
           (or (and (boundp 'sendmail-coding-system) sendmail-coding-system)
               (and (default-boundp 'buffer-file-coding-system)
                    (default-value 'buffer-file-coding-system))
               'iso-latin-1))))

This is similar to, but not quite the same as, the standard Emacs
function select-message-coding-system that exists specifically for this
purpose. Eg the mh-e version does not consult default-sendmail-coding-system.

It would be great if mh-e could use the standard function, or if not
have some comments added to the code explaining the reason(s) for the
difference(s).

Thanks.

Message #6 received at 30060 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 30060 <at> debbugs.gnu.org
Subject: Re: bug#30060: mh-send-letter coding-system selection
Date: Wed, 10 Jan 2018 17:28:31 +0200

> From: Glenn Morris <rgm <at> gnu.org>
> Date: Wed, 10 Jan 2018 01:50:53 -0500
> 
>         (coding-system-for-write
>          (if (and (local-variable-p 'buffer-file-coding-system
>                                     (current-buffer)) ;XEmacs needs two args
>                   ;; We're not sure why, but buffer-file-coding-system
>                   ;; tends to get set to undecided-unix.
>                   (not (memq buffer-file-coding-system
>                              '(undecided undecided-unix undecided-dos))))
>              buffer-file-coding-system
>            (or (and (boundp 'sendmail-coding-system) sendmail-coding-system)
>                (and (default-boundp 'buffer-file-coding-system)
>                     (default-value 'buffer-file-coding-system))
>                'iso-latin-1))))
> 
> This is similar to, but not quite the same as, the standard Emacs
> function select-message-coding-system that exists specifically for this
> purpose. Eg the mh-e version does not consult default-sendmail-coding-system.
> 
> It would be great if mh-e could use the standard function

Indeed.

> or if not have some comments added to the code explaining the
> reason(s) for the difference(s).

I'd be surprised to hear there are any reasons except some historical
accident.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.