From unknown Sun Jun 22 07:48:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jan 2018 01:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 30037@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151545955518608 (code B ref -1); Tue, 09 Jan 2018 01:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 9 Jan 2018 00:59:15 +0000 Received: from localhost ([127.0.0.1]:41906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYiFx-0004pt-QY for submit@debbugs.gnu.org; Mon, 08 Jan 2018 19:59:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYiFw-0004pf-0Y for submit@debbugs.gnu.org; Mon, 08 Jan 2018 19:59:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYiFp-0002Xr-Mm for submit@debbugs.gnu.org; Mon, 08 Jan 2018 19:59:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59333) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eYiFp-0002Xj-Ij for submit@debbugs.gnu.org; Mon, 08 Jan 2018 19:59:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYiFo-0002SR-0p for guix-patches@gnu.org; Mon, 08 Jan 2018 19:59:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYiFm-0002Ud-E1 for guix-patches@gnu.org; Mon, 08 Jan 2018 19:59:00 -0500 Received: from tobias.gr ([2001:470:cc92::1]:34190) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eYiFl-0002Sq-Sq for guix-patches@gnu.org; Mon, 08 Jan 2018 19:58:58 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id 01e6f260 for ; Tue, 9 Jan 2018 00:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=2018; bh=XHgmGJ1zgVjg3qTyF4Fak6zVV PoyBYniJJ3Tyu6xaCw=; b=iRcM8b+cIknrKDq/zB1Bvw+rbCcJOYTnyXI7c0J+G kn4AAUzupEPz4YJYsPnBbG3AdspjA14c5s73pUMgnZ9T4PC2N447BfRiXUzRjCIC Ab+WCiVz/wIk8AqJB3+4vhJZFgFFqLuzC/TuEXJGER9V8cb+8u46zw0FwaK4tN/C IeUwMF3v0SoJhLWQ8AEtXEc0ViAs8MPxB23ek1uAnHRzo98OrVNu169mhoto71r0 boJTEeRYjTmC8pJSPGREv8TRLcYJmZvLlW1U2iIFJ9R5II0icen7dpkj3YWqGMg1 OYnk4fpgtq2FEAnH2/ZetmtrZUdI5lSglHAAXg0J/GBIg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 85590694 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for ; Tue, 9 Jan 2018 00:58:53 +0000 (UTC) From: Tobias Geerinckx-Rice Date: Tue, 9 Jan 2018 02:01:38 +0100 Message-Id: <20180109010138.29740-1-me@tobias.gr> X-Mailer: git-send-email 2.15.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) * gnu/packages/networking.scm (whois)[source]: Remove mkpasswd sources in a snippet. [native-inputs]: Add gettext. [arguments]: Add ‘update-po’ phase. [description]: Remove historical not about bundled mkpasswd. --- Guix, A quick TODO item glanced in a recent commit notification, done. While everything could be done in a single phase, I prefer ripping such cruft out early. Manually building the modified sources works fine, at the cost of slightly bloated .po files with some unused strings. It's unlikely someone will want to unpack this to build mkpasswd... Then again, it's not a licence issue so I don't really care that much. Kind regards, T G-R gnu/packages/networking.scm | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index 94621052d..9a8993be2 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -4,7 +4,7 @@ ;;; Copyright © 2015 Mark H Weaver ;;; Copyright © 2015, 2016, 2017 Stefan Reichör ;;; Copyright © 2016 Raimon Grau -;;; Copyright © 2016, 2017 Tobias Geerinckx-Rice +;;; Copyright © 2016, 2017, 2018 Tobias Geerinckx-Rice ;;; Copyright © 2016 John Darrington ;;; Copyright © 2016, 2017 Nicolas Goaziou ;;; Copyright © 2016 Eric Bavier @@ -458,15 +458,31 @@ and up to 1 Mbit/s downstream.") name "_" version ".tar.xz")) (sha256 (base32 - "02f00vpgrdb77w7lskl9jfm2akpy21ws9cjazs13gash2xksnj38")))) + "02f00vpgrdb77w7lskl9jfm2akpy21ws9cjazs13gash2xksnj38")) + (modules '((guix build utils))) + (snippet + '(begin + ;; Remove unused ‘mkpasswd’ bundled for historical reasons. + (for-each delete-file + (find-files "." "^mkpasswd\\.")) + (substitute* "Makefile" + ((" (install-|)mkpasswd ") " ")) + (substitute* "po/Makefile" + (("\\.\\./mkpasswd\\.c") "")) + #t)))) (build-system gnu-build-system) - ;; TODO: unbundle mkpasswd binary + its po files. + (native-inputs + `(("gettext" ,gettext))) ; for update-po phase (arguments `(#:tests? #f ; Does not exist #:make-flags (list "CC=gcc" (string-append "prefix=" (assoc-ref %outputs "out"))) #:phases (modify-phases %standard-phases + (add-after 'unpack 'update-po + ;; Remove harmless but useless ‘mkpasswd’ remnants from .po files. + (lambda _ + (invoke "make" "-C" "po" "update-po"))) (delete 'configure) ; No configure (add-before 'build 'setenv (lambda _ @@ -481,9 +497,7 @@ and up to 1 Mbit/s downstream.") ("pkg-config" ,pkg-config))) (synopsis "Improved whois client") (description "This whois client is intelligent and can -automatically select the appropriate whois server for most queries. -Because of historical reasons this also includes a tool called mkpasswd -which can be used to encrypt a password with @code{crypt(3)}.") +automatically select the appropriate whois server for most queries.") (home-page "https://github.com/rfc1036/whois") (license license:gpl2+))) -- 2.15.0 From unknown Sun Jun 22 07:48:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jan 2018 01:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 30037@debbugs.gnu.org Received: via spool by 30037-submit@debbugs.gnu.org id=B30037.151545970318935 (code B ref 30037); Tue, 09 Jan 2018 01:02:01 +0000 Received: (at 30037) by debbugs.gnu.org; 9 Jan 2018 01:01:43 +0000 Received: from localhost ([127.0.0.1]:41921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYiIQ-0004vL-Na for submit@debbugs.gnu.org; Mon, 08 Jan 2018 20:01:42 -0500 Received: from tobias.gr ([51.15.135.5]:48432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYiIO-0004vC-NN for 30037@debbugs.gnu.org; Mon, 08 Jan 2018 20:01:41 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id baae7def for <30037@debbugs.gnu.org>; Tue, 9 Jan 2018 01:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject :from:to:references:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=2018; bh=6U92xkXyXIEt zaviqThYzrqHvoNvBDnOs1Ll2+gOImw=; b=MXnq1N9fjCPkwZajN+AKvkJF5n+C Y9c+sRNe3mpSNhge6i1MXZFES+78CgBe1d6okNFOPuiVf2JyBOZUIvUjtLvf1Xv3 /WnIBMDfObKopB4wv68/p7t8tWGOCv1NAzsi04W5NmCSeGLrnqLHo9llOTtAaK1+ 9OWs+7FZyTD41VEaOS4q1kuwfJbIq4Rnv0tbVmxQED8GIZK1px6bo20PzADI8kbM Btgf2e+KW56gsdP4FfLvhn0xkhF7VqvQ+3qkG+BVCJBt+HaEzh6wJlE7L7TDhRVa +m8Ezto4F9eFzbNXXX7xjDQYr562iS0GHTIZEnDhz2yaAfjebd+b3NAMEw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 592c2acc (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <30037@debbugs.gnu.org>; Tue, 9 Jan 2018 01:01:37 +0000 (UTC) From: Tobias Geerinckx-Rice References: <20180109010138.29740-1-me@tobias.gr> Message-ID: Date: Tue, 9 Jan 2018 02:04:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180109010138.29740-1-me@tobias.gr> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Tobias Geerinckx-Rice wrote on 09/01/18 at 02:01: > * gnu/packages/networking.scm (whois)[source]: Remove mkpasswd sources in a > snippet. > [native-inputs]: Add gettext. > [arguments]: Add ‘update-po’ phase. > [description]: Remove historical not about bundled mkpasswd. ^^^ Sigh. Noted. Kind regards, T G-R From unknown Sun Jun 22 07:48:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. Resent-From: ng0 Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jan 2018 06:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 30037@debbugs.gnu.org Received: via spool by 30037-submit@debbugs.gnu.org id=B30037.151548073320813 (code B ref 30037); Tue, 09 Jan 2018 06:53:02 +0000 Received: (at 30037) by debbugs.gnu.org; 9 Jan 2018 06:52:13 +0000 Received: from localhost ([127.0.0.1]:41990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYnlV-0005PV-Ji for submit@debbugs.gnu.org; Tue, 09 Jan 2018 01:52:12 -0500 Received: from aibo.runbox.com ([91.220.196.211]:55120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYnlU-0005PK-0K for 30037@debbugs.gnu.org; Tue, 09 Jan 2018 01:52:04 -0500 Received: from [10.9.9.212] (helo=mailfront12.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1eYnlS-0006Nz-JR; Tue, 09 Jan 2018 07:52:02 +0100 Received: from dslb-088-078-094-182.088.078.pools.vodafone-ip.de ([88.78.94.182] helo=localhost) by mailfront12.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1eYnlO-0005M7-Je; Tue, 09 Jan 2018 07:51:58 +0100 Date: Tue, 9 Jan 2018 06:51:57 +0000 From: ng0 Message-ID: <20180109065157.j4ffqj7rye5wwike@abyayala> References: <20180109010138.29740-1-me@tobias.gr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="auftsf2hbl6ui4fx" Content-Disposition: inline In-Reply-To: <20180109010138.29740-1-me@tobias.gr> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --auftsf2hbl6ui4fx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice transcribed 3.4K bytes: > * gnu/packages/networking.scm (whois)[source]: Remove mkpasswd sources in= a > snippet. > [native-inputs]: Add gettext. > [arguments]: Add =E2=80=98update-po=E2=80=99 phase. > [description]: Remove historical not about bundled mkpasswd. > --- >=20 > Guix, >=20 > A quick TODO item glanced in a recent commit notification, done. >=20 > While everything could be done in a single phase, I prefer ripping such > cruft out early. Manually building the modified sources works fine, at > the cost of slightly bloated .po files with some unused strings. It's > unlikely someone will want to unpack this to build mkpasswd... or you could move the mkpasswd to its own output. I think you want to look into the old discussions around this. I don't remember why this wasn't chosen, all I know is that upstream made it very clear to me that they won't separate mkpasswd. >=20 > Then again, it's not a licence issue so I don't really care that much. >=20 > Kind regards, >=20 > T G-R >=20 > gnu/packages/networking.scm | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) >=20 > diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm > index 94621052d..9a8993be2 100644 > --- a/gnu/packages/networking.scm > +++ b/gnu/packages/networking.scm > @@ -4,7 +4,7 @@ > ;;; Copyright =C2=A9 2015 Mark H Weaver > ;;; Copyright =C2=A9 2015, 2016, 2017 Stefan Reich=C3=B6r > ;;; Copyright =C2=A9 2016 Raimon Grau > -;;; Copyright =C2=A9 2016, 2017 Tobias Geerinckx-Rice > +;;; Copyright =C2=A9 2016, 2017, 2018 Tobias Geerinckx-Rice > ;;; Copyright =C2=A9 2016 John Darrington > ;;; Copyright =C2=A9 2016, 2017 Nicolas Goaziou > ;;; Copyright =C2=A9 2016 Eric Bavier > @@ -458,15 +458,31 @@ and up to 1 Mbit/s downstream.") > name "_" version ".tar.xz")) > (sha256 > (base32 > - "02f00vpgrdb77w7lskl9jfm2akpy21ws9cjazs13gash2xksnj38")))) > + "02f00vpgrdb77w7lskl9jfm2akpy21ws9cjazs13gash2xksnj38")) > + (modules '((guix build utils))) > + (snippet > + '(begin > + ;; Remove unused =E2=80=98mkpasswd=E2=80=99 bundled for histo= rical reasons. > + (for-each delete-file > + (find-files "." "^mkpasswd\\.")) > + (substitute* "Makefile" > + ((" (install-|)mkpasswd ") " ")) > + (substitute* "po/Makefile" > + (("\\.\\./mkpasswd\\.c") "")) > + #t)))) > (build-system gnu-build-system) > - ;; TODO: unbundle mkpasswd binary + its po files. > + (native-inputs > + `(("gettext" ,gettext))) ; for update-po phase > (arguments > `(#:tests? #f ; Does not exist > #:make-flags (list "CC=3Dgcc" > (string-append "prefix=3D" (assoc-ref %outputs= "out"))) > #:phases > (modify-phases %standard-phases > + (add-after 'unpack 'update-po > + ;; Remove harmless but useless =E2=80=98mkpasswd=E2=80=99 rem= nants from .po files. > + (lambda _ > + (invoke "make" "-C" "po" "update-po"))) > (delete 'configure) ; No configure > (add-before 'build 'setenv > (lambda _ > @@ -481,9 +497,7 @@ and up to 1 Mbit/s downstream.") > ("pkg-config" ,pkg-config))) > (synopsis "Improved whois client") > (description "This whois client is intelligent and can > -automatically select the appropriate whois server for most queries. > -Because of historical reasons this also includes a tool called mkpasswd > -which can be used to encrypt a password with @code{crypt(3)}.") > +automatically select the appropriate whois server for most queries.") > (home-page "https://github.com/rfc1036/whois") > (license license:gpl2+))) > =20 > --=20 > 2.15.0 >=20 >=20 >=20 >=20 >=20 --=20 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys WWW: https://n0.is/a/ :: https://ea.n0.is --auftsf2hbl6ui4fx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlpUZo0ACgkQ4i+bv+40 hYjM1RAAq5GEIQtGNhz3PjQevmrO/sCOKbE6oFNxdstSExouCMYslEj6fKLnnKqC RDDcgkNSE5uuJpPfHtkL7w7rFmHGcudRuaNFeUgqaUdqg+lQ0TOpVNhwxV+L0x0W Ryeu25AJvFCgM03MFDrpBebzx2ZxNo9zZGTh7sU68Jx/vPU5m+Yi1hXrihomMRh3 TGeHlt1Uj444Q30eLYZhaORVGpDuE2HKthS1aW7gtBUz+VjAJDXmFh0iSfENJhtj bJE/Rf5t0oRJhg1Xh65l1ljSGaNIQdP90nmgD7JCp1CKxvv8jcVylXyG71dCoFIu qkHzqPkpPYBsU11kMQC5Z3r3Gk6qj47lW2VLxP60SraXfBDFmOhGbfyyPNVjo4BD BlpyspLjK8zXNtqyhaSR1WyvuvKoHRY+lbQyDzrJRXO9evfSwB4BgP4hUbR2XkVf 2hwUv7IuvLj6394mXjTx+TKQ38zvw748lhoHF1dMc6bvrt8ytBXplhrIQ9UehTVO M15GYF7FNEMD1SmTRQNzMIZei/IQTBH4/izXGE2pq0o1adTYI+EDpfX5KFQ4WUYK ExZ4xJiFdoiJ15Ebq/7hIrLKKFrXeWxuZdGAOGM+wGZrE1eRecFVSX3SkbUdUphD kLcFBZzJdns6exOjmHuGPaUYQ2y2HYxU682Ivnv8xJezvrZhu6g= =a6nP -----END PGP SIGNATURE----- --auftsf2hbl6ui4fx-- From unknown Sun Jun 22 07:48:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jan 2018 13:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 30037@debbugs.gnu.org Received: via spool by 30037-submit@debbugs.gnu.org id=B30037.15155050075028 (code B ref 30037); Tue, 09 Jan 2018 13:37:01 +0000 Received: (at 30037) by debbugs.gnu.org; 9 Jan 2018 13:36:47 +0000 Received: from localhost ([127.0.0.1]:42228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYu59-0001J2-JZ for submit@debbugs.gnu.org; Tue, 09 Jan 2018 08:36:47 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:43320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYu58-0001Iu-65 for 30037@debbugs.gnu.org; Tue, 09 Jan 2018 08:36:46 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 25181F8C9; Tue, 9 Jan 2018 14:36:45 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jYIBkfR_eSBX; Tue, 9 Jan 2018 14:36:43 +0100 (CET) Received: from ribbon (unknown [193.50.110.243]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 415B9F8C7; Tue, 9 Jan 2018 14:36:43 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180109010138.29740-1-me@tobias.gr> Date: Tue, 09 Jan 2018 14:36:41 +0100 In-Reply-To: <20180109010138.29740-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Tue, 9 Jan 2018 02:01:38 +0100") Message-ID: <877esrtaqe.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Tobias Geerinckx-Rice skribis: > * gnu/packages/networking.scm (whois)[source]: Remove mkpasswd sources in= a > snippet. > [native-inputs]: Add gettext. > [arguments]: Add =E2=80=98update-po=E2=80=99 phase. > [description]: Remove historical not about bundled mkpasswd. LGTM, thanks! Ludo'. From unknown Sun Jun 22 07:48:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jan 2018 16:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ng0@n0.is Cc: 30037@debbugs.gnu.org Received: via spool by 30037-submit@debbugs.gnu.org id=B30037.15155162091679 (code B ref 30037); Tue, 09 Jan 2018 16:44:02 +0000 Received: (at 30037) by debbugs.gnu.org; 9 Jan 2018 16:43:29 +0000 Received: from localhost ([127.0.0.1]:49799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYwzp-0000R1-3V for submit@debbugs.gnu.org; Tue, 09 Jan 2018 11:43:29 -0500 Received: from tobias.gr ([51.15.135.5]:36626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYwzn-0000Qq-GO for 30037@debbugs.gnu.org; Tue, 09 Jan 2018 11:43:28 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id 5512c85e; Tue, 9 Jan 2018 16:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type; s=2018; bh=5tMd7ivENpqnKrOMyqB9lIueER8Tmf3Dn4D2Q5 CEOHk=; b=lJ5TnGd6WmoeuNqCO/p7AhjnpbtRNfqvahYqhLnwXqPeVI1oOh3V9j Q/Xgs+1RELCyBbXKMOZZwKnSFbXXSXe2Zd4S/T00UkCtKddJOdmYMJ7yzY6tDdU6 uJ117QJAKOLAHTPQ96FiUMWio2HDN0Ob6LWNbiBt359eIvgHGnNyHM17zgaqVwTz qfpaAbtfr7m3h2m1o2A8+yMItN+7bUlXm7gXlC/V2Lh9N/y5favSbYYCciN56bhM C52/USWf9lx338cUgXenrkvgk4+mYQqyjrhfdTCRdWsD657QJ0sGfxjMMPkPlmeA 6aTvxDyCMJKKjQQXdl6ndKrfmq6b2oYg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id b2d5618a (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Tue, 9 Jan 2018 16:43:23 +0000 (UTC) References: <20180109010138.29740-1-me@tobias.gr> <20180109065157.j4ffqj7rye5wwike@abyayala> From: Tobias Geerinckx-Rice Message-ID: <65a6b7e7-afca-cc9e-d1b7-cf23038800d4@tobias.gr> Date: Tue, 9 Jan 2018 17:46:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180109065157.j4ffqj7rye5wwike@abyayala> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h4Q7vayftDwKveUhsueBq2LkAI5pRB47k" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --h4Q7vayftDwKveUhsueBq2LkAI5pRB47k Content-Type: multipart/mixed; boundary="HyCQXaWTFELCJRNODgs8zAWS48z33v24I"; protected-headers="v1" From: Tobias Geerinckx-Rice To: ng0@n0.is Cc: 30037@debbugs.gnu.org Message-ID: <65a6b7e7-afca-cc9e-d1b7-cf23038800d4@tobias.gr> Subject: Re: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. References: <20180109010138.29740-1-me@tobias.gr> <20180109065157.j4ffqj7rye5wwike@abyayala> In-Reply-To: <20180109065157.j4ffqj7rye5wwike@abyayala> --HyCQXaWTFELCJRNODgs8zAWS48z33v24I Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable ng0, ng0 wrote on 09/01/18 at 07:51: > or you could move the mkpasswd to its own output. That's not (a step towards) unbundling, though, is it? > I think you want to look into the old discussions around this. I > don't remember why this wasn't chosen, all I know is that upstream > made it very clear to me that they won't separate mkpasswd. OK, I found this thread[0] on guix-devel. I'd only checked guix-patches. I can somewhat understand your use of the word =E2=80=98bundle=E2=80=99 i= n the TODO comment =E2=80=94 or at least where it came from =E2=80=94 but it's prett= y misleading in that context. As you rightly noted: Ludo'> Why to you call that =E2=80=9Cunbundling=E2=80=9D? ng0> Wrong choice of words. [...] ng0> It's annoying that two unrelated applications are thrown ng0> into one distribution/package. It would have been nice to adjust the comment at that point, or mention that this =E2=80=98mkpasswd=E2=80=99 is unrelated to the better-known Exp= ect =E2=80=98mkpasswd=E2=80=99. (Hark, this one doesn't even mk passwds! For maximum irony, it was renamed from =E2=80=98cryptpw=E2=80=99, which perfectly described its pu= rpose...) Since this is its own thing, for better or worse, I agree with the others in that thread that it should remain part of this package/output until upstream repents. Kind regards, T G-R [0]: https://lists.gnu.org/archive/html/guix-devel/2017-01/msg00504.html --HyCQXaWTFELCJRNODgs8zAWS48z33v24I-- --h4Q7vayftDwKveUhsueBq2LkAI5pRB47k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCWlTx2g0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15DsUBAJmFTvRddWyBofE6ghSEC1e6xayGrStlds6xKtwA i34jAP4gaZCT16SIrv8xvMh0vFTgIx0OUEfxdomqx0znHQ1AAw== =7GjR -----END PGP SIGNATURE----- --h4Q7vayftDwKveUhsueBq2LkAI5pRB47k-- From unknown Sun Jun 22 07:48:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jan 2018 16:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org Cc: 30037@debbugs.gnu.org Received: via spool by 30037-submit@debbugs.gnu.org id=B30037.15155162321718 (code B ref 30037); Tue, 09 Jan 2018 16:44:02 +0000 Received: (at 30037) by debbugs.gnu.org; 9 Jan 2018 16:43:52 +0000 Received: from localhost ([127.0.0.1]:49802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYx0C-0000Re-CK for submit@debbugs.gnu.org; Tue, 09 Jan 2018 11:43:52 -0500 Received: from tobias.gr ([51.15.135.5]:36630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYx0A-0000RT-8D for 30037@debbugs.gnu.org; Tue, 09 Jan 2018 11:43:50 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id 8a8bead6; Tue, 9 Jan 2018 16:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=2018; bh=4+1MtqJ7zE9F pxMB42ozsVQD2yv7HZwweFoqbDIB7i0=; b=VjdDAfrHFqVgFuR9vtAOlc3iseI+ uO4XGChjih6lN+nAIyLfXZNUUX6Rax2/6XdNU08NQi2Ummbx5YGHgSAbauZwGqpW KPoTE9MWwpR5Ta3ZI2i5JFCv0lAVHeZ1HmQ0wNgtDJgE92APYBPr36uLbAIU0/t9 HB6pUFVPkCShmAcxyug59GUQ2iYEblPZXU0fcyHc28OltArTTP/cioDD0q77OtnT oBs5iKgtwr/FoLXQ8r/VqelnAWWIBVtWeMJi0Ka+MTvRXUNGSeSP/8ZTahGEJMfU nrThgM80YfUzBmW2U5TB4PY8AGsxTitl8/u9JUcZ9aqHoNVO1yoZ3Dgscw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 8288c2c6 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Tue, 9 Jan 2018 16:43:47 +0000 (UTC) References: <20180109010138.29740-1-me@tobias.gr> <877esrtaqe.fsf@gnu.org> From: Tobias Geerinckx-Rice Message-ID: <11ef27fb-447c-254e-fd07-6574cdf26ed9@tobias.gr> Date: Tue, 9 Jan 2018 17:46:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <877esrtaqe.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Ludo', Ludovic Courtès wrote on 09/01/18 at 14:36: > LGTM, thanks! Thanks. However, I'm now convinced that this program is confusingly named but belongs where it is, and we should simply remove the TODO comment. It's not ‘bundled’ in the sense of the word we use. If no-one objects I'll do just that & close this bug. Kind regards, T G-R From unknown Sun Jun 22 07:48:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jan 2018 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice , ludo@gnu.org Cc: 30037@debbugs.gnu.org Received: via spool by 30037-submit@debbugs.gnu.org id=B30037.15155175633926 (code B ref 30037); Tue, 09 Jan 2018 17:07:02 +0000 Received: (at 30037) by debbugs.gnu.org; 9 Jan 2018 17:06:03 +0000 Received: from localhost ([127.0.0.1]:49819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYxLf-00011G-DG for submit@debbugs.gnu.org; Tue, 09 Jan 2018 12:06:03 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:45121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYxLe-000119-Fa for 30037@debbugs.gnu.org; Tue, 09 Jan 2018 12:06:02 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1DC7120D12; Tue, 9 Jan 2018 12:06:02 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Tue, 09 Jan 2018 12:06:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=ewqsFGi6/8XEfF53RN0v+Ra0CTy+GFmqt+gavqoSHXI=; b=YHedsJp1 9wA36mY59prVDp7c5gTfN2/TO6IdbTu4t4seUoabYYgn3dchkoHzcKvvRXUyknd9 i4332I/h3i7rQaOWv7Al3QzJTYAxoB7o9bF7q8fr35jHU70tSKLbTYE6U3NNEW++ B/rBRNygJ78DOOWY2VpQa4IVnfj1O6vNNoc2fpdRcPQzorPTDycfPgRUoCb6J023 +kgv0/u9tNQ9DOpcoh5a8lLssjjZSPd0UZv3u5ALDsEwbcj6hrnr31rHzLtafZ/g lo4aGo/tozqKdch6nTYswMkC+I8RUq5PjeBKMCUYsgoPUfHvTLUdxVunDyKdkKfI 1LniayBQlsaFWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=ewqsFGi6/8XEfF53RN0v+Ra0CTy+G Fmqt+gavqoSHXI=; b=ZldsyfHqFMVxusYSqz23GsbdEeX6kYW7BcuDFaAFpD1ti d9W9nXsCp96ibVJ4kfOwixhxfFuOUaERPQygtvNt9oensxwAD/wE1U8VeA1HqL7W KhOK+e8ckfQW4VETqgf03xBv4+83Nl+T2JmBOxss6y12OjXAojWizHAsa80Qkb1x Nd1neTe7VEsGGnJSBDZA3ylTiRCThCT60xj3krtMLVM+YDPQisBY+o8QP3h6m58n B9JJj84mmcvRubeWcdU0FCxd80lOfEv0dueXmRzIox/cXJojhvjZAR2xfF1qRZG0 s0dJG4kt85UXUjePoAu/qFdZjluEFJ4I67YhnNEmQ== X-ME-Sender: Received: from localhost (cm-84.214.173.174.getinternet.no [84.214.173.174]) by mail.messagingengine.com (Postfix) with ESMTPA id 83E817E322; Tue, 9 Jan 2018 12:06:01 -0500 (EST) From: Marius Bakke In-Reply-To: <11ef27fb-447c-254e-fd07-6574cdf26ed9@tobias.gr> References: <20180109010138.29740-1-me@tobias.gr> <877esrtaqe.fsf@gnu.org> <11ef27fb-447c-254e-fd07-6574cdf26ed9@tobias.gr> User-Agent: Notmuch/0.25.3 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Tue, 09 Jan 2018 18:05:55 +0100 Message-ID: <87shbf2c98.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice writes: > Ludo', > > Ludovic Court=C3=A8s wrote on 09/01/18 at 14:36: >> LGTM, thanks! > > Thanks. However, I'm now convinced that this program is confusingly > named but belongs where it is, and we should simply remove the TODO > comment. It's not =E2=80=98bundled=E2=80=99 in the sense of the word we u= se. > > If no-one objects I'll do just that & close this bug. LGTM! I was just about to write that I actually *use* this software, and suggest doing the same thing. It's a convenient tool for generating a password string suitable for /etc/shadow. And it's tiny, so separating it out seems "overkill". --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlpU9nMACgkQoqBt8qM6 VPqxGAf/d/VuHFSwnrFsLr4TENLHAiCOpVEXp/v1UJbm9atv4E05UQZ0rANJlyU3 3PLvNsYCqkLWbyeDKUdh2i2OBOjrGpnPVXKd6Kapdthf/TjaVrUdtaCPV6bM3uBx shiwE376h6mvG7Zt027Rs2YSGMmL5dkA7qqeC+bdDALrzTyFBs38nNaWPN/feLU9 A/IS30bd3rjVXhr0VU+oVb3Eh1XUx1wP1FFqxCiNHPVIfHZ1AZ/CdApUyajy2j/w B8sBGAG2ggBrWeGSizdsdCDLGfUkqC7vDox/qkgbWJfRXOPUoXORjbv3Bvn4HHc8 B+4Zq8R1jxXIV5x6fJUk8QPOuB/Yhw== =c7jo -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 07:48:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. Resent-From: ng0 Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Jan 2018 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: ludo@gnu.org, Tobias Geerinckx-Rice , 30037@debbugs.gnu.org Received: via spool by 30037-submit@debbugs.gnu.org id=B30037.151559204526314 (code B ref 30037); Wed, 10 Jan 2018 13:48:02 +0000 Received: (at 30037) by debbugs.gnu.org; 10 Jan 2018 13:47:25 +0000 Received: from localhost ([127.0.0.1]:50353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZGiy-0006qL-Hn for submit@debbugs.gnu.org; Wed, 10 Jan 2018 08:47:24 -0500 Received: from aibo.runbox.com ([91.220.196.211]:58098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZGiw-0006qD-NL for 30037@debbugs.gnu.org; Wed, 10 Jan 2018 08:47:23 -0500 Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1eZGis-00005Y-H6; Wed, 10 Jan 2018 14:47:18 +0100 Received: from dslb-088-078-094-182.088.078.pools.vodafone-ip.de ([88.78.94.182] helo=localhost) by mailfront10.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1eZGiN-0004oB-7c; Wed, 10 Jan 2018 14:46:47 +0100 Date: Wed, 10 Jan 2018 14:46:55 +0000 From: ng0 Message-ID: <20180110144655.iq4q7spqf3ng5w2y@abyayala> References: <20180109010138.29740-1-me@tobias.gr> <877esrtaqe.fsf@gnu.org> <11ef27fb-447c-254e-fd07-6574cdf26ed9@tobias.gr> <87shbf2c98.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z5bgu72e3hf6pis2" Content-Disposition: inline In-Reply-To: <87shbf2c98.fsf@fastmail.com> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --z5bgu72e3hf6pis2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Marius Bakke transcribed 1.3K bytes: > Tobias Geerinckx-Rice writes: >=20 > > Ludo', > > > > Ludovic Court=C3=A8s wrote on 09/01/18 at 14:36: > >> LGTM, thanks! > > > > Thanks. However, I'm now convinced that this program is confusingly > > named but belongs where it is, and we should simply remove the TODO > > comment. It's not =E2=80=98bundled=E2=80=99 in the sense of the word we= use. > > > > If no-one objects I'll do just that & close this bug. >=20 > LGTM! >=20 > I was just about to write that I actually *use* this software, and > suggest doing the same thing. It's a convenient tool for generating a > password string suitable for /etc/shadow. And it's tiny, so separating > it out seems "overkill". Which is exactly what we concluded in the old thread about this, which I suggested to read. I just should've removed the TODO note a long time ago. I still find mkpasswd feels like an historical accident bundling in favor of some OS that relies on it (iirc the old thread or authors replies), but doesn't really matter. Bikeshedding on the highest level of bikesheds I guess. --=20 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys WWW: https://n0.is/a/ :: https://ea.n0.is --z5bgu72e3hf6pis2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlpWJ18ACgkQ4i+bv+40 hYijQBAAl/+1TcxlsiyEBrBDXez2IUd1JKZq+hATv15X19CMC1BwHeGURDTAYIrq BEW7K1zaE9bfQxN1hwdrbLl57BCPis/J+bUiseHVvLleqlVk96i7nzdby2Vyk8tr k2Br/HPpex+ayuDVe9VjsQNun2hlkbqA2U3JlwNNHjfB5YHxrdQ82p/UvxsIXjlu TeZg4Sp/v/OQuGoxiBj00G9ojPAIPPh8hfrH8GYy+YjJe2S1xVX4rcSaCqnVLMft 0slwvuk5dAqBFwIOk9iYloTTE2mlMsbTczEU4fZ9HyyG2He/kjPUZBLHOTOzX26T GT0PnffSNjYsv9qR9IQAEsKJc2wzcjiK/k8jURKOUYxLC4ORF/csWBMFeXzHcNWk zPNg9wkfJddPryoPfRIBH3G93Z3vY0AnPMGIGJCVgk9CGBlKeonQaC2VoTEABdxd 7J836Y+NXKHVPwdh4PsILu0/maHkERL+oahIJ1YoqkmO0D9yKGyMixYRBq28pN2u cmZvPykTXwPt5jlX6l5xIn0ENB7dqPIo3fLBjVzE+SzXG3rJVn2roUKYGNdB6ZYp 1Iw6ZKrtQiORHgLcBBRaMj4FfCFWMRABgB3rparUmiKYn/pWUwi99uJQ7F8SJNl1 PQrAYgzgd63SevqbGZ4ypA6GZ5h8+Lo96qNtU5fKZC9n/RI/jNc= =9Onq -----END PGP SIGNATURE----- --z5bgu72e3hf6pis2-- From unknown Sun Jun 22 07:48:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. Resent-From: ng0 Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Jan 2018 13:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 30037@debbugs.gnu.org, ng0@n0.is Received: via spool by 30037-submit@debbugs.gnu.org id=B30037.151559257427222 (code B ref 30037); Wed, 10 Jan 2018 13:57:02 +0000 Received: (at 30037) by debbugs.gnu.org; 10 Jan 2018 13:56:14 +0000 Received: from localhost ([127.0.0.1]:50357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZGrV-00074z-JW for submit@debbugs.gnu.org; Wed, 10 Jan 2018 08:56:13 -0500 Received: from aibo.runbox.com ([91.220.196.211]:58722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZGrS-00074n-Cy for 30037@debbugs.gnu.org; Wed, 10 Jan 2018 08:56:10 -0500 Received: from [10.9.9.212] (helo=mailfront12.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1eZGrR-0000oN-14; Wed, 10 Jan 2018 14:56:09 +0100 Received: from dslb-088-078-094-182.088.078.pools.vodafone-ip.de ([88.78.94.182] helo=localhost) by mailfront12.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1eZGr4-0005LZ-3e; Wed, 10 Jan 2018 14:55:46 +0100 Date: Wed, 10 Jan 2018 14:55:54 +0000 From: ng0 Message-ID: <20180110145554.bdnge6atptnrsg7c@abyayala> References: <20180109010138.29740-1-me@tobias.gr> <20180109065157.j4ffqj7rye5wwike@abyayala> <65a6b7e7-afca-cc9e-d1b7-cf23038800d4@tobias.gr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c33baftoxiz634o5" Content-Disposition: inline In-Reply-To: <65a6b7e7-afca-cc9e-d1b7-cf23038800d4@tobias.gr> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --c33baftoxiz634o5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice transcribed 2.6K bytes: > ng0, >=20 > ng0 wrote on 09/01/18 at 07:51: > > or you could move the mkpasswd to its own output. >=20 > That's not (a step towards) unbundling, though, is it? >=20 > > I think you want to look into the old discussions around this. I > > don't remember why this wasn't chosen, all I know is that upstream > > made it very clear to me that they won't separate mkpasswd. >=20 > OK, I found this thread[0] on guix-devel. I'd only checked guix-patches. >=20 > I can somewhat understand your use of the word =E2=80=98bundle=E2=80=99 i= n the TODO > comment =E2=80=94 or at least where it came from =E2=80=94 but it's prett= y misleading in > that context. As you rightly noted: >=20 > Ludo'> Why to you call that =E2=80=9Cunbundling=E2=80=9D? > ng0> Wrong choice of words. > [...] > ng0> It's annoying that two unrelated applications are thrown > ng0> into one distribution/package. >=20 > It would have been nice to adjust the comment at that point, or mention > that this =E2=80=98mkpasswd=E2=80=99 is unrelated to the better-known Exp= ect =E2=80=98mkpasswd=E2=80=99. >=20 > (Hark, this one doesn't even mk passwds! For maximum irony, it was > renamed from =E2=80=98cryptpw=E2=80=99, which perfectly described its pu= rpose...) >=20 > Since this is its own thing, for better or worse, I agree with the > others in that thread that it should remain part of this package/output > until upstream repents. >=20 > Kind regards, >=20 > T G-R >=20 > [0]: https://lists.gnu.org/archive/html/guix-devel/2017-01/msg00504.html >=20 I had whois installed for some time, but consider this (or test it): What if someone under account root install 'whois' into their profile. Wouldn't they have 2 mkpasswd now in their path of exectuables and encounter a collision? Should we rename it for the sake of namespace collisions reduction? --=20 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys WWW: https://n0.is/a/ :: https://ea.n0.is --c33baftoxiz634o5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlpWKXoACgkQ4i+bv+40 hYi7QA//QIF21ehv0JyQ41hhhGI0yEAFtl3ksyHJP4OlNjzps5qPmHqRlVYVroks f4mChgE7kJAJQ4zmV229kvqQoRIvHRuD916k4poQwhwSvLockxxknX23DZcXjyxc u3NlbInyYqforVEXlORi+LP0uGVo5LpUn7ilcfzi4kOH93exH3Cik5Wd3cyML012 laBRpySKH6f5Zg7ENmIUuooj56oFSrmsRd472dye3TT8nrayCgHxJHb89tpImUR0 GSjw+2v9zdkr0bMySwa9iGLanYfUONF72cvbMVivryrjS+Y8/GYn8w69+O1b60MP KR26dt54E5At3ryw5+SkYnauQN8mjM3uoLi0yXejxoHUvTIAt32x+kyaV23pLA5P DJlpLq9YqdESuBiP6/4n+OIyQWcva741yWh29hjB4CYr9objsoeKE65P2feRaY5C c3dy9L2eJ+RbdFYzkwydW99xMRlKb/PFj2wjhXczHblrjUhVigP7j+GV8biuQAVd ntg17RKdnxUzcQHg/a84WFqVtSixHScr/3XIyMTMlGrPrFjdVZf4f7b5X1rr2Hsv 5OOvs0zH61SjyVnJQcZPOV2c3uvY+k9JFvJdusitEvudHYU+nZyKQPdRclXQXwOh BG5m1JcCmkTIwH1OYGVrUTSIpFiEYXhoZpXwjzN07pBMRlumbCQ= =Amiu -----END PGP SIGNATURE----- --c33baftoxiz634o5-- From unknown Sun Jun 22 07:48:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Tobias Geerinckx-Rice Subject: bug#30037: closed (Re: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd.) Message-ID: References: <20180109010138.29740-1-me@tobias.gr> X-Gnu-PR-Message: they-closed 30037 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 30037@debbugs.gnu.org Date: Wed, 10 Jan 2018 15:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1515597842-11089-1" This is a multi-part message in MIME format... ------------=_1515597842-11089-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #30037: [PATCH] gnu: whois: Remove bundled mkpasswd. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 30037@debbugs.gnu.org. --=20 30037: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30037 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1515597842-11089-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 30037-done) by debbugs.gnu.org; 10 Jan 2018 15:23:48 +0000 Received: from localhost ([127.0.0.1]:51157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZIEG-0002sM-B4 for submit@debbugs.gnu.org; Wed, 10 Jan 2018 10:23:48 -0500 Received: from tobias.gr ([51.15.135.5]:34496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZIEF-0002sE-8J for 30037-done@debbugs.gnu.org; Wed, 10 Jan 2018 10:23:47 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id bb902de2; Wed, 10 Jan 2018 15:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type; s=2018; bh=9ewjfGsv96K1k8civ8OOUadcsehSNRzR/Ze5kb 3ie2o=; b=ZW/7HZrJjNf819Bp9+S1Fk/UwR9Mbce8mWOmI2lmqPPecbvCnnxHBz mEfz44BQhSlRMGUYxmSWuEOTKiaxQQ8yKdE72GjTUGPbOuS3EpB2vgQAIUu9TKLZ jYdQ20JUmVEmgexmFCYIFnFw6PU4gfolFYNGfbdKi103ydn5aFsLshklFf3oBLjX edl8EYMS8D7XRuP1ic0DoVX5Z71/ybLZQi4G6Rq73dnJJfA8pTJOZ4fJZ83Fd65z FOnqSCuI8xTjjYIE0PYG/fkMz2ybdDmUhXyZ3v78YXuk+9hlHJDCtk+woB4lIFm2 pc62i/W8fR1NyfS0SXdUTVmVrYwg2Wdw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 2b7bee86 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Wed, 10 Jan 2018 15:23:42 +0000 (UTC) Subject: Re: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. To: ng0@n0.is, mbakke@fastmail.com References: <20180109010138.29740-1-me@tobias.gr> <877esrtaqe.fsf@gnu.org> <11ef27fb-447c-254e-fd07-6574cdf26ed9@tobias.gr> <87shbf2c98.fsf@fastmail.com> <20180110144655.iq4q7spqf3ng5w2y@abyayala> From: Tobias Geerinckx-Rice Message-ID: Date: Wed, 10 Jan 2018 16:26:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180110144655.iq4q7spqf3ng5w2y@abyayala> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MmCp5lGYNzBJ0UwPgMUOFOzCCU2NSnDWo" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30037-done Cc: ludo@gnu.org, 30037-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MmCp5lGYNzBJ0UwPgMUOFOzCCU2NSnDWo Content-Type: multipart/mixed; boundary="XvKWXVUhx9eXpv7DspnJhfgnlqVphsaVh"; protected-headers="v1" From: Tobias Geerinckx-Rice To: ng0@n0.is, mbakke@fastmail.com Cc: ludo@gnu.org, 30037-done@debbugs.gnu.org Message-ID: Subject: Re: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. References: <20180109010138.29740-1-me@tobias.gr> <877esrtaqe.fsf@gnu.org> <11ef27fb-447c-254e-fd07-6574cdf26ed9@tobias.gr> <87shbf2c98.fsf@fastmail.com> <20180110144655.iq4q7spqf3ng5w2y@abyayala> In-Reply-To: <20180110144655.iq4q7spqf3ng5w2y@abyayala> --XvKWXVUhx9eXpv7DspnJhfgnlqVphsaVh Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable ng0 wrote on 10/01/18 at 15:46: > Which is exactly what we concluded in the old thread about this, > which I suggested to read. I just should've removed the TODO note a > long time ago. As I wrote in my previous message addressing that exact thread, that would have been nice. No harm done beyond some wasted time. > I still find mkpasswd feels like an historical accident bundling in > favor of some OS that relies on it (iirc the old thread or authors > replies), but doesn't really matter. Bikeshedding on the highest > level of bikesheds I guess. Yup :-) I've removed the comment in master and am closing the shed. Kind regards, T G-R --XvKWXVUhx9eXpv7DspnJhfgnlqVphsaVh-- --MmCp5lGYNzBJ0UwPgMUOFOzCCU2NSnDWo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCWlYwrg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15kvoA/in1JaQEK7kRQqLSKqDhr5b32B77x3By16XkIbht 7JjZAQDLjcDVkWY0QzT6JGEf+oQ+bBu/jB8V0v0G1paw2EP2AA== =NJdT -----END PGP SIGNATURE----- --MmCp5lGYNzBJ0UwPgMUOFOzCCU2NSnDWo-- ------------=_1515597842-11089-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Jan 2018 00:59:15 +0000 Received: from localhost ([127.0.0.1]:41906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYiFx-0004pt-QY for submit@debbugs.gnu.org; Mon, 08 Jan 2018 19:59:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYiFw-0004pf-0Y for submit@debbugs.gnu.org; Mon, 08 Jan 2018 19:59:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYiFp-0002Xr-Mm for submit@debbugs.gnu.org; Mon, 08 Jan 2018 19:59:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59333) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eYiFp-0002Xj-Ij for submit@debbugs.gnu.org; Mon, 08 Jan 2018 19:59:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYiFo-0002SR-0p for guix-patches@gnu.org; Mon, 08 Jan 2018 19:59:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYiFm-0002Ud-E1 for guix-patches@gnu.org; Mon, 08 Jan 2018 19:59:00 -0500 Received: from tobias.gr ([2001:470:cc92::1]:34190) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eYiFl-0002Sq-Sq for guix-patches@gnu.org; Mon, 08 Jan 2018 19:58:58 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id 01e6f260 for ; Tue, 9 Jan 2018 00:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=2018; bh=XHgmGJ1zgVjg3qTyF4Fak6zVV PoyBYniJJ3Tyu6xaCw=; b=iRcM8b+cIknrKDq/zB1Bvw+rbCcJOYTnyXI7c0J+G kn4AAUzupEPz4YJYsPnBbG3AdspjA14c5s73pUMgnZ9T4PC2N447BfRiXUzRjCIC Ab+WCiVz/wIk8AqJB3+4vhJZFgFFqLuzC/TuEXJGER9V8cb+8u46zw0FwaK4tN/C IeUwMF3v0SoJhLWQ8AEtXEc0ViAs8MPxB23ek1uAnHRzo98OrVNu169mhoto71r0 boJTEeRYjTmC8pJSPGREv8TRLcYJmZvLlW1U2iIFJ9R5II0icen7dpkj3YWqGMg1 OYnk4fpgtq2FEAnH2/ZetmtrZUdI5lSglHAAXg0J/GBIg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 85590694 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for ; Tue, 9 Jan 2018 00:58:53 +0000 (UTC) From: Tobias Geerinckx-Rice To: guix-patches@gnu.org Subject: [PATCH] gnu: whois: Remove bundled mkpasswd. Date: Tue, 9 Jan 2018 02:01:38 +0100 Message-Id: <20180109010138.29740-1-me@tobias.gr> X-Mailer: git-send-email 2.15.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) * gnu/packages/networking.scm (whois)[source]: Remove mkpasswd sources in a snippet. [native-inputs]: Add gettext. [arguments]: Add ‘update-po’ phase. [description]: Remove historical not about bundled mkpasswd. --- Guix, A quick TODO item glanced in a recent commit notification, done. While everything could be done in a single phase, I prefer ripping such cruft out early. Manually building the modified sources works fine, at the cost of slightly bloated .po files with some unused strings. It's unlikely someone will want to unpack this to build mkpasswd... Then again, it's not a licence issue so I don't really care that much. Kind regards, T G-R gnu/packages/networking.scm | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index 94621052d..9a8993be2 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -4,7 +4,7 @@ ;;; Copyright © 2015 Mark H Weaver ;;; Copyright © 2015, 2016, 2017 Stefan Reichör ;;; Copyright © 2016 Raimon Grau -;;; Copyright © 2016, 2017 Tobias Geerinckx-Rice +;;; Copyright © 2016, 2017, 2018 Tobias Geerinckx-Rice ;;; Copyright © 2016 John Darrington ;;; Copyright © 2016, 2017 Nicolas Goaziou ;;; Copyright © 2016 Eric Bavier @@ -458,15 +458,31 @@ and up to 1 Mbit/s downstream.") name "_" version ".tar.xz")) (sha256 (base32 - "02f00vpgrdb77w7lskl9jfm2akpy21ws9cjazs13gash2xksnj38")))) + "02f00vpgrdb77w7lskl9jfm2akpy21ws9cjazs13gash2xksnj38")) + (modules '((guix build utils))) + (snippet + '(begin + ;; Remove unused ‘mkpasswd’ bundled for historical reasons. + (for-each delete-file + (find-files "." "^mkpasswd\\.")) + (substitute* "Makefile" + ((" (install-|)mkpasswd ") " ")) + (substitute* "po/Makefile" + (("\\.\\./mkpasswd\\.c") "")) + #t)))) (build-system gnu-build-system) - ;; TODO: unbundle mkpasswd binary + its po files. + (native-inputs + `(("gettext" ,gettext))) ; for update-po phase (arguments `(#:tests? #f ; Does not exist #:make-flags (list "CC=gcc" (string-append "prefix=" (assoc-ref %outputs "out"))) #:phases (modify-phases %standard-phases + (add-after 'unpack 'update-po + ;; Remove harmless but useless ‘mkpasswd’ remnants from .po files. + (lambda _ + (invoke "make" "-C" "po" "update-po"))) (delete 'configure) ; No configure (add-before 'build 'setenv (lambda _ @@ -481,9 +497,7 @@ and up to 1 Mbit/s downstream.") ("pkg-config" ,pkg-config))) (synopsis "Improved whois client") (description "This whois client is intelligent and can -automatically select the appropriate whois server for most queries. -Because of historical reasons this also includes a tool called mkpasswd -which can be used to encrypt a password with @code{crypt(3)}.") +automatically select the appropriate whois server for most queries.") (home-page "https://github.com/rfc1036/whois") (license license:gpl2+))) -- 2.15.0 ------------=_1515597842-11089-1-- From unknown Sun Jun 22 07:48:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Jan 2018 15:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ng0@n0.is Cc: 30037@debbugs.gnu.org Received: via spool by 30037-submit@debbugs.gnu.org id=B30037.151559970414195 (code B ref 30037); Wed, 10 Jan 2018 15:56:02 +0000 Received: (at 30037) by debbugs.gnu.org; 10 Jan 2018 15:55:04 +0000 Received: from localhost ([127.0.0.1]:51186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZIiV-0003gs-QT for submit@debbugs.gnu.org; Wed, 10 Jan 2018 10:55:03 -0500 Received: from tobias.gr ([51.15.135.5]:34696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZIiT-0003gP-A7 for 30037@debbugs.gnu.org; Wed, 10 Jan 2018 10:55:01 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id df76b4c6; Wed, 10 Jan 2018 15:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type; s=2018; bh=dp7zgthpVI+hPMtWYlLPl50L5TLSxEGZteURv6 k/dFI=; b=lV9jimftt2eVW7NNGbpmD+wWD3k39Q51XZ/n6x9cimzxVJ2K5EOfv+ nVHJDO9HSjI9Od3SP5xhS9w7AIPWlteLrTRBY4Fz/LsIhQi04M+OwNzKYpCUOFyr 3UlK1tw9qN8p6AhPzke43pFNwGOyWTjLq+IUkJASS+OV0G7U+IFnDsf+ErSVd/6q RpWd9NNLwLdupOM1+UzPBpXbDV0/kWH7bp0VpPV5jEJMganHgpyaGCNnhjNd5ASl 03o6p9ZEC0nIMwdH8QveHiUNVtj/CXMsAeNtz4DudBsM9gSd4geKHdMsstx4Qbb9 S0zz8xfkfqhMIQrJv7rxdRDqXIozO4wQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 81cd4186 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Wed, 10 Jan 2018 15:54:57 +0000 (UTC) References: <20180109010138.29740-1-me@tobias.gr> <20180109065157.j4ffqj7rye5wwike@abyayala> <65a6b7e7-afca-cc9e-d1b7-cf23038800d4@tobias.gr> <20180110145554.bdnge6atptnrsg7c@abyayala> From: Tobias Geerinckx-Rice Message-ID: <6615f0ce-9417-8a15-686e-7d8656b7ad3f@tobias.gr> Date: Wed, 10 Jan 2018 16:57:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180110145554.bdnge6atptnrsg7c@abyayala> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LcKFgLj8HljV4AhjpBnpmIfHu1mSmesgk" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LcKFgLj8HljV4AhjpBnpmIfHu1mSmesgk Content-Type: multipart/mixed; boundary="iUCkqMsODhtS5isrKRND6hz4ZHjINroQl"; protected-headers="v1" From: Tobias Geerinckx-Rice To: ng0@n0.is Cc: 30037@debbugs.gnu.org Message-ID: <6615f0ce-9417-8a15-686e-7d8656b7ad3f@tobias.gr> Subject: Re: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. References: <20180109010138.29740-1-me@tobias.gr> <20180109065157.j4ffqj7rye5wwike@abyayala> <65a6b7e7-afca-cc9e-d1b7-cf23038800d4@tobias.gr> <20180110145554.bdnge6atptnrsg7c@abyayala> In-Reply-To: <20180110145554.bdnge6atptnrsg7c@abyayala> --iUCkqMsODhtS5isrKRND6hz4ZHjINroQl Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable ng0, ng0 wrote on 10/01/18 at 15:55: > What if someone under account root install 'whois' into their=20 > profile. [together with expect, source of The Other Mkpasswd.] > Wouldn't they have 2 mkpasswd now in their path of exectuables and=20 > encounter a collision? Presumably. > Should we rename it for the sake of namespace collisions reduction? I don't think this case warrants manual intervention. Whois' mkpasswd encrypt()s a given passwd and prints the result. Expect's generates a random string that satisfies some criteria. Neither are what I'd call day-to-day system administration tools. I'd rather give users deterministic control over any collision, but now who's bikeshedding (with no intention to write the code)... :-) Kind regards, T G-R --iUCkqMsODhtS5isrKRND6hz4ZHjINroQl-- --LcKFgLj8HljV4AhjpBnpmIfHu1mSmesgk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCWlY4AQ0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15NZgA/iFQaugadf9UOPUjJZd3dqjsTc1GpiT1hW3qisrG 4bIVAP4/mV2Cfk0NK170aOAQoEez0lzQaMrC9EKgr3wNlReiBg== =7h/d -----END PGP SIGNATURE----- --LcKFgLj8HljV4AhjpBnpmIfHu1mSmesgk-- From unknown Sun Jun 22 07:48:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#30037] [PATCH] gnu: whois: Remove bundled mkpasswd. Resent-From: ng0 Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Jan 2018 16:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30037 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 30037-done@debbugs.gnu.org, mbakke@fastmail.com, ludo@gnu.org, ng0@n0.is Received: via spool by 30037-done@debbugs.gnu.org id=D30037.151560107616235 (code D ref 30037); Wed, 10 Jan 2018 16:18:01 +0000 Received: (at 30037-done) by debbugs.gnu.org; 10 Jan 2018 16:17:56 +0000 Received: from localhost ([127.0.0.1]:51204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZJ4d-0004Dn-WB for submit@debbugs.gnu.org; Wed, 10 Jan 2018 11:17:56 -0500 Received: from aibo.runbox.com ([91.220.196.211]:59352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZJ4b-0004De-Ob for 30037-done@debbugs.gnu.org; Wed, 10 Jan 2018 11:17:54 -0500 Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1eZJ4X-00010G-7l; Wed, 10 Jan 2018 17:17:49 +0100 Received: from dslb-088-078-094-182.088.078.pools.vodafone-ip.de ([88.78.94.182] helo=localhost) by mailfront10.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1eZJ4N-0001AI-Nr; Wed, 10 Jan 2018 17:17:39 +0100 Date: Wed, 10 Jan 2018 17:17:46 +0000 From: ng0 Message-ID: <20180110171746.vdd4yqadg337ytld@abyayala> References: <20180109010138.29740-1-me@tobias.gr> <877esrtaqe.fsf@gnu.org> <11ef27fb-447c-254e-fd07-6574cdf26ed9@tobias.gr> <87shbf2c98.fsf@fastmail.com> <20180110144655.iq4q7spqf3ng5w2y@abyayala> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uireei6dsr2dxxto" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --uireei6dsr2dxxto Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice transcribed 2.0K bytes: > ng0 wrote on 10/01/18 at 15:46: > > Which is exactly what we concluded in the old thread about this, > > which I suggested to read. I just should've removed the TODO note a > > long time ago. >=20 > As I wrote in my previous message addressing that exact thread, that > would have been nice. No harm done beyond some wasted time. >=20 > > I still find mkpasswd feels like an historical accident bundling in > > favor of some OS that relies on it (iirc the old thread or authors > > replies), but doesn't really matter. Bikeshedding on the highest > > level of bikesheds I guess. >=20 > Yup :-) I've removed the comment in master and am closing the shed. >=20 > Kind regards, >=20 > T G-R >=20 Okay, ty! --=20 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys WWW: https://n0.is/a/ :: https://ea.n0.is --uireei6dsr2dxxto Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlpWSroACgkQ4i+bv+40 hYg+5A/+MUG00GZRlogan+UpvXaKKyyj3VnS5RTVjdTdXFvEujhZjXUV3LthBGY+ FfLbcNKCcO7My7AjUaIfVGdPLN5ls0btJZy4MPXEL1Sa8d5PvZpitOqlaQ2nGou5 cY29lcUrUshaGAZ1BuWGb1xOlzeSuruEZbWLtPTpl0tBFP0v9IOhjvpUx9V9Fs6h reRuxaNVlnnrtiJUgS+fl3YGIx8XUIu1wQkQskgixkE4WoR2c0R4O74ggT2iqeoQ DIv5VC0dF62vxUsXOeth0T4C9SK48kjh+cc046bU5et4rgZOxUu0nsCVqeGotmgY X3UOgGvfaR0H3qFIkvXIOBExx08HQWySlwM6a+/1X07ApWKpKWuSCxYqrmJnVpS0 iL6ettplg6k1OOsTZary/oBtOLiaznJR5EM5m0Q540hKnBsOQUPRtmIZlR8r+c9G 68mKuTAovBQoTiftELIoU+zPnXk5vVcaOIrPxLugtssL6UhRd52sQUMjH8IqPZiV vzuOWHDwf3FrW3rRntwKMRkYspY9EXVbw6clB6Azy+RuO3JJtpjy7SNxPSZIWYr3 bof/DtwYarTK/kv1lpM39zy2h8JQPxx5BEpW+6FRuQHnni9XS6t7JlsByFXngy5F oYWehZQk33p2rGZ9MVbJeQWbR8r9hCfF0CsY+27wtulRWXaV0mQ= =G32Y -----END PGP SIGNATURE----- --uireei6dsr2dxxto--