Subject: Re: [bug#30036] [PATCH] gnu: Update emacs-sr-speedbar to version 20161025.

From: Kei Kebreau <[email-masked]>
Date: Thu, 11 Jan 2018 13:39:58 -0500

Maxim Cournoyer <[email-masked]> writes:

> Hello,
>
> This patch updates emacs-sr-speedbar to the latest version available.
>
> Thanks!
>
> Maxim
>
>
> From f1b8e41b19f44bd508eb49224e6fc491ef83b591 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <[email-masked]>
> Date: Mon, 8 Jan 2018 15:05:50 -0500
> Subject: [PATCH] gnu: Update emacs-sr-speedbar to version 20161025.
>
> * gnu/packages/emacs.scm (emacs-sr-speedbar): Update version to 20161025. Use
> a git comit as there is no tag provided.

I've changed the commit message so it's a bit more conventional. The
assumption when a package uses the fetch method to 'git-fetch' is that
'url-fetch' is not sufficient or a compressed source file is not available.

> ---
>  gnu/packages/emacs.scm | 42 ++++++++++++++++++++++--------------------
>  1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index ebee6f61b..253707d7e 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -31,7 +31,7 @@
>  ;;; Copyright © 2017 Peter Mikkelsen <[email-masked]>
>  ;;; Copyright © 2017 Tobias Geerinckx-Rice <[email-masked]>
>  ;;; Copyright © 2017 Mike Gerwitz <[email-masked]>
> -;;; Copyright © 2017 Maxim Cournoyer <[email-masked]>
> +;;; Copyright © 2017, 2018 Maxim Cournoyer <[email-masked]>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -2331,27 +2331,29 @@ truncation.")
>      (license license:gpl2+)))
>  
>  (define-public emacs-sr-speedbar
> -  (package
> -    (name "emacs-sr-speedbar")
> -    (version "20140914.2339")
> -    (source
> -     (origin
> -       (method url-fetch)
> -       (uri (string-append
> -             "https://github.com/emacsorphanage/sr-speedbar/archive/"
> -             version ".tar.gz"))
> -       (file-name (string-append name "-" version ".tar.gz"))
> -       (sha256
> -        (base32
> -         "15xwwc6kgvmk4wdhx1j8w6m6ivxvc94028ppgdpa2m51a8c9vjm9"))))
> -    (build-system emacs-build-system)
> -    (home-page "https://www.emacswiki.org/emacs/SrSpeedbar")
> -    (synopsis "Same frame Emacs @code{speedbar}")
> -    (description
> -     "This Emacs package allows you to show @code{M-x speedbar} in the
> +  (let ((commit "77a83fb50f763a465c021eca7343243f465b4a47")
> +        (revision "0"))
> +    (package
> +      (name "emacs-sr-speedbar")
> +      (version (git-version "20161025" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/emacsorphanage/sr-speedbar.git")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "0sd12555hk7z721y00kv3crdybvcn1i08wmd148z5imayzibj153"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://www.emacswiki.org/emacs/SrSpeedbar")
> +      (synopsis "Same frame Emacs @code{speedbar}")
> +      (description
> +       "This Emacs package allows you to show @code{M-x speedbar} in the
>  same frame (in an extra window).  You can customize the initial width of
>  the speedbar window.")
> -    (license license:gpl3+)))
> +      (license license:gpl3+))))
>  
>  (define-public emacs-shell-switcher
>    (package

Other than that, this LGTM and I've pushed this to master. Thanks for
contributing!