GNU bug report logs - #30036
[PATCH] gnu: Update emacs-sr-speedbar to version 20161025.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30036 in the body.
You can then email your comments to 30036 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Update emacs-sr-speedbar to version 20161025.
Date: Mon, 8 Jan 2018 18:11:53 -0500

[Message part 1 (text/plain, inline)]

Hello,

This patch updates emacs-sr-speedbar to the latest version available.

Thanks!

Maxim

[Message part 2 (text/html, inline)]

[0001-gnu-Update-emacs-sr-speedbar-to-version-20161025.patch (text/x-patch, attachment)]

Message #10 received at 30036-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 30036-done <at> debbugs.gnu.org
Subject: Re: [bug#30036] [PATCH] gnu: Update emacs-sr-speedbar to version
 20161025.
Date: Thu, 11 Jan 2018 13:39:58 -0500

[Message part 1 (text/plain, inline)]

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hello,
>
> This patch updates emacs-sr-speedbar to the latest version available.
>
> Thanks!
>
> Maxim
>
>
> From f1b8e41b19f44bd508eb49224e6fc491ef83b591 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Mon, 8 Jan 2018 15:05:50 -0500
> Subject: [PATCH] gnu: Update emacs-sr-speedbar to version 20161025.
>
> * gnu/packages/emacs.scm (emacs-sr-speedbar): Update version to 20161025. Use
> a git comit as there is no tag provided.

I've changed the commit message so it's a bit more conventional. The
assumption when a package uses the fetch method to 'git-fetch' is that
'url-fetch' is not sufficient or a compressed source file is not available.

> ---
>  gnu/packages/emacs.scm | 42 ++++++++++++++++++++++--------------------
>  1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index ebee6f61b..253707d7e 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -31,7 +31,7 @@
>  ;;; Copyright © 2017 Peter Mikkelsen <petermikkelsen10 <at> gmail.com>
>  ;;; Copyright © 2017 Tobias Geerinckx-Rice <me <at> tobias.gr>
>  ;;; Copyright © 2017 Mike Gerwitz <mtg <at> gnu.org>
> -;;; Copyright © 2017 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> +;;; Copyright © 2017, 2018 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -2331,27 +2331,29 @@ truncation.")
>      (license license:gpl2+)))
>  
>  (define-public emacs-sr-speedbar
> -  (package
> -    (name "emacs-sr-speedbar")
> -    (version "20140914.2339")
> -    (source
> -     (origin
> -       (method url-fetch)
> -       (uri (string-append
> -             "https://github.com/emacsorphanage/sr-speedbar/archive/"
> -             version ".tar.gz"))
> -       (file-name (string-append name "-" version ".tar.gz"))
> -       (sha256
> -        (base32
> -         "15xwwc6kgvmk4wdhx1j8w6m6ivxvc94028ppgdpa2m51a8c9vjm9"))))
> -    (build-system emacs-build-system)
> -    (home-page "https://www.emacswiki.org/emacs/SrSpeedbar")
> -    (synopsis "Same frame Emacs @code{speedbar}")
> -    (description
> -     "This Emacs package allows you to show @code{M-x speedbar} in the
> +  (let ((commit "77a83fb50f763a465c021eca7343243f465b4a47")
> +        (revision "0"))
> +    (package
> +      (name "emacs-sr-speedbar")
> +      (version (git-version "20161025" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/emacsorphanage/sr-speedbar.git")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "0sd12555hk7z721y00kv3crdybvcn1i08wmd148z5imayzibj153"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://www.emacswiki.org/emacs/SrSpeedbar")
> +      (synopsis "Same frame Emacs @code{speedbar}")
> +      (description
> +       "This Emacs package allows you to show @code{M-x speedbar} in the
>  same frame (in an extra window).  You can customize the initial width of
>  the speedbar window.")
> -    (license license:gpl3+)))
> +      (license license:gpl3+))))
>  
>  (define-public emacs-shell-switcher
>    (package

Other than that, this LGTM and I've pushed this to master. Thanks for
contributing!

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 30036-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 30036-done <at> debbugs.gnu.org
Subject: Re: [bug#30036] [PATCH] gnu: Update emacs-sr-speedbar to version
 20161025.
Date: Fri, 12 Jan 2018 08:19:24 -0500

Hi Kei,

Kei Kebreau <kkebreau <at> posteo.net> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>
>> Hello,
>>
>> This patch updates emacs-sr-speedbar to the latest version available.
>>
>> Thanks!
>>
>> Maxim
>>
>>
>> From f1b8e41b19f44bd508eb49224e6fc491ef83b591 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Mon, 8 Jan 2018 15:05:50 -0500
>> Subject: [PATCH] gnu: Update emacs-sr-speedbar to version 20161025.
>>
>> * gnu/packages/emacs.scm (emacs-sr-speedbar): Update version to 20161025. Use
>> a git comit as there is no tag provided.
>
> I've changed the commit message so it's a bit more conventional. The
> assumption when a package uses the fetch method to 'git-fetch' is that
> 'url-fetch' is not sufficient or a compressed source file is not available.

Thanks for the feedback! Noted :)

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.