Subject: Re: [bug#30007] [PATCH 1/2] gnu: Add libb2.

From: Leo Famulari <[email-masked]>
Date: Sat, 6 Jan 2018 12:49:10 -0500

On Sat, Jan 06, 2018 at 04:54:17PM +0100, Tobias Geerinckx-Rice wrote:
> * gnu/packages/digest.scm (libb2): New public variable.

> +      (name "libb2")
> +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))

Use the (git-version) procedure here

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/BLAKE2/libb2")
> +                      (commit commit)))
> +                (file-name (string-append name "-" version "-checkout"))

And (git-file-name)

> +           (add-after 'unpack 'bootstrap
> +             (lambda _
> +               (invoke "sh" "autogen.sh")
> +               #t)))))

(invoke) should raise an exception if something goes wrong;
otherwise it returns #t. Do we need that extra #t?