From unknown Mon Aug 18 14:25:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30006 <30006@debbugs.gnu.org> To: bug#30006 <30006@debbugs.gnu.org> Subject: Status: bzip2 does not provide libbz2.so Reply-To: bug#30006 <30006@debbugs.gnu.org> Date: Mon, 18 Aug 2025 21:25:41 +0000 retitle 30006 bzip2 does not provide libbz2.so reassign 30006 guix submitter 30006 ludo@gnu.org (Ludovic Court=C3=A8s) severity 30006 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 06 08:29:18 2018 Received: (at submit) by debbugs.gnu.org; 6 Jan 2018 13:29:18 +0000 Received: from localhost ([127.0.0.1]:37623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXoXG-0000tw-9n for submit@debbugs.gnu.org; Sat, 06 Jan 2018 08:29:18 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXoXE-0000tk-Ps for submit@debbugs.gnu.org; Sat, 06 Jan 2018 08:29:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXoX8-00008W-Jh for submit@debbugs.gnu.org; Sat, 06 Jan 2018 08:29:11 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50753) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXoX8-00008E-Gg for submit@debbugs.gnu.org; Sat, 06 Jan 2018 08:29:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXoX7-0003eK-IG for bug-guix@gnu.org; Sat, 06 Jan 2018 08:29:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXoX2-0008Vh-Ks for bug-guix@gnu.org; Sat, 06 Jan 2018 08:29:09 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:45542) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXoX2-0008Ui-Eo for bug-guix@gnu.org; Sat, 06 Jan 2018 08:29:04 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1028E107B6 for ; Sat, 6 Jan 2018 14:29:03 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EdWgqHAX44eP for ; Sat, 6 Jan 2018 14:29:02 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C6AB2FB27 for ; Sat, 6 Jan 2018 14:29:01 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: bug-guix@gnu.org Subject: bzip2 does not provide libbz2.so X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 =?utf-8?Q?Niv=C3=B4se?= an 226 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 06 Jan 2018 14:29:00 +0100 Message-ID: <87incft8tf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Our current bzip2 package does not provide libbz2.so: --8<---------------cut here---------------start------------->8--- $ ls $(guix build bzip2)/lib libbz2.a libbz2.so.1.0 libbz2.so.1.0.6 --8<---------------cut here---------------end--------------->8--- Consequently, software that uses libbz2 always ends up statically-linking it. Thus, security issues in libbz2 cannot be grafted. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 08:02:14 2018 Received: (at 30006) by debbugs.gnu.org; 23 Mar 2018 12:02:14 +0000 Received: from localhost ([127.0.0.1]:48760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezLOg-0008Cy-Gf for submit@debbugs.gnu.org; Fri, 23 Mar 2018 08:02:14 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:51849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezLOe-0008Cp-61 for 30006@debbugs.gnu.org; Fri, 23 Mar 2018 08:02:12 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 93FB9216C3; Fri, 23 Mar 2018 08:02:11 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Fri, 23 Mar 2018 08:02:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=eGsuxfVrsQpm5aVOJZfRXOigC1MDL9sDy4qkrR1VmD4=; b=oOG1qXqd hQntxFKlTAkRxZ6oVLY1z1iK99K2piEdh8nDz3cx6JoCTUGwwxTIUdRFNUZa2N7U WhwhuvVWuZ6kwP7OL4aQ2Jy7HL9scBwjiSerwxt3qPWEu9VW9RDorO3x4s76GGvb fJQXQmglvwelx4v1mOJ0E8BDXTyh9XDnN4cQQD9/miWi+fsvAaJ4qvs/omh2mEE3 cvQVPdstcZou0XwwSLlW4t/LUPgkKf1NmqQKWGformvTA0YyldB89kvmaAUNxOJv 4gWt+yo33uNloxX54DEs4CQtyfvOefJe3daKcF2ZQxzZ5yiNyIAPrjmVZTUlr7XK r7fowUkQxCab9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=eGsuxfVrsQpm5aVOJZfRXOigC1MDL 9sDy4qkrR1VmD4=; b=ODC5x1/gAjYWWRjyYynAfWCjLF8+vlfrm1Y85PXa7C0HD ASrWHR5FQ9chJTAYall7VxEQXX/TjgJX+mItGCvMcHUT3PI/G/hEFEtPADVHAHK3 chsWNbQ0z2x3YIZ9SVA913M5T6jS6pVfHdkmC4AQ1akiTwbLbtRAGfl9g84IFv0/ Kdl8PIvi5dy1KD5ca5fv452HKM0s4Turqiiyk/ZndTsEA0Aq6lawXMOJWo+ZMoNT QBpmSjOHpeNK8B2k7f93N+50FmiFTexb5CwfzvDiFWFMPv4YmXS8CUn6/ydyEsOx Rps+gNESPE9Q+J8F1RlzaNZZYKw6NVvWOTmsClh9w== X-ME-Sender: Received: from localhost (unknown [80.89.52.157]) by mail.messagingengine.com (Postfix) with ESMTPA id EC7107E0DF; Fri, 23 Mar 2018 08:02:10 -0400 (EDT) From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 30006@debbugs.gnu.org Subject: Re: bug#30006: bzip2 does not provide libbz2.so In-Reply-To: <87incft8tf.fsf@gnu.org> References: <87incft8tf.fsf@gnu.org> User-Agent: Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Fri, 23 Mar 2018 13:02:07 +0100 Message-ID: <877eq3knk0.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30006 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Our current bzip2 package does not provide libbz2.so: > > --8<---------------cut here---------------start------------->8--- > $ ls $(guix build bzip2)/lib > libbz2.a libbz2.so.1.0 libbz2.so.1.0.6 > --8<---------------cut here---------------end--------------->8--- > > Consequently, software that uses libbz2 always ends up > statically-linking it. Thus, security issues in libbz2 cannot be > grafted. WDYT of this patch? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-bzip2-Provide-libbz2.so.patch Content-Transfer-Encoding: quoted-printable From=201eec25f2aad3d20289ced4fbca9a614f6d614fa6 Mon Sep 17 00:00:00 2001 From: Marius Bakke Date: Fri, 23 Mar 2018 12:56:45 +0100 Subject: [PATCH] gnu: bzip2: Provide libbz2.so. Fixes . * gnu/packages/compression.scm (bzip2)[arguments]: In INSTALL-SHARED-LIBS-PHASE, add a symlink. =2D-- gnu/packages/compression.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index b158feac4..fd111e579 100644 =2D-- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -272,6 +272,9 @@ file; as a result, it is often used in conjunction with= \"tar\", resulting in (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) (libdir (string-append out "/lib"))) + ;; The Make target above does not create "libbz2.so", only + ;; the versioned libs, so we have to create it ourselves. + (symlink "libbz2.so.1.0" "libbz2.so") (for-each (lambda (file) (let ((base (basename file))) (format #t "installing `~a' to `~a'~%" =2D-=20 2.16.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlq07L8ACgkQoqBt8qM6 VPrVawf/fEiCwKqnxaElXxUiN6WvEIfWt3HZbyk2T/RiTaxqKrfx1eXQNkOHfYpx jn4hsPZv9sMfDNNZxDIwtwQi1p9Ykqc3yZ1IY6kRXdxGDNkjPBU1Oj6jAboyj2N0 jm2EOFIoWELGGauTsrdcUwlNR7wbkxzgef5obcNEgcgAsHEkgGUl+avWJsZWm6rT LMUIRIz+074RkrzvbOXAxXHLpae3tfIeHP1NWk2Z8etICS0+DRWv8AYBtWqQO0Zb Sp+ifeVuIYLfjmFJcYhmHw1a/Olg/2BIVOc69biWMQOdpKFiaJUUOxBHmQ20la1x 12OYByQXGLdyBgkbSrn4iBRTmf3Jbw== =f7b8 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 08:19:42 2018 Received: (at 30006) by debbugs.gnu.org; 23 Mar 2018 12:19:42 +0000 Received: from localhost ([127.0.0.1]:48772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezLfa-0000AF-Eq for submit@debbugs.gnu.org; Fri, 23 Mar 2018 08:19:42 -0400 Received: from tobias.gr ([51.15.135.5]:56716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezLfZ-0000A6-At for 30006@debbugs.gnu.org; Fri, 23 Mar 2018 08:19:41 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 6a32acb3; Fri, 23 Mar 2018 12:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h= mime-version:content-type:content-transfer-encoding:date:from:to :cc:subject:in-reply-to:references:message-id; s=2018; i= me@tobias.gr; bh=vMWAlirMcXmd4svpendu9Cu0hiCtD28RSb0TjEkvEZU=; b= lWcsRGmLhG2SsZT7cj3vZG4NPNocSXdPQTctSRIcOJWKXrWlY7k9fy7m5ba1T065 tbScGeds7iL4x7tf3djVzoz4jgsDKTHX9LU286RbrhzLuLHYegoZDm4n/PE2IoPW x0ZnL+DrAzkWaYl2Eh7MRNkJem+Bxxx6EUTLxQA4OQ8fkhOvqrQ6QzpnpzF6JKZg 4dzNixxhytycWJb+rsdmyOKu9ErQ//mSDUOIdGaiW27vLkecT4MVTqZcHVnJ0vVQ VjBT6ySi3K8bYUqiKEUfun8JsNgZGxj0JH4XVP9/8r9zp7AN7tUyC1k65MgQW84M ei4p8uawekItzfpk9oOA7Q== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id c421158a (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); Fri, 23 Mar 2018 12:19:37 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 23 Mar 2018 13:19:33 +0100 From: Tobias Geerinckx-Rice To: Marius Bakke Subject: Re: bug#30006: bzip2 does not provide libbz2.so Organization: tobias.gr In-Reply-To: <877eq3knk0.fsf@fastmail.com> References: <87incft8tf.fsf@gnu.org> <877eq3knk0.fsf@fastmail.com> Message-ID: <718583be2617e43743e8ee40397bb0b4@tobias.gr> X-Sender: me@tobias.gr User-Agent: Roundcube Webmail X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30006 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 30006@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Marius, On 2018-03-23 13:02, Marius Bakke wrote: > diff --git a/gnu/packages/compression.scm > b/gnu/packages/compression.scm > index b158feac4..fd111e579 100644 > --- a/gnu/packages/compression.scm > +++ b/gnu/packages/compression.scm > @@ -272,6 +272,9 @@ file; as a result, it is often used in conjunction > with \"tar\", resulting in > (lambda* (#:key outputs #:allow-other-keys) > (let* ((out (assoc-ref outputs "out")) > (libdir (string-append out "/lib"))) > + ;; The Make target above does not create "libbz2.so", > only > + ;; the versioned libs, so we have to create it > ourselves. > + (symlink "libbz2.so.1.0" "libbz2.so") How about symlinking to (string-append ... version) directly? Seems more robust & worked fine when I tried it, I think.™ Kind regards, T G-R Sent from a Web browser. Excuse or enjoy my brevity. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 08:38:30 2018 Received: (at 30006) by debbugs.gnu.org; 23 Mar 2018 12:38:30 +0000 Received: from localhost ([127.0.0.1]:48793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezLxl-0002Zc-Rk for submit@debbugs.gnu.org; Fri, 23 Mar 2018 08:38:30 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:46141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezLxj-0002ZT-Qm for 30006@debbugs.gnu.org; Fri, 23 Mar 2018 08:38:28 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4885720F27; Fri, 23 Mar 2018 08:38:27 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Fri, 23 Mar 2018 08:38:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=rz3GmiHPundsm1+2tHnv+OKyir62tqoiEeHPudi2S14=; b=LD8aUqba ut0Go/j3DN+/NrY2YGt326ZILAvKWZzs6LgG0OdcQFxSlVcx5Ljf18eiscChK90b HBvAbPQoJS2VUtqLWAeRe5X5eH8F9QQz63M5mI7cKimJz+o+OdcDurlY4xHYHIaY IaTLicXqufXtewXmaYcR4Jk921/M/B4ysIHW+/FJttnEctoOWLYFKyM/bodf+/u3 u8Vq2PKMNtcLIdefMyfMm4f2/ILnoGPQKokx/+8cBpYjNShFWwBXe1+xwJm8CKht 8ed5C5E4WnQgbQK5xaooMdFpc9RMywRkfm9V39/pslVeyzpFxQrlCeOH5tO3uZz8 8NFmv1RocvRvTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=rz3GmiHPundsm1+2tHnv+OKyir62t qoiEeHPudi2S14=; b=Ry2drBohTcoFRcVDOuvNsuHMEN+ryWPa25x5KiKWUJwJq 8Cy0m9Ca8qH9e89IgGd44tYOuDXWAv9BpxMb8FTRD0iedbZeEr5yD3Aj5YWOGx1Y KjhtUXGNykzYpgT59qoM3kkhyQ20uvTWqkReomYJXTKriuMOqYN6VpR7o7LkjVbQ LyUp16IVFY9VrP/Eq4kg6tNFz6sfKyV+8w+KbZuAEPMDnMTnrvEGYt/OuDfOM2KQ 3JszQJOTie4/l7I6BQ/4jZV2gOe/7YG/lrPd1rDSMgwWqiLjzHa0dFXWoRDppY7u rCCkGaxp80UE6V3VyJunjkYQVdtfL28zOdXHznPuw== X-ME-Sender: Received: from localhost (unknown [80.89.52.157]) by mail.messagingengine.com (Postfix) with ESMTPA id A88C47E0EE; Fri, 23 Mar 2018 08:38:26 -0400 (EDT) From: Marius Bakke To: Tobias Geerinckx-Rice Subject: Re: bug#30006: bzip2 does not provide libbz2.so In-Reply-To: <718583be2617e43743e8ee40397bb0b4@tobias.gr> References: <87incft8tf.fsf@gnu.org> <877eq3knk0.fsf@fastmail.com> <718583be2617e43743e8ee40397bb0b4@tobias.gr> User-Agent: Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Fri, 23 Mar 2018 13:38:24 +0100 Message-ID: <871sgbklvj.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30006 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 30006@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice writes: > Marius, > > On 2018-03-23 13:02, Marius Bakke wrote: >> diff --git a/gnu/packages/compression.scm=20 >> b/gnu/packages/compression.scm >> index b158feac4..fd111e579 100644 >> --- a/gnu/packages/compression.scm >> +++ b/gnu/packages/compression.scm >> @@ -272,6 +272,9 @@ file; as a result, it is often used in conjunction=20 >> with \"tar\", resulting in >> (lambda* (#:key outputs #:allow-other-keys) >> (let* ((out (assoc-ref outputs "out")) >> (libdir (string-append out "/lib"))) >> + ;; The Make target above does not create "libbz2.so",=20 >> only >> + ;; the versioned libs, so we have to create it=20 >> ourselves. >> + (symlink "libbz2.so.1.0" "libbz2.so") > > How about symlinking to (string-append ... version) directly? > Seems more robust & worked fine when I tried it, I think.=E2=84=A2 That makes sense. I just wanted to stay close to the typical Autotools way of creating these links, where libfoo.so points to libfoo.so.1 which points to libfoo.so.1.2. I'll change to (version-major+minor ...) instead, in the off chance that bzip2 ever gets a new version. Side note: "copy-file" (and thus "install-file") actually dereferences symlinks, so in the end you get three copies of the same library. Is there an alternative to "copy-file" that preserves soft links? Not that it matters in practice due to deduplication, but still... --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlq09UAACgkQoqBt8qM6 VPoHUgf/S4NBOQSAa/58Xy3ZZDnoXwF5WiAnwEbbp4LSIOZWkhuPIwu7UwodfYua 5xJCQhM0lFVsKddJGqJOR3JHsmN1P2BQgWGlMExZK9TpAmqW1UhJ2b7o55iO21rs pYqwicg4CixA3U8/Sh0Vj2zRGVcjxPHwwb0bCVl2Zxd45Of3xGEbR4SJWgRWwNlk 53pVj/B8sqwHlAtXfSTwmf8WDB2v8ROD6YkWUtgKJoAK9kEie+9681L61UYORCO/ P9O7rwIBwADcOwfir9EyStVokRIyl3eBnX/h65Z6z/1DdzM/eTKqRkLUvb6I6/sY YIONs1+XV6jOM7dlFe6eKZEtAiliXA== =K9UA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 16:51:19 2018 Received: (at 30006) by debbugs.gnu.org; 23 Mar 2018 20:51:19 +0000 Received: from localhost ([127.0.0.1]:50086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezTeh-00084V-Do for submit@debbugs.gnu.org; Fri, 23 Mar 2018 16:51:19 -0400 Received: from world.peace.net ([50.252.239.5]:47216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezTef-00084F-HO for 30006@debbugs.gnu.org; Fri, 23 Mar 2018 16:51:18 -0400 Received: from turntable.mit.edu ([18.18.160.11] helo=jojen) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ezTeZ-0004ma-5H; Fri, 23 Mar 2018 16:51:11 -0400 From: Mark H Weaver To: Tobias Geerinckx-Rice Subject: Re: bug#30006: bzip2 does not provide libbz2.so References: <87incft8tf.fsf@gnu.org> <877eq3knk0.fsf@fastmail.com> <718583be2617e43743e8ee40397bb0b4@tobias.gr> Date: Fri, 23 Mar 2018 16:50:22 -0400 In-Reply-To: <718583be2617e43743e8ee40397bb0b4@tobias.gr> (Tobias Geerinckx-Rice's message of "Fri, 23 Mar 2018 13:19:33 +0100") Message-ID: <87woy234a9.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30006 Cc: Marius Bakke , 30006@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Hi, Tobias Geerinckx-Rice writes: > On 2018-03-23 13:02, Marius Bakke wrote: >> diff --git a/gnu/packages/compression.scm >> b/gnu/packages/compression.scm >> index b158feac4..fd111e579 100644 >> --- a/gnu/packages/compression.scm >> +++ b/gnu/packages/compression.scm >> @@ -272,6 +272,9 @@ file; as a result, it is often used in >> conjunction with \"tar\", resulting in >> (lambda* (#:key outputs #:allow-other-keys) >> (let* ((out (assoc-ref outputs "out")) >> (libdir (string-append out "/lib"))) >> + ;; The Make target above does not create "libbz2.so", on= ly >> + ;; the versioned libs, so we have to create it ourselves. >> + (symlink "libbz2.so.1.0" "libbz2.so") > > How about symlinking to (string-append ... version) directly? > Seems more robust & worked fine when I tried it, I think.=E2=84=A2 In general, the version numbers at the end of shared library names like "libbz2.so.1.0" do not necessarily match the version number of the corresponding source release. Therefore, I don't think we should write code that assumes that those two versions will coincide. However, I agree that it would be better not to hardcode the "1.0". I would suggest using 'find-files' to find the versioned shared library, and to verify that there is exactly one match. (ice-9 match) provides an elegant way to check for a singleton list while matching its element. What do you think? Thanks for working on it. Mark From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 21:18:04 2018 Received: (at 30006) by debbugs.gnu.org; 24 Mar 2018 01:18:04 +0000 Received: from localhost ([127.0.0.1]:50270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezXoq-0001AU-9H for submit@debbugs.gnu.org; Fri, 23 Mar 2018 21:18:04 -0400 Received: from tobias.gr ([51.15.135.5]:40320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezXoo-0001A3-81 for 30006@debbugs.gnu.org; Fri, 23 Mar 2018 21:18:03 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id d4ab8bd3; Sat, 24 Mar 2018 01:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h= mime-version:content-type:content-transfer-encoding:date:from:to :cc:subject:in-reply-to:references:message-id; s=2018; i= me@tobias.gr; bh=GnrIGYgRwT+NKnvs7WtJbFRZoch8YubIvhnQZS5NisI=; b= KfR7836kWk0SVQxJu9REsqF0tF07qVxCzm2/iXuwCf7w5ttiGLzMPLRNjEleTJmt juXYAhL/C2Py/+jP3R/+N1L09UyxBZd6AEbG0sw3p26oCVYRrZ6C5rKItZYnQzDQ DWojeMBs77XtYnOFQV9lniwzXqVhILwZ97c7KaS7E9pL8a2T+sJGtcc/rtYLEqW3 tK93NZCsbJ3vJVsYxI85BO6CXvQHtYuwiLJntzlZC50eUKqa7e8pGi+GWjBt345n O/AAJ91DbXWR2mfjduuwb7LVYLAwaMzjnLH23W5MG6fnpKOAoE8dx/v/RkahNpiX j8LUcqih48Gl921Q+4nN8Q== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id ff8f624c (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); Sat, 24 Mar 2018 01:17:57 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sat, 24 Mar 2018 02:17:54 +0100 From: Tobias Geerinckx-Rice To: Marius Bakke Subject: Re: bug#30006: bzip2 does not provide libbz2.so Organization: tobias.gr In-Reply-To: <87woy234a9.fsf@netris.org> References: <87incft8tf.fsf@gnu.org> <877eq3knk0.fsf@fastmail.com> <718583be2617e43743e8ee40397bb0b4@tobias.gr> <87woy234a9.fsf@netris.org> Message-ID: <99e250aee52d4a4fdce7a7d98d94c5ea@tobias.gr> X-Sender: me@tobias.gr User-Agent: Roundcube Webmail X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30006 Cc: Mark H Weaver , 30006@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Marius, Mark, On 2018-03-23 21:50, Mark H Weaver wrote: > Hi, > > Tobias Geerinckx-Rice writes: > >> On 2018-03-23 13:02, Marius Bakke wrote: >>> diff --git a/gnu/packages/compression.scm >>> b/gnu/packages/compression.scm >>> index b158feac4..fd111e579 100644 >>> --- a/gnu/packages/compression.scm >>> +++ b/gnu/packages/compression.scm >>> @@ -272,6 +272,9 @@ file; as a result, it is often used in >>> conjunction with \"tar\", resulting in >>> (lambda* (#:key outputs #:allow-other-keys) >>> (let* ((out (assoc-ref outputs "out")) >>> (libdir (string-append out "/lib"))) >>> + ;; The Make target above does not create "libbz2.so", >>> only >>> + ;; the versioned libs, so we have to create it >>> ourselves. >>> + (symlink "libbz2.so.1.0" "libbz2.so") >> >> How about symlinking to (string-append ... version) directly? >> Seems more robust & worked fine when I tried it, I think.™ > > In general, the version numbers at the end of shared library names like > "libbz2.so.1.0" do not necessarily match the version number of the > corresponding source release. Therefore, I don't think we should write > code that assumes that those two versions will coincide. Do note that I'm not suggesting doing so in general; just in the case of bzip2 where that rule does historically hold. If that ever changes, so will the ‘1.0’ assumption. (I did substitute ‘version’ for the ‘version-major+minor’ I actually used for... simplicity, I guess, which was probably ill advised.) > However, I agree that it would be better not to hardcode the "1.0". I > would suggest using 'find-files' to find the versioned shared library, > and to verify that there is exactly one match. (ice-9 match) provides > an elegant way to check for a singleton list while matching its > element. I wasn't aware of such an elegant possibility. A perfect fit IMO :-) Thanks, T G-R Sent from a Web browser. Excuse or enjoy my brevity. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 24 12:54:52 2018 Received: (at 30006) by debbugs.gnu.org; 24 Mar 2018 16:54:52 +0000 Received: from localhost ([127.0.0.1]:51651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezmRQ-0003lK-6i for submit@debbugs.gnu.org; Sat, 24 Mar 2018 12:54:52 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:53792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezmRO-0003lC-1v for 30006@debbugs.gnu.org; Sat, 24 Mar 2018 12:54:50 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id B2EC913077; Sat, 24 Mar 2018 17:54:48 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T7I_808YuVOL; Sat, 24 Mar 2018 17:54:47 +0100 (CET) Received: from ribbon (vpn-0-27.aquilenet.fr [IPv6:2a0c:e300:4:27::]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 9F88113073; Sat, 24 Mar 2018 17:54:47 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Marius Bakke Subject: Re: bug#30006: bzip2 does not provide libbz2.so References: <87incft8tf.fsf@gnu.org> <877eq3knk0.fsf@fastmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 Germinal an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 24 Mar 2018 17:54:46 +0100 In-Reply-To: <877eq3knk0.fsf@fastmail.com> (Marius Bakke's message of "Fri, 23 Mar 2018 13:02:07 +0100") Message-ID: <877eq1l8h5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30006 Cc: 30006@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hey Marius, Marius Bakke skribis: > Ludovic Court=C3=A8s writes: > >> Our current bzip2 package does not provide libbz2.so: >> >> --8<---------------cut here---------------start------------->8--- >> $ ls $(guix build bzip2)/lib >> libbz2.a libbz2.so.1.0 libbz2.so.1.0.6 >> --8<---------------cut here---------------end--------------->8--- >> >> Consequently, software that uses libbz2 always ends up >> statically-linking it. Thus, security issues in libbz2 cannot be >> grafted. > > WDYT of this patch? > > From 1eec25f2aad3d20289ced4fbca9a614f6d614fa6 Mon Sep 17 00:00:00 2001 > From: Marius Bakke > Date: Fri, 23 Mar 2018 12:56:45 +0100 > Subject: [PATCH] gnu: bzip2: Provide libbz2.so. > > Fixes . > > * gnu/packages/compression.scm (bzip2)[arguments]: In > INSTALL-SHARED-LIBS-PHASE, add a symlink. LGTM, thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 24 13:01:08 2018 Received: (at 30006) by debbugs.gnu.org; 24 Mar 2018 17:01:08 +0000 Received: from localhost ([127.0.0.1]:51660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezmXU-0003ve-6Q for submit@debbugs.gnu.org; Sat, 24 Mar 2018 13:01:08 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:53834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezmXR-0003vV-Pw for 30006@debbugs.gnu.org; Sat, 24 Mar 2018 13:01:06 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 14D1A130B9; Sat, 24 Mar 2018 18:01:05 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i88JOX8LTnh0; Sat, 24 Mar 2018 18:01:04 +0100 (CET) Received: from ribbon (vpn-0-27.aquilenet.fr [IPv6:2a0c:e300:4:27::]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 2233D130B6; Sat, 24 Mar 2018 18:01:04 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Marius Bakke Subject: Re: bug#30006: bzip2 does not provide libbz2.so References: <87incft8tf.fsf@gnu.org> <877eq3knk0.fsf@fastmail.com> <718583be2617e43743e8ee40397bb0b4@tobias.gr> <871sgbklvj.fsf@fastmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 Germinal an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 24 Mar 2018 18:01:02 +0100 In-Reply-To: <871sgbklvj.fsf@fastmail.com> (Marius Bakke's message of "Fri, 23 Mar 2018 13:38:24 +0100") Message-ID: <87zi2xjtm9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30006 Cc: 30006@debbugs.gnu.org, Tobias Geerinckx-Rice X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Marius Bakke skribis: > Tobias Geerinckx-Rice writes: > >> Marius, >> >> On 2018-03-23 13:02, Marius Bakke wrote: >>> diff --git a/gnu/packages/compression.scm=20 >>> b/gnu/packages/compression.scm >>> index b158feac4..fd111e579 100644 >>> --- a/gnu/packages/compression.scm >>> +++ b/gnu/packages/compression.scm >>> @@ -272,6 +272,9 @@ file; as a result, it is often used in conjunction= =20 >>> with \"tar\", resulting in >>> (lambda* (#:key outputs #:allow-other-keys) >>> (let* ((out (assoc-ref outputs "out")) >>> (libdir (string-append out "/lib"))) >>> + ;; The Make target above does not create "libbz2.so",=20 >>> only >>> + ;; the versioned libs, so we have to create it=20 >>> ourselves. >>> + (symlink "libbz2.so.1.0" "libbz2.so") >> >> How about symlinking to (string-append ... version) directly? >> Seems more robust & worked fine when I tried it, I think.=E2=84=A2 > > That makes sense. I just wanted to stay close to the typical Autotools > way of creating these links, where libfoo.so points to libfoo.so.1 which > points to libfoo.so.1.2. I'll change to (version-major+minor ...) > instead, in the off chance that bzip2 ever gets a new version. Note that there=E2=80=99s no reason for the SONAME numbers to match the ver= sion number (it=E2=80=99s even not recommended to do that because it may not car= ry the relevant info regarding ABI compatibility.) So I think the hard-coded number is fine, but we should probably do: (symlink =E2=80=A6 "libbz2.so") (unless (file-exists? "libbz2.so) (error "wrong symlink target!" (readlink "libbz2.so"))) to be on the safe side. > Side note: "copy-file" (and thus "install-file") actually dereferences > symlinks, so in the end you get three copies of the same library. Is > there an alternative to "copy-file" that preserves soft links? Not that > it matters in practice due to deduplication, but still... There=E2=80=99s no such function, which is unfortunate. But I agree it=E2= =80=99s nicer to preserve symlinks in this case. Perhaps we should actually do: (with-directory-excursion libdir (symlink =E2=80=A6 "libbz2.so")) ? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 26 13:36:41 2018 Received: (at 30006) by debbugs.gnu.org; 26 Mar 2018 17:36:41 +0000 Received: from localhost ([127.0.0.1]:54662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0W2y-0004Kt-LC for submit@debbugs.gnu.org; Mon, 26 Mar 2018 13:36:40 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:51753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0W2w-0004Kl-VA for 30006@debbugs.gnu.org; Mon, 26 Mar 2018 13:36:39 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4C396215DD; Mon, 26 Mar 2018 13:36:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 26 Mar 2018 13:36:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=4CBZk+n4akrKomksIJoE/woA2i7mSV2DBjeJso1zb4U=; b=Ni3Zb3W3 5cglNCtHT1LJPOtjaC29Pftqvae7izG0ddOn66zLGeK7Ac5aj0jXbXVNjDsCEVnU nh/exgQ3ooOBtKQDwaVhHq3ZtZlWNh/uJgWSO+tVEZT6vjFTKW5M99BA2FqhfcHY PPxbPP2+WGfqK5byKSGjlAGKr69mR7UXJIklLuRGD786OX3RhQBxcgJ+6w0GAXl8 Nrzf4si6fwKAuWL1vTzCu7H6MbZ4phMAY/T1JqFhICY9NWWpqSf9VcUzIyXiYw9R j9lee1hKq0zUIMoQORnG3iONX8RlLVYFp4LMmXjpuV0fE4v3pvoqqZlJPxfFKAnI 9magmC2pYi+8YA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=4CBZk+n4akrKomksIJoE/woA2i7mS V2DBjeJso1zb4U=; b=nndfMIM5sALbfFDlIbIbDM3WMqGuvaNB3eB6BEMlSERhr RNld6snOd063tu0GRzUOrAqTcpJArFk840qZ0tyH8Q0hmOVgZv9Jmtp7cZn96ler tgnfodrndBzifT8/OGpI5u0leWLdDMBkXRJCqtszXcINqU4W/x6OmkND0+UDFz3f 3bfHo4p90PmPa7hNrLBvS1xPEcglSNTBkc0vFXhUjyhvgJ9oBPHEvYB1Np7cfuh/ SNprebiVcrfY/MzBsXBfAMcXP8id/bVrvdKsKUdYQkHWw+S6/sQHedt13s9frbaa H49WwtI0V79sz28GiDUa/kPT4BO8hNbsZ6b/v9A+Q== X-ME-Sender: Received: from localhost (ti0089a400-2222.bb.online.no [88.89.166.190]) by mail.messagingengine.com (Postfix) with ESMTPA id C171B1025A; Mon, 26 Mar 2018 13:36:37 -0400 (EDT) From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#30006: bzip2 does not provide libbz2.so In-Reply-To: <87zi2xjtm9.fsf@gnu.org> References: <87incft8tf.fsf@gnu.org> <877eq3knk0.fsf@fastmail.com> <718583be2617e43743e8ee40397bb0b4@tobias.gr> <871sgbklvj.fsf@fastmail.com> <87zi2xjtm9.fsf@gnu.org> User-Agent: Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Mon, 26 Mar 2018 19:36:35 +0200 Message-ID: <87bmfakacc.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30006 Cc: Mark H Weaver , 30006@debbugs.gnu.org, Tobias Geerinckx-Rice X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > There=E2=80=99s no such function, which is unfortunate. But I agree it= =E2=80=99s nicer > to preserve symlinks in this case. > > Perhaps we should actually do: > > (with-directory-excursion libdir > (symlink =E2=80=A6 "libbz2.so")) Thanks for the feedback everyone. I settled on a slightly different solution, that first extracts the (full) soversion from the built library, then creates symlinks for each "sub-version". It assumes that the major version is "1". That could be circumvented with a regex, but I'm not sure if it's worth the effort. As an added bonus, this also creates "libbz2.so.1" which was missing too. WDYT of this approach? Can it be made simpler? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-bzip2-Provide-libbz2.so-and-libbz2.so.1.patch Content-Transfer-Encoding: quoted-printable From=206c903b1da1ab64c4f52581c7debb82b65a6afb0e Mon Sep 17 00:00:00 2001 From: Marius Bakke Date: Mon, 26 Mar 2018 19:24:59 +0200 Subject: [PATCH] gnu: bzip2: Provide libbz2.so and libbz2.so.1. Fixes . * gnu/packages/compression.scm (bzip2)[arguments]: Rework INSTALL-SHARED-LIBS-PHASE to manage all library symlinks. =2D-- gnu/packages/compression.scm | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index 3bcc09bd3..7c853e432 100644 =2D-- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -271,15 +271,28 @@ file; as a result, it is often used in conjunction wi= th \"tar\", resulting in (add-after 'install 'install-shared-lib (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) =2D (libdir (string-append out "/lib"))) =2D (for-each (lambda (file) =2D (let ((base (basename file))) =2D (format #t "installing `~a' to `~a'~%" =2D base libdir) =2D (copy-file file =2D (string-append libdir "/" base))= )) =2D (find-files "." "^libbz2\\.so"))) =2D #t)) + (libdir (string-append out "/lib")) + ;; Find the actual library (e.g. "libbz2.so.1.0.6"). + (lib (string-drop + (car (find-files + "." + (lambda (file stat) + (and (string-prefix? "./libbz2.so.1" fil= e) + (eq? 'regular (stat:type stat)))))) + 2)) + (soversion (string-drop lib (string-length "libbz2.so.= ")))) + ;; The Makefile above does not have an 'install' target, nor + ;; does it create the versioned symlinks, so we handle it h= ere. + (install-file lib libdir) + (with-directory-excursion libdir + (let ((libs (string-split soversion #\.)) + (base "libbz2.so")) + (map (lambda (so) + (let ((next (string-append base "." so))) + (symlink next base) + (set! base next))) + libs))) + #t))) (add-after 'install-shared-lib 'patch-scripts (lambda* (#:key outputs inputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out"))) =2D-=20 2.16.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlq5L6MACgkQoqBt8qM6 VPqApQf/TjCXrrQzEF9jt59FE6RGjecqpsEHiIul6UIowloJxdEZ4QQwMT/V7Ghz WhQ21cjlEPOtNhZqpMUkm2myIuHZ1eJrQqQYdtuPa9LG590QwlyrgyU+F5mFKhM1 M4DEOAdaz+WOqJjrDnXImUZXu5veqavk5f9avr7Od7OflLiWv01Uh68srH5ywxeh 5A+pk3U5vuuwtEx54JGK50Bw3PaeeDx7GupIjMxkSpH8rYyH0b43ZUaCqM+MUNhG sXqx2iYsbaZQ4Wi4rl1c3IsGUah3Ll8VFKUYPMIbJsnHh6WZS0FOY+7Lj+OeeFig Ij+2qX741TK/TAkWb0WdGdNBtPlzTA== =8e4P -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 27 03:32:15 2018 Received: (at 30006) by debbugs.gnu.org; 27 Mar 2018 07:32:15 +0000 Received: from localhost ([127.0.0.1]:55086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0j5a-0000YR-Tf for submit@debbugs.gnu.org; Tue, 27 Mar 2018 03:32:15 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:48252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0j5Y-0000YI-ST for 30006@debbugs.gnu.org; Tue, 27 Mar 2018 03:32:13 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id DDB36124EC; Tue, 27 Mar 2018 09:32:11 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lEwUQ8R4TiLa; Tue, 27 Mar 2018 09:32:10 +0200 (CEST) Received: from ribbon (vpn-0-27.aquilenet.fr [IPv6:2a0c:e300:4:27::]) by hera.aquilenet.fr (Postfix) with ESMTPSA id B469912337; Tue, 27 Mar 2018 09:32:10 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Marius Bakke Subject: Re: bug#30006: bzip2 does not provide libbz2.so References: <87incft8tf.fsf@gnu.org> <877eq3knk0.fsf@fastmail.com> <718583be2617e43743e8ee40397bb0b4@tobias.gr> <871sgbklvj.fsf@fastmail.com> <87zi2xjtm9.fsf@gnu.org> <87bmfakacc.fsf@fastmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Germinal an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 27 Mar 2018 09:32:10 +0200 In-Reply-To: <87bmfakacc.fsf@fastmail.com> (Marius Bakke's message of "Mon, 26 Mar 2018 19:36:35 +0200") Message-ID: <87370m0y9x.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30006 Cc: Mark H Weaver , 30006@debbugs.gnu.org, Tobias Geerinckx-Rice X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello Marius, Marius Bakke skribis: > Ludovic Court=C3=A8s writes: > >> There=E2=80=99s no such function, which is unfortunate. But I agree it= =E2=80=99s nicer >> to preserve symlinks in this case. >> >> Perhaps we should actually do: >> >> (with-directory-excursion libdir >> (symlink =E2=80=A6 "libbz2.so")) > > Thanks for the feedback everyone. I settled on a slightly different > solution, that first extracts the (full) soversion from the built > library, then creates symlinks for each "sub-version". > > It assumes that the major version is "1". That could be circumvented > with a regex, but I'm not sure if it's worth the effort. > > As an added bonus, this also creates "libbz2.so.1" which was missing too. > > WDYT of this approach? Can it be made simpler? Sounds reasonable to me. I have a suggestion: > From 6c903b1da1ab64c4f52581c7debb82b65a6afb0e Mon Sep 17 00:00:00 2001 > From: Marius Bakke > Date: Mon, 26 Mar 2018 19:24:59 +0200 > Subject: [PATCH] gnu: bzip2: Provide libbz2.so and libbz2.so.1. > > Fixes . > > * gnu/packages/compression.scm (bzip2)[arguments]: Rework > INSTALL-SHARED-LIBS-PHASE to manage all library symlinks. [...] > + (with-directory-excursion libdir > + (let ((libs (string-split soversion #\.)) > + (base "libbz2.so")) > + (map (lambda (so) > + (let ((next (string-append base "." so))) > + (symlink next base) > + (set! base next))) > + libs))) To avoid =E2=80=98set!=E2=80=99, I=E2=80=99d write it along these lines: ;; Create symlinks libbz2.so.1.2 -> libbz2.so.1, etc. (let loop ((base "libbz2.so") (numbers (string-split soversion #\.))) (unless (null? numbers) (let ((so-file (string-append base "." (car numbers)))) (symlink so-file base) (loop so-file (cdr numbers))))) Otherwise LGTM. Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 27 16:49:27 2018 Received: (at 30006-done) by debbugs.gnu.org; 27 Mar 2018 20:49:27 +0000 Received: from localhost ([127.0.0.1]:56288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0vX3-0001wD-4r for submit@debbugs.gnu.org; Tue, 27 Mar 2018 16:49:27 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:48097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0vX1-0001w5-6l for 30006-done@debbugs.gnu.org; Tue, 27 Mar 2018 16:49:23 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D04C121792; Tue, 27 Mar 2018 16:49:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 27 Mar 2018 16:49:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=HWz0olcDEBtSIFTY69w57e7hrWnHu2l/7+NxglJWVMo=; b=fqXrPeCQ 3w8Sb1apxUePFUOTi9LlWa1GccOGQotKX7U+6lisRMvTbf2UPtipckgofjulee/l NSKspG9QfmzUfd2joKLlFGjcoSFzffNsSVWSwbMG5RK3uk7uSPp3wjMGO4o8a99v 1lbApU0RF96P+jYFyHrnqIKDVopeJcM4HBIk7jgA57zjfIeG6O7WkpKu/Iq8BUiw 3U8XV6SK9Wfw1yo5STUpKKn3+UzvneLxYUhMMdaGU5hu8/q8zLQ7RqWrd7y+WyPz oJWjmNVAWu2opjHIs2t81NqDi4Cj/grstBAjl8t6SSYOa9WrEz4RYVnO5M3C6Ude 2XnHEjnhMSxMcA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=HWz0olcDEBtSIFTY69w57e7hrWnHu 2l/7+NxglJWVMo=; b=ZMHbNLxQyK5Ln5hTt3EkvHAkX9xATK+dVl+R/DLWKdlZw OFbVbZUoy6q28NLVpaGdR9osVyz1Po1KvqZfb58l6R7TIX+67cWUCpa5Jz6iR2eg TJlwDu48Tx6hy1MjiVUYKYvchWVDVv87nWI7e/h4Qp9TV8urQjQjW34y2eAHxSGn 5JX7n6EbYzf3M4hW0ReYitAWK3G+5elSx3oDDlDvde4+MKmGbyCyYA3bFOo+ur2U rfFK6AeDg2aOCPAoRmwWb6IybIsBa0HTrCuC+o5Y3GJAmcoRMLInEQWr5nTw4jkE k1zuJg0C0FnfeuftOM2M/fgEfDxJUmTLMg/gtfZAQ== X-ME-Sender: Received: from localhost (ti0089a400-2222.bb.online.no [88.89.166.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 5112810258; Tue, 27 Mar 2018 16:49:22 -0400 (EDT) From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#30006: bzip2 does not provide libbz2.so In-Reply-To: <87370m0y9x.fsf@gnu.org> References: <87incft8tf.fsf@gnu.org> <877eq3knk0.fsf@fastmail.com> <718583be2617e43743e8ee40397bb0b4@tobias.gr> <871sgbklvj.fsf@fastmail.com> <87zi2xjtm9.fsf@gnu.org> <87bmfakacc.fsf@fastmail.com> <87370m0y9x.fsf@gnu.org> User-Agent: Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Tue, 27 Mar 2018 22:49:19 +0200 Message-ID: <87bmf9gs6o.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30006-done Cc: Mark H Weaver , 30006-done@debbugs.gnu.org, Tobias Geerinckx-Rice X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello Marius, > > Marius Bakke skribis: > >> Ludovic Court=C3=A8s writes: >> >>> There=E2=80=99s no such function, which is unfortunate. But I agree it= =E2=80=99s nicer >>> to preserve symlinks in this case. >>> >>> Perhaps we should actually do: >>> >>> (with-directory-excursion libdir >>> (symlink =E2=80=A6 "libbz2.so")) >> >> Thanks for the feedback everyone. I settled on a slightly different >> solution, that first extracts the (full) soversion from the built >> library, then creates symlinks for each "sub-version". >> >> It assumes that the major version is "1". That could be circumvented >> with a regex, but I'm not sure if it's worth the effort. >> >> As an added bonus, this also creates "libbz2.so.1" which was missing too. >> >> WDYT of this approach? Can it be made simpler? > > Sounds reasonable to me. I have a suggestion: [...] > To avoid =E2=80=98set!=E2=80=99, I=E2=80=99d write it along these lines: > > ;; Create symlinks libbz2.so.1.2 -> libbz2.so.1, etc. > (let loop ((base "libbz2.so") > (numbers (string-split soversion #\.))) > (unless (null? numbers) > (let ((so-file (string-append base "." (car numbers)))) > (symlink so-file base) > (loop so-file (cdr numbers))))) This is much nicer, thanks! I've pushed the patch with this improvement. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlq6rk8ACgkQoqBt8qM6 VPreMQgAqF4i/nyhdzt/qa/d6H/N9xQUf1JZXIiAtx2BG7qVVXQ5IXMLmRINYv/h 5Y5Lr+v/H7xCo6PZYeRAPPIfYWRcB+K7mPH+O4uimMpfE1+ZA9lgzHTZ8CfOF+Dl n2U6pqxiw/fPHWURpU+JdQi1J5JujWLG8umYoM7FqDom+rtBkXvFB+TlxoYEi0wP uR/yb1ylHSXv8F+/8BMbmtqlGnvB1PodtcJ1N1PAweLIKGvqiXhVpemu60KfHD5v V8tjS2zJEnaGCK9fRiaMlTbqZnw+aY2FBNlZM9jLa2FvlWRynWYAqkC0Bqr0hgdu J65/55WyEA+d9fFdmEcrStZ546VyVw== =nRKY -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Aug 18 14:25:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 25 Apr 2018 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator