From unknown Sat Aug 16 17:00:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29986: Add frame arg to toggle-frame-maximized Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jan 2018 21:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29986@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15151025339283 (code B ref -1); Thu, 04 Jan 2018 21:49:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2018 21:48:53 +0000 Received: from localhost ([127.0.0.1]:36089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXDNd-0002Pc-Kn for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXDNc-0002PG-9d for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXDNW-0007zB-5h for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60062) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXDNW-0007yt-3A for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXDNU-0006Ne-PO for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXDNQ-0007tL-Hu for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:44 -0500 Received: from hapkido.dreamhost.com ([66.33.216.122]:48344) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXDNQ-0007qQ-9N for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:40 -0500 Received: from homiemail-a76.g.dreamhost.com (sub3.mail.dreamhost.com [69.163.253.7]) by hapkido.dreamhost.com (Postfix) with ESMTP id 07A398E005 for ; Thu, 4 Jan 2018 13:48:36 -0800 (PST) Received: from homiemail-a76.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTP id 9A68945807B for ; Thu, 4 Jan 2018 13:48:34 -0800 (PST) Received: from localhost.linkov.net (m91-129-109-142.cust.tele2.ee [91.129.109.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTPSA id E8747458079 for ; Thu, 4 Jan 2018 13:48:33 -0800 (PST) From: Juri Linkov Organization: LINKOV.NET Date: Thu, 04 Jan 2018 23:42:21 +0200 Message-ID: <87r2r5z4g2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I propose to add a standard optional arg =E2=80=98frame=E2=80=99 to =E2=80=98toggle-frame-maximized=E2=80=99 and =E2=80=98toggle-frame-fullsc= reen=E2=80=99, so it would be easier to add to ~/.emacs such customizations as e.g. (add-to-list 'after-make-frame-functions 'toggle-frame-maximized) diff --git a/lisp/frame.el b/lisp/frame.el index a28baf7..7ed2f9f 100644 --- a/lisp/frame.el +++ b/lisp/frame.el @@ -2388,8 +2388,8 @@ blink-cursor-mode =0C ;; Frame maximization/fullscreen =20 -(defun toggle-frame-maximized () - "Toggle maximization state of selected frame. +(defun toggle-frame-maximized (&optional frame) + "Toggle maximization state of FRAME. Maximize selected frame or un-maximize if it is already maximized. =20 If the frame is in fullscreen state, don't change its state, but @@ -2404,19 +2404,19 @@ toggle-frame-maximized =20 See also `toggle-frame-fullscreen'." (interactive) - (let ((fullscreen (frame-parameter nil 'fullscreen))) + (let ((fullscreen (frame-parameter frame 'fullscreen))) (cond ((memq fullscreen '(fullscreen fullboth)) - (set-frame-parameter nil 'fullscreen-restore 'maximized)) + (set-frame-parameter frame 'fullscreen-restore 'maximized)) ((eq fullscreen 'maximized) - (set-frame-parameter nil 'fullscreen nil)) + (set-frame-parameter frame 'fullscreen nil)) (t - (set-frame-parameter nil 'fullscreen 'maximized))))) + (set-frame-parameter frame 'fullscreen 'maximized))))) =20 -(defun toggle-frame-fullscreen () - "Toggle fullscreen state of selected frame. -Make selected frame fullscreen or restore its previous size if it -is already fullscreen. +(defun toggle-frame-fullscreen (&optional frame) + "Toggle fullscreen state of FRAME. +Make selected frame fullscreen or restore its previous size +if it is already fullscreen. =20 Before making the frame fullscreen remember the current value of the frame's `fullscreen' parameter in the `fullscreen-restore' @@ -2431,14 +2431,14 @@ toggle-frame-fullscreen =20 See also `toggle-frame-maximized'." (interactive) - (let ((fullscreen (frame-parameter nil 'fullscreen))) + (let ((fullscreen (frame-parameter frame 'fullscreen))) (if (memq fullscreen '(fullscreen fullboth)) - (let ((fullscreen-restore (frame-parameter nil 'fullscreen-restore))) + (let ((fullscreen-restore (frame-parameter frame 'fullscreen-restore))) (if (memq fullscreen-restore '(maximized fullheight fullwidth)) - (set-frame-parameter nil 'fullscreen fullscreen-restore) - (set-frame-parameter nil 'fullscreen nil))) + (set-frame-parameter frame 'fullscreen fullscreen-restore) + (set-frame-parameter frame 'fullscreen nil))) (modify-frame-parameters - nil `((fullscreen . fullboth) (fullscreen-restore . ,fullscreen))= )) + frame `((fullscreen . fullboth) (fullscreen-restore . ,fullscreen= )))) ;; Manipulating a frame without waiting for the fullscreen ;; animation to complete can cause a crash, or other unexpected ;; behaviour, on macOS (bug#28496). From unknown Sat Aug 16 17:00:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29986: Add frame arg to toggle-frame-maximized Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jan 2018 16:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , 29986@debbugs.gnu.org Received: via spool by 29986-submit@debbugs.gnu.org id=B29986.15153413523189 (code B ref 29986); Sun, 07 Jan 2018 16:10:02 +0000 Received: (at 29986) by debbugs.gnu.org; 7 Jan 2018 16:09:12 +0000 Received: from localhost ([127.0.0.1]:39767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYDVY-0000pM-8i for submit@debbugs.gnu.org; Sun, 07 Jan 2018 11:09:12 -0500 Received: from mout.gmx.net ([212.227.17.22]:58538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYDVV-0000p8-QC for 29986@debbugs.gnu.org; Sun, 07 Jan 2018 11:09:10 -0500 Received: from [192.168.1.100] ([212.95.5.154]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MQ7sF-1eTYfX3ncp-005Jos; Sun, 07 Jan 2018 17:09:01 +0100 Message-ID: <5A524617.2060602@gmx.at> Date: Sun, 07 Jan 2018 17:08:55 +0100 From: martin rudalics MIME-Version: 1.0 References: <87r2r5z4g2.fsf@mail.linkov.net> In-Reply-To: <87r2r5z4g2.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Z9KoEKdo0u8MzI+ewFl0ogWr6QVAmbpvru6L290Qzn4/EnRdBrG YCMfufUaTmGXlXl+UZP6beQqOWfXY0CIRu/eIiZACumwtVTIeJQYYoQNA29V6cs4I2meecN 9CuyzLm/Vyr7CG8ri/cbkl5x7D7gSMgpBlpytjyxZjZhELh0tqXDbL1oIRxJdO/rM93Fn63 LX/BMxVLZDbsHYa3TnWVQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:zJlEqbrxWnc=:Lpz0IcLG8xoGmsf136Ee0x 7qLDM36jXbFnt7nAeRIODltEovY55Dk+8zx1oZrIUHprLhmkSyiRwp4rKucPYnLcXjMwIAN+s tM4Hrh7w0KW0PW0NSmuiPES5hARTkAljpHDOQNLbDqAJd+1aupVfU6ZPp+ySuY+QJucc7sTf6 WuchAewYRgFibVUJ2EjkdRzhV73nFWHVnboZOOr88/IDwI8tTzSZoddk9kiidshYNpJ/nLL99 cPwYdrWH/+e9zv3EvIlbjUuIJ9/6+hO3vK/yo9cGrsaouRm1syBMGyiAcIN2g1LcFRUittW8W on7U7xO591Z29/DFscEsAPVfoE0nrIRjE0856vHj/As+Ih0RJDEzNi9F22MUAQ2bVRZHkcRL4 Pqhnmk3SZLSKBgij5iHzbLtubffymZj3phX+cUGalC8Qbqg03vP3R5J+zhyfXaQOx97P6QNli cXSvn4A46/4rS5s1vCtKooQmhz1nc5/+TD5t3rgAldQApH36xGvEnASI2zW2Bt+FnGiW3/Gmq Modk/p2tOKsH/hIBWjAy6yRbgO814DgW+l+zpVrQLj/MYwHlnWJf7Eg4jovF0oD+qtmiN9C+x aaNtq+Qz7fXYEtDIRrwjTIXphyQhj4dJcftt+rfunzu3qh5pwJdx1Q+VAjCuGaI0fBDurqupt 0602ehuMcaWk1MBHqge5oZaKX/LfIjHPv3poaD+aP4xnwfsGMgTCjaBIbd0YxJWy0aUVtCrWz uKLZDg2znheMp//dOuTCSe/1urDB34m+6qGGLugmlBllm1YYN4SLyQErLswxpuSgyDv04i619 k5QOfD3TovW+rTmLZLjgD0pwZcbSPq1zAqaq6/whUJ1gXRcQ0WvkgWGH8sPtDgShiVHcJ2r X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > (add-to-list 'after-make-frame-functions > 'toggle-frame-maximized) How would this behave when the frame is maximized initially by the windowing system/manager? Would it then set the frame to its normal size? martin From unknown Sat Aug 16 17:00:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29986: Add frame arg to toggle-frame-maximized Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jan 2018 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 29986@debbugs.gnu.org Received: via spool by 29986-submit@debbugs.gnu.org id=B29986.151536224516308 (code B ref 29986); Sun, 07 Jan 2018 21:58:02 +0000 Received: (at 29986) by debbugs.gnu.org; 7 Jan 2018 21:57:25 +0000 Received: from localhost ([127.0.0.1]:39928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYIwX-0004Ey-0H for submit@debbugs.gnu.org; Sun, 07 Jan 2018 16:57:25 -0500 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:50124 helo=homiemail-a17.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYIwV-0004Em-3J for 29986@debbugs.gnu.org; Sun, 07 Jan 2018 16:57:23 -0500 Received: from homiemail-a17.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a17.g.dreamhost.com (Postfix) with ESMTP id E73CD2B206A; Sun, 7 Jan 2018 13:57:21 -0800 (PST) Received: from localhost.linkov.net (m91-129-109-142.cust.tele2.ee [91.129.109.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a17.g.dreamhost.com (Postfix) with ESMTPSA id 168E02B2065; Sun, 7 Jan 2018 13:57:20 -0800 (PST) From: Juri Linkov Organization: LINKOV.NET References: <87r2r5z4g2.fsf@mail.linkov.net> <5A524617.2060602@gmx.at> Date: Sun, 07 Jan 2018 23:30:14 +0200 In-Reply-To: <5A524617.2060602@gmx.at> (martin rudalics's message of "Sun, 07 Jan 2018 17:08:55 +0100") Message-ID: <87r2r1peox.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >> (add-to-list 'after-make-frame-functions >> 'toggle-frame-maximized) > > How would this behave when the frame is maximized initially by the > windowing system/manager? Would it then set the frame to its normal > size? Exactly. But as long as the frame is not maximized initially by the window manager, this should work fine. From unknown Sat Aug 16 17:00:49 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#29986: closed (Re: bug#29986: Add frame arg to toggle-frame-maximized) Message-ID: References: <87vag8dovd.fsf@mail.linkov.net> <87r2r5z4g2.fsf@mail.linkov.net> X-Gnu-PR-Message: they-closed 29986 X-Gnu-PR-Package: emacs Reply-To: 29986@debbugs.gnu.org Date: Thu, 11 Jan 2018 22:16:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1515708962-21438-1" This is a multi-part message in MIME format... ------------=_1515708962-21438-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29986: Add frame arg to toggle-frame-maximized which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29986@debbugs.gnu.org. --=20 29986: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29986 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1515708962-21438-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29986-done) by debbugs.gnu.org; 11 Jan 2018 22:15:10 +0000 Received: from localhost ([127.0.0.1]:52630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZl7t-0005Yj-Vl for submit@debbugs.gnu.org; Thu, 11 Jan 2018 17:15:10 -0500 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:60329 helo=homiemail-a18.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZl7r-0005Yb-O3 for 29986-done@debbugs.gnu.org; Thu, 11 Jan 2018 17:15:08 -0500 Received: from homiemail-a18.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTP id 0A327258069 for <29986-done@debbugs.gnu.org>; Thu, 11 Jan 2018 14:15:07 -0800 (PST) Received: from localhost.linkov.net (m91-129-109-142.cust.tele2.ee [91.129.109.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 5B91125805C for <29986-done@debbugs.gnu.org>; Thu, 11 Jan 2018 14:15:06 -0800 (PST) From: Juri Linkov To: 29986-done@debbugs.gnu.org Subject: Re: bug#29986: Add frame arg to toggle-frame-maximized Organization: LINKOV.NET References: <87r2r5z4g2.fsf@mail.linkov.net> Date: Fri, 12 Jan 2018 00:14:46 +0200 In-Reply-To: <87r2r5z4g2.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 04 Jan 2018 23:42:21 +0200") Message-ID: <87vag8dovd.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29986-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > I propose to add a standard optional arg =E2=80=98frame=E2=80=99 to > =E2=80=98toggle-frame-maximized=E2=80=99 and =E2=80=98toggle-frame-full= screen=E2=80=99, > so it would be easier to add to ~/.emacs such customizations > as e.g. > > (add-to-list 'after-make-frame-functions > 'toggle-frame-maximized) Done. ------------=_1515708962-21438-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Jan 2018 21:48:53 +0000 Received: from localhost ([127.0.0.1]:36089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXDNd-0002Pc-Kn for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXDNc-0002PG-9d for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXDNW-0007zB-5h for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60062) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXDNW-0007yt-3A for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXDNU-0006Ne-PO for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXDNQ-0007tL-Hu for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:44 -0500 Received: from hapkido.dreamhost.com ([66.33.216.122]:48344) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXDNQ-0007qQ-9N for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:40 -0500 Received: from homiemail-a76.g.dreamhost.com (sub3.mail.dreamhost.com [69.163.253.7]) by hapkido.dreamhost.com (Postfix) with ESMTP id 07A398E005 for ; Thu, 4 Jan 2018 13:48:36 -0800 (PST) Received: from homiemail-a76.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTP id 9A68945807B for ; Thu, 4 Jan 2018 13:48:34 -0800 (PST) Received: from localhost.linkov.net (m91-129-109-142.cust.tele2.ee [91.129.109.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTPSA id E8747458079 for ; Thu, 4 Jan 2018 13:48:33 -0800 (PST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Add frame arg to toggle-frame-maximized Organization: LINKOV.NET Date: Thu, 04 Jan 2018 23:42:21 +0200 Message-ID: <87r2r5z4g2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I propose to add a standard optional arg =E2=80=98frame=E2=80=99 to =E2=80=98toggle-frame-maximized=E2=80=99 and =E2=80=98toggle-frame-fullsc= reen=E2=80=99, so it would be easier to add to ~/.emacs such customizations as e.g. (add-to-list 'after-make-frame-functions 'toggle-frame-maximized) diff --git a/lisp/frame.el b/lisp/frame.el index a28baf7..7ed2f9f 100644 --- a/lisp/frame.el +++ b/lisp/frame.el @@ -2388,8 +2388,8 @@ blink-cursor-mode =0C ;; Frame maximization/fullscreen =20 -(defun toggle-frame-maximized () - "Toggle maximization state of selected frame. +(defun toggle-frame-maximized (&optional frame) + "Toggle maximization state of FRAME. Maximize selected frame or un-maximize if it is already maximized. =20 If the frame is in fullscreen state, don't change its state, but @@ -2404,19 +2404,19 @@ toggle-frame-maximized =20 See also `toggle-frame-fullscreen'." (interactive) - (let ((fullscreen (frame-parameter nil 'fullscreen))) + (let ((fullscreen (frame-parameter frame 'fullscreen))) (cond ((memq fullscreen '(fullscreen fullboth)) - (set-frame-parameter nil 'fullscreen-restore 'maximized)) + (set-frame-parameter frame 'fullscreen-restore 'maximized)) ((eq fullscreen 'maximized) - (set-frame-parameter nil 'fullscreen nil)) + (set-frame-parameter frame 'fullscreen nil)) (t - (set-frame-parameter nil 'fullscreen 'maximized))))) + (set-frame-parameter frame 'fullscreen 'maximized))))) =20 -(defun toggle-frame-fullscreen () - "Toggle fullscreen state of selected frame. -Make selected frame fullscreen or restore its previous size if it -is already fullscreen. +(defun toggle-frame-fullscreen (&optional frame) + "Toggle fullscreen state of FRAME. +Make selected frame fullscreen or restore its previous size +if it is already fullscreen. =20 Before making the frame fullscreen remember the current value of the frame's `fullscreen' parameter in the `fullscreen-restore' @@ -2431,14 +2431,14 @@ toggle-frame-fullscreen =20 See also `toggle-frame-maximized'." (interactive) - (let ((fullscreen (frame-parameter nil 'fullscreen))) + (let ((fullscreen (frame-parameter frame 'fullscreen))) (if (memq fullscreen '(fullscreen fullboth)) - (let ((fullscreen-restore (frame-parameter nil 'fullscreen-restore))) + (let ((fullscreen-restore (frame-parameter frame 'fullscreen-restore))) (if (memq fullscreen-restore '(maximized fullheight fullwidth)) - (set-frame-parameter nil 'fullscreen fullscreen-restore) - (set-frame-parameter nil 'fullscreen nil))) + (set-frame-parameter frame 'fullscreen fullscreen-restore) + (set-frame-parameter frame 'fullscreen nil))) (modify-frame-parameters - nil `((fullscreen . fullboth) (fullscreen-restore . ,fullscreen))= )) + frame `((fullscreen . fullboth) (fullscreen-restore . ,fullscreen= )))) ;; Manipulating a frame without waiting for the fullscreen ;; animation to complete can cause a crash, or other unexpected ;; behaviour, on macOS (bug#28496). ------------=_1515708962-21438-1--