From unknown Sat Aug 16 12:43:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29985: Allow modifier combinations in windmove-default-keybindings Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jan 2018 21:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29985@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15151025339277 (code B ref -1); Thu, 04 Jan 2018 21:49:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2018 21:48:53 +0000 Received: from localhost ([127.0.0.1]:36087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXDNd-0002PX-CL for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXDNc-0002PF-3z for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXDNW-0007z4-5l for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51642) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXDNW-0007yp-2T for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXDNU-0006Nd-P0 for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXDNQ-0007tx-Rn for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:44 -0500 Received: from hapkido.dreamhost.com ([66.33.216.122]:48345) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXDNQ-0007sS-Lw for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:40 -0500 Received: from homiemail-a76.g.dreamhost.com (sub3.mail.dreamhost.com [69.163.253.7]) by hapkido.dreamhost.com (Postfix) with ESMTP id 2FEA28E03B for ; Thu, 4 Jan 2018 13:48:39 -0800 (PST) Received: from homiemail-a76.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTP id 33FBA45807B for ; Thu, 4 Jan 2018 13:48:38 -0800 (PST) Received: from localhost.linkov.net (m91-129-109-142.cust.tele2.ee [91.129.109.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTPSA id 89C85458079 for ; Thu, 4 Jan 2018 13:48:37 -0800 (PST) From: Juri Linkov Organization: LINKOV.NET Date: Thu, 04 Jan 2018 23:47:36 +0200 Message-ID: <87po6pz47b.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I propose to support a list of modifiers as an arg of =E2=80=98windmove-default-keybindings=E2=80=99 to be able to customize it with e.g. (windmove-default-keybindings '(meta shift)) diff --git a/lisp/windmove.el b/lisp/windmove.el index db77d81..f565068 100644 --- a/lisp/windmove.el +++ b/lisp/windmove.el @@ -543,16 +543,18 @@ windmove-down ;; probably want to use different bindings in that case. =20 ;;;###autoload -(defun windmove-default-keybindings (&optional modifier) +(defun windmove-default-keybindings (&optional modifiers) "Set up keybindings for `windmove'. -Keybindings are of the form MODIFIER-{left,right,up,down}. -Default MODIFIER is `shift'." +Keybindings are of the form MODIFIERS-{left,right,up,down}, +where MODIFIERS is either a list of modifiers or a single modifier. +Default value of MODIFIERS is `shift'." (interactive) - (unless modifier (setq modifier 'shift)) - (global-set-key (vector (list modifier 'left)) 'windmove-left) - (global-set-key (vector (list modifier 'right)) 'windmove-right) - (global-set-key (vector (list modifier 'up)) 'windmove-up) - (global-set-key (vector (list modifier 'down)) 'windmove-down)) + (unless modifiers (setq modifiers 'shift)) + (unless (listp modifiers) (setq modifiers (list modifiers))) + (global-set-key (vector (append modifiers '(left))) 'windmove-left) + (global-set-key (vector (append modifiers '(right))) 'windmove-right) + (global-set-key (vector (append modifiers '(up))) 'windmove-up) + (global-set-key (vector (append modifiers '(down))) 'windmove-down)) =20 =20 (provide 'windmove) From unknown Sat Aug 16 12:43:27 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#29985: closed (Re: bug#29985: Allow modifier combinations in windmove-default-keybindings) Message-ID: References: <874lnsf3m4.fsf@mail.linkov.net> <87po6pz47b.fsf@mail.linkov.net> X-Gnu-PR-Message: they-closed 29985 X-Gnu-PR-Package: emacs Reply-To: 29985@debbugs.gnu.org Date: Thu, 11 Jan 2018 22:12:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1515708722-21059-1" This is a multi-part message in MIME format... ------------=_1515708722-21059-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29985: Allow modifier combinations in windmove-default-keybindings which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29985@debbugs.gnu.org. --=20 29985: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29985 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1515708722-21059-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29985-done) by debbugs.gnu.org; 11 Jan 2018 22:11:27 +0000 Received: from localhost ([127.0.0.1]:52623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZl4J-0005Sw-Fv for submit@debbugs.gnu.org; Thu, 11 Jan 2018 17:11:27 -0500 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:58241 helo=homiemail-a18.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZl4I-0005So-7H for 29985-done@debbugs.gnu.org; Thu, 11 Jan 2018 17:11:26 -0500 Received: from homiemail-a18.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTP id 92E3B258069 for <29985-done@debbugs.gnu.org>; Thu, 11 Jan 2018 14:11:25 -0800 (PST) Received: from localhost.linkov.net (m91-129-109-142.cust.tele2.ee [91.129.109.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTPSA id D12EE25805C for <29985-done@debbugs.gnu.org>; Thu, 11 Jan 2018 14:11:24 -0800 (PST) From: Juri Linkov To: 29985-done@debbugs.gnu.org Subject: Re: bug#29985: Allow modifier combinations in windmove-default-keybindings Organization: LINKOV.NET References: <87po6pz47b.fsf@mail.linkov.net> Date: Fri, 12 Jan 2018 00:10:59 +0200 In-Reply-To: <87po6pz47b.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 04 Jan 2018 23:47:36 +0200") Message-ID: <874lnsf3m4.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29985-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > I propose to support a list of modifiers as an arg of > =E2=80=98windmove-default-keybindings=E2=80=99 to be able to customize = it > with e.g. (windmove-default-keybindings '(meta shift)) Done. ------------=_1515708722-21059-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Jan 2018 21:48:53 +0000 Received: from localhost ([127.0.0.1]:36087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXDNd-0002PX-CL for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXDNc-0002PF-3z for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXDNW-0007z4-5l for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51642) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXDNW-0007yp-2T for submit@debbugs.gnu.org; Thu, 04 Jan 2018 16:48:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXDNU-0006Nd-P0 for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXDNQ-0007tx-Rn for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:44 -0500 Received: from hapkido.dreamhost.com ([66.33.216.122]:48345) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXDNQ-0007sS-Lw for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2018 16:48:40 -0500 Received: from homiemail-a76.g.dreamhost.com (sub3.mail.dreamhost.com [69.163.253.7]) by hapkido.dreamhost.com (Postfix) with ESMTP id 2FEA28E03B for ; Thu, 4 Jan 2018 13:48:39 -0800 (PST) Received: from homiemail-a76.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTP id 33FBA45807B for ; Thu, 4 Jan 2018 13:48:38 -0800 (PST) Received: from localhost.linkov.net (m91-129-109-142.cust.tele2.ee [91.129.109.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTPSA id 89C85458079 for ; Thu, 4 Jan 2018 13:48:37 -0800 (PST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Allow modifier combinations in windmove-default-keybindings Organization: LINKOV.NET Date: Thu, 04 Jan 2018 23:47:36 +0200 Message-ID: <87po6pz47b.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I propose to support a list of modifiers as an arg of =E2=80=98windmove-default-keybindings=E2=80=99 to be able to customize it with e.g. (windmove-default-keybindings '(meta shift)) diff --git a/lisp/windmove.el b/lisp/windmove.el index db77d81..f565068 100644 --- a/lisp/windmove.el +++ b/lisp/windmove.el @@ -543,16 +543,18 @@ windmove-down ;; probably want to use different bindings in that case. =20 ;;;###autoload -(defun windmove-default-keybindings (&optional modifier) +(defun windmove-default-keybindings (&optional modifiers) "Set up keybindings for `windmove'. -Keybindings are of the form MODIFIER-{left,right,up,down}. -Default MODIFIER is `shift'." +Keybindings are of the form MODIFIERS-{left,right,up,down}, +where MODIFIERS is either a list of modifiers or a single modifier. +Default value of MODIFIERS is `shift'." (interactive) - (unless modifier (setq modifier 'shift)) - (global-set-key (vector (list modifier 'left)) 'windmove-left) - (global-set-key (vector (list modifier 'right)) 'windmove-right) - (global-set-key (vector (list modifier 'up)) 'windmove-up) - (global-set-key (vector (list modifier 'down)) 'windmove-down)) + (unless modifiers (setq modifiers 'shift)) + (unless (listp modifiers) (setq modifiers (list modifiers))) + (global-set-key (vector (append modifiers '(left))) 'windmove-left) + (global-set-key (vector (append modifiers '(right))) 'windmove-right) + (global-set-key (vector (append modifiers '(up))) 'windmove-up) + (global-set-key (vector (append modifiers '(down))) 'windmove-down)) =20 =20 (provide 'windmove) ------------=_1515708722-21059-1--