Subject: [bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tests.

From: Eric Bavier <[email-masked]>
Date: Thu, 4 Jan 2018 11:04:27 -0600

This patch disable the signal handler unit tests in 'glog'.  These
tests are known to fail on several systems where the expected signals
are not generated.

-- 
Eric Bavier, Scientific Libraries, Cray Inc.
>From 08e3f2407c98e8cdad631e5671c8563de3b78978 Mon Sep 17 00:00:00 2001
From: Eric Bavier <[email-masked]>
Date: Thu, 7 Dec 2017 16:15:38 -0600
Subject: [PATCH] gnu: glog: Disable signal-handler unit tests.

* gnu/packages/logging.scm (glog)[arguments]: Add 'disable-signal-tests' phase.
---
 gnu/packages/logging.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm
index 6f9056d8f..713435c6a 100644
--- a/gnu/packages/logging.scm
+++ b/gnu/packages/logging.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2016 Ricardo Wurmus <[email-masked]>
 ;;; Copyright © 2016, 2017 Ludovic Courtès <[email-masked]>
 ;;; Copyright © 2017 Stefan Reichör <[email-masked]>
+;;; Copyright © 2017 Eric Bavier <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -84,7 +85,14 @@ staying as close to their API as is reasonable.")
                       ;; mismatch, so run the whole thing.
                       (delete-file "test-driver")
                       (delete-file "configure")   ;it's read-only
-                      (zero? (system* "autoreconf" "-vfi")))))))
+                      (zero? (system* "autoreconf" "-vfi"))))
+                  (add-before 'check 'disable-signal-tests
+                    (lambda _
+                      ;; See e.g. https://github.com/google/glog/issues/219
+                      ;; and https://github.com/google/glog/issues/256
+                      (substitute* "Makefile"
+                        (("\tsignalhandler_unittest_sh") "\t$(EMPTY)"))
+                      #t)))))
     (synopsis "C++ logging library")
     (description
      "Google glog is a library that implements application-level logging.
-- 
2.15.0