From unknown Sat Jun 21 12:30:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tests. Resent-From: Eric Bavier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Jan 2018 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 29979@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151508560415971 (code B ref -1); Thu, 04 Jan 2018 17:07:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2018 17:06:44 +0000 Received: from localhost ([127.0.0.1]:35888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eX8yV-00049S-Ac for submit@debbugs.gnu.org; Thu, 04 Jan 2018 12:06:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eX8yU-00049F-2U for submit@debbugs.gnu.org; Thu, 04 Jan 2018 12:06:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX8y3-0003FN-Nh for submit@debbugs.gnu.org; Thu, 04 Jan 2018 12:06:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55297) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eX8y3-0003F7-II for submit@debbugs.gnu.org; Thu, 04 Jan 2018 12:06:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX8xd-0005rl-2N for guix-patches@gnu.org; Thu, 04 Jan 2018 12:06:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX8xE-000225-9K for guix-patches@gnu.org; Thu, 04 Jan 2018 12:05:45 -0500 Received: from esa1.cray.iphmx.com ([68.232.142.33]:11440) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eX8xD-0001yT-Qp for guix-patches@gnu.org; Thu, 04 Jan 2018 12:05:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cray.com; i=@cray.com; q=dns/txt; s=cray1024; t=1515086651; x=1546622651; h=date:from:to:subject:message-id:mime-version: content-transfer-encoding; bh=GpFD4bLKke3Dx6R8OyGy9dNvHywcNf/SuLvddJZSTd8=; b=Bhd3qytdHDQQrUcip3sKPe0pk8+4GOLhebN+qX4poy9bJp7PqcvrS1ND htjzy9ypw5FUyd0+YAH0iN7KZSEO03OZIV/MBYQjXeUvlY5St1YpPhDwT Ukd/YdMhGpWbVzI94bSZddH0aUNdUYDBocs8h6K6Fb22hDhlX6TN1aihh A=; X-IronPort-AV: E=Sophos;i="5.46,314,1511827200"; d="scan'208,223";a="17315485" X-Cray-OBMMKR: 1433258124 17315485 Received: from cray-smtp-7.cray.com (HELO sealmr01.us.cray.com) ([136.162.66.2]) by esa1.cray.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Jan 2018 17:23:15 +0000 Received: from pe06.us.cray.com (pe06.us.cray.com [172.30.79.74]) by sealmr01.us.cray.com (8.14.3/8.13.8/hubv3-LastChangedRevision: 16250) with ESMTP id w04H4ROk025448 for ; Thu, 4 Jan 2018 09:04:28 -0800 Received: by pe06.us.cray.com (Postfix, from userid 30272) id AD317ABEB3; Thu, 4 Jan 2018 11:04:27 -0600 (CST) Date: Thu, 4 Jan 2018 11:04:27 -0600 From: Eric Bavier Message-ID: <20180104170427.GI188239@pe06.us.cray.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.17 (2007-11-01) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline This patch disable the signal handler unit tests in 'glog'. These tests are known to fail on several systems where the expected signals are not generated. -- Eric Bavier, Scientific Libraries, Cray Inc. --fUYQa+Pmc3FrFX/N Content-Type: text/x-patch; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-glog-Disable-signal-handler-unit-tests.patch" Content-Transfer-Encoding: 8bit >From 08e3f2407c98e8cdad631e5671c8563de3b78978 Mon Sep 17 00:00:00 2001 From: Eric Bavier Date: Thu, 7 Dec 2017 16:15:38 -0600 Subject: [PATCH] gnu: glog: Disable signal-handler unit tests. * gnu/packages/logging.scm (glog)[arguments]: Add 'disable-signal-tests' phase. --- gnu/packages/logging.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm index 6f9056d8f..713435c6a 100644 --- a/gnu/packages/logging.scm +++ b/gnu/packages/logging.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2016 Ricardo Wurmus ;;; Copyright © 2016, 2017 Ludovic Courtès ;;; Copyright © 2017 Stefan Reichör +;;; Copyright © 2017 Eric Bavier ;;; ;;; This file is part of GNU Guix. ;;; @@ -84,7 +85,14 @@ staying as close to their API as is reasonable.") ;; mismatch, so run the whole thing. (delete-file "test-driver") (delete-file "configure") ;it's read-only - (zero? (system* "autoreconf" "-vfi"))))))) + (zero? (system* "autoreconf" "-vfi")))) + (add-before 'check 'disable-signal-tests + (lambda _ + ;; See e.g. https://github.com/google/glog/issues/219 + ;; and https://github.com/google/glog/issues/256 + (substitute* "Makefile" + (("\tsignalhandler_unittest_sh") "\t$(EMPTY)")) + #t))))) (synopsis "C++ logging library") (description "Google glog is a library that implements application-level logging. -- 2.15.0 --fUYQa+Pmc3FrFX/N-- From unknown Sat Jun 21 12:30:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tests. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Jan 2018 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Eric Bavier Cc: 29979@debbugs.gnu.org Received: via spool by 29979-submit@debbugs.gnu.org id=B29979.151508898921223 (code B ref 29979); Thu, 04 Jan 2018 18:04:02 +0000 Received: (at 29979) by debbugs.gnu.org; 4 Jan 2018 18:03:09 +0000 Received: from localhost ([127.0.0.1]:35958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eX9rA-0005WF-C3 for submit@debbugs.gnu.org; Thu, 04 Jan 2018 13:03:09 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:39969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eX9r7-0005W6-1P for 29979@debbugs.gnu.org; Thu, 04 Jan 2018 13:03:07 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id DDB9D20AEB; Thu, 4 Jan 2018 13:03:04 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Thu, 04 Jan 2018 13:03:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=HvG/QYfvf6FgvkQLfjnTbMkCUGw6nCMY/ocqYfvrcdk=; b=M+aNO 0QsDtT7WBqzVS1nGQ16y10f6h0+aSVUmD4A00/AyzjtPNQLyDyj4qyz9zFIWpfJc ubTLAbQs35D18+FZNZud10HcGuBQ/5h58CeRXyVLKRk7YJvwYr3SMZDj64D7E9+R R9OFKGTO4LCoa9BeC7OPTIx5HmoWwzIK65GhGk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=HvG/QYfvf6FgvkQLfjnTbMkCUGw6n CMY/ocqYfvrcdk=; b=DK6cruBLqVPWtyefXVHGzUO3s+W7HEsL9AeUPbQSWmj1N roCQwSSJG9uxoF2meONo+unsvi13Yjb0v5eKW6FeOoofihNs42eAVomKANpNSTpg SYqawj6o1vgxtiXJ30CucT5tzYwOFh05VhQZVkX+AXK9eVns1tiXXtPawe1w5dGJ wGyIF1N9hEWdJaiqe/C+DzgVFoiSIYdI2o94FYXvez/hCT+cWYc5jh4wJtt0K0jY en14N9kF8FZoGixEEh9CM/hjFPVLgDn5Z0LrmCWYWEUX68WrLxgXD3KC6JbzHa8a 2J7xqhr62uW6eROxOMVEoCQ+Lo3PfCVtCWmC9ab3g== X-ME-Sender: Received: from localhost (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70]) by mail.messagingengine.com (Postfix) with ESMTPA id 90DD62465D; Thu, 4 Jan 2018 13:03:04 -0500 (EST) Date: Thu, 4 Jan 2018 13:03:03 -0500 From: Leo Famulari Message-ID: <20180104180303.GB9302@jasmine.lan> References: <20180104170427.GI188239@pe06.us.cray.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+pHx0qQiF2pBVqBT" Content-Disposition: inline In-Reply-To: <20180104170427.GI188239@pe06.us.cray.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --+pHx0qQiF2pBVqBT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 04, 2018 at 11:04:27AM -0600, Eric Bavier wrote: > This patch disable the signal handler unit tests in 'glog'. These > tests are known to fail on several systems where the expected signals > are not generated. LGTM --+pHx0qQiF2pBVqBT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlpObFcACgkQJkb6MLrK fwhTNBAA0/2qd5pJxUS69WW3dDQ/SFOnmgnzYFzrCPAA8RDlcMzlxH0Ql9kCPW6V GGMi88rNZGeUE/e9TYCAVmybMLsxQjZLuKQlVx1giqc5jxQWmDmZ3Yj0hDX04tFR QnDRHbauIten8Pv9Q+n/SJ39RPUQ5N2HzWDmx6Lkhygz+FsYzox4S7xypL2E2NxR LjI/VZN1kbZpMpkqrb+TJmgBJf2Na8H4iNjTghO9c1GRy/j0Hz5WcHskT/OglA9S 77JNqwF51GFUHHT4IWFMss1VgowV5Dn3fxbkRnVeRgNttPaPO84kKGNHywJcn7Pa Z0z1mlNQ5mjpcDG3h6SDcv3lZM/O1Fw0Dwa4uiehg8vLrJZXN+xhWAVpPjXWB6br cU336hlO6o4Qg4XJSH1JC8czhc66ju5rcRmkquAP03EOT/7KnQX3RRMHOyYw2Bi0 8TZTfVN6h0VOnW2/uh5EGXiJkxE2tVKjeEr5HGzvfOpFVj5yDsPpzoD6OJlyCuiA yYbS2WTIvp1XVAj0nXkhWNa9pLNY0CPS5TqUmwVPeIehZe+qcRiPPaVsea9pcu8Z P4a1jZjEAYQx3f2WGsBzpR7tIqs9smP9aOH6JDRw+Oxd1gNhJLX/8FyVPROuDGNF 5GFalcjx/5C5sEGFoxWabpSOgns2QYucFvihvWVSOOZVU1BZ0Pc= =Bpfn -----END PGP SIGNATURE----- --+pHx0qQiF2pBVqBT-- From unknown Sat Jun 21 12:30:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eric Bavier Subject: bug#29979: closed (Re: [bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tests.) Message-ID: References: <20180104170427.GI188239@pe06.us.cray.com> X-Gnu-PR-Message: they-closed 29979 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 29979@debbugs.gnu.org Date: Fri, 05 Jan 2018 02:37:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1515119822-22448-1" This is a multi-part message in MIME format... ------------=_1515119822-22448-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29979: [PATCH] gnu: glog: Disable signal-handler unit tests. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29979@debbugs.gnu.org. --=20 29979: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29979 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1515119822-22448-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29979-done) by debbugs.gnu.org; 5 Jan 2018 02:36:49 +0000 Received: from localhost ([127.0.0.1]:36208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXHsH-0005pb-Gp for submit@debbugs.gnu.org; Thu, 04 Jan 2018 21:36:49 -0500 Received: from esa1.cray.iphmx.com ([68.232.142.33]:20955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXHsF-0005p9-RN for 29979-done@debbugs.gnu.org; Thu, 04 Jan 2018 21:36:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cray.com; i=@cray.com; q=dns/txt; s=cray1024; t=1515120201; x=1546656201; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MOUSpfrPCyPvoQptPRnToFbRCRgIHCt+kj0AGzT9TBQ=; b=mW02yfW5RffbcdyFLrS8u8h09Lv1NiRXAOGsgjTfKDM3c8Xxcd21Isrh 64/ZOKpqzreL4YsUH3yOzn3rXhP8XWuLi8GFU1L5e+OiQMvXL5xHsef/0 4fNA8yC0K9uiQMu0GiZyKWLRIx9jAw6IdgBQXrf+ThmE/UwOIYw/V/Dgn Q=; X-IronPort-AV: E=Sophos;i="5.46,316,1511827200"; d="scan'208";a="17324619" X-Cray-OBMMKR: 1433258124 17324619 Received: from cray-smtp-2.cray.com (HELO CFWEX01.americas.cray.com) ([136.162.34.11]) by esa1.cray.iphmx.com with ESMTP/TLS/AES256-SHA; 05 Jan 2018 02:43:12 +0000 Received: from CFWEXHYBRID.americas.cray.com (172.30.88.178) by CFWEX01.americas.cray.com (172.30.88.25) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 4 Jan 2018 20:36:39 -0600 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (207.46.163.24) by mail.cray.com (172.30.88.178) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 4 Jan 2018 20:36:39 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crayinc.onmicrosoft.com; s=selector1-cray-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9enEQ6/4/Eqlwto56m8Z+/WDnhSKE15KK7j2KniJPD0=; b=V7uPypOEAsuMMUWbBa5j92jJdJ2Iqkoj6A42VoKRR3LzsY+nmG17haYB2y7u0gPPp3/5jrXLQ2yk/Fv891Q05w9+opkwoi5Ae3anHYaHft2HUqk3neWrpVEpsXPc8Tvnj8rY+PV+9K0YgRnrPOOkHCIso8ZhndaPOL7a63oGiRw= Received: from CY4PR11MB1718.namprd11.prod.outlook.com (10.169.255.151) by CY4PR11MB1717.namprd11.prod.outlook.com (10.169.255.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.8; Fri, 5 Jan 2018 02:36:38 +0000 Received: from CY4PR11MB1718.namprd11.prod.outlook.com ([10.169.255.151]) by CY4PR11MB1718.namprd11.prod.outlook.com ([10.169.255.151]) with mapi id 15.20.0366.009; Fri, 5 Jan 2018 02:36:38 +0000 From: Eric Bavier To: Leo Famulari Subject: Re: [bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tests. Thread-Topic: [bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tests. Thread-Index: AQHThX5d3MKN+nK8CEawnF3TdtEc6qNkAYqAgACPRGY= Date: Fri, 5 Jan 2018 02:36:38 +0000 Message-ID: References: <20180104170427.GI188239@pe06.us.cray.com>, <20180104180303.GB9302@jasmine.lan> In-Reply-To: <20180104180303.GB9302@jasmine.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=bavier@cray.com; x-originating-ip: [67.6.113.173] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR11MB1717; 7:CKiPq1D9BhxDI5+Kpdn9E3HL4AKyl1QCq/WS4WipX32c6fPbV/+woRo9zAKRMvtmFH1I/bYgl5NjC7sSCN0X5163IunCa1sS2bBzRlrErpcAu9gbx9DvBcw4M+/pabsBGALFqNBDeGM6y44cGnYlGZM5Z4cm3xbIVQYLV6PQj09nbUZTPJbFkt1pr7Kl7iFtda61cNMVSRFCTZq/GIqIaoheJDj4/OwnLO5zNi+qXKSU+Om6ymWsg/bJtK1cy/ie x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: da3d6cb7-7fe8-42db-bd0a-08d553e52573 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060); SRVR:CY4PR11MB1717; x-ms-traffictypediagnostic: CY4PR11MB1717: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(22074186197030); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231023)(944501075)(6041268)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:CY4PR11MB1717; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY4PR11MB1717; x-forefront-prvs: 05437568AA x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(366004)(39380400002)(346002)(39850400004)(396003)(199004)(189003)(24454002)(51914003)(102836004)(478600001)(68736007)(2906002)(53936002)(14454004)(86362001)(5660300001)(66066001)(6506007)(25786009)(53546011)(97736004)(4326008)(575784001)(6116002)(3846002)(6916009)(316002)(2950100002)(305945005)(81166006)(81156014)(8676002)(55016002)(74316002)(6436002)(77096006)(7696005)(9686003)(76176011)(105586002)(106356001)(6246003)(7736002)(3660700001)(229853002)(99286004)(33656002)(3280700002)(8936002)(2900100001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR11MB1717; H:CY4PR11MB1718.namprd11.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-microsoft-antispam-message-info: QN4EDcioboOIT7waB0c4pp9nwX3c1CLIXXhJSday+IkjYxuiLEjGJTILwOwlbJu+JOmc171rPg3YNWHdrmws2A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: da3d6cb7-7fe8-42db-bd0a-08d553e52573 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2018 02:36:38.2501 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e7b8488a-c0cd-4614-aae1-996bfabec247 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1717 X-OriginatorOrg: cray.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29979-done Cc: "29979-done@debbugs.gnu.org" <29979-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Thanks for the review. Pushed in 17e1e21603e7cba622cf4ec41c0e1467972fd449 Eric Bavier, Scientific Libraries, Cray Inc. ________________________________________ From: Leo Famulari Sent: Thursday, January 4, 2018 12:03 To: Eric Bavier Cc: 29979@debbugs.gnu.org Subject: Re: [bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tes= ts. On Thu, Jan 04, 2018 at 11:04:27AM -0600, Eric Bavier wrote: > This patch disable the signal handler unit tests in 'glog'. These > tests are known to fail on several systems where the expected signals > are not generated. LGTM ------------=_1515119822-22448-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Jan 2018 17:06:44 +0000 Received: from localhost ([127.0.0.1]:35888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eX8yV-00049S-Ac for submit@debbugs.gnu.org; Thu, 04 Jan 2018 12:06:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eX8yU-00049F-2U for submit@debbugs.gnu.org; Thu, 04 Jan 2018 12:06:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX8y3-0003FN-Nh for submit@debbugs.gnu.org; Thu, 04 Jan 2018 12:06:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55297) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eX8y3-0003F7-II for submit@debbugs.gnu.org; Thu, 04 Jan 2018 12:06:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX8xd-0005rl-2N for guix-patches@gnu.org; Thu, 04 Jan 2018 12:06:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX8xE-000225-9K for guix-patches@gnu.org; Thu, 04 Jan 2018 12:05:45 -0500 Received: from esa1.cray.iphmx.com ([68.232.142.33]:11440) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eX8xD-0001yT-Qp for guix-patches@gnu.org; Thu, 04 Jan 2018 12:05:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cray.com; i=@cray.com; q=dns/txt; s=cray1024; t=1515086651; x=1546622651; h=date:from:to:subject:message-id:mime-version: content-transfer-encoding; bh=GpFD4bLKke3Dx6R8OyGy9dNvHywcNf/SuLvddJZSTd8=; b=Bhd3qytdHDQQrUcip3sKPe0pk8+4GOLhebN+qX4poy9bJp7PqcvrS1ND htjzy9ypw5FUyd0+YAH0iN7KZSEO03OZIV/MBYQjXeUvlY5St1YpPhDwT Ukd/YdMhGpWbVzI94bSZddH0aUNdUYDBocs8h6K6Fb22hDhlX6TN1aihh A=; X-IronPort-AV: E=Sophos;i="5.46,314,1511827200"; d="scan'208,223";a="17315485" X-Cray-OBMMKR: 1433258124 17315485 Received: from cray-smtp-7.cray.com (HELO sealmr01.us.cray.com) ([136.162.66.2]) by esa1.cray.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Jan 2018 17:23:15 +0000 Received: from pe06.us.cray.com (pe06.us.cray.com [172.30.79.74]) by sealmr01.us.cray.com (8.14.3/8.13.8/hubv3-LastChangedRevision: 16250) with ESMTP id w04H4ROk025448 for ; Thu, 4 Jan 2018 09:04:28 -0800 Received: by pe06.us.cray.com (Postfix, from userid 30272) id AD317ABEB3; Thu, 4 Jan 2018 11:04:27 -0600 (CST) Date: Thu, 4 Jan 2018 11:04:27 -0600 From: Eric Bavier To: guix-patches@gnu.org Subject: [PATCH] gnu: glog: Disable signal-handler unit tests. Message-ID: <20180104170427.GI188239@pe06.us.cray.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.17 (2007-11-01) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline This patch disable the signal handler unit tests in 'glog'. These tests are known to fail on several systems where the expected signals are not generated. -- Eric Bavier, Scientific Libraries, Cray Inc. --fUYQa+Pmc3FrFX/N Content-Type: text/x-patch; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-glog-Disable-signal-handler-unit-tests.patch" Content-Transfer-Encoding: 8bit >From 08e3f2407c98e8cdad631e5671c8563de3b78978 Mon Sep 17 00:00:00 2001 From: Eric Bavier Date: Thu, 7 Dec 2017 16:15:38 -0600 Subject: [PATCH] gnu: glog: Disable signal-handler unit tests. * gnu/packages/logging.scm (glog)[arguments]: Add 'disable-signal-tests' phase. --- gnu/packages/logging.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm index 6f9056d8f..713435c6a 100644 --- a/gnu/packages/logging.scm +++ b/gnu/packages/logging.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2016 Ricardo Wurmus ;;; Copyright © 2016, 2017 Ludovic Courtès ;;; Copyright © 2017 Stefan Reichör +;;; Copyright © 2017 Eric Bavier ;;; ;;; This file is part of GNU Guix. ;;; @@ -84,7 +85,14 @@ staying as close to their API as is reasonable.") ;; mismatch, so run the whole thing. (delete-file "test-driver") (delete-file "configure") ;it's read-only - (zero? (system* "autoreconf" "-vfi"))))))) + (zero? (system* "autoreconf" "-vfi")))) + (add-before 'check 'disable-signal-tests + (lambda _ + ;; See e.g. https://github.com/google/glog/issues/219 + ;; and https://github.com/google/glog/issues/256 + (substitute* "Makefile" + (("\tsignalhandler_unittest_sh") "\t$(EMPTY)")) + #t))))) (synopsis "C++ logging library") (description "Google glog is a library that implements application-level logging. -- 2.15.0 --fUYQa+Pmc3FrFX/N-- ------------=_1515119822-22448-1--