GNU bug report logs - #29967
24.5; Bash syntax highlighting: wrong closing double quote mark

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29967 in the body.
You can then email your comments to 29967 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sam Kuper <sam.kuper <at> uclmail.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; Bash syntax highlighting: wrong closing double quote mark
Date: Wed, 3 Jan 2018 20:47:39 +0000

[Message part 1 (text/plain, inline)]

--text follows this line--

- Run `emacs -Q emacs_syntax_highlighting_bug.bash` (the latter file is
  attached).

- Note the double quote mark on line 5.

- Emacs incorrectly assumes that the corresponding closing double
  quote mark is the one on line 10, but in fact it is the one on line 11.

- As a result, the rest of the script (i.e. beyond the double
  quote mark on line 10) has incorrect syntax highlighting.



In GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
 of 2017-09-12 on hullmann, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11902000
System Description:	Debian GNU/Linux 9.3 (stretch)

Configured using:
 `configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.5/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.5/site-lisp:/usr/share/emacs/site-lisp
 --without-gnutls --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.5/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.5/site-lisp:/usr/share/emacs/site-lisp
 --without-gnutls --with-x=yes --with-x-toolkit=gtk3
 --with-toolkit-scroll-bars 'CFLAGS=-g -O2
 -fdebug-prefix-map=/build/emacs24-24.5+1=. -fstack-protector-strong
 -Wformat -Werror=format-security -Wall -fno-PIE' 'CPPFLAGS=-Wdate-time
 -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-z,relro -no-pie''

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Shell-script

Minor modes in effect:
  sh-electric-here-document-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Setting up indent for shell type bash
Indentation variables are now local.
Indentation setup for shell type bash

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils vc-git sh-script smie executable
time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment lisp-mode prog-mode register page menu-bar
rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind gfilenotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty emacs)

Memory information:
((conses 16 80118 8190)
 (symbols 48 18142 0)
 (miscs 40 40 100)
 (strings 32 12168 4820)
 (string-bytes 1 311223)
 (vectors 16 9904)
 (vector-slots 8 403254 13521)
 (floats 8 63 299)
 (intervals 56 244 0)
 (buffers 960 13))

[emacs_syntax_highlighting_bug.bash (application/octet-stream, attachment)]

Message #8 received at 29967 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Sam Kuper <sam.kuper <at> uclmail.net>
Cc: 29967 <at> debbugs.gnu.org
Subject: Re: bug#29967: 24.5;
 Bash syntax highlighting: wrong closing double quote mark
Date: Wed, 03 Jan 2018 22:00:20 +0100

On Jan 03 2018, Sam Kuper <sam.kuper <at> uclmail.net> wrote:

> --text follows this line--
>
> - Run `emacs -Q emacs_syntax_highlighting_bug.bash` (the latter file is
>   attached).
>
> - Note the double quote mark on line 5.
>
> - Emacs incorrectly assumes that the corresponding closing double
>   quote mark is the one on line 10, but in fact it is the one on line 11.
>
> - As a result, the rest of the script (i.e. beyond the double
>   quote mark on line 10) has incorrect syntax highlighting.

That works correctly for me in Emacs 26, so it appears to be fixed
already.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #11 received at 29967 <at> debbugs.gnu.org (full text, mbox):

From: Sam Kuper <sam.kuper <at> uclmail.net>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 29967 <at> debbugs.gnu.org
Subject: Re: bug#29967: 24.5; Bash syntax highlighting: wrong closing double
 quote mark
Date: Wed, 3 Jan 2018 21:32:39 +0000

On 03/01/2018, Andreas Schwab <schwab <at> linux-m68k.org> wrote:
> That works correctly for me in Emacs 26, so it appears to be fixed
> already.

Thanks, good to know. Any idea which commit/patch fixed it?

Would be nice to have the fix included in Debian's package of 24.5.1.
I guess I should report this to the Debian bug tracker...

Message #14 received at 29967 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Sam Kuper <sam.kuper <at> uclmail.net>
Cc: Andreas Schwab <schwab <at> linux-m68k.org>, 29967 <at> debbugs.gnu.org
Subject: Re: bug#29967: 24.5;
 Bash syntax highlighting: wrong closing double quote mark
Date: Wed, 03 Jan 2018 17:49:02 -0500

Sam Kuper wrote:

> Thanks, good to know. Any idea which commit/patch fixed it?
>
> Would be nice to have the fix included in Debian's package of 24.5.1.
> I guess I should report this to the Debian bug tracker...

It's fixed in Emacs 25.1. So: apt-get install emacs25 .

Message #19 received at 29967 <at> debbugs.gnu.org (full text, mbox):

From: Sam Kuper <sam.kuper <at> uclmail.net>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Andreas Schwab <schwab <at> linux-m68k.org>, 29967 <at> debbugs.gnu.org
Subject: Re: bug#29967: 24.5; Bash syntax highlighting: wrong closing double
 quote mark
Date: Fri, 5 Jan 2018 15:28:02 +0000

On 03/01/2018, Glenn Morris <rgm <at> gnu.org> wrote:
> It's fixed in Emacs 25.1. So: apt-get install emacs25 .

Thanks. I can confirm that this workaround is successful.

It would still be good for the issue to be fixed in the 24.x branch, though.

Message #22 received at 29967 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Sam Kuper <sam.kuper <at> uclmail.net>
Cc: Andreas Schwab <schwab <at> linux-m68k.org>, 29967 <at> debbugs.gnu.org
Subject: Re: bug#29967: 24.5;
 Bash syntax highlighting: wrong closing double quote mark
Date: Fri, 05 Jan 2018 13:40:39 -0500

Sam Kuper wrote:

>> It's fixed in Emacs 25.1. So: apt-get install emacs25 .
>
> Thanks. I can confirm that this workaround is successful.
>
> It would still be good for the issue to be fixed in the 24.x branch, though.

Looking at the rate of changes that Debian Emacs receives,
I don't think this is a realistic expectation.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.