GNU bug report logs - #29960
[PATCH] gnu: Add emacs-evil-quickscope.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29960 in the body.
You can then email your comments to 29960 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: Add emacs-evil-quickscope.
Date: Wed,  3 Jan 2018 11:48:57 +0530

* gnu/packages/emacs.scm (emacs-evil-quickscope): New variable.
---
 gnu/packages/emacs.scm | 37 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 538c79a50..ebee6f61b 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -16,7 +16,7 @@
 ;;; Copyright © 2016 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2016, 2017 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2016, 2017 Alex Vong <alexvong1995 <at> gmail.com>
-;;; Copyright © 2016, 2017 Arun Isaac <arunisaac <at> systemreboot.net>
+;;; Copyright © 2016, 2017, 2018 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2017 Christopher Baines <mail <at> cbaines.net>
 ;;; Copyright © 2017 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;; Copyright © 2017 Clément Lassieur <clement <at> lassieur.org>
@@ -6599,3 +6599,38 @@ evil mode using @kbd{%}.  It is a port of @code{matchit} for Vim.")
 makes Evil play nice with Smartparens.  Evil is an Emacs minor mode that
 emulates Vim features and provides Vim-like key bindings.")
     (license license:gpl3+)))
+
+(define-public emacs-evil-quickscope
+  (package
+    (name "emacs-evil-quickscope")
+    (version "0.1.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/blorbx/evil-quickscope/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1r26a412mmar7vbf89zcifswiwpdg30mjzj32xdyqss57aqi83ma"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-evil" ,emacs-evil)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'install 'check
+           (lambda* (#:key inputs #:allow-other-keys)
+             (invoke "emacs" "--batch" "-L"
+                     (string-append (assoc-ref inputs "emacs-evil")
+                                    "/share/emacs/site-lisp/guix.d/evil-"
+                                    ,(package-version emacs-evil))
+                     "-l" "evil-quickscope-tests.el"
+                     "-f" "ert-run-tests-batch-and-exit"))))))
+    (home-page "https://github.com/blorbx/evil-quickscope")
+    (synopsis "Target highlighting for emacs evil-mode f,F,t and T commands")
+    (description "@code{emacs-evil-quickscope} highlights targets for Evil
+mode’s f,F,t,T keys, allowing for quick navigation within a line.  It is a
+port of quick-scope for Vim.  Evil is an Emacs minor mode that emulates Vim
+features and provides Vim-like key bindings.")
+    (license license:gpl3+)))
-- 
2.15.1

Message #8 received at 29960 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 29960 <at> debbugs.gnu.org
Subject: Re: [bug#29960] [PATCH] gnu: Add emacs-evil-quickscope.
Date: Wed, 3 Jan 2018 19:57:16 +0100

[Message part 1 (text/plain, inline)]

2018-01-03 7:18 GMT+01:00 Arun Isaac <arunisaac <at> systemreboot.net>:

> * gnu/packages/emacs.scm (emacs-evil-quickscope): New variable.
> ---
>  gnu/packages/emacs.scm | 37 ++++++++++++++++++++++++++++++++++++-
>  1 file changed, 36 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 538c79a50..ebee6f61b 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -16,7 +16,7 @@
>  ;;; Copyright © 2016 Alex Griffin <a <at> ajgrf.com>
>  ;;; Copyright © 2016, 2017 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
>  ;;; Copyright © 2016, 2017 Alex Vong <alexvong1995 <at> gmail.com>
> -;;; Copyright © 2016, 2017 Arun Isaac <arunisaac <at> systemreboot.net>
> +;;; Copyright © 2016, 2017, 2018 Arun Isaac <arunisaac <at> systemreboot.net>
>  ;;; Copyright © 2017 Christopher Baines <mail <at> cbaines.net>
>  ;;; Copyright © 2017 Mathieu Othacehe <m.othacehe <at> gmail.com>
>  ;;; Copyright © 2017 Clément Lassieur <clement <at> lassieur.org>
> @@ -6599,3 +6599,38 @@ evil mode using @kbd{%}.  It is a port of
> @code{matchit} for Vim.")
>  makes Evil play nice with Smartparens.  Evil is an Emacs minor mode that
>  emulates Vim features and provides Vim-like key bindings.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-evil-quickscope
>

LGTM

Admittedly, I didn't build and lint this one

As for running it, I couldn't because, as I said, I'm too old to learn new
key combinations

But at a first glance it seems ok, I trust Arun that this runs fine

The license is actually GPL3+, as you can see here
https://github.com/blorbx/evil-quickscope/blob/master/LICENSE

The description mentions Evil and explains what it is

So as ar as I'm concerned, this is ok

Arun, you can commit on your own, you wouldn't need to post these little
things here ;-)

Ciao

[Message part 2 (text/html, inline)]

Message #11 received at 29960 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Catonano <catonano <at> gmail.com>
Cc: 29960 <at> debbugs.gnu.org, Arun Isaac <arunisaac <at> systemreboot.net>
Subject: Re: [bug#29960] [PATCH] gnu: Add emacs-evil-quickscope.
Date: Wed, 3 Jan 2018 14:31:41 -0500

[Message part 1 (text/plain, inline)]

On Wed, Jan 03, 2018 at 07:57:16PM +0100, Catonano wrote:
> 2018-01-03 7:18 GMT+01:00 Arun Isaac <arunisaac <at> systemreboot.net>:
> > * gnu/packages/emacs.scm (emacs-evil-quickscope): New variable.
> 
> LGTM

> Arun, you can commit on your own, you wouldn't need to post these little
> things here ;-)

Agreed :)

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 29960 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Catonano <catonano <at> gmail.com>
Cc: 29960 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#29960] [PATCH] gnu: Add emacs-evil-quickscope.
Date: Thu, 04 Jan 2018 12:51:35 +0530

> The license is actually GPL3+, as you can see here
> https://github.com/blorbx/evil-quickscope/blob/master/LICENSE

Just confused... Isn't that what I've already put in the patch?

> Arun, you can commit on your own, you wouldn't need to post these little
> things here ;-)

Yes, these are simple packages and I could commit directly. But, I post
here just to get a quick sanity check on the summary, description,
license, etc. I'll probably mention that next time so the reviewer's job
will be easier. :-)

Message #17 received at 29960 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 29960 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#29960] [PATCH] gnu: Add emacs-evil-quickscope.
Date: Thu, 4 Jan 2018 09:11:12 +0100

[Message part 1 (text/plain, inline)]

2018-01-04 8:21 GMT+01:00 Arun Isaac <arunisaac <at> systemreboot.net>:

>
> > The license is actually GPL3+, as you can see here
> > https://github.com/blorbx/evil-quickscope/blob/master/LICENSE
>
> Just confused... Isn't that what I've already put in the patch?
>

Yes, it is !

I was just showing that I checked the license ;-)

> Arun, you can commit on your own, you wouldn't need to post these little
> > things here ;-)
>
> Yes, these are simple packages and I could commit directly. But, I post
> here just to get a quick sanity check on the summary, description,
> license, etc. I'll probably mention that next time so the reviewer's job
> will be easier. :-)
>

Ah ok. Well, you got waht you wanted then :-)

LGTM !

Ciao

[Message part 2 (text/html, inline)]

Message #22 received at 29960-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Catonano <catonano <at> gmail.com>
Cc: 29960-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#29960] [PATCH] gnu: Add emacs-evil-quickscope.
Date: Thu, 04 Jan 2018 14:18:51 +0530

Catonano <catonano <at> gmail.com> writes:

> I was just showing that I checked the license ;-)

Ok, ok. I understand now. :-)

>> Arun, you can commit on your own, you wouldn't need to post these little
>> > things here ;-)
>>
>> Yes, these are simple packages and I could commit directly. But, I post
>> here just to get a quick sanity check on the summary, description,
>> license, etc. I'll probably mention that next time so the reviewer's job
>> will be easier. :-)
>
> Ah ok. Well, you got waht you wanted then :-)

Yes, I got what I wanted.

> LGTM !

Pushed, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.