From unknown Mon Jun 23 07:53:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29956: 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jan 2018 03:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29956@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151495146928718 (code B ref -1); Wed, 03 Jan 2018 03:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jan 2018 03:51:09 +0000 Received: from localhost ([127.0.0.1]:33698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWa57-0007T8-Dz for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWa54-0007Sa-7S for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWa4y-0001Xx-3B for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39221) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eWa4x-0001Xo-Vx for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWa4w-0006Xy-Lz for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:50:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWa4t-0001Tb-Ed for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:50:58 -0500 Received: from pmta11.teksavvy.com ([76.10.157.34]:15425) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWa4t-0001SV-8p for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:50:55 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2E8CgBmUkxa/2Obs2tdg29GgRSDbYtjjiYBgjMBglyWLwoThSIEhDNEFAEBAQEBAQEBAQNoKIYBXxMhARwNimW0MYpxhAyFUYkYhTAFkiCBFJAaoT6HdZcDgTw2I4FPMhoIMD2CKoIDAQuCZSOJMgEBAQ X-IPAS-Result: A2E8CgBmUkxa/2Obs2tdg29GgRSDbYtjjiYBgjMBglyWLwoThSIEhDNEFAEBAQEBAQEBAQNoKIYBXxMhARwNimW0MYpxhAyFUYkYhTAFkiCBFJAaoT6HdZcDgTw2I4FPMhoIMD2CKoIDAQuCZSOJMgEBAQ X-IronPort-AV: E=Sophos;i="5.45,500,1508817600"; d="scan'208";a="17183745" Received: from 107-179-155-99.cpe.teksavvy.com (HELO ceviche.home) ([107.179.155.99]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2018 22:50:53 -0500 Received: by ceviche.home (Postfix, from userid 20848) id D72A7662E5; Tue, 2 Jan 2018 22:50:52 -0500 (EST) From: Stefan Monnier Date: Tue, 02 Jan 2018 22:50:52 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Package: Emacs Version: 26.0.90 % src/emacs -Q lisp/emacs-lisp/pcase.el ...Select the first (def-edebug-spec ...) C-x v h In the *VC-history* buffer, hit `d' This gives me `Wrong type argument: sequencep, 47' [ Which file you use, and which region of the file you select doesn't really matter. ] The patch below fixes it for me. Is it OK to install it into emacs-26, or should I keep it on `master`? FWIW, it's not a new bug in Emacs-26 and it's not terribly urgent to fix it, e.g. because you can use `D' which does work (tho it doesn't do quite the same), so I'm fine with either choice. Stefan diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 7c502f88df..0a87e70017 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2426,9 +2426,11 @@ vc-region-history (setq-local vc-log-view-type 'long)) (vc-call region-history file buf lfrom lto) (with-current-buffer buf + (setq default-directory (file-name-directory file)) (vc-call-backend backend 'region-history-mode) (set (make-local-variable 'log-view-vc-backend) backend) - (set (make-local-variable 'log-view-vc-fileset) file) + (set (make-local-variable 'log-view-vc-fileset) + (list (file-relative-name file))) (set (make-local-variable 'revert-buffer-function) (lambda (_ignore-auto _noconfirm) (with-current-buffer buf From unknown Mon Jun 23 07:53:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29956: 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jan 2018 15:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 29956@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29956-submit@debbugs.gnu.org id=B29956.151499199510847 (code B ref 29956); Wed, 03 Jan 2018 15:07:01 +0000 Received: (at 29956) by debbugs.gnu.org; 3 Jan 2018 15:06:35 +0000 Received: from localhost ([127.0.0.1]:34494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWkck-0002os-Um for submit@debbugs.gnu.org; Wed, 03 Jan 2018 10:06:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWkci-0002od-Ma for 29956@debbugs.gnu.org; Wed, 03 Jan 2018 10:06:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWkca-0008HO-Hu for 29956@debbugs.gnu.org; Wed, 03 Jan 2018 10:06:27 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWkca-0008HE-E4; Wed, 03 Jan 2018 10:06:24 -0500 Received: from [176.228.60.248] (port=2138 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eWkca-0004mD-05; Wed, 03 Jan 2018 10:06:24 -0500 Date: Wed, 03 Jan 2018 17:06:23 +0200 Message-Id: <83vagjasnk.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Stefan Monnier on Tue, 02 Jan 2018 22:50:52 -0500) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Stefan Monnier > Date: Tue, 02 Jan 2018 22:50:52 -0500 > > % src/emacs -Q lisp/emacs-lisp/pcase.el > ...Select the first (def-edebug-spec ...) > C-x v h > In the *VC-history* buffer, hit `d' > > This gives me `Wrong type argument: sequencep, 47' > [ Which file you use, and which region of the file you select doesn't > really matter. ] > > The patch below fixes it for me. > > Is it OK to install it into emacs-26, or should I keep it on `master`? It's okay for emacs-26, but I'm curious why did you need the default-directory part. Is that related to the problem? Thanks. From unknown Mon Jun 23 07:53:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29956: 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jan 2018 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 29956@debbugs.gnu.org Received: via spool by 29956-submit@debbugs.gnu.org id=B29956.15150114179929 (code B ref 29956); Wed, 03 Jan 2018 20:31:02 +0000 Received: (at 29956) by debbugs.gnu.org; 3 Jan 2018 20:30:17 +0000 Received: from localhost ([127.0.0.1]:34678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWpg1-0002a5-6M for submit@debbugs.gnu.org; Wed, 03 Jan 2018 15:30:17 -0500 Received: from pmta21.teksavvy.com ([76.10.157.36]:13735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWpfw-0002Yy-J4 for 29956@debbugs.gnu.org; Wed, 03 Jan 2018 15:30:12 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2E5FgABPU1a/xCds2tdg2+BWolJhgeOEQGCADMBmQsKhTUEAgKEL0QUAQEBAQEBAQEBA2gohSUBBAFWIxALNBIUGA0kijkItBmKPQEBAQEGAgElhBOIf4saBZM1kByLK4wJig2HdpcGgTw2I4FPMhoIMD2CKoJTHIIFI4oDAQEB X-IPAS-Result: A2E5FgABPU1a/xCds2tdg2+BWolJhgeOEQGCADMBmQsKhTUEAgKEL0QUAQEBAQEBAQEBA2gohSUBBAFWIxALNBIUGA0kijkItBmKPQEBAQEGAgElhBOIf4saBZM1kByLK4wJig2HdpcGgTw2I4FPMhoIMD2CKoJTHIIFI4oDAQEB X-IronPort-AV: E=Sophos;i="5.45,503,1508817600"; d="scan'208";a="16760546" Received: from 107-179-157-16.cpe.teksavvy.com (HELO ceviche.home) ([107.179.157.16]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2018 15:30:06 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 87E2D6630A; Wed, 3 Jan 2018 15:30:06 -0500 (EST) From: Stefan Monnier Message-ID: References: <83vagjasnk.fsf@gnu.org> Date: Wed, 03 Jan 2018 15:30:06 -0500 In-Reply-To: <83vagjasnk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 Jan 2018 17:06:23 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> Is it OK to install it into emacs-26, or should I keep it on `master`? > It's okay for emacs-26, but I'm curious why did you need the > default-directory part. Is that related to the problem? I first tried by just setting log-view-vc-fileset to (list file) but that gave me an error which gave me the impression that the fileset should be composed of relative file names, and since the buffer can be reused it's important to set default-directory properly before we can use relative file names. Stefan From unknown Mon Jun 23 07:53:18 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stefan Monnier Subject: bug#29956: closed (Re: bug#29956: 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47) Message-ID: References: X-Gnu-PR-Message: they-closed 29956 X-Gnu-PR-Package: emacs Reply-To: 29956@debbugs.gnu.org Date: Wed, 03 Jan 2018 20:36:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1515011761-10522-1" This is a multi-part message in MIME format... ------------=_1515011761-10522-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29956: 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29956@debbugs.gnu.org. --=20 29956: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29956 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1515011761-10522-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29956-done) by debbugs.gnu.org; 3 Jan 2018 20:35:46 +0000 Received: from localhost ([127.0.0.1]:34697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWplK-0002jA-0R for submit@debbugs.gnu.org; Wed, 03 Jan 2018 15:35:46 -0500 Received: from pmta21.teksavvy.com ([76.10.157.36]:60549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWplI-0002ia-H1 for 29956-done@debbugs.gnu.org; Wed, 03 Jan 2018 15:35:44 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2E5FgAwPk1a/xCds2tdg2+BWolJhgeOE?= =?us-ascii?q?QGCADMBmQsKhTUEAgKEL0QUAQEBAQEBAQEBA2gohSUBBAFWIwULCzQSFBgNJIo?= =?us-ascii?q?5CLQbij0BAQEBBgIBJYQTiH+LGgWTNZAcoUGHdpcGgTw2I4FPMhoIMD2CKoJTH?= =?us-ascii?q?IIFI4oDAQEB?= X-IPAS-Result: =?us-ascii?q?A2E5FgAwPk1a/xCds2tdg2+BWolJhgeOEQGCADMBmQsKhTU?= =?us-ascii?q?EAgKEL0QUAQEBAQEBAQEBA2gohSUBBAFWIwULCzQSFBgNJIo5CLQbij0BAQEBB?= =?us-ascii?q?gIBJYQTiH+LGgWTNZAcoUGHdpcGgTw2I4FPMhoIMD2CKoJTHIIFI4oDAQEB?= X-IronPort-AV: E=Sophos;i="5.45,503,1508817600"; d="scan'208";a="16761967" Received: from 107-179-157-16.cpe.teksavvy.com (HELO ceviche.home) ([107.179.157.16]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2018 15:35:38 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 4C3AB6630A; Wed, 3 Jan 2018 15:35:38 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#29956: 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47 Message-ID: References: <83vagjasnk.fsf@gnu.org> Date: Wed, 03 Jan 2018 15:35:38 -0500 In-Reply-To: <83vagjasnk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 Jan 2018 17:06:23 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 29956-done Cc: 29956-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > It's okay for emacs-26, but I'm curious why did you need the > default-directory part. Is that related to the problem? I checked the value of log-view-vc-fileset elsewhere and they seem to use absolute file names. So I tried again with (list file) and it worked fine, not sure why I got an error when I checked last time. So I installed the patch below instead, Stefan diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 7c502f88df..f8d63d1498 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2428,7 +2428,7 @@ vc-region-history (with-current-buffer buf (vc-call-backend backend 'region-history-mode) (set (make-local-variable 'log-view-vc-backend) backend) - (set (make-local-variable 'log-view-vc-fileset) file) + (set (make-local-variable 'log-view-vc-fileset) (list file)) (set (make-local-variable 'revert-buffer-function) (lambda (_ignore-auto _noconfirm) (with-current-buffer buf ------------=_1515011761-10522-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Jan 2018 03:51:09 +0000 Received: from localhost ([127.0.0.1]:33698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWa57-0007T8-Dz for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWa54-0007Sa-7S for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWa4y-0001Xx-3B for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39221) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eWa4x-0001Xo-Vx for submit@debbugs.gnu.org; Tue, 02 Jan 2018 22:51:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWa4w-0006Xy-Lz for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:50:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWa4t-0001Tb-Ed for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:50:58 -0500 Received: from pmta11.teksavvy.com ([76.10.157.34]:15425) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWa4t-0001SV-8p for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 22:50:55 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2E8CgBmUkxa/2Obs2tdg29GgRSDbYtjj?= =?us-ascii?q?iYBgjMBglyWLwoThSIEhDNEFAEBAQEBAQEBAQNoKIYBXxMhARwNimW0MYpxhAy?= =?us-ascii?q?FUYkYhTAFkiCBFJAaoT6HdZcDgTw2I4FPMhoIMD2CKoIDAQuCZSOJMgEBAQ?= X-IPAS-Result: =?us-ascii?q?A2E8CgBmUkxa/2Obs2tdg29GgRSDbYtjjiYBgjMBglyWLwo?= =?us-ascii?q?ThSIEhDNEFAEBAQEBAQEBAQNoKIYBXxMhARwNimW0MYpxhAyFUYkYhTAFkiCBF?= =?us-ascii?q?JAaoT6HdZcDgTw2I4FPMhoIMD2CKoIDAQuCZSOJMgEBAQ?= X-IronPort-AV: E=Sophos;i="5.45,500,1508817600"; d="scan'208";a="17183745" Received: from 107-179-155-99.cpe.teksavvy.com (HELO ceviche.home) ([107.179.155.99]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2018 22:50:53 -0500 Received: by ceviche.home (Postfix, from userid 20848) id D72A7662E5; Tue, 2 Jan 2018 22:50:52 -0500 (EST) From: Stefan Monnier To: bug-gnu-emacs@gnu.org Subject: 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47 Date: Tue, 02 Jan 2018 22:50:52 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Package: Emacs Version: 26.0.90 % src/emacs -Q lisp/emacs-lisp/pcase.el ...Select the first (def-edebug-spec ...) C-x v h In the *VC-history* buffer, hit `d' This gives me `Wrong type argument: sequencep, 47' [ Which file you use, and which region of the file you select doesn't really matter. ] The patch below fixes it for me. Is it OK to install it into emacs-26, or should I keep it on `master`? FWIW, it's not a new bug in Emacs-26 and it's not terribly urgent to fix it, e.g. because you can use `D' which does work (tho it doesn't do quite the same), so I'm fine with either choice. Stefan diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 7c502f88df..0a87e70017 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2426,9 +2426,11 @@ vc-region-history (setq-local vc-log-view-type 'long)) (vc-call region-history file buf lfrom lto) (with-current-buffer buf + (setq default-directory (file-name-directory file)) (vc-call-backend backend 'region-history-mode) (set (make-local-variable 'log-view-vc-backend) backend) - (set (make-local-variable 'log-view-vc-fileset) file) + (set (make-local-variable 'log-view-vc-fileset) + (list (file-relative-name file))) (set (make-local-variable 'revert-buffer-function) (lambda (_ignore-auto _noconfirm) (with-current-buffer buf ------------=_1515011761-10522-1--