GNU bug report logs - #29950
[PATCH] gnu: Add instantmusic.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#29950: closed ([PATCH] gnu: Add instantmusic.)
Date: Sun, 28 Jan 2018 22:47:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 28 Jan 2018 23:46:05 +0100
with message-id <87a7wxy53m.fsf <at> gnu.org>
and subject line Re: [bug#29950] [PATCH] gnu: Add instantmusic.
has caused the debbugs.gnu.org bug report #29950,
regarding [PATCH] gnu: Add instantmusic.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
29950: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29950
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add instantmusic.
Date: Tue, 02 Jan 2018 19:39:56 +0100

* gnu/packages/music.scm (instantmusic): New variable.
---
 gnu/packages/music.scm |   41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 5b8728e..db1c33d 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2017 Pierre Langlois <pierre.langlois <at> gmx.com>
 ;;; Copyright © 2017 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2017 Tobias Geerinckx-Rice <me <at> tobias.gr>
+;;; Copyright © 2018 Stefan Reichör <stefan <at> xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2459,6 +2460,46 @@ websites such as Libre.fm.")
 (define-public python2-pylast
   (package-with-python2 python-pylast))
 
+(define-public instantmusic
+  (let ((commit "300891d09c703525215fa5a116b9294af1c923c8")
+        (revision "1"))
+    (package
+      (name "instantmusic")
+      (version (string-append "0.1-" revision "." (string-take commit 9)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/yask123/Instant-Music-Downloader.git")
+                      (commit commit)))
+                (file-name (string-append name "-" version "-checkout"))
+                (sha256
+                 (base32
+                  "0j7qivaa04bpdz3anmgci5833dgiyfqqwq9fdrpl9m68b34gl773"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-requests" ,python-requests)
+       ("eyed3", eyed3)
+       ("python-beautifulsoup4" ,python-beautifulsoup4)
+       ("youtube-dl" ,youtube-dl)))
+    (arguments
+     '(#:modules ((guix build python-build-system)
+                  (guix build utils)
+                  (srfi srfi-26))
+       #:phases (modify-phases %standard-phases
+                  (add-before 'build 'change-directory
+                    (lambda _
+                      (chdir "instantmusic-0.1")
+                      ;; Fix some read-only files that would cause a build failure
+                      (for-each (cut chmod <> #o644)
+                                (find-files "instantmusic.egg-info"
+                                            "PKG-INFO|.*\\.txt"))
+                      #t)))))
+    (home-page "http://iyask.me/Instant-Music-Downloader/")
+    (synopsis "Command line app to download a song from youtube")
+    (description "Download a song from youtube in .mp3 format.  Songs can be
+searched by artist, name or even by a part of the song text.")
+    (license license:expat))))
+
 (define-public beets
   (package
     (name "beets")

[Message part 3 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 29950-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#29950] [PATCH] gnu: Add instantmusic.
Date: Sun, 28 Jan 2018 23:46:05 +0100

[Message part 4 (text/plain, inline)]

Hi Stefan,

Stefan Reichör <stefan <at> xsteve.at> skribis:

>> Can you send an updated patch?
>
> * gnu/packages/music.scm (instantmusic): New variable.

I applied the cosmetic changes below and committed.

In the future please send the file produced by ‘git format-patch’ so
that the reviewer can directly pipe it through ‘git am’.

Thank you!

Ludo’.

[Message part 5 (text/x-patch, inline)]

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 57ef87bf9..9e06bf55a 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2527,9 +2527,9 @@ websites such as Libre.fm.")
                                             "PKG-INFO|.*\\.txt"))
                       #t)))))
     (home-page "http://iyask.me/Instant-Music-Downloader/")
-    (synopsis "Command line app to download a song from youtube")
-    (description "Download a song from youtube in .mp3 format.  Songs can be
-searched by artist, name or even by a part of the song text.")
+    (synopsis "Command-line program to download a song from YouTube")
+    (description "InstantMusic downloads a song from YouTube in MP3 format.
+Songs can be searched by artist, name or even by a part of the song text.")
     (license license:expat))))
 
 (define-public beets

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.