From unknown Mon Aug 18 04:43:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29919: 26.0.90; Incorrect Edebug spec for cl-macrolet Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Dec 2017 21:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29919 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29919@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151475620116392 (code B ref -1); Sun, 31 Dec 2017 21:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 31 Dec 2017 21:36:41 +0000 Received: from localhost ([127.0.0.1]:59088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eVlHd-0004GK-Kx for submit@debbugs.gnu.org; Sun, 31 Dec 2017 16:36:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eVlHb-0004Fy-C3 for submit@debbugs.gnu.org; Sun, 31 Dec 2017 16:36:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eVlHV-0007WH-6J for submit@debbugs.gnu.org; Sun, 31 Dec 2017 16:36:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56545) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eVlHV-0007Vv-2b for submit@debbugs.gnu.org; Sun, 31 Dec 2017 16:36:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eVlHU-0008PE-2Z for bug-gnu-emacs@gnu.org; Sun, 31 Dec 2017 16:36:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eVlHQ-0007Ru-2L for bug-gnu-emacs@gnu.org; Sun, 31 Dec 2017 16:36:32 -0500 Received: from aibo.runbox.com ([91.220.196.211]:36942) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eVlHP-0007Qb-Nn for bug-gnu-emacs@gnu.org; Sun, 31 Dec 2017 16:36:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=1ppUjVPUM7J/NNDszPNboNABwyEh2TOFS8Z81NCjqBs=; b=fIFcsn5pZ7fetFHjm5BgrJWju p1YVGoumAYdQ1hhlC8627PGpRIh9jUIlBT0pL7cGufJFY03aBjqBH5jDRf6+HkO0nVHkL1fVdcnqB OiJV1ftF0SZSM6ban6Slo2Yq8ESu+hX6swVW8zIgoKLSjuCzr0yuN9u9Usp6S7Ja+5qA53H+DU1wB LzU02eB8q/LKIsHMLcOocVnepWFrvc5vxfzstSwKw6lnZvpG9XPqFQTTzIvKXQRpqWdUBqlJHGY9B 4D7V2qiGFr3evk0k0h3ankKyH841xXvRoe589sXRhXmp+ghjQd4YanXZE/eYH9WnEgCsQPOEkQ7s0 QR8uaTWNw==; Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1eVlHN-0007uI-Ro for bug-gnu-emacs@gnu.org; Sun, 31 Dec 2017 22:36:25 +0100 Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=chinook) by mailfront10.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1eVlHI-00073Q-L0 for bug-gnu-emacs@gnu.org; Sun, 31 Dec 2017 22:36:21 +0100 From: Gemini Lasswell Date: Sun, 31 Dec 2017 13:36:17 -0800 Message-ID: <87vagmwpf2.fsf@runbox.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Edebug gives an error when trying to instrument a function which uses cl-macrolet to define a macro with an argument list containing &rest. To reproduce, enter the following into *scratch*: (defun bug (x) (cl-macrolet ((wrap (func &rest args) `(progn (message "%s" ',args) (funcall #',func ,@args)))) (wrap + 1 x))) Then C-u C-M-x. Result: edebug-syntax-error: Invalid read syntax: "Failed matching" Looks to me like the problem is that the Edebug spec is using (&rest arg) when it should be using cl-macro-list, assuming that cl-macrolet supports full CL argument lists. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 04 11:11:03 2018 Received: (at control) by debbugs.gnu.org; 4 Feb 2018 16:11:03 +0000 Received: from localhost ([127.0.0.1]:57264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiMsh-00083z-Bm for submit@debbugs.gnu.org; Sun, 04 Feb 2018 11:11:03 -0500 Received: from mail-it0-f53.google.com ([209.85.214.53]:50462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiMsf-00083Q-Od; Sun, 04 Feb 2018 11:11:01 -0500 Received: by mail-it0-f53.google.com with SMTP id x128so13990965ite.0; Sun, 04 Feb 2018 08:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=K+d00ucDpl61W6mDl5ofvUYeZQrrHPSTfQgqZN5CPdU=; b=n0Yr72nBcuezi5Z96xxSuZ0ks/4BKlQUz8HM3/HPScYCjJPz+z3ApbLSbTZhD7LGEZ Ml0y4AY4+PFPlRjuP5visDO35ngPr+v8OdLxOsi8LtsDQmv8gHIpitkc8kFgx1n+vdQj pgeP8cQPhBC82E6ulscOLQT1reJoRXEZ3Q8ZsiCoRIY1L5mpZrdyAdZvwRQqwOfzVcMl YnJGTao+QYtyYsZCpF69QVFhQpvYAennQi6iYRSmbICkaY533yqSO/IvWWmzxgAtgDQA 8EHmIgw46KmT+i5Jl479Jbr159uLLZwgJ759uJf7F+BIFDW0oXkc4jjZxjLtnDyIlgK5 Ws5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=K+d00ucDpl61W6mDl5ofvUYeZQrrHPSTfQgqZN5CPdU=; b=OxcdNZu+DGi3rFGsBSu7sqv1zMwy0JvYelW39ntvKi2HYByaDTmG1Q8dNqbrfIvQfw f9zmiuQbdgzFQs/3ahM+WNs7+/d183Z4iu6STqX1AoDtsa1XIck/IU7VjKi73S0Y8rgS CvZKiJLVAzIxgw1L8pLBRsaIlyyaRVHaRrZY/yeqeQK17YIoy8tvUhs0I3Kh5Lfnc9eD TzxmE546BxkN7w8hoiJYLJlxD7MsSSPPi2rW0CoP3tGlZjsg0nUrVMtKiy67Jfy3zjZA uXTPxDPvHYaaa6LlMg8MhZDN+qNDqJvrATHoEFzpOqkj5ld/Llh5IZFCvVF7OkldvWVZ 1thg== X-Gm-Message-State: APf1xPA0oRSupA9tJXyy2uasvZEmazgbs+0DHgy3CW32rOFs8c5WUqpV lG91iJwzpta8Z0II+Tecet+Psw== X-Google-Smtp-Source: AH8x224AAehgoce4nwIqiKll0GLWOc6cWDgQrPHsHbdGnkJmwNPK+h0441KtxtVyB0Dfa3CmL4e/XQ== X-Received: by 10.36.28.68 with SMTP id c65mr5306669itc.142.1517760656167; Sun, 04 Feb 2018 08:10:56 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 20sm4010770iof.43.2018.02.04.08.10.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Feb 2018 08:10:55 -0800 (PST) From: Noam Postavsky To: Kaushal Modi Subject: Re: bug#30348: 26.0.91; Unable to edebug org-export-data References: Date: Sun, 04 Feb 2018 11:10:54 -0500 In-Reply-To: (Kaushal Modi's message of "Sun, 04 Feb 2018 16:04:52 +0000") Message-ID: <877ersg2gh.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: control Cc: 30348@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) merge 30348 29919 quit Kaushal Modi writes: > Trying to edebug org-export-data in emacs -Q (emacs 26.0.91, using > inbuilt Org 9.1.6) gives this error: > > edebug-syntax-error: Invalid read syntax: "Failed matching", (&rest > (&define name (&rest arg) cl-declarations-or-string def-body)) This is an instance of Bug#29919. From unknown Mon Aug 18 04:43:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29919: 26.0.90; Incorrect Edebug spec for cl-macrolet Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Jul 2018 23:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29919 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gemini Lasswell Cc: 29919@debbugs.gnu.org, Kaushal Modi Received: via spool by 29919-submit@debbugs.gnu.org id=B29919.153247448012696 (code B ref 29919); Tue, 24 Jul 2018 23:22:01 +0000 Received: (at 29919) by debbugs.gnu.org; 24 Jul 2018 23:21:20 +0000 Received: from localhost ([127.0.0.1]:55867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fi6cJ-0003Ii-NQ for submit@debbugs.gnu.org; Tue, 24 Jul 2018 19:21:20 -0400 Received: from aibo.runbox.com ([91.220.196.211]:43592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fi6cH-0003IY-3w for 29919@debbugs.gnu.org; Tue, 24 Jul 2018 19:21:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=7yYg0qb0roAvxM8i/Ej3PcJO0WDTYR5bM4sZ1h0AZzw=; b=SUUzKyLjxRsRTRkKQEcKrj1f7x BSLg2r40PN0jwx6m+/gRo6gBg0tQ1VlWd0D3CH9Va7v/AgX9pyn4dMgnELdxGDLMNsXotPgWn8+tq JSeqsyYXeFnUdBuX5ygwSehwoBcYOR9nVIXPd0sntPf9HwJJoALEXLcRpD0957eUHEGhvArjTFXth /L0Y+hOe/eKX5ksvtMwl7l+DdZGJyzf941QQYZ4ux6x414oPMIbxC6nOxrBVyxUvsqG7niJPtG1zi LI/KpcFzHTBZ6vwkbpNwyPue7l1V0O2sf0R/HpdhDMbEEH+ZQTlcyyiWQhX022B/oyAScTDizIP1u t4CfdI1g==; Received: from [10.9.9.212] (helo=mailfront12.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1fi6cF-0001RK-Op; Wed, 25 Jul 2018 01:21:15 +0200 Received: by mailfront12.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1fi6bl-0000rM-Lu; Wed, 25 Jul 2018 01:20:47 +0200 From: Gemini Lasswell References: <87vagmwpf2.fsf@runbox.com> Date: Tue, 24 Jul 2018 16:20:42 -0700 In-Reply-To: <87vagmwpf2.fsf@runbox.com> (Gemini Lasswell's message of "Sun, 31 Dec 2017 13:36:17 -0800") Message-ID: <87k1pkqkz9.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Gemini Lasswell writes: > Edebug gives an error when trying to instrument a function which uses > cl-macrolet to define a macro with an argument list containing &rest. > > Looks to me like the problem is that the Edebug spec is using (&rest arg) > when it should be using cl-macro-list, assuming that cl-macrolet > supports full CL argument lists. That was one of the problems, and the other problem was that Edebug would wrap all the arguments to the temporary macros, even those that are not evaluated, causing breakage. I solved that in the attached patch by writing Edebug match functions for cl-macrolet which treat the temporary macros like normal macros without Edebug specs, which means none of their arguments get wrapped. This fixes the breakage but means you can't Edebug through those of the arguments which do get evaluated. To do that we'd have to add the ability to have (declare (debug ...)) forms in the temporary macro bodies so that they could have temporary Edebug specs, which would mean changing cl-macrolet itself instead of just its Edebug spec. Kaushal, I was able to step through org-export-data with this patch in place. Let me know if you are able to give it a try. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0001-Fix-Edebug-spec-for-cl-macrolet-bug-29919.patch >From 6a9c02ac9b1515d44d1c28c82ee4d19e231797a8 Mon Sep 17 00:00:00 2001 From: Gemini Lasswell Date: Tue, 24 Jul 2018 09:07:18 -0700 Subject: [PATCH] Fix Edebug spec for cl-macrolet (bug#29919) Add an Edebug matching function for cl-macrolet which collects the symbols used in the bindings. When those symbols are found in the body of the expression, they are treated as macros without Edebug specs. * lisp/emacs-lisp/edebug.el (edebug--cl-macrolet-defs): New variable. (edebug-list-form-args): Use it. (edebug--current-cl-macrolet-defs): New variable. (edebug-match-cl-macrolet-expr, edebug-match-cl-macrolet-name) (edebug-match-cl-macrolet-body): New functions. * lisp/emacs-lisp/cl-macs.el (cl-macrolet): Use cl-macrolet-expr for Edebug spec. * test/lisp/emacs-lisp/edebug-tests.el (edebug-tests-cl-macrolet): New test. * test/lisp/emacs-lisp/edebug-resources/edebug-test-code.el (edebug-test-code-use-cl-macrolet): New function. --- lisp/emacs-lisp/cl-macs.el | 5 +-- lisp/emacs-lisp/edebug.el | 47 ++++++++++++++++++++++ .../edebug-resources/edebug-test-code.el | 7 ++++ test/lisp/emacs-lisp/edebug-tests.el | 11 +++++ 4 files changed, 66 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 011965acb5..d0d1c3b156 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -2083,10 +2083,7 @@ cl-macrolet \(fn ((NAME ARGLIST BODY...) ...) FORM...)" (declare (indent 1) - (debug - ((&rest (&define name (&rest arg) cl-declarations-or-string - def-body)) - cl-declarations body))) + (debug (cl-macrolet-expr))) (if (cdr bindings) `(cl-macrolet (,(car bindings)) (cl-macrolet ,(cdr bindings) ,@body)) (if (null bindings) (macroexp-progn body) diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index e759c5b5b2..f0c0db182e 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -1198,6 +1198,8 @@ edebug-def-interactive (defvar edebug-inside-func) ;; whether code is inside function context. ;; Currently def-form sets this to nil; def-body sets it to t. +(defvar edebug--cl-macrolet-defs) ;; Fully defined below. + (defun edebug-interactive-p-name () ;; Return a unique symbol for the variable used to store the ;; status of interactive-p for this function. @@ -1463,6 +1465,11 @@ edebug-list-form-args ;; Helper for edebug-list-form (let ((spec (get-edebug-spec head))) (cond + ;; Treat cl-macrolet bindings like macros with no spec. + ((member head edebug--cl-macrolet-defs) + (if edebug-eval-macro-args + (edebug-forms cursor) + (edebug-sexps cursor))) (spec (cond ((consp spec) @@ -1651,6 +1658,9 @@ edebug-match-specs ;; (function . edebug-match-function) (lambda-expr . edebug-match-lambda-expr) (cl-generic-method-args . edebug-match-cl-generic-method-args) + (cl-macrolet-expr . edebug-match-cl-macrolet-expr) + (cl-macrolet-name . edebug-match-cl-macrolet-name) + (cl-macrolet-body . edebug-match-cl-macrolet-body) (¬ . edebug-match-¬) (&key . edebug-match-&key) (place . edebug-match-place) @@ -1954,6 +1964,43 @@ edebug-match-cl-generic-method-args (edebug-move-cursor cursor) (list args))) +(defvar edebug--cl-macrolet-defs nil + "List of symbols found within the bindings of enclosing `cl-macrolet' forms.") +(defvar edebug--current-cl-macrolet-defs nil + "List of symbols found within the bindings of the current `cl-macrolet' form.") + +(defun edebug-match-cl-macrolet-expr (cursor) + "Match a `cl-macrolet' form at CURSOR." + (let (edebug--current-cl-macrolet-defs) + (edebug-match cursor + '((&rest (&define cl-macrolet-name cl-macro-list + cl-declarations-or-string + def-body)) + cl-declarations cl-macrolet-body)))) + +(defun edebug-match-cl-macrolet-name (cursor) + "Match the name in a `cl-macrolet' binding at CURSOR. +Collect the names in `edebug--cl-macrolet-defs' where they +will be checked by `edebug-list-form-args' and treated as +macros without a spec." + (let ((name (edebug-top-element-required cursor "Expected name"))) + (when (not (symbolp name)) + (edebug-no-match cursor "Bad name:" name)) + ;; Change edebug-def-name to avoid conflicts with + ;; names at global scope. + (setq edebug-def-name (gensym "edebug-anon")) + (edebug-move-cursor cursor) + (push name edebug--current-cl-macrolet-defs) + (list name))) + +(defun edebug-match-cl-macrolet-body (cursor) + "Match the body of a `cl-macrolet' expression at CURSOR. +Put the definitions collected in `edebug--current-cl-macrolet-defs' +into `edebug--cl-macrolet-defs' which is checked in `edebug-list-form-args'." + (let ((edebug--cl-macrolet-defs (nconc edebug--current-cl-macrolet-defs + edebug--cl-macrolet-defs))) + (edebug-match-body cursor))) + (defun edebug-match-arg (cursor) ;; set the def-args bound in edebug-defining-form (let ((edebug-arg (edebug-top-element-required cursor "Expected arg"))) diff --git a/test/lisp/emacs-lisp/edebug-resources/edebug-test-code.el b/test/lisp/emacs-lisp/edebug-resources/edebug-test-code.el index e86c2f1c1e..f3fc78d4e1 100644 --- a/test/lisp/emacs-lisp/edebug-resources/edebug-test-code.el +++ b/test/lisp/emacs-lisp/edebug-resources/edebug-test-code.el @@ -130,5 +130,12 @@ edebug-test-code-use-destructuring-bind (let ((two 2) (three 3)) (cl-destructuring-bind (x . y) (cons two three) (+ x!x! y!y!)))) +(defun edebug-test-code-use-cl-macrolet (x) + (cl-macrolet ((wrap (func &rest args) + `(format "The result of applying %s to %s is %S" + ',func!func! ',args + ,(cons func args)))) + (wrap + 1 x))) + (provide 'edebug-test-code) ;;; edebug-test-code.el ends here diff --git a/test/lisp/emacs-lisp/edebug-tests.el b/test/lisp/emacs-lisp/edebug-tests.el index 85f6bd47db..7d780edf28 100644 --- a/test/lisp/emacs-lisp/edebug-tests.el +++ b/test/lisp/emacs-lisp/edebug-tests.el @@ -913,5 +913,16 @@ edebug-tests-setup-code-file "g" (should (equal edebug-tests-@-result 5))))) +(ert-deftest edebug-tests-cl-macrolet () + "Edebug can instrument `cl-macrolet' expressions. (Bug#29919)" + (edebug-tests-with-normal-env + (edebug-tests-setup-@ "use-cl-macrolet" '(10) t) + (edebug-tests-run-kbd-macro + "@ SPC SPC" + (edebug-tests-should-be-at "use-cl-macrolet" "func") + (edebug-tests-should-match-result-in-messages "+") + "g" + (should (equal edebug-tests-@-result "The result of applying + to (1 x) is 11"))))) + (provide 'edebug-tests) ;;; edebug-tests.el ends here -- 2.16.4 --=-=-=-- From unknown Mon Aug 18 04:43:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29919: 26.0.90; Incorrect Edebug spec for cl-macrolet Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jul 2018 22:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29919 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gemini Lasswell Cc: 29919@debbugs.gnu.org Received: via spool by 29919-submit@debbugs.gnu.org id=B29919.153255746915064 (code B ref 29919); Wed, 25 Jul 2018 22:25:01 +0000 Received: (at 29919) by debbugs.gnu.org; 25 Jul 2018 22:24:29 +0000 Received: from localhost ([127.0.0.1]:57802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiSCq-0003uu-TI for submit@debbugs.gnu.org; Wed, 25 Jul 2018 18:24:29 -0400 Received: from mail-lf1-f43.google.com ([209.85.167.43]:40353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiSCp-0003ug-1g for 29919@debbugs.gnu.org; Wed, 25 Jul 2018 18:24:27 -0400 Received: by mail-lf1-f43.google.com with SMTP id y200-v6so6515996lfd.7 for <29919@debbugs.gnu.org>; Wed, 25 Jul 2018 15:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6a1ygCSbT3VXGxQix+MB+ZhaBow1JhrhEYLa9w8RZFM=; b=DtzAW/uroT7w8OmtpoB9D/S23QL6C9cJbuEtyAv7eTlckllAcN6AZn57vhE3DL63U5 HxQT4TG4nw7ViZ0yigIanMWddRdLeUJWzDePqztSA8BSyN6VkFQbk8IZ/jJQ5dKfvw8T 4fNP57LB4TAnCZqUYhm8FqidrSzHUPPRwneaDiJuANqojQ+oxIlc+wZZiAIfA4o0wqDl KtirarOFuFknKFsV+/Mqh/wjdennNc41YzNwLI8loB+LX2qKEnwfDvpXiLARP9Jepj1O nxsn9xVF2ManpdPq/Ym6ZOQus0BDnIPUu68sMc9IPLbI22XhIIsWCtltqc7OGH4FKFfn q2Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6a1ygCSbT3VXGxQix+MB+ZhaBow1JhrhEYLa9w8RZFM=; b=pRGEXInvLQrDM09akGBG+2s3e2UY4SHmRg8CXz69GithS2p9YXxtSdY04cyP4HUA1n 9iz51X5DhqvekVPGEWNYUliPr+0tW0Qbf8b1p7Dkr4d9lH8OtNVyxd2nWyPyXVFslLby oAhZiC4pgC7f3HwN1Z6SZLlvkqfCwmpgEGCy0F061nTEsWvF4NlXgiAIe6LtdXWe+HaY eHqeZ0eWeJ4un8jbZruVDNhgqEbS76Y2mpLjJp7cHWsLBUujRNEKohw9pKGw50sPlgSS Wbp5EQlKSfV9Hd8L30i/IdNSxiLsxCN7IGTdQGS7z1FW0/r27ETa4IuEc/PDOYSgykMQ CJ+Q== X-Gm-Message-State: AOUpUlGRGcWJLwKYHgdr5EMEDZTgV1IOV0XsuWSVq+XE1YxWmQJOEJNN D1RPW/NUK9myivfXzPBDGHsrzyjE2bVc8epEejM= X-Google-Smtp-Source: AAOMgpexQZHe6VrTc1xmKqibiEpB5AxhFuOqhdJeCDLbI7Pom8yUEWzG5cJJbTeub2z0o9cajgO5Srj5Vh8kV3zQGzE= X-Received: by 2002:a19:1c81:: with SMTP id c123-v6mr14394385lfc.105.1532557461000; Wed, 25 Jul 2018 15:24:21 -0700 (PDT) MIME-Version: 1.0 References: <87vagmwpf2.fsf@runbox.com> <87k1pkqkz9.fsf@runbox.com> In-Reply-To: <87k1pkqkz9.fsf@runbox.com> From: Kaushal Modi Date: Wed, 25 Jul 2018 18:24:09 -0400 Message-ID: Content-Type: multipart/alternative; boundary="0000000000000f98670571da5716" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000f98670571da5716 Content-Type: text/plain; charset="UTF-8" On Tue, Jul 24, 2018 at 7:21 PM Gemini Lasswell wrote: > > Kaushal, I was able to step through org-export-data with this patch in > place. Let me know if you are able to give it a try. > Hello, Thanks for pinging me to try this out. I am currently on Emacs version: GNU Emacs 27.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 2.24.23) of 2018-07-24, built using commit 0ed21b7b3e71303d7858192246012f4b26438ad8. .. and looks like that sluggishness on edebug of Org exporter functions due to info already got resolved with one of the commits on master branch since I last responded in this thread. Because even without your patch, the edebug of info var is quite snappy. I can though confirm that even after applying your patch (I don't understand exactly what it's doing as I haven't yet learnt about cl-macrolet), the edebug of Org export functions with info var is still snappy. -- Kaushal Modi --0000000000000f98670571da5716 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Jul 24= , 2018 at 7:21 PM Gemini Lasswell <geminilasswell@runbox.com> wrote:

Kaushal, I was able to step through org-export-data with this patch in
place.=C2=A0 Let me know if you are able to give it a try.
=

Hello,

Thanks for pinging me t= o try this out.

I am currently on
<= br>
Emacs version: GNU Emacs 27.0.50 (build 3, x86_64-pc-linux-gn= u, GTK+ Version 2.24.23)
=C2=A0of 2018-07-24, built using commit 0ed21b7= b3e71303d7858192246012f4b26438ad8.

.. and looks like that= sluggishness on edebug of Org exporter functions due to info already got r= esolved with one of the commits on master branch since I last responded in = this thread.

Because even without your patch, the = edebug of info var is quite snappy.

I can though c= onfirm that even after applying your patch (I don't understand exactly = what it's doing as I haven't yet learnt about cl-macrolet), the ede= bug of Org export functions with info var is still snappy.
<= /div>--

Kaushal Modi

--0000000000000f98670571da5716-- From unknown Mon Aug 18 04:43:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29919: 26.0.90; Incorrect Edebug spec for cl-macrolet Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jul 2018 19:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29919 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kaushal Modi Cc: 29919@debbugs.gnu.org Received: via spool by 29919-submit@debbugs.gnu.org id=B29919.153271864621161 (code B ref 29919); Fri, 27 Jul 2018 19:11:01 +0000 Received: (at 29919) by debbugs.gnu.org; 27 Jul 2018 19:10:46 +0000 Received: from localhost ([127.0.0.1]:60596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj88U-0005VF-Hq for submit@debbugs.gnu.org; Fri, 27 Jul 2018 15:10:46 -0400 Received: from aibo.runbox.com ([91.220.196.211]:44712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj88S-0005V7-RU for 29919@debbugs.gnu.org; Fri, 27 Jul 2018 15:10:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=nuG3l60aqldyyTP+YisfBiMm6M3iaLzovwYf89uoEe8=; b=lt5QUKIfwRmqlJbYAdkJ2vcOAk sLx8Xnlxv4i48245OtNHWeRi9MtK9VVlXmemw30MhTg1FShvkAbqHwMyOf+MD9h8AIr/O4QVN5l5J udTVgXIPFxie9WQ7ewbNN/GMOQwforfd8CC3dnwBzcXQFjw+TfdhMZUcE6sKa9wlkfFJPCSpkmU1Y FrMqJRkwvhzCn+caKJ4XvVmSatqnURBu0sKyaetFY6g4trAbhlDnrXmiVHL/BkkS91/Qf4PTuoYaj 1VUO7Gh0h0hoogDaLBLUDzEH/HaH7szn3+8ACyTxNSHCms+rKDm+ijzSMFUkOxOyGv7v7+zwC2ajN v9oS8QDw==; Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1fj88R-0006d1-Ap; Fri, 27 Jul 2018 21:10:43 +0200 Received: by mailfront10.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1fj880-0006As-6r; Fri, 27 Jul 2018 21:10:16 +0200 From: Gemini Lasswell References: <87vagmwpf2.fsf@runbox.com> <87k1pkqkz9.fsf@runbox.com> Date: Fri, 27 Jul 2018 12:10:14 -0700 In-Reply-To: (Kaushal Modi's message of "Wed, 25 Jul 2018 18:24:09 -0400") Message-ID: <876010qyuh.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Kaushal Modi writes: > .. and looks like that sluggishness on edebug of Org exporter functions due to info already got resolved with one of the commits on master branch since I last responded in this thread. > > Because even without your patch, the edebug of info var is quite snappy. > > I can though confirm that even after applying your patch (I don't understand exactly what it's doing as I haven't yet learnt about cl-macrolet), the edebug of Org export functions with info > var is still snappy. Hi Kaushal, Thanks for giving it a try. It was the fix for #31559 which made Edebugging large data structures faster. This patch fixes the edebug-syntax-error message that happened when you tried to debug code containing a cl-macrolet. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 02 12:10:22 2018 Received: (at control) by debbugs.gnu.org; 2 Aug 2018 16:10:22 +0000 Received: from localhost ([127.0.0.1]:39182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flGBC-00066e-Ix for submit@debbugs.gnu.org; Thu, 02 Aug 2018 12:10:22 -0400 Received: from aibo.runbox.com ([91.220.196.211]:57890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flGBA-00066W-DS for control@debbugs.gnu.org; Thu, 02 Aug 2018 12:10:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Subject:From:To:Message-Id:Date; bh=e+EmWHutZi3sVjehr6aHTKNnTwJp78cs6MASO30FnH8=; b=Why7tXihCY8flhvGcSV9/bOQz+ oLfLG0udhRFCjJVtQbqzUJUAqKvR+76a/d9zf13iEGQgfitE+IAXDcPrO5VKLaBKr5E/v2SSrzzfb 5ip8sOyzsyKLrDUsSi+RuSCOPj2lkR49EKeDbFOXLm2hi8SUs3S3igorF8M3fuqup5hN8+UNkLeJw imkjurGYh4Uu6Devap9CstBhWImmYZ0thylMbvWN71ZYwIPUyH7EiTfVaHbnAGc0E0Dhu+S/zJxeT FnQvA04RKyTRcmpGCZrkEjgcfzF/n86DzKeLemgWa6b8kpGC0GA/z5rovak9k2cuy5RBl5AqA5IDy YjSkXYew==; Received: from [10.9.9.212] (helo=mailfront12.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1flGB9-0000dP-DJ for control@debbugs.gnu.org; Thu, 02 Aug 2018 18:10:19 +0200 Received: by mailfront12.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1flGB7-0005Kf-Es for control@debbugs.gnu.org; Thu, 02 Aug 2018 18:10:18 +0200 Date: Thu, 02 Aug 2018 09:10:14 -0700 Message-Id: <87lg9ooil5.fsf@runbox.com> To: control@debbugs.gnu.org From: Gemini Lasswell Subject: control message for bug #29919 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 29919 fixed close 29919 27.1