From unknown Wed Jun 18 23:06:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#29896 <29896@debbugs.gnu.org> To: bug#29896 <29896@debbugs.gnu.org> Subject: Status: [PATCH core-updates] gnu: java-asm: Update to 6.0. Reply-To: bug#29896 <29896@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:06:19 +0000 retitle 29896 [PATCH core-updates] gnu: java-asm: Update to 6.0. reassign 29896 guix-patches submitter 29896 G=C3=A1bor Boskovits severity 29896 normal tag 29896 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 14:01:12 2017 Received: (at submit) by debbugs.gnu.org; 29 Dec 2017 19:01:12 +0000 Received: from localhost ([127.0.0.1]:56924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eUzu3-0005OY-P9 for submit@debbugs.gnu.org; Fri, 29 Dec 2017 14:01:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eUzu1-0005OM-Si for submit@debbugs.gnu.org; Fri, 29 Dec 2017 14:01:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUztp-0005fg-Bp for submit@debbugs.gnu.org; Fri, 29 Dec 2017 14:01:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53619) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eUztp-0005eZ-1z for submit@debbugs.gnu.org; Fri, 29 Dec 2017 14:00:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUztm-0008Mu-0j for guix-patches@gnu.org; Fri, 29 Dec 2017 14:00:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUztg-0005Hj-Vk for guix-patches@gnu.org; Fri, 29 Dec 2017 14:00:53 -0500 Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]:42485) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eUztg-0005Fz-OY for guix-patches@gnu.org; Fri, 29 Dec 2017 14:00:48 -0500 Received: by mail-wr0-x235.google.com with SMTP id w107so16463392wrb.9 for ; Fri, 29 Dec 2017 11:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zHkhEJqPv2iq4PSzpmsT/tShIeQWUDO34lyrGxdXe9U=; b=UneuDwC2Cb/TH9Hxdpwm9Cj0GxxYOlfXvJfjdVpPmhq6fc1GGjM2+WmVyno3N8nmsa DGfD2yTny05xYDATWF/vltQntYwcOpvwpe+NgWDqE3QI0G/JrGmDiHTUzfffkkMGQ9G9 Ejdeg0E3vgGq3IViGjG7C3eCJQn/mIuj6OFsd7Ff0eWHuyktrVGY+Icxlvyq7JKg1qgX nOnJDo5B6Kuy7h2aY5Os0hS3SBhscac4W72+zbLYTjgLeijQrYFaHdWCyPsbi1BBh1cI AIvTI8k4HTXo2/l6J567RkBtneBKtdPyVNEMsW4+ssJeLELZRF8SlOGy20J9rx3wEr3j ffxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zHkhEJqPv2iq4PSzpmsT/tShIeQWUDO34lyrGxdXe9U=; b=eHThLmOdHUc9lSiLfLSKn+TPDCd3v3BA+mbMeIFmCTuoJRkXuzSA5v2o67Lp2DFR9q CV2Ht6K+vshzIY1cWba2xGEvcRnzjBnpfGoUrdg7v4z1mlzV8JzDS+aiIKCj/hvapoK9 zDDmhrIvE2duV6FRY1L/Yfj2F26HASLXpSKLR4Akj2ewRcOAClA0dzAdEtkfNA1SZF0b PULKZxP88Q5YfyxARcjehKnquy9mwRX4a26XpxFKiRr7BiRJxZ3CPu7F10d7id9zXyTB 66RnF5JVTEECrVsmFpHfky/BHufxcxgjgqYLhNSOiSy50Vrp26MDPqN9Oco5FvMyWEj1 nxyQ== X-Gm-Message-State: AKGB3mKNWcFBdy4jyZthyQux763cO6Qkj31hqlGVs0d+c9EqGi3OZNrC cEFgrciOeVVjWnPtcBD9HuBMxc4= X-Google-Smtp-Source: ACJfBosfvrD6xJuczvMCEBCHTLQ+gcT7Ovlf2TP9no59ueOykIPBnNFlGbIiNbTTI719d4pdMRLIFw== X-Received: by 10.223.150.108 with SMTP id c41mr34749620wra.119.1514574047196; Fri, 29 Dec 2017 11:00:47 -0800 (PST) Received: from localhost.localdomain (54013FC9.dsl.pool.telekom.hu. [84.1.63.201]) by smtp.gmail.com with ESMTPSA id u194sm19134938wmd.6.2017.12.29.11.00.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Dec 2017 11:00:46 -0800 (PST) From: =?UTF-8?q?G=C3=A1bor=20Boskovits?= To: guix-patches@gnu.org Subject: [PATCH core-updates] gnu: java-asm: Update to 6.0. Date: Fri, 29 Dec 2017 20:00:22 +0100 Message-Id: <20171229190022.22705-1-boskovits@gmail.com> X-Mailer: git-send-email 2.15.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?G=C3=A1bor=20Boskovits?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * gnu/packages/java.scm (java-asm): Update to 6.0. [inputs]: Add java-aqute-bndlib, java-aqute-libg. (New dependencies) [arguments]: Adjust make-flags, so that the build does not complain about unset properties. --- gnu/packages/java.scm | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 41f9af87e..8a244328f 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2663,15 +2663,18 @@ archives (jar).") (define-public java-asm (package (name "java-asm") - (version "5.2") + (version "6.0") (source (origin (method url-fetch) (uri (string-append "http://download.forge.ow2.org/asm/" "asm-" version ".tar.gz")) (sha256 (base32 - "0kxvmv5275rnjl7jv0442k3wjnq03ngkb7sghs78avf45pzm4qgr")))) + "115l5pqblirdkmzi32dxx7gbcm4jy0s14y5wircr6h8jdr9aix00")))) (build-system ant-build-system) + (inputs + `(("java-aqute-bndlib" ,java-aqute-bndlib) + ("java-aqute-libg" ,java-aqute-libg))) (arguments `(#:build-target "compile" ;; The tests require an old version of Janino, which no longer compiles @@ -2679,7 +2682,8 @@ archives (jar).") #:tests? #f ;; We don't need these extra ant tasks, but the build system asks us to ;; provide a path anyway. - #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo")) + #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo") + (string-append "-Dbiz.aQute.bnd.path=" (assoc-ref %build-inputs "java-aqute-bndlib"))) #:phases (modify-phases %standard-phases (add-before 'install 'build-jars -- 2.15.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 07 16:25:15 2018 Received: (at 29896) by debbugs.gnu.org; 7 Jan 2018 21:25:15 +0000 Received: from localhost ([127.0.0.1]:39907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYIRO-0003Sq-U8 for submit@debbugs.gnu.org; Sun, 07 Jan 2018 16:25:15 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:42905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYIRN-0003Sd-6Z for 29896@debbugs.gnu.org; Sun, 07 Jan 2018 16:25:13 -0500 Received: by mail-wm0-f42.google.com with SMTP id b141so10974401wme.1 for <29896@debbugs.gnu.org>; Sun, 07 Jan 2018 13:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=gndWDtTYrtovBxgyVH51hCjQi8ljtO4PeJM0I83g4Tc=; b=Va9jMveQqULkakusRTtMRSbCxnfHEqmD+jGZntHqSPYekNoGIph9GXcZ8SsUXgIA+c JBHC/yGcVn1nv7ahTGVhfD5NEXnYiyhvpvPsIYxBRk7fUtKA1rkw0rAt2yEQFwXg9I+K nBeUPqHJ1Sikx8I9N5yORCUeA3E0P3oPz4bH9flbmwQxAQM0JfqV7fp8k1uy6nH/bhOK 0niL8ywfVnjNqYjwCdcJoY5dXoVAFaaYszraHa7rXpCAYVgy/GYSb2KVEp+IdgdFPH7s ii5WpeHGYmPfHFLlRhH6doHsLzIiI+b0cEqD/KFLXWa561ndPHgLYmQw1b5qF71pec/t Kfdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gndWDtTYrtovBxgyVH51hCjQi8ljtO4PeJM0I83g4Tc=; b=UIUiXlP9eOXC+qSRp+poKiFTduYNwJpZBbjpYoODvzxFa0OClQiuQJ+4cUOJnY1seF 7F+Iht2R0vBhxljx2fc6bVE8uA/szs1zKc10kPbydfYg0yM55A+REubOWezLhRMHtZix OYa3kguCZYloSGfGiH4J0pMtvswpbIr44hiLbHiuarZ9ufZgCDWymXs4apP68tTBRduU Pef8UifitMlMiGVuAdetrI85kwc67wMwSkfJBNOUG/nTHK5pJKrof0nXzaAabsV1zc34 Oo3uA9sY9GETtxQg0WBur19NPPqSmfOPXZaki+5iThpu7nL3wg1uVdpnApdEkQzwni/J bKZg== X-Gm-Message-State: AKGB3mJeznvRtu7l73sX/5uEyS6xajSjPfApNVQs5gjVOR1g0ez63rUx C23kOLB/rncqfWqMR9NH70bfYhE= X-Google-Smtp-Source: ACJfBosUJJR3b3Z2I7N9Y6lb7gLxTQ8iWS7pHFwNv3MYWviDll843iOWhVZ3/mA332tcGl/Z0454DA== X-Received: by 10.28.236.198 with SMTP id h67mr7129178wmi.71.1515360307181; Sun, 07 Jan 2018 13:25:07 -0800 (PST) Received: from localhost.localdomain (540139FB.dsl.pool.telekom.hu. [84.1.57.251]) by smtp.gmail.com with ESMTPSA id 20sm10749112wms.8.2018.01.07.13.25.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Jan 2018 13:25:06 -0800 (PST) From: =?UTF-8?q?G=C3=A1bor=20Boskovits?= To: 29896@debbugs.gnu.org Subject: [PATCH] gnu: java-asm: Update to 6.0. Date: Sun, 7 Jan 2018 22:23:56 +0100 Message-Id: <20180107212356.18556-1-boskovits@gmail.com> X-Mailer: git-send-email 2.15.1 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29896 Cc: =?UTF-8?q?G=C3=A1bor=20Boskovits?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/java.scm (java-asm): Update to 6.0. [inputs]: Add java-aqute-bndlib, java-aqute-libg. (New dependencies) [arguments]: Adjust make-flags, so that the build does not complain about unset properties. --- gnu/packages/java.scm | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 41f9af87e..8579f7c8b 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2663,15 +2663,18 @@ archives (jar).") (define-public java-asm (package (name "java-asm") - (version "5.2") + (version "6.0") (source (origin (method url-fetch) (uri (string-append "http://download.forge.ow2.org/asm/" "asm-" version ".tar.gz")) (sha256 (base32 - "0kxvmv5275rnjl7jv0442k3wjnq03ngkb7sghs78avf45pzm4qgr")))) + "115l5pqblirdkmzi32dxx7gbcm4jy0s14y5wircr6h8jdr9aix00")))) (build-system ant-build-system) + (inputs + `(("java-aqute-bndlib" ,java-aqute-bndlib) + ("java-aqute-libg" ,java-aqute-libg))) (arguments `(#:build-target "compile" ;; The tests require an old version of Janino, which no longer compiles @@ -2679,7 +2682,9 @@ archives (jar).") #:tests? #f ;; We don't need these extra ant tasks, but the build system asks us to ;; provide a path anyway. - #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo")) + #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo") + (string-append "-Dbiz.aQute.bnd.path=" + (assoc-ref %build-inputs "java-aqute-bndlib"))) #:phases (modify-phases %standard-phases (add-before 'install 'build-jars -- 2.15.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 07 16:27:16 2018 Received: (at 29896) by debbugs.gnu.org; 7 Jan 2018 21:27:16 +0000 Received: from localhost ([127.0.0.1]:39911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYITM-0003Vs-AQ for submit@debbugs.gnu.org; Sun, 07 Jan 2018 16:27:16 -0500 Received: from mail-it0-f48.google.com ([209.85.214.48]:42998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYITK-0003Vc-Hz for 29896@debbugs.gnu.org; Sun, 07 Jan 2018 16:27:14 -0500 Received: by mail-it0-f48.google.com with SMTP id p139so7027275itb.1 for <29896@debbugs.gnu.org>; Sun, 07 Jan 2018 13:27:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=32w8daFPcoVeEVPq1K4ljn8VKwCEeTxch2ZOiPjMkX4=; b=D5pjajWv+WV7uASuVMxIdZdLzCVlO7hIXLJev5T+vjMJGVEo4kOU8/KIyzkT9jL3UU Kxx1oXTzQ3XSHNxZJYBTNgUZ0EySGHy8Ez7/M3mBr7iGPi7b6ndoPtcsujOumNBkNC67 PL6boupchFfn0rok38TFecLlE7767QDJvml/oam8hTMKu+REx3tU79je6Y7sfFy4+Jvy 1MV9xdAU+b8c5XT1rjmDvDHJjWwiOxu3S3h2rjw0o32gCd/xFZWhXYpm0GlqJ2RjtUTo ocjWy55k4njn8TUtdUJhcBHqoQnKwZ1V9XGfQ5pyTFagOL4p9XYHEy7iOOoKU0XsRIHU uLxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=32w8daFPcoVeEVPq1K4ljn8VKwCEeTxch2ZOiPjMkX4=; b=SfIsps1yQKrPqhTSfXttOmoDMPCoOsqn+XCAfaGM0Vph1j3qfZX3LyUUzcQL6fm1M3 /54USA0lelx1ZVPUFGQNTxmr6AZEB5kXI9k4gtTKs4wG5F6VhItfB9a71WI0wiZezUEx +TCwQO/QTlwD61iVn8W7EpXncuTGnugLR+KrYMeTnXq44CiMON8N9uavpyM9xCdyY+29 KRzMujiV8NrM3jkx2nh+SVLRrO0xf3GIQWedJsbA2XasO5Rd+ChQ64ZTHJIPEGtRJrvR 7XfPm96pTZ3OREpSx+QtuD0ocxG6p5+yKA21DsKJDk2c5cH61YMRRxgVtt0JFbpVL7HT LYfg== X-Gm-Message-State: AKwxytc/Xbr47D5nrkfnyh1mBBbQ0JfBFe30gXcqW+nXBmXo0mQEsju0 PKVNK8u0Jp7FDfYMPki2Hf2nzIKNaj5/sACL9ug2 X-Google-Smtp-Source: ACJfBovBzMuBQ5FJg4b5v+PrNAly9wPaL92e0oq8T1LbKpp9v4Yka9NZiEtVo8Th4pbQDqDJvv7w5IuQtqRt721j1wI= X-Received: by 10.36.69.233 with SMTP id c102mr4820436itd.112.1515360428946; Sun, 07 Jan 2018 13:27:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.79.36.209 with HTTP; Sun, 7 Jan 2018 13:27:08 -0800 (PST) In-Reply-To: <20180107212356.18556-1-boskovits@gmail.com> References: <20180107212356.18556-1-boskovits@gmail.com> From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Date: Sun, 7 Jan 2018 22:27:08 +0100 Message-ID: Subject: Re: [PATCH] gnu: java-asm: Update to 6.0. To: 29896@debbugs.gnu.org Content-Type: multipart/alternative; boundary="001a11c1468a12f72005623658e3" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29896 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --001a11c1468a12f72005623658e3 Content-Type: text/plain; charset="UTF-8" The second version of this patch passes guix lint. The first one contains a line too long. Sorry about that. --001a11c1468a12f72005623658e3 Content-Type: text/html; charset="UTF-8"
The second version of this patch passes guix lint. The first one contains a line too long.
Sorry about that.
--001a11c1468a12f72005623658e3-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 19 01:35:48 2018 Received: (at 29896) by debbugs.gnu.org; 19 Jan 2018 06:35:48 +0000 Received: from localhost ([127.0.0.1]:33979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecQHE-00037J-3z for submit@debbugs.gnu.org; Fri, 19 Jan 2018 01:35:48 -0500 Received: from mail-pg0-f50.google.com ([74.125.83.50]:46641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecQHC-000376-L5 for 29896@debbugs.gnu.org; Fri, 19 Jan 2018 01:35:46 -0500 Received: by mail-pg0-f50.google.com with SMTP id s9so714693pgq.13 for <29896@debbugs.gnu.org>; Thu, 18 Jan 2018 22:35:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=AGPWAFp6HP3pUw0yr6b0EYi2umLthu2SGlwDHghoOgE=; b=GbIdPhz+suiu52gfVwvTk+4a5UAAgkkFBNogzFRXKyOxH4OWaVU6AaoCz5kZvI9qX5 LiH/3jvX0Rg7YWgD1Z/rF/dLDlEAjBxh23+Hgo/ivG94KzLqF+uy5sAG66XvTaXnZ1tt YNWFMvitFGg97TacK6JR64EKfb9i5/LofTPgRi1aKFM6A0ju3X9VwS1FSm1FDb2v4fPa vq6tQ4VMCqszlRRFgFYyhee51tBVKTJkmufYugGAOGdN66RVb9qBypLur6y0GU8X77+q zO10PfTs/IObJcnb9IxTnHI7xS/38V/Up28kmMh4ZgzGAVbf3r/xSjBspOIBKxfw1++5 Uv9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=AGPWAFp6HP3pUw0yr6b0EYi2umLthu2SGlwDHghoOgE=; b=GobjNBqUvo4dZRK1xMMPb64Iont7LSHbiudFFo2c4yk+OxtqdJW3GC5+nrjYGL+wEg YbeNoqpmMK1dOQ6jyIifuF49sdHemmbqfXpZ/k0vncMNQI/4vtqJCw8nIXgrTuWs7EiJ xfxeF34DADsaXdp7MG5BBC0OTfDzjM12/9HcJoQZ3dAbEb1PpRfim3Q9+jzbbUqOpftw 60jBR/XVGxPjmr8DfD3aMsPX3uyJgZ1iJvVgubodGOiJOP973u8YvHKcz/XWxDyUTsAX BDLZ5n4oi7co4dO+oJ9fEp+MW3sokofeL+k/YPmIpqAyO3hd+gN03aNdLuYxaCGcfj+f ja+g== X-Gm-Message-State: AKwxytcJnyeyTaUvNlQmbgwzSWMKyvAC6/C6ySL+Avf3+kwqLl6+I/J9 RDnozbsPnpAo/qp7ZNcdEvA= X-Google-Smtp-Source: ACJfBosdO3jT+bCt8k6j0R7/7OJFIGLM3oo0oVJYvLGw7lhxRT86GDRBAZxvs9Z2n2dGiAYY7g1Kew== X-Received: by 2002:a17:902:9a9:: with SMTP id 38-v6mr1056910pln.202.1516343740287; Thu, 18 Jan 2018 22:35:40 -0800 (PST) Received: from garuda.local ([2601:602:9d02:4725:6495:ba21:1ebe:620a]) by smtp.gmail.com with ESMTPSA id b69sm19022862pfk.128.2018.01.18.22.35.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Jan 2018 22:35:38 -0800 (PST) From: Chris Marusich To: =?utf-8?Q?G=C3=A1bor?= Boskovits Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> Date: Thu, 18 Jan 2018 22:35:34 -0800 In-Reply-To: <20180107212356.18556-1-boskovits@gmail.com> (=?utf-8?Q?=22G?= =?utf-8?Q?=C3=A1bor?= Boskovits"'s message of "Sun, 7 Jan 2018 22:23:56 +0100") Message-ID: <87efmmtky1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29896 Cc: Ricardo Wurmus , 29896@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable G=C3=A1bor Boskovits writes: > + (inputs > + `(("java-aqute-bndlib" ,java-aqute-bndlib) > + ("java-aqute-libg" ,java-aqute-libg))) > (arguments > `(#:build-target "compile" > ;; The tests require an old version of Janino, which no longer co= mpiles > @@ -2679,7 +2682,9 @@ archives (jar).") > #:tests? #f > ;; We don't need these extra ant tasks, but the build system asks= us to > ;; provide a path anyway. > - #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=3Df= oo")) > + #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=3Df= oo") > + (string-append "-Dbiz.aQute.bnd.path=3D" > + (assoc-ref %build-inputs "java-= aqute-bndlib"))) Even though we added some inputs, there appear to be no retained references in the output, as shown by this command: guix gc --referrers $(./pre-inst-env guix build java-asm) Is this expected? At first blush, this seems reasonable only if java-aqute-bndlib and java-aqute-libg are not required at runtime. Perhaps Ricardo knows more, since he has more experience working with the ant-build-system. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlphkbYACgkQ3UCaFdgi Rp25Ow//bEI15rPLFryqdHhesWAaZzPjgukHTZI/bRbay3K7pX9uyYcFGqocuETI gUVHI6dS7Nn/68cDBiS9cUS/ysFs+RIsf5scBQ87gXyce/Tx/4s2baf6lqn2Cawy pgk9Mb0+dwbU86f85WGd+dKW0QeKTJEM+5uLKywJja8CRAZycrKC3Aig+HUjpC3r IAcO7v1Pp4cJrQfW2btMiC3XCi0ZKdHf+GL57Gd1snwxbbTi+r5DChNZ2xh7TbGr FE34Is0d6+3A9oJiI3VFeTt2xXisoPt5A8qA/STpaQZbEuoOuqrPOg+h9aMu1PTb O4sgcmFbKA769Qe4SgV5kzgR+G2NQmbKTu5Atf5G51iA9BRessTOiZ0xeJt18I6h CGJf3QpQOTo95Sg+khr7NMrQ0xQ3t+Q/cEeWrKVVdGkq+QL/J8vLKO938GwjuKgn y3Q3ue2hJLAroi67sUSTuXwHvGXF1Gdz3X6NixzKJtBBnRZSgBIJVk/EZV371RqW QoV2Rtqp9qmRnFeWpMi3Yia7545JhQndk7w/MjNUDqXdbbyU3p3KNHcEoL6M+nAZ TiVYYpzRNKVnKBchjk92xs3IxDUfJP6Ez1nbBXMJAfjSasih+411KuqeX6qSMA5P p88Dx4/ghQYw6/fb5oabN1h6EBziiCYUSXMybQ5JCji/bTKxDvc= =aPS7 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 19 03:12:06 2018 Received: (at 29896) by debbugs.gnu.org; 19 Jan 2018 08:12:06 +0000 Received: from localhost ([127.0.0.1]:34013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecRmQ-0005Pd-GP for submit@debbugs.gnu.org; Fri, 19 Jan 2018 03:12:06 -0500 Received: from mail-io0-f182.google.com ([209.85.223.182]:37111) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecRmO-0005P9-QR for 29896@debbugs.gnu.org; Fri, 19 Jan 2018 03:12:05 -0500 Received: by mail-io0-f182.google.com with SMTP id f89so1317171ioj.4 for <29896@debbugs.gnu.org>; Fri, 19 Jan 2018 00:12:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=K6ZURqh0zjuoB7Xp0rFAMErpXztZyrcMjUlFU2OdpvU=; b=NRsd5rxFVxkOXgEZFp2SIbrsdCmstOSPJ2knrWYpKfRZmeOOzFvrHuFDSYlpvSf+1/ vJFjvOEIuJXyXzuFAbcrVD5sbgeek003xI1YmBWRuj8RVzgKCknUeHQDI56vCKtUBFtZ fU7QWzW4D8GeNjzQDQhJmETb5y6csoedsUeAftHY5ddrI0+MmcgRxwoP6sGO0rG/J67B 27GWb9kLf5OcAe1eQa9x9uOoGCLfYr2QadhphgBEKXecviKB92HWBh+29DUNGmhRwLx5 oaXqHKOYzZwxkMr7ppjug/RXvS1P+5dJSClUM/DSLnAmSP5dPZtZSt/kzpM9AeCtcQRl kO0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=K6ZURqh0zjuoB7Xp0rFAMErpXztZyrcMjUlFU2OdpvU=; b=NFp7wJGAKdaIMO/g4Gt7scaCQ6JzfhooWn85wcFkIXdn6Lm9TKN1v6KiGg01xeguF3 IbzJVepqFiQElrbPazRG2kvzBx4TwYAxxU0Oyu4YXG6Xz2w0TfV7Ojx+hN9YWWFqc+8S U3ZkFfw888F70r3XtuE0UNKpjCF+aS/cWDcpu2yG5m6H0MS9C/0uFvXJRYp7Nbl05VUK vfdpvkNfyVxKPD2pA+udAXFN45CWPNldmnR8v/prb3w6/gjlC2RTc7xvcw+gIcbXdMyv K/9sAlbgrAfsnrYuJnnMk31cLpmTjBXCI3UKNjKGlZ/skl0qgg3sNIhSMHj+0IWFjFDi aHdw== X-Gm-Message-State: AKGB3mKsTzxNY5E+TW9UY+Ay4Nw2YjJBUj0qtT/611vEiyjXdQLiVjD7 bUx4JN3XsCOruKmh1UsELm21pUywuvQSMGS0rA== X-Google-Smtp-Source: ACJfBotk7g4VpPHSb0xH2hhAQqOR1WqIxh9j+nKSoy/TkmL5qtMgzItwUgpiNBJa7ehiCTUQCx+xTq5i+z8qAHB/IV4= X-Received: by 10.107.172.69 with SMTP id v66mr48781876ioe.198.1516349519148; Fri, 19 Jan 2018 00:11:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.79.197.4 with HTTP; Fri, 19 Jan 2018 00:11:58 -0800 (PST) In-Reply-To: <87efmmtky1.fsf@gmail.com> References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Date: Fri, 19 Jan 2018 09:11:58 +0100 Message-ID: Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. To: Chris Marusich Content-Type: multipart/alternative; boundary="94eb2c05921a71bf3205631ca28f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29896 Cc: Ricardo Wurmus , 29896@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --94eb2c05921a71bf3205631ca28f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Actually I did forget to check if it is used runtime. It is used to build and OSGi bundle. At first I tried to fake the dependency like for the ant tasks, but I got compilation errors. 2018-01-19 7:35 GMT+01:00 Chris Marusich : > G=C3=A1bor Boskovits writes: > > > + (inputs > > + `(("java-aqute-bndlib" ,java-aqute-bndlib) > > + ("java-aqute-libg" ,java-aqute-libg))) > > (arguments > > `(#:build-target "compile" > > ;; The tests require an old version of Janino, which no longer > compiles > > @@ -2679,7 +2682,9 @@ archives (jar).") > > #:tests? #f > > ;; We don't need these extra ant tasks, but the build system > asks us to > > ;; provide a path anyway. > > - #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path= =3D > foo")) > > + #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path= =3D > foo") > > + (string-append "-Dbiz.aQute.bnd.path=3D" > > + (assoc-ref %build-inputs > "java-aqute-bndlib"))) > > Even though we added some inputs, there appear to be no retained > references in the output, as shown by this command: > > guix gc --referrers $(./pre-inst-env guix build java-asm) > > Is this expected? At first blush, this seems reasonable only if > java-aqute-bndlib and java-aqute-libg are not required at runtime. > Perhaps Ricardo knows more, since he has more experience working with > the ant-build-system. > > -- > Chris > --94eb2c05921a71bf3205631ca28f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Actually I did forget to check if it is used runtime.
= It is used to build and OSGi bundle.
At first I tried to fake the= dependency like for the ant tasks,
but I got compilation errors.=

2018-= 01-19 7:35 GMT+01:00 Chris Marusich <cmmarusich@gmail.com>:
G=C3=A1bor Boskovits = <boskovits@gmail.com> writ= es:

> +=C2=A0 =C2=A0 (inputs
> +=C2=A0 =C2=A0 =C2=A0`(("java-aqute-bndlib" ,java-aqute-bndl= ib)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("java-aqute-libg" ,java-aqute-l= ibg)))
>=C2=A0 =C2=A0 =C2=A0 (arguments
>=C2=A0 =C2=A0 =C2=A0 =C2=A0`(#:build-target "compile"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; The tests require an old version o= f Janino, which no longer compiles
> @@ -2679,7 +2682,9 @@ archives (jar).")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#:tests? #f
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; We don't need these extra ant = tasks, but the build system asks us to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; provide a path anyway.
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0#:make-flags (list (string-append "-D= objectweb.ant.tasks.path=3Dfoo"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0#:make-flags (list (string-append "-D= objectweb.ant.tasks.path=3Dfoo")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 (string-append "-Dbiz.aQute.bnd.path=3D" > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0(assoc-ref %build-inputs "java-aqute-bndlib")))

Even though we added some inputs, there appear to be no retained
references in the output, as shown by this command:

=C2=A0 guix gc --referrers $(./pre-inst-env guix build java-asm)

Is this expected?=C2=A0 At first blush, this seems reasonable only if
java-aqute-bndlib and java-aqute-libg are not required at runtime.
Perhaps Ricardo knows more, since he has more experience working with
the ant-build-system.

--
Chris

--94eb2c05921a71bf3205631ca28f-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 19 04:59:31 2018 Received: (at 29896) by debbugs.gnu.org; 19 Jan 2018 09:59:31 +0000 Received: from localhost ([127.0.0.1]:34058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecTSM-0001LD-QH for submit@debbugs.gnu.org; Fri, 19 Jan 2018 04:59:31 -0500 Received: from mail-it0-f54.google.com ([209.85.214.54]:38183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecTSK-0001Kz-OF for 29896@debbugs.gnu.org; Fri, 19 Jan 2018 04:59:29 -0500 Received: by mail-it0-f54.google.com with SMTP id w14so1511236itc.3 for <29896@debbugs.gnu.org>; Fri, 19 Jan 2018 01:59:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=T+/g3D+FJ369olCygBQxl6jdyIQMgsSM7byaTUmS808=; b=N7YZ9w60LblooHvoT6WoRAPTPf1q2aw1/vOkHzH1P6UjeskHxQAUfLk0kfZk/qyO0b 7uDPamIrQnGs7Z0YGNP1q3C2Xp9Vs85S02r+w5OY8+DbS2YoB1QEjH/1DAf8Luj1t+HV n3IsMTTbWVtdJphP1PPithxjWDHmAU4nNxF+IRs7EmRcUSBTMKKskbvgFIqsybpKDbPR zPL8uP+Bohw4oeC/ZqfyTz/QILUd7+RmiZWDy8vNFeFj5JpOjvVQDzb95Pr6OThmJU8e FccdATeJ0TV2y0UXpA+xoXOFsIrTk0F5DpZ9KVhUimnV23Oae5xmfeQf9/yrbmOB2mda 7CVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=T+/g3D+FJ369olCygBQxl6jdyIQMgsSM7byaTUmS808=; b=oqRDZAAoOuITpmijnPJFWD3YtSMqNCkR8skuCHX63O+ZvNuwLEiI00gHAj/QhVdEMR YV0uJHAx2skXqleqPyFWX54rmAJJy14JzX9fPIeTQffdlY4qn8FUXggECZdMULOnc+dw ytpO3LZ5tt2iDUENpFfFD3iZ6Ruv0f8HQldBYu7BNm6yrVapiMIcDF12tZEt1Usf5p35 Y/fmxsR1iaVShBHYt9VhGIDht2Ll776Z/cX4v9Apz35jVhdDuNuISujtBqfcJ8Fo24TL vvnwopciV/n8W1+8PnkZNwEYSoaSB4vEbTYSZPFfDiaBDiP0NjlpQIE/Lb7bT+BjCdrt 98vw== X-Gm-Message-State: AKwxytf5LJPhtNym35d8zUBoAaNtV/piI/1lZXmZn7Ag78kVlgx2ZhtS t5LfP+i41p3YXCewnUlfe6A= X-Google-Smtp-Source: ACJfBotU+t6dW+f2HTPzJKc2wlq8sAHrE7ROe62hwQsBWbaL9zVpq4h42WVUHDiaShUkLPVpDu5WbQ== X-Received: by 10.36.0.209 with SMTP id 200mr29188030ita.4.1516355962660; Fri, 19 Jan 2018 01:59:22 -0800 (PST) Received: from garuda.local ([2601:602:9d02:4725:6495:ba21:1ebe:620a]) by smtp.gmail.com with ESMTPSA id p68sm608114itc.26.2018.01.19.01.59.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Jan 2018 01:59:20 -0800 (PST) From: Chris Marusich To: =?utf-8?Q?G=C3=A1bor?= Boskovits Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> Date: Fri, 19 Jan 2018 01:59:18 -0800 In-Reply-To: (=?utf-8?Q?=22G=C3=A1bor?= Boskovits"'s message of "Fri, 19 Jan 2018 09:11:58 +0100") Message-ID: <87y3kuf9u1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29896 Cc: Ricardo Wurmus , 29896@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable G=C3=A1bor Boskovits writes: > Actually I did forget to check if it is used runtime. > It is used to build and OSGi bundle. > At first I tried to fake the dependency like for the ant tasks, > but I got compilation errors. If the new input is also required at runtime, then I'm not sure this package definition is correct. I would normally expect a "runtime dependency" to be either retained as a reference in the output, or declared as a propagated-input (so that it gets installed alongside this package when this package is installed into a profile). Perhaps I am missing some information here. I'm hoping Ricardo can comment on how this is intended to work for Java packages, since he originally added the ant-build-system. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlphwXcACgkQ3UCaFdgi Rp1fZBAAukMmJCHICBqB80+ysH3SJV/UN8Kx217k+G1RrgqbIdqEJBPw1elrVesN gQ8BgIVuyG3gMgTMgVOShpXRjMLrUfHHWEncffBV+uOrNRQc8k4ZNTKMy3OjLoqZ Ba21/jDwnnMaXiZE4AUihUM6EignKDhinxLvCzLD83DUgVGBYDtm+pStBbjKV30/ Al5FkKvimtXnhhx4wZNrCUnZcsjgOBdCyU7jiLdRtQWKmhWfHuCDBE36XlCAtwdO x8zDawsMQL6+2W4auj59+PcWaFAcSrc8AfhxR0cCOyOwgdVRSFNOLObkN3VHuBJw nh9rC8xCPuOLtAK8DlzYctzCob+G2Cl+dl3jl9+zq9K6ENeyi/FVnSkCguoTadEE 0iQm4bDIvUFj3mv/8moWSyYXfrxLTdGxfJX3H5j4Qu58iu9fqK1uhcJ39wVOSjjA I8Mdh7qQxMi35tD/cwCTiw/7OlKc/KBGE9/tkdOJii5nYZZyla8KIdbjdDMtQJ8I oVeInMlu7u9XbI7M6NsCwDFU7Bj/CxM8Attq3SHc80HdRIUnxHfs962H3/S3nD+k EmaFELHt8HG7/2Bu7OSYhlmdEKSGwWNs/xmkP0yxLeNoPMD1a25fRUzYRPcmK2K7 9Pi59iodZZogCi6x0PGKpltoOh2sQbQzMkSS3bFKF2UNfr98IQ0= =U0bI -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 19 19:12:06 2018 Received: (at 29896) by debbugs.gnu.org; 20 Jan 2018 00:12:06 +0000 Received: from localhost ([127.0.0.1]:35374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecglS-0004ew-Ef for submit@debbugs.gnu.org; Fri, 19 Jan 2018 19:12:06 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:43933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecglP-0004en-U9 for 29896@debbugs.gnu.org; Fri, 19 Jan 2018 19:12:04 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 726E420B95; Fri, 19 Jan 2018 19:12:03 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Fri, 19 Jan 2018 19:12:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=ki2y9lxSMaEUTnZaIOB6zNMF/F588yvvnHQtyPkn7sg=; b=J0k5z Wv8iCIxvtXcKn5OUVewXDBA/d1kay/zjf+B1WM9mBBuMfuiTwisJsA3GUJwxHh5T gF6w7/UPW+kZV5atP6hg4Y0xdMW8ixCaEirfW13lmNbSpKjpexCXTzpI8vAj1/Mm sofWEDX5iPc+L/rdwnBVgPlksBlh0SOZHGTK08= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=ki2y9lxSMaEUTnZaIOB6zNMF/F588 yvvnHQtyPkn7sg=; b=BkeWByK0a9pJZIHr9lAAtxrYeOOrtMcg+sZp/aTt+DWIz QMQ1e4fbUCbaFtSIZs4xYAlzgO5r//u9oZ8T26v/xkTWnw7YiYe9xaxwUYnyFryA ZtKmhYBlHI88mJXFql0qHQE1slhJCCXwY6H6f0gE9ncTZmspY70UscooEYNGUSr8 QDeKc6lO0h9VZrdiwoyUixSNs7PvJbZhybzRwLboV/B8rkuXpzLgD0GKtmcq/z/r H3sjdFFkSxAxqyYT7MrQ9voIw3yOz7mr/h1kNrxTIe6Pr/JShwGycn8x5w9HRyi1 zqD4X+hhkuymfqnI8aMhksVo3N7zWF9IZ97TqKwNg== X-ME-Sender: Received: from localhost (unknown [68.119.236.136]) by mail.messagingengine.com (Postfix) with ESMTPA id 152372449D; Fri, 19 Jan 2018 19:12:03 -0500 (EST) Date: Fri, 19 Jan 2018 16:12:02 -0800 From: Leo Famulari To: Chris Marusich Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. Message-ID: <20180120001202.GC18016@jasmine.lan> References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Qxx1br4bt0+wmkIi" Content-Disposition: inline In-Reply-To: <87efmmtky1.fsf@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29896 Cc: Ricardo Wurmus , =?iso-8859-1?Q?G=E1bor?= Boskovits , 29896@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Qxx1br4bt0+wmkIi Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 18, 2018 at 10:35:34PM -0800, Chris Marusich wrote: > G=E1bor Boskovits writes: >=20 > > + (inputs > > + `(("java-aqute-bndlib" ,java-aqute-bndlib) > > + ("java-aqute-libg" ,java-aqute-libg))) > > (arguments > > `(#:build-target "compile" > > ;; The tests require an old version of Janino, which no longer = compiles > > @@ -2679,7 +2682,9 @@ archives (jar).") > > #:tests? #f > > ;; We don't need these extra ant tasks, but the build system as= ks us to > > ;; provide a path anyway. > > - #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path= =3Dfoo")) > > + #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path= =3Dfoo") > > + (string-append "-Dbiz.aQute.bnd.path=3D" > > + (assoc-ref %build-inputs "jav= a-aqute-bndlib"))) >=20 > Even though we added some inputs, there appear to be no retained > references in the output, as shown by this command: >=20 > guix gc --referrers $(./pre-inst-env guix build java-asm) To check the retained references in the output [0], it's actually `guix gc --references $(./pre-inst-env guix build ...)`. [0] To clarify "retained references", they are literally occurences of strings that begin with '/gnu/store/', then a Guix hash, then a hyphen, and then a package name. --Qxx1br4bt0+wmkIi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlpiiU8ACgkQJkb6MLrK fwiHnw//W9qAd6IJNLrMWA0/ODDB0tMINnrpBHcXQeMVDDfhYGNHF4MludDno3Cy t4pJYRjYy2xetbOTRqKRzzyZkgdOoUIJ+80kRYbWX88jLzNVof0Ax1F26yjODUOe FRr3DSkME59bkYDRGrq7DZLnuaKYJ0pp2IdTzpwjXl8uJsBLWkpoJABOknvm1/7V tatUICOLNUjfpsBlismMkQgqu1GD+4npV3uNyRQxdn/tpgeFrDDorKPoRH/91tc0 oaqcbGxYYEBprv2mPqpp5CXl99q7OdRX3WoscsEsv4RHaxDTqWLgsO7dEm4lIqds e4M8uAPRblXUupDkaM8tgD/d+9s+re5b+z8oIX/Yhmy66TkcNZ2ltsgr1lhJ5v45 yb4/Wh0Wbdp8YDxT57SuzP+nuw8WHSvk4WbxzBfxulAkrvbSnWEjmL76dFxonyYh 4J3CGwrbIpfRyEvjRnHYYgYYe85gRX7yX8o3b7FtL+frKJLgzUBLIRIOxfprw2hC 3UbD6K+aQWI8whJiQvhn8PfJ6moXEoWJa30mwqKhzk2UpbkYIg1Vd66+c+5IqZIw dTuIj9iMkwnLH1DUWoiIyulhinJ3UyjAY2VH6WIpfpvtDj+5kIBuqZLcc1aEOo7Q HR3/LeklKSJHQI0kye53LnpxFal4edwMfrr8BJF69eOgX06rARg= =uLEw -----END PGP SIGNATURE----- --Qxx1br4bt0+wmkIi-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 02:50:56 2018 Received: (at 29896) by debbugs.gnu.org; 20 Jan 2018 07:50:56 +0000 Received: from localhost ([127.0.0.1]:35512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecnvU-0001Pz-2w for submit@debbugs.gnu.org; Sat, 20 Jan 2018 02:50:56 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:46198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecnvS-0001Pm-3E for 29896@debbugs.gnu.org; Sat, 20 Jan 2018 02:50:54 -0500 Received: by mail-pf0-f169.google.com with SMTP id y5so3102684pff.13 for <29896@debbugs.gnu.org>; Fri, 19 Jan 2018 23:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=MmcAmoMS11axvdeAaBFhFUUGMYagkpNNNk74Vcbp60Y=; b=azSPF79fWsdEmXq8kFNHx+t0GHcRkEjaMnlvpHD4k5a7muNJ7FgZBQbXRFUuBMHYio OWnYWX6QrVF9uN8us/SBr4aPDDJdG9+40nV4xUGLrWrHGMi0JlmH1os56xD93QVAzi3a B4fBJ5ByPt9TB2qr64gAgyx7va/R4ThhuPJoVcmkGpCQMp4Gyd+cOI/jHlEGTKpkaHDU hu/HhAR03fxQyGPod5r81GwcQ9Cpha40F968714Zz0C6gIrW3ZLsYPu0vgcdqGxSFn30 cuxt3n9kQ8jTDTeU1zNWaYspl9vdWbh4fGt1VDVzy6nlqZ6HYCu6RfgDm72f/uN6Nlx7 4Jfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MmcAmoMS11axvdeAaBFhFUUGMYagkpNNNk74Vcbp60Y=; b=PR1AGzSpQVHMbdFJHLKlyaEt36IBNDRC18jDlzb+NJ3f06Vwf3DoHdNmuHAdo94q59 dtnSaUBKGzRkiwvUQe4Zcrp3yYLWaNg2omyhr7orpNl4SAHvuz2eG0IRIQZTOcm9PIoA 46TyZTcJVH6e1EXg8ZYvnABcTY7f8ukBJRLoJf5krNpI2EhGWpzaNzYPV+Dw730mr7ay QahvXkf920e4c7bqu8BW9p8KH3ZIn25mhG/AsDtaHzUgViwa+i2/H4axKE1ZoM6zLkzP wK1LNqnufXjKDqTDK/0nZuTS7Yvlp1LoIsrz8MugG3L7iXYxzoA6f3Ra5kff4kh8++K9 c9vg== X-Gm-Message-State: AKwxytdaV0kZrRbEqZshj83/0UdAjahG7WflF/IxtL2inu0bSfpjn/oU sgrFG529D8AY+b1gGgQuzJ+6Fg== X-Google-Smtp-Source: AH8x22602KCQ5OnKVN6Qz08VPkb4ZoQS2EeyHJDkmyHBTkImgpRQHqkvpCRATbZj4iqwnj/XN1wYWg== X-Received: by 2002:a17:902:e85:: with SMTP id 5-v6mr572922plx.136.1516434647486; Fri, 19 Jan 2018 23:50:47 -0800 (PST) Received: from garuda.local ([2601:602:9d02:4725:6495:ba21:1ebe:620a]) by smtp.gmail.com with ESMTPSA id 8sm16925061pfh.170.2018.01.19.23.50.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Jan 2018 23:50:45 -0800 (PST) From: Chris Marusich To: Leo Famulari , Ricardo Wurmus , =?utf-8?Q?G=C3=A1bor?= Boskovits Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> <20180120001202.GC18016@jasmine.lan> Date: Fri, 19 Jan 2018 23:50:43 -0800 In-Reply-To: <20180120001202.GC18016@jasmine.lan> (Leo Famulari's message of "Fri, 19 Jan 2018 16:12:02 -0800") Message-ID: <87fu71ufxo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29896 Cc: 29896@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Thu, Jan 18, 2018 at 10:35:34PM -0800, Chris Marusich wrote: >> Even though we added some inputs, there appear to be no retained >> references in the output, as shown by this command: >>=20 >> guix gc --referrers $(./pre-inst-env guix build java-asm) > > To check the retained references in the output [0], it's actually `guix > gc --references $(./pre-inst-env guix build ...)`. > > [0] To clarify "retained references", they are literally occurences of > strings that begin with '/gnu/store/', then a Guix hash, then a hyphen, > and then a package name. You're right; this was a "thinko" on my part. I meant to write "--references" instead of "--referrers". The output of the correct command is still empty, so there are still no references. Ricardo Wurmus writes: > Chris Marusich writes: > >> If the new input is also required at runtime, then I'm not sure this >> package definition is correct. I would normally expect a "runtime >> dependency" to be either retained as a reference in the output, or >> declared as a propagated-input (so that it gets installed alongside this >> package when this package is installed into a profile). Perhaps I am >> missing some information here. >> >> I'm hoping Ricardo can comment on how this is intended to work for Java >> packages, since he originally added the ant-build-system. > > The jars that the ant-build-system generates are uncompressed and thus > allow the scanner to find embedded store references. The problem seems > to be that references to other *jars* are not kept, because they are > never recorded anywhere. That=E2=80=99s normal for Java, which looks for= named > classes on the classpath, i.e. a list of jars. It behaves very much > like Python and its PYTHONPATH in this regard. > > The best we can do here is to propagate inputs. The alternative is to > try to be smart and record the effective runtime classpath, but that=E2= =80=99s > hard/impossible to get right. OK - thank you for the explanation! In light of that information, I think that in the case of a package that uses the ant-build-system (like java-asm), if we know for sure that an input is required at runtime, we should make it a propagated input. The installed software still won't work without additional work on the part of the user (e.g., the user needs to set the CLASSPATH when invoking java, or use java's -cp option), but for now at least making the input a propagated input will ensure that it gets installed alongside the package which at runtime requires it, which is better than nothing. Here's an updated patch that makes this change. In addition, I discovered that (1) the build succeeds and produces the same JAR file even when I removed java-aqute-libg as an input, so I've removed that, and (2) the build succeeds and produces the same JAR file even when I use a dummy value for the biz.aQute.bnd.path Ant property, so I did that to make it clear that it wasn't important to the build. What do you think? =2D-=20 Chris --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-java-asm-Update-to-6.0.patch Content-Transfer-Encoding: quoted-printable From=20b7ab0f263338f54d3982b6d1cc91306f4691116a Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?G=3DC3=3DA1bor=3D20Boskovits?=3D Date: Sun, 7 Jan 2018 22:23:56 +0100 Subject: [PATCH] gnu: java-asm: Update to 6.0. * gnu/packages/java.scm (java-asm): Update to 6.0. [propagated-inputs]: Add java-aqute-bndlib (new dependency). [arguments]: Adjust make-flags, so that the build does not complain about unset properties. =2D-- gnu/packages/java.scm | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index c04b45c53..38bfffaf5 100644 =2D-- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -2660,23 +2660,31 @@ archives (jar).") (define-public java-asm (package (name "java-asm") =2D (version "5.2") + (version "6.0") (source (origin (method url-fetch) (uri (string-append "http://download.forge.ow2.org/asm/" "asm-" version ".tar.gz")) (sha256 (base32 =2D "0kxvmv5275rnjl7jv0442k3wjnq03ngkb7sghs78avf45pzm4qgr"))= )) + "115l5pqblirdkmzi32dxx7gbcm4jy0s14y5wircr6h8jdr9aix00")))) (build-system ant-build-system) + (propagated-inputs + `(("java-aqute-bndlib" ,java-aqute-bndlib))) (arguments `(#:build-target "compile" ;; The tests require an old version of Janino, which no longer comp= iles ;; with the JDK7. #:tests? #f =2D ;; We don't need these extra ant tasks, but the build system asks= us to =2D ;; provide a path anyway. =2D #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=3Df= oo")) + #:make-flags + (list + ;; We don't need these extra ant tasks, but the build system asks = us to + ;; provide a path anyway. + "-Dobjectweb.ant.tasks.path=3Ddummy-path" + ;; The java-aqute.bndlib JAR file will be put onto the classpath a= nd + ;; used during the build automatically by ant-build-system, but + ;; java-asm's build.xml fails unless we provide something here. + "-Dbiz.aQute.bnd.path=3Ddummy-path") #:phases (modify-phases %standard-phases (add-before 'install 'build-jars =2D-=20 2.15.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlpi9NQACgkQ3UCaFdgi Rp3ZgA/9Gf7fuPvGvyDt1zTPEz0tf1kl/1KQr3ZKURLkUeyEoM5hxMMITQ69tye0 ZPcTyVnh6r7FuJLnR9FxdF0YVyUg52C1cLaHX0szpicfPsdp/8QFRbcukRc9gYcv oy/7qhMipM8tVji73Dkfq8rXnRNQGiXpai0htuZ14C9Cybt3cLiTH5l4mj7dx7hd 9Cm1Br2G2ebLAsroRu5aRV2RCpjH7XycguV8ChM6XQy7NeU7YdUa94aWcAr67q3P kueSDBVxEeaxJB/FalT1trEZdbEcHqYZcUiJdHAr8IbU1qMWx/yjqnfMxSY0H5hy LgzOH0upgFDz54uP+dTm5AEzvwSHLg5re9/QmRwdqRGeI0Bp4ZmSYtjvpBM55ljy iR7bchDiTH1gCHqkm6N1I3H7osFh571+ymI804uo7q824ObY7yasy6YMelvpqrKl S+yq3cQlj8C9xWvGqAX2y6ovJeqyyMbU+N79UUCrrHgR7fJdEM8k6ow72MLpx5Ts pyA1aidB3x0a9nzx+sELqjqYsTB1mQ+2IZe5A/AUqtrx+thV3zzabRgmgUY0KOSx MA7JUJNbxBupVwLEETRzCBsjCMztyvWQK1YZ7SBl/vvPmr3RW2fmojGXNWqALVj9 U1Zx/5wn6I+CkGPwJl51ttHlgR4N0Wos5hCLchnJheW+OL24lb4= =d8vf -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 04:08:13 2018 Received: (at 29896) by debbugs.gnu.org; 20 Jan 2018 09:08:13 +0000 Received: from localhost ([127.0.0.1]:35541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecp8H-0003Ad-4l for submit@debbugs.gnu.org; Sat, 20 Jan 2018 04:08:13 -0500 Received: from mail-it0-f48.google.com ([209.85.214.48]:35899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecp8E-0003AP-6w for 29896@debbugs.gnu.org; Sat, 20 Jan 2018 04:08:11 -0500 Received: by mail-it0-f48.google.com with SMTP id p124so4755242ite.1 for <29896@debbugs.gnu.org>; Sat, 20 Jan 2018 01:08:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kxOlkQT//KBGQfUDQtGtsJzuMndSoEcrvwqvBOAEt2E=; b=hrr/PFNWhKAwWsK7DyQ7CvQ3tsVkXAX4DzkgcVqOh3cfSCOvlzc/HB+2sAsMnv/ADH E4V//8/mvh+bJO3RKgq5zC5G162V0zmD5tl0GEeD8GEW2pNeQ6LycM8J9m/r3Ta8EWB+ 2jXw30nnOMpVWb3cubqVTCzK57iojD2Y7gwX1ikorY38WRyHTvY5QIvV9XKc81DLvf19 jHleV3RcPBMIOzScdijtB+nbkv3aF7KI8BDHr304xXw35/xry/KAjPx/7aCnHL5b8JiE oDJ8QI7nP20/2o6zeUmVaUHLC1lc/475Fp/qkOb8ocNuud2bOZBmn2a/sPhHrC/LpHF8 K2dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kxOlkQT//KBGQfUDQtGtsJzuMndSoEcrvwqvBOAEt2E=; b=a/qT6uI5B1puzjb50prfknyqUPJYdWhr8T8ogRD3JAKVKKxeXN6pazomqm7w4Imwke UBya1O2xiZFgy51Oy8oH15sLNDTooXElS5mHaaP6O0BqX5dxM5ZzKorBZmmrlyrGvQIG sT1vmmY1Oe2/OIyM6z5V1P9mZs0fqNcxldKHYIRRar9FN847IR+/m0fvZpchBvbppa1u jC5rQ9Wy4DW082tqW1UCD5DzUp5Ey+SC/AiqBMbgxNzVkeiFDsD5m1hNbsrVGpstWIZL 0mPW0qizZOEcQDiB5Ly7HSQNKl2Vx676ruYacUJYxX5GAKp6Dq3T9J50ZxFC9b4gE3U4 QlbA== X-Gm-Message-State: AKwxytesejHIZBvGRBH9NUoVcopl08INGtR62RufiGQ3poueKZbzLUP0 zIVJXTGr8kemNKwiIgr9eHzXvmEWMFjmswtFOg== X-Google-Smtp-Source: AH8x227ZZx7X9a37eAibqZRj5uKcfjp2NqhFL8o/3p4YQ4D3ozpz/iL35ZXkP1jlm13/gW90PK9ZceuQHr9Mweskigs= X-Received: by 10.36.69.233 with SMTP id c102mr1009877itd.112.1516439284633; Sat, 20 Jan 2018 01:08:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.79.197.4 with HTTP; Sat, 20 Jan 2018 01:08:04 -0800 (PST) In-Reply-To: <87fu71ufxo.fsf@gmail.com> References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> <20180120001202.GC18016@jasmine.lan> <87fu71ufxo.fsf@gmail.com> From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Date: Sat, 20 Jan 2018 10:08:04 +0100 Message-ID: Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. To: Chris Marusich Content-Type: multipart/alternative; boundary="001a11c1468ae2558b05633188b5" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29896 Cc: Ricardo Wurmus , 29896@debbugs.gnu.org, Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --001a11c1468ae2558b05633188b5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-01-20 8:50 GMT+01:00 Chris Marusich : > Leo Famulari writes: > > > On Thu, Jan 18, 2018 at 10:35:34PM -0800, Chris Marusich wrote: > >> Even though we added some inputs, there appear to be no retained > >> references in the output, as shown by this command: > >> > >> guix gc --referrers $(./pre-inst-env guix build java-asm) > > > > To check the retained references in the output [0], it's actually `guix > > gc --references $(./pre-inst-env guix build ...)`. > > > > [0] To clarify "retained references", they are literally occurences of > > strings that begin with '/gnu/store/', then a Guix hash, then a hyphen, > > and then a package name. > > You're right; this was a "thinko" on my part. I meant to write > "--references" instead of "--referrers". The output of the correct > command is still empty, so there are still no references. > > Ricardo Wurmus writes: > > > Chris Marusich writes: > > > >> If the new input is also required at runtime, then I'm not sure this > >> package definition is correct. I would normally expect a "runtime > >> dependency" to be either retained as a reference in the output, or > >> declared as a propagated-input (so that it gets installed alongside th= is > >> package when this package is installed into a profile). Perhaps I am > >> missing some information here. > >> > >> I'm hoping Ricardo can comment on how this is intended to work for Jav= a > >> packages, since he originally added the ant-build-system. > > > > The jars that the ant-build-system generates are uncompressed and thus > > allow the scanner to find embedded store references. The problem seems > > to be that references to other *jars* are not kept, because they are > > never recorded anywhere. That=E2=80=99s normal for Java, which looks f= or named > > classes on the classpath, i.e. a list of jars. It behaves very much > > like Python and its PYTHONPATH in this regard. > > > > The best we can do here is to propagate inputs. The alternative is to > > try to be smart and record the effective runtime classpath, but that=E2= =80=99s > > hard/impossible to get right. > > OK - thank you for the explanation! In light of that information, I > think that in the case of a package that uses the ant-build-system (like > java-asm), if we know for sure that an input is required at runtime, we > should make it a propagated input. The installed software still won't > work without additional work on the part of the user (e.g., the user > needs to set the CLASSPATH when invoking java, or use java's -cp > option), but for now at least making the input a propagated input will > ensure that it gets installed alongside the package which at runtime > requires it, which is better than nothing. > > Here's an updated patch that makes this change. In addition, I > discovered that (1) the build succeeds and produces the same JAR file > even when I removed java-aqute-libg as an input, so I've removed that, > and (2) the build succeeds and produces the same JAR file even when I > use a dummy value for the biz.aQute.bnd.path Ant property, so I did that > to make it clear that it wasn't important to the build. What do you > think? > > I think this is ok. I also noticed, that a dummy value would do, but I ha= d no policy at hand about what to do in this case. Actually I am not sure, that bnd is used runtime. How could we check that? > -- > Chris > --001a11c1468ae2558b05633188b5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2018= -01-20 8:50 GMT+01:00 Chris Marusich <cmmarusich@gmail.com>:
Leo Famulari <leo@famulari.name> writes:

> On Thu, Jan 18, 2018 at 10:35:34PM -0800, Chris Marusich wrote:
>> Even though we added some inputs, there ap= pear to be no retained
>> references in the output, as shown by this command:
>>
>>=C2=A0 =C2=A0guix gc --referrers $(./pre-inst-env guix build java-a= sm)
>
> To check the retained references in the output [0], it's actually = `guix
> gc --references $(./pre-inst-env guix build ...)`.
>
> [0] To clarify "retained references", they are literally occ= urences of
> strings that begin with '/gnu/store/', then a Guix hash, then = a hyphen,
> and then a package name.

You're right; this was a "thinko" on my part.=C2=A0 I = meant to write
"--references" instead of "--referrers".=C2=A0 The outp= ut of the correct
command is still empty, so there are still no references.

Ricardo Wurmus <rekado@elephly.net= > writes:

> Chris Marusich <cmmarusich@= gmail.com> writes:
>
>> If the new input is also required at runtime, then I'm not sur= e this
>> package definition is correct.=C2=A0 I would normally expect a &qu= ot;runtime
>> dependency" to be either retained as a reference in the outpu= t, or
>> declared as a propagated-input (so that it gets installed alongsid= e this
>> package when this package is installed into a profile).=C2=A0 Perh= aps I am
>> missing some information here.
>>
>> I'm hoping Ricardo can comment on how this is intended to work= for Java
>> packages, since he originally added the ant-build-system.
>
> The jars that the ant-build-system generates are uncompressed and thus=
> allow the scanner to find embedded store references.=C2=A0 The problem= seems
> to be that references to other *jars* are not kept, because they are > never recorded anywhere.=C2=A0 That=E2=80=99s normal for Java, which l= ooks for named
> classes on the classpath, i.e. a list of jars.=C2=A0 It behaves very m= uch
> like Python and its PYTHONPATH in this regard.
>
> The best we can do here is to propagate inputs.=C2=A0 The alternative = is to
> try to be smart and record the effective runtime classpath, but that= =E2=80=99s
> hard/impossible to get right.

OK - thank you for the explanation!=C2=A0 In light of that informati= on, I
think that in the case of a package that uses the ant-build-system (like java-asm), if we know for sure that an input is required at runtime, we
should make it a propagated input.=C2=A0 The installed software still won&#= 39;t
work without additional work on the part of the user (e.g., the user
needs to set the CLASSPATH when invoking java, or use java's -cp
option), but for now at least making the input a propagated input will
ensure that it gets installed alongside the package which at runtime
requires it, which is better than nothing.

Here's an updated patch that makes this change.=C2=A0 In addition, I discovered that (1) the build succeeds and produces the same JAR file
even when I removed java-aqute-libg as an input, so I've removed that,<= br> and (2) the build succeeds and produces the same JAR file even when I
use a dummy value for the biz.aQute.bnd.path Ant property, so I did that to make it clear that it wasn't important to the build.=C2=A0 What do y= ou
think?

I think this is ok. I also noticed, that a dummy value would do, bu= t I had no policy
at hand about what to do in this case.

Actually I am not sure, that bnd is used runtime. How coul= d we check that?
=C2=A0
--
Chris

--001a11c1468ae2558b05633188b5-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 06:24:36 2018 Received: (at 29896) by debbugs.gnu.org; 20 Jan 2018 11:24:36 +0000 Received: from localhost ([127.0.0.1]:35599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecrGE-0006LX-Sz for submit@debbugs.gnu.org; Sat, 20 Jan 2018 06:24:36 -0500 Received: from lepiller.eu ([89.234.186.109]:49038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecrGC-0006LL-FI for 29896@debbugs.gnu.org; Sat, 20 Jan 2018 06:24:33 -0500 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 86ae89ea (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <29896@debbugs.gnu.org>; Sat, 20 Jan 2018 11:24:54 +0000 (UTC) Date: Sat, 20 Jan 2018 12:24:24 +0100 From: Julien Lepiller To: 29896@debbugs.gnu.org Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. Message-ID: <20180120122424.1016d079@lepiller.eu> In-Reply-To: References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> <20180120001202.GC18016@jasmine.lan> <87fu71ufxo.fsf@gmail.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29896 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Le Sat, 20 Jan 2018 10:08:04 +0100, G=C3=A1bor Boskovits a =C3=A9crit : > 2018-01-20 8:50 GMT+01:00 Chris Marusich : >=20 > > Leo Famulari writes: > > =20 > > > On Thu, Jan 18, 2018 at 10:35:34PM -0800, Chris Marusich wrote: =20 > > >> Even though we added some inputs, there appear to be no retained > > >> references in the output, as shown by this command: > > >> > > >> guix gc --referrers $(./pre-inst-env guix build java-asm) =20 > > > > > > To check the retained references in the output [0], it's actually > > > `guix gc --references $(./pre-inst-env guix build ...)`. > > > > > > [0] To clarify "retained references", they are literally > > > occurences of strings that begin with '/gnu/store/', then a Guix > > > hash, then a hyphen, and then a package name. =20 > > > > You're right; this was a "thinko" on my part. I meant to write > > "--references" instead of "--referrers". The output of the correct > > command is still empty, so there are still no references. > > > > Ricardo Wurmus writes: > > =20 > > > Chris Marusich writes: > > > =20 > > >> If the new input is also required at runtime, then I'm not sure > > >> this package definition is correct. I would normally expect a > > >> "runtime dependency" to be either retained as a reference in the > > >> output, or declared as a propagated-input (so that it gets > > >> installed alongside this package when this package is installed > > >> into a profile). Perhaps I am missing some information here. > > >> > > >> I'm hoping Ricardo can comment on how this is intended to work > > >> for Java packages, since he originally added the > > >> ant-build-system. =20 > > > > > > The jars that the ant-build-system generates are uncompressed and > > > thus allow the scanner to find embedded store references. The > > > problem seems to be that references to other *jars* are not kept, > > > because they are never recorded anywhere. That=E2=80=99s normal for > > > Java, which looks for named classes on the classpath, i.e. a list > > > of jars. It behaves very much like Python and its PYTHONPATH in > > > this regard. > > > > > > The best we can do here is to propagate inputs. The alternative > > > is to try to be smart and record the effective runtime classpath, > > > but that=E2=80=99s hard/impossible to get right. =20 > > > > OK - thank you for the explanation! In light of that information, I > > think that in the case of a package that uses the ant-build-system > > (like java-asm), if we know for sure that an input is required at > > runtime, we should make it a propagated input. The installed > > software still won't work without additional work on the part of > > the user (e.g., the user needs to set the CLASSPATH when invoking > > java, or use java's -cp option), but for now at least making the > > input a propagated input will ensure that it gets installed > > alongside the package which at runtime requires it, which is better > > than nothing. > > > > Here's an updated patch that makes this change. In addition, I > > discovered that (1) the build succeeds and produces the same JAR > > file even when I removed java-aqute-libg as an input, so I've > > removed that, and (2) the build succeeds and produces the same JAR > > file even when I use a dummy value for the biz.aQute.bnd.path Ant > > property, so I did that to make it clear that it wasn't important > > to the build. What do you think? > > > > I think this is ok. I also noticed, that a dummy value would do, > > but I had =20 > no policy > at hand about what to do in this case. >=20 > Actually I am not sure, that bnd is used runtime. How could we check > that? Try to run it when bnd is not in the CLASSPATH? There's a method to get references to a dependency in java: you can put it in the MANIFEST.MF file as: Class-Path: /gnu/store/... It's a space-separated list of jar files that have to be added to the classpath. This could be done in a phase that runs just before the build phase, like the phase that adds a Main-Class. >=20 >=20 > > -- > > Chris > > =20 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 16:43:20 2018 Received: (at 29896-done) by debbugs.gnu.org; 20 Jan 2018 21:43:20 +0000 Received: from localhost ([127.0.0.1]:36384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ed0v2-0000od-Ig for submit@debbugs.gnu.org; Sat, 20 Jan 2018 16:43:20 -0500 Received: from mail-pg0-f54.google.com ([74.125.83.54]:33927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ed0v0-0000oQ-BX for 29896-done@debbugs.gnu.org; Sat, 20 Jan 2018 16:43:19 -0500 Received: by mail-pg0-f54.google.com with SMTP id r19so4100794pgn.1 for <29896-done@debbugs.gnu.org>; Sat, 20 Jan 2018 13:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=g6I8Mri9YUNQvC6HnEnMK58V11tY/Gv13guCmuSNoVo=; b=L4DI7ItVBX1icEUwSCYd84UQvyYzgR1h1sUzmtUExe0wTEH8Yw7ueWlVPEaG57ZY36 h+r1ha1ooLi8H/5KUZJYQ7GgLvnperiPVsRysnpofIF/RYnnf5qC/+n9aOmW/8PfEX8o tFExK0SsGnQ9eZvBW87G4DSVABx1toq+Si6Pf3boON5E/vJEm6zGOIynraIuYavRFdzx /1Sq952i6XTYNdjBPpt83q7oLDQODLVoL/NgT03ZjQ0s5PJde4oN8piPau2nMa1/xx95 lx9MOJ4e37QReR2eC8P4DIpXSXE5X6IodcHLxDzxsUEdwZqxsG7tURKN9cgi+aOjynX4 mxvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=g6I8Mri9YUNQvC6HnEnMK58V11tY/Gv13guCmuSNoVo=; b=GzCVDgJbwur2TapOS3XBeySFU2s2jiY3IKSFtBBnPR3Am0APmVz3eKt1bX0+IWLo4y KLsYWO6xddtZyK6VQlCPdgDokamLKduKQRDLX+rH3HUkpaZXkMkJepjktP9hsXG2McFC Fxp08Dx7gPbhdkgq9NooKsVkCs69pg9ZjskSiEferZ6vesGdcv8diFXzrUskHqQNg/7n LNgg3novZjN9sOsa1rWTkmsW7Q4Gmdl3OcdKWHD/5lMqW8q4aI2iFSEdxDa7IF4dLkxM cbsV5NLITOAl46qSyggvoyRXM+Yj4k1mPMhtMKCI7/93c1yERLxYjMQf/zuVE5mjS6pk 4Qyg== X-Gm-Message-State: AKwxytd4bi7wi9TdnvMucenkxiRBJWj5rDBGXMOV4CBZe1eL5SdkYPzm NCCLw9PHcVObdUqs+Hu8wpI= X-Google-Smtp-Source: AH8x227hBnryAVPJzVDWEwU6AqEcLj3OaYg5hgclMN9TggEJGVF9Vo2WMcI4PgyM77wDHnKSw0h4NQ== X-Received: by 10.101.85.195 with SMTP id k3mr2991057pgs.191.1516484592340; Sat, 20 Jan 2018 13:43:12 -0800 (PST) Received: from garuda.local ([2601:602:9d02:4725:6495:ba21:1ebe:620a]) by smtp.gmail.com with ESMTPSA id v81sm25575486pfi.65.2018.01.20.13.43.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 20 Jan 2018 13:43:10 -0800 (PST) From: Chris Marusich To: =?utf-8?Q?G=C3=A1bor?= Boskovits , Ricardo Wurmus , Julien Lepiller Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> <20180120001202.GC18016@jasmine.lan> <87fu71ufxo.fsf@gmail.com> Date: Sat, 20 Jan 2018 13:43:06 -0800 In-Reply-To: (=?utf-8?Q?=22G=C3=A1bor?= Boskovits"'s message of "Sat, 20 Jan 2018 10:08:04 +0100") Message-ID: <87y3ksw6j9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29896-done Cc: 29896-done@debbugs.gnu.org, Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable G=C3=A1bor Boskovits writes: > Actually I am not sure, that bnd is used runtime. How could we check that? The only class in the java-asm source code that uses bnd seems to be ModuleInfoBndPlugin.java. I checked by grepping for imports that mentioned the string "bnd". This class is declared public, and it is included in the output JAR, so it is technically possible for code that depends on java-asm to use this class (and therefore java-aqute-bndlib) at runtime, even though there might also be code that depends on java-asm that does not use this class at runtime. So it seems reasonable to make it a propagated-input. The only downside is that java-aqute-bndlib is 125% larger than java-asm (1.8 MiB compared to 0.8 MiB). I've committed this patch as d0e9ded713e06790aad4992de7c26d075d18b86d, with the changes we agreed upon. I've also added a copyright line for both you and me gnu/packages/java.scm. Julien Lepiller writes: > There's a method to get references to a dependency in java: you can put > it in the MANIFEST.MF file as: > > Class-Path: /gnu/store/... > > It's a space-separated list of jar files that have to be added to the > classpath. This could be done in a phase that runs just before the > build phase, like the phase that adds a Main-Class. We've considered using this feature, but I don't know if anybody followed through and tried it out. Your help would be welcome! Prior discussions can be found here: https://lists.gnu.org/archive/html/guix-devel/2017-04/msg00249.html https://lists.gnu.org/archive/html/guix-devel/2017-05/msg00019.html If you want to discuss this further, please start a new thread on guix-devel@gnu.org. Ricardo Wurmus writes: > Chris Marusich writes: > >> The installed software still won't >> work without additional work on the part of the user (e.g., the user >> needs to set the CLASSPATH when invoking java, or use java's -cp >> option), but for now at least making the input a propagated input will >> ensure that it gets installed alongside the package which at runtime >> requires it, which is better than nothing. > > This can be fixed by adding a search path specification for CLASSPATH to > the icedtea packages. I think that's a good idea! I'll follow up with a separate patch later, unless you beat me to it. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlpjt+oACgkQ3UCaFdgi Rp1A+BAAurchPfbdy6EnQiRhteJJAeuwSIuDmsLCItCgXOWOu+FXyr70uON6ZpIK PDjaZ354ZCoQ2xogaisQyS3HZpRAuPfrHEvCxXEY9rnODYfjHXjb+oAI9I1GGTdE vVr/J7+wZeJPPYdJCKoLRJZXkQI+8OmOfMLkwNebz9QBLV6ANC9t9jf1lO/Y6U44 dVXIUTjdgo0B6VOV54vzwEMmZBtiJWi0uYxHlVPMTU4rdaX2MYlVLZ5LxPOJAbxz SVsLkNyncorY5prAnx8amqpwsBxGBK/wGbNafTzzBk8745Tjb6Sf53m0czJIQ9zc X7jPVg0DNJQm7LiD6mzVPUb8a8yNO9Nb52xsh3d5p+ZTw0dxZ2HyrvpCrX2MvvBz /CW+fCuftB217zNFBaJyvAEk1YSOAmydYuFiIe0FxNJjb6xQK31KwAjvNbS+ZrwG ATNj1U6pDoAg6do3dwEf0y9wLLmcYIiQJnbZpiSc8NkBPsQ9o8GlHFaBAxYN1eZu 52xt/x9rv9yMtF9XkXJgYSH4EXEG9Djp6cbAeBcE9wg2wIELJSU9NE2U6lnEyr+Z El3PXz9JiG2nmlEOMn67EIjZkvK0IIvZ+tQw3ReIE90hqbRIJJs7SdXwwrBScnZr F93afhqbMyanYMoaKqdWfoigIPrDYSSPE2lHtWiP4hKPBjCazQ0= =72y3 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 21 08:53:15 2018 Received: (at 29896-done) by debbugs.gnu.org; 21 Jan 2018 13:53:15 +0000 Received: from localhost ([127.0.0.1]:36652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edG3e-0003Ry-Rd for submit@debbugs.gnu.org; Sun, 21 Jan 2018 08:53:15 -0500 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edG3d-0003Rq-Dd for 29896-done@debbugs.gnu.org; Sun, 21 Jan 2018 08:53:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1516542760; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type; l=666; bh=RXOO2nmJNW4YX39vBxFgNlIDB5d104GgmLzgjpB3N6w=; b=gdp/gywDYIBCHCXf4BkPFB8XmOGFnmVjir+EQX62I86hsnahZ6RwontkICSIAWme FGobc0m+GKacugyZnXq/TZ1bRC4g6ykAORA5N68y3Phk9iN8oID+efI+BwqGlLITVhW fSkpLU1W9yLWI7y4gQ81PmB2UwWu9SqHfe0t9fMA= Received: from localhost (port-92-200-13-49.dynamic.qsc.de [92.200.13.49]) by mx.zohomail.com with SMTPS id 1516542760161498.87313640007835; Sun, 21 Jan 2018 05:52:40 -0800 (PST) References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> <20180120001202.GC18016@jasmine.lan> <87fu71ufxo.fsf@gmail.com> <87y3ksw6j9.fsf@gmail.com> User-agent: mu4e 1.0-alpha3; emacs 25.3.1 From: Ricardo Wurmus To: Chris Marusich Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. In-reply-to: <87y3ksw6j9.fsf@gmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Sun, 21 Jan 2018 14:52:36 +0100 Message-ID: <87tvvf1fq3.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29896-done Cc: =?utf-8?Q?G=C3=A1bor?= Boskovits , Leo Famulari , Julien Lepiller , 29896-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Julien Lepiller writes: > >> There's a method to get references to a dependency in java: you can put >> it in the MANIFEST.MF file as: >> >> Class-Path: /gnu/store/... >> >> It's a space-separated list of jar files that have to be added to the >> classpath. This could be done in a phase that runs just before the >> build phase, like the phase that adds a Main-Class. > > We've considered using this feature, but I don't know if anybody > followed through and tried it out. It would only work for applications, not for libraries. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 22 15:03:22 2018 Received: (at 29896) by debbugs.gnu.org; 22 Jan 2018 20:03:22 +0000 Received: from localhost ([127.0.0.1]:38517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ediJO-00065m-Ii for submit@debbugs.gnu.org; Mon, 22 Jan 2018 15:03:22 -0500 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ediJK-00065b-EP for 29896@debbugs.gnu.org; Mon, 22 Jan 2018 15:03:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1516364036; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; l=1541; bh=6v4lMN2IIfnzvy5Q86BXByYhvgBwqHJvHTT4rCh4t54=; b=QJhbTRwDn+SwjoAWYwuCI++FvLQqaFqEsCaxXzHb9NIWT4QhDUKVSUB/92Zv42g2 1W79r+cJ1bcp5vo3aPzKYWZBUDmFNmGZqW87s3zZpbXoJjGB6DDyyH4KQz4LVLqnRgZ Q+unOQXWUgZtuLCVSF+aZtCD6U0VgDFg2zwHmelE= Received: from localhost (141.80.247.185 [141.80.247.185]) by mx.zohomail.com with SMTPS id 1516364036887245.84546957592966; Fri, 19 Jan 2018 04:13:56 -0800 (PST) References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> <87y3kuf9u1.fsf@gmail.com> User-agent: mu4e 1.0-alpha3; emacs 25.3.1 From: Ricardo Wurmus To: Chris Marusich Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. In-reply-to: <87y3kuf9u1.fsf@gmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Fri, 19 Jan 2018 13:13:54 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87a7xa6o71.fsf@elephly.net> X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29896 Cc: =?utf-8?Q?G=C3=A1bor?= Boskovits , 29896@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Chris Marusich writes: > G=C3=A1bor Boskovits writes: > >> Actually I did forget to check if it is used runtime. >> It is used to build and OSGi bundle. >> At first I tried to fake the dependency like for the ant tasks, >> but I got compilation errors. > > If the new input is also required at runtime, then I'm not sure this > package definition is correct. I would normally expect a "runtime > dependency" to be either retained as a reference in the output, or > declared as a propagated-input (so that it gets installed alongside this > package when this package is installed into a profile). Perhaps I am > missing some information here. > > I'm hoping Ricardo can comment on how this is intended to work for Java > packages, since he originally added the ant-build-system. The jars that the ant-build-system generates are uncompressed and thus allow the scanner to find embedded store references. The problem seems to be that references to other *jars* are not kept, because they are never recorded anywhere. That=E2=80=99s normal for Java, which looks for n= amed classes on the classpath, i.e. a list of jars. It behaves very much like Python and its PYTHONPATH in this regard. The best we can do here is to propagate inputs. The alternative is to try to be smart and record the effective runtime classpath, but that=E2=80= =99s hard/impossible to get right. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 23 02:19:09 2018 Received: (at 29896) by debbugs.gnu.org; 23 Jan 2018 07:19:10 +0000 Received: from localhost ([127.0.0.1]:38940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edsrN-0002P2-N7 for submit@debbugs.gnu.org; Tue, 23 Jan 2018 02:19:09 -0500 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edsrK-0002Op-Un for 29896@debbugs.gnu.org; Tue, 23 Jan 2018 02:19:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1516447794; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type; l=614; bh=9pLZm82Ao32kU6fWDFqe3WU805x/3bgBgMP/McQFhLQ=; b=VzpdGdgUMGxUq4vS8kM51SZ2qySXcfGl7hyzWlFo5eKxsGzWnreOCWZ+kqs09a/l /L2yMg3wUIWkvRFnCBFwldYNh/ZJBDlDrh8G+QbVX7SFZMYY5NKeWu/jhSaG4erLDrN v7AENAJsKyEQzs2SBNT12A4fJnWNcl8C7uqVeuh0= Received: from localhost (port-92-200-82-6.dynamic.qsc.de [92.200.82.6]) by mx.zohomail.com with SMTPS id 151644779428493.86276357852933; Sat, 20 Jan 2018 03:29:54 -0800 (PST) References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> <20180120001202.GC18016@jasmine.lan> <87fu71ufxo.fsf@gmail.com> User-agent: mu4e 1.0-alpha3; emacs 25.3.1 From: Ricardo Wurmus To: Chris Marusich Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. In-reply-to: <87fu71ufxo.fsf@gmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Sat, 20 Jan 2018 12:29:50 +0100 Message-ID: <87607wepjl.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29896 Cc: =?utf-8?Q?G=C3=A1bor?= Boskovits , 29896@debbugs.gnu.org, Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Chris Marusich writes: > The installed software still won't > work without additional work on the part of the user (e.g., the user > needs to set the CLASSPATH when invoking java, or use java's -cp > option), but for now at least making the input a propagated input will > ensure that it gets installed alongside the package which at runtime > requires it, which is better than nothing. This can be fixed by adding a search path specification for CLASSPATH to the icedtea packages. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From unknown Wed Jun 18 23:06:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Feb 2018 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator