GNU bug report logs - #29896
[PATCH core-updates] gnu: java-asm: Update to 6.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29896 in the body.
You can then email your comments to 29896 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Gábor Boskovits <boskovits <at> gmail.com>
Subject: [PATCH core-updates] gnu: java-asm: Update to 6.0.
Date: Fri, 29 Dec 2017 20:00:22 +0100

* gnu/packages/java.scm (java-asm): Update to 6.0.
[inputs]: Add java-aqute-bndlib, java-aqute-libg. (New dependencies)
[arguments]: Adjust make-flags, so that the build does not complain about unset properties.
---
 gnu/packages/java.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 41f9af87e..8a244328f 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -2663,15 +2663,18 @@ archives (jar).")
 (define-public java-asm
   (package
     (name "java-asm")
-    (version "5.2")
+    (version "6.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://download.forge.ow2.org/asm/"
                                   "asm-" version ".tar.gz"))
               (sha256
                (base32
-                "0kxvmv5275rnjl7jv0442k3wjnq03ngkb7sghs78avf45pzm4qgr"))))
+                "115l5pqblirdkmzi32dxx7gbcm4jy0s14y5wircr6h8jdr9aix00"))))
     (build-system ant-build-system)
+    (inputs
+     `(("java-aqute-bndlib" ,java-aqute-bndlib)
+       ("java-aqute-libg" ,java-aqute-libg)))
     (arguments
      `(#:build-target "compile"
        ;; The tests require an old version of Janino, which no longer compiles
@@ -2679,7 +2682,8 @@ archives (jar).")
        #:tests? #f
        ;; We don't need these extra ant tasks, but the build system asks us to
        ;; provide a path anyway.
-       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo"))
+       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo")
+                          (string-append "-Dbiz.aQute.bnd.path=" (assoc-ref %build-inputs "java-aqute-bndlib")))
        #:phases
        (modify-phases %standard-phases
          (add-before 'install 'build-jars
-- 
2.15.1

Message #8 received at 29896 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 29896 <at> debbugs.gnu.org
Cc: Gábor Boskovits <boskovits <at> gmail.com>
Subject: [PATCH] gnu: java-asm: Update to 6.0.
Date: Sun,  7 Jan 2018 22:23:56 +0100

* gnu/packages/java.scm (java-asm): Update to 6.0.
[inputs]: Add java-aqute-bndlib, java-aqute-libg. (New dependencies)
[arguments]: Adjust make-flags, so that the build does not complain about unset properties.
---
 gnu/packages/java.scm | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 41f9af87e..8579f7c8b 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -2663,15 +2663,18 @@ archives (jar).")
 (define-public java-asm
   (package
     (name "java-asm")
-    (version "5.2")
+    (version "6.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://download.forge.ow2.org/asm/"
                                   "asm-" version ".tar.gz"))
               (sha256
                (base32
-                "0kxvmv5275rnjl7jv0442k3wjnq03ngkb7sghs78avf45pzm4qgr"))))
+                "115l5pqblirdkmzi32dxx7gbcm4jy0s14y5wircr6h8jdr9aix00"))))
     (build-system ant-build-system)
+    (inputs
+     `(("java-aqute-bndlib" ,java-aqute-bndlib)
+       ("java-aqute-libg" ,java-aqute-libg)))
     (arguments
      `(#:build-target "compile"
        ;; The tests require an old version of Janino, which no longer compiles
@@ -2679,7 +2682,9 @@ archives (jar).")
        #:tests? #f
        ;; We don't need these extra ant tasks, but the build system asks us to
        ;; provide a path anyway.
-       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo"))
+       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo")
+                          (string-append "-Dbiz.aQute.bnd.path="
+                                         (assoc-ref %build-inputs "java-aqute-bndlib")))
        #:phases
        (modify-phases %standard-phases
          (add-before 'install 'build-jars
-- 
2.15.1

Message #11 received at 29896 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 29896 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: java-asm: Update to 6.0.
Date: Sun, 7 Jan 2018 22:27:08 +0100

[Message part 1 (text/plain, inline)]

The second version of this patch passes guix lint. The first one contains a
line too long.
Sorry about that.

[Message part 2 (text/html, inline)]

Message #14 received at 29896 <at> debbugs.gnu.org (full text, mbox):

From: Chris Marusich <cmmarusich <at> gmail.com>
To: Gábor Boskovits <boskovits <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 29896 <at> debbugs.gnu.org
Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Thu, 18 Jan 2018 22:35:34 -0800

[Message part 1 (text/plain, inline)]

Gábor Boskovits <boskovits <at> gmail.com> writes:

> +    (inputs
> +     `(("java-aqute-bndlib" ,java-aqute-bndlib)
> +       ("java-aqute-libg" ,java-aqute-libg)))
>      (arguments
>       `(#:build-target "compile"
>         ;; The tests require an old version of Janino, which no longer compiles
> @@ -2679,7 +2682,9 @@ archives (jar).")
>         #:tests? #f
>         ;; We don't need these extra ant tasks, but the build system asks us to
>         ;; provide a path anyway.
> -       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo"))
> +       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo")
> +                          (string-append "-Dbiz.aQute.bnd.path="
> +                                         (assoc-ref %build-inputs "java-aqute-bndlib")))

Even though we added some inputs, there appear to be no retained
references in the output, as shown by this command:

  guix gc --referrers $(./pre-inst-env guix build java-asm)

Is this expected?  At first blush, this seems reasonable only if
java-aqute-bndlib and java-aqute-libg are not required at runtime.
Perhaps Ricardo knows more, since he has more experience working with
the ant-build-system.

-- 
Chris

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 29896 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 29896 <at> debbugs.gnu.org
Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Fri, 19 Jan 2018 09:11:58 +0100

[Message part 1 (text/plain, inline)]

Actually I did forget to check if it is used runtime.
It is used to build and OSGi bundle.
At first I tried to fake the dependency like for the ant tasks,
but I got compilation errors.

2018-01-19 7:35 GMT+01:00 Chris Marusich <cmmarusich <at> gmail.com>:

> Gábor Boskovits <boskovits <at> gmail.com> writes:
>
> > +    (inputs
> > +     `(("java-aqute-bndlib" ,java-aqute-bndlib)
> > +       ("java-aqute-libg" ,java-aqute-libg)))
> >      (arguments
> >       `(#:build-target "compile"
> >         ;; The tests require an old version of Janino, which no longer
> compiles
> > @@ -2679,7 +2682,9 @@ archives (jar).")
> >         #:tests? #f
> >         ;; We don't need these extra ant tasks, but the build system
> asks us to
> >         ;; provide a path anyway.
> > -       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=
> foo"))
> > +       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=
> foo")
> > +                          (string-append "-Dbiz.aQute.bnd.path="
> > +                                         (assoc-ref %build-inputs
> "java-aqute-bndlib")))
>
> Even though we added some inputs, there appear to be no retained
> references in the output, as shown by this command:
>
>   guix gc --referrers $(./pre-inst-env guix build java-asm)
>
> Is this expected?  At first blush, this seems reasonable only if
> java-aqute-bndlib and java-aqute-libg are not required at runtime.
> Perhaps Ricardo knows more, since he has more experience working with
> the ant-build-system.
>
> --
> Chris
>

[Message part 2 (text/html, inline)]

Message #20 received at 29896 <at> debbugs.gnu.org (full text, mbox):

From: Chris Marusich <cmmarusich <at> gmail.com>
To: Gábor Boskovits <boskovits <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 29896 <at> debbugs.gnu.org
Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Fri, 19 Jan 2018 01:59:18 -0800

[Message part 1 (text/plain, inline)]

Gábor Boskovits <boskovits <at> gmail.com> writes:

> Actually I did forget to check if it is used runtime.
> It is used to build and OSGi bundle.
> At first I tried to fake the dependency like for the ant tasks,
> but I got compilation errors.

If the new input is also required at runtime, then I'm not sure this
package definition is correct.  I would normally expect a "runtime
dependency" to be either retained as a reference in the output, or
declared as a propagated-input (so that it gets installed alongside this
package when this package is installed into a profile).  Perhaps I am
missing some information here.

I'm hoping Ricardo can comment on how this is intended to work for Java
packages, since he originally added the ant-build-system.

-- 
Chris

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 29896 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>,
 Gábor Boskovits <boskovits <at> gmail.com>,
 29896 <at> debbugs.gnu.org
Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Fri, 19 Jan 2018 16:12:02 -0800

[Message part 1 (text/plain, inline)]

On Thu, Jan 18, 2018 at 10:35:34PM -0800, Chris Marusich wrote:
> Gábor Boskovits <boskovits <at> gmail.com> writes:
> 
> > +    (inputs
> > +     `(("java-aqute-bndlib" ,java-aqute-bndlib)
> > +       ("java-aqute-libg" ,java-aqute-libg)))
> >      (arguments
> >       `(#:build-target "compile"
> >         ;; The tests require an old version of Janino, which no longer compiles
> > @@ -2679,7 +2682,9 @@ archives (jar).")
> >         #:tests? #f
> >         ;; We don't need these extra ant tasks, but the build system asks us to
> >         ;; provide a path anyway.
> > -       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo"))
> > +       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=foo")
> > +                          (string-append "-Dbiz.aQute.bnd.path="
> > +                                         (assoc-ref %build-inputs "java-aqute-bndlib")))
> 
> Even though we added some inputs, there appear to be no retained
> references in the output, as shown by this command:
> 
>   guix gc --referrers $(./pre-inst-env guix build java-asm)

To check the retained references in the output [0], it's actually `guix
gc --references $(./pre-inst-env guix build ...)`.

[0] To clarify "retained references", they are literally occurences of
strings that begin with '/gnu/store/', then a Guix hash, then a hyphen,
and then a package name.

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 29896 <at> debbugs.gnu.org (full text, mbox):

From: Chris Marusich <cmmarusich <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>, Ricardo Wurmus <rekado <at> elephly.net>,
 Gábor Boskovits <boskovits <at> gmail.com>
Cc: 29896 <at> debbugs.gnu.org
Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Fri, 19 Jan 2018 23:50:43 -0800

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Thu, Jan 18, 2018 at 10:35:34PM -0800, Chris Marusich wrote:
>> Even though we added some inputs, there appear to be no retained
>> references in the output, as shown by this command:
>> 
>>   guix gc --referrers $(./pre-inst-env guix build java-asm)
>
> To check the retained references in the output [0], it's actually `guix
> gc --references $(./pre-inst-env guix build ...)`.
>
> [0] To clarify "retained references", they are literally occurences of
> strings that begin with '/gnu/store/', then a Guix hash, then a hyphen,
> and then a package name.

You're right; this was a "thinko" on my part.  I meant to write
"--references" instead of "--referrers".  The output of the correct
command is still empty, so there are still no references.

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Chris Marusich <cmmarusich <at> gmail.com> writes:
>
>> If the new input is also required at runtime, then I'm not sure this
>> package definition is correct.  I would normally expect a "runtime
>> dependency" to be either retained as a reference in the output, or
>> declared as a propagated-input (so that it gets installed alongside this
>> package when this package is installed into a profile).  Perhaps I am
>> missing some information here.
>>
>> I'm hoping Ricardo can comment on how this is intended to work for Java
>> packages, since he originally added the ant-build-system.
>
> The jars that the ant-build-system generates are uncompressed and thus
> allow the scanner to find embedded store references.  The problem seems
> to be that references to other *jars* are not kept, because they are
> never recorded anywhere.  That’s normal for Java, which looks for named
> classes on the classpath, i.e. a list of jars.  It behaves very much
> like Python and its PYTHONPATH in this regard.
>
> The best we can do here is to propagate inputs.  The alternative is to
> try to be smart and record the effective runtime classpath, but that’s
> hard/impossible to get right.

OK - thank you for the explanation!  In light of that information, I
think that in the case of a package that uses the ant-build-system (like
java-asm), if we know for sure that an input is required at runtime, we
should make it a propagated input.  The installed software still won't
work without additional work on the part of the user (e.g., the user
needs to set the CLASSPATH when invoking java, or use java's -cp
option), but for now at least making the input a propagated input will
ensure that it gets installed alongside the package which at runtime
requires it, which is better than nothing.

Here's an updated patch that makes this change.  In addition, I
discovered that (1) the build succeeds and produces the same JAR file
even when I removed java-aqute-libg as an input, so I've removed that,
and (2) the build succeeds and produces the same JAR file even when I
use a dummy value for the biz.aQute.bnd.path Ant property, so I did that
to make it clear that it wasn't important to the build.  What do you
think?

-- 
Chris

[0001-gnu-java-asm-Update-to-6.0.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 29896 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 29896 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Sat, 20 Jan 2018 10:08:04 +0100

[Message part 1 (text/plain, inline)]

2018-01-20 8:50 GMT+01:00 Chris Marusich <cmmarusich <at> gmail.com>:

> Leo Famulari <leo <at> famulari.name> writes:
>
> > On Thu, Jan 18, 2018 at 10:35:34PM -0800, Chris Marusich wrote:
> >> Even though we added some inputs, there appear to be no retained
> >> references in the output, as shown by this command:
> >>
> >>   guix gc --referrers $(./pre-inst-env guix build java-asm)
> >
> > To check the retained references in the output [0], it's actually `guix
> > gc --references $(./pre-inst-env guix build ...)`.
> >
> > [0] To clarify "retained references", they are literally occurences of
> > strings that begin with '/gnu/store/', then a Guix hash, then a hyphen,
> > and then a package name.
>
> You're right; this was a "thinko" on my part.  I meant to write
> "--references" instead of "--referrers".  The output of the correct
> command is still empty, so there are still no references.
>
> Ricardo Wurmus <rekado <at> elephly.net> writes:
>
> > Chris Marusich <cmmarusich <at> gmail.com> writes:
> >
> >> If the new input is also required at runtime, then I'm not sure this
> >> package definition is correct.  I would normally expect a "runtime
> >> dependency" to be either retained as a reference in the output, or
> >> declared as a propagated-input (so that it gets installed alongside this
> >> package when this package is installed into a profile).  Perhaps I am
> >> missing some information here.
> >>
> >> I'm hoping Ricardo can comment on how this is intended to work for Java
> >> packages, since he originally added the ant-build-system.
> >
> > The jars that the ant-build-system generates are uncompressed and thus
> > allow the scanner to find embedded store references.  The problem seems
> > to be that references to other *jars* are not kept, because they are
> > never recorded anywhere.  That’s normal for Java, which looks for named
> > classes on the classpath, i.e. a list of jars.  It behaves very much
> > like Python and its PYTHONPATH in this regard.
> >
> > The best we can do here is to propagate inputs.  The alternative is to
> > try to be smart and record the effective runtime classpath, but that’s
> > hard/impossible to get right.
>
> OK - thank you for the explanation!  In light of that information, I
> think that in the case of a package that uses the ant-build-system (like
> java-asm), if we know for sure that an input is required at runtime, we
> should make it a propagated input.  The installed software still won't
> work without additional work on the part of the user (e.g., the user
> needs to set the CLASSPATH when invoking java, or use java's -cp
> option), but for now at least making the input a propagated input will
> ensure that it gets installed alongside the package which at runtime
> requires it, which is better than nothing.
>
> Here's an updated patch that makes this change.  In addition, I
> discovered that (1) the build succeeds and produces the same JAR file
> even when I removed java-aqute-libg as an input, so I've removed that,
> and (2) the build succeeds and produces the same JAR file even when I
> use a dummy value for the biz.aQute.bnd.path Ant property, so I did that
> to make it clear that it wasn't important to the build.  What do you
> think?
>
> I think this is ok. I also noticed, that a dummy value would do, but I had
no policy
at hand about what to do in this case.

Actually I am not sure, that bnd is used runtime. How could we check that?


> --
> Chris
>

[Message part 2 (text/html, inline)]

Message #32 received at 29896 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 29896 <at> debbugs.gnu.org
Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Sat, 20 Jan 2018 12:24:24 +0100

Le Sat, 20 Jan 2018 10:08:04 +0100,
Gábor Boskovits <boskovits <at> gmail.com> a écrit :

> 2018-01-20 8:50 GMT+01:00 Chris Marusich <cmmarusich <at> gmail.com>:
> 
> > Leo Famulari <leo <at> famulari.name> writes:
> >  
> > > On Thu, Jan 18, 2018 at 10:35:34PM -0800, Chris Marusich wrote:  
> > >> Even though we added some inputs, there appear to be no retained
> > >> references in the output, as shown by this command:
> > >>
> > >>   guix gc --referrers $(./pre-inst-env guix build java-asm)  
> > >
> > > To check the retained references in the output [0], it's actually
> > > `guix gc --references $(./pre-inst-env guix build ...)`.
> > >
> > > [0] To clarify "retained references", they are literally
> > > occurences of strings that begin with '/gnu/store/', then a Guix
> > > hash, then a hyphen, and then a package name.  
> >
> > You're right; this was a "thinko" on my part.  I meant to write
> > "--references" instead of "--referrers".  The output of the correct
> > command is still empty, so there are still no references.
> >
> > Ricardo Wurmus <rekado <at> elephly.net> writes:
> >  
> > > Chris Marusich <cmmarusich <at> gmail.com> writes:
> > >  
> > >> If the new input is also required at runtime, then I'm not sure
> > >> this package definition is correct.  I would normally expect a
> > >> "runtime dependency" to be either retained as a reference in the
> > >> output, or declared as a propagated-input (so that it gets
> > >> installed alongside this package when this package is installed
> > >> into a profile).  Perhaps I am missing some information here.
> > >>
> > >> I'm hoping Ricardo can comment on how this is intended to work
> > >> for Java packages, since he originally added the
> > >> ant-build-system.  
> > >
> > > The jars that the ant-build-system generates are uncompressed and
> > > thus allow the scanner to find embedded store references.  The
> > > problem seems to be that references to other *jars* are not kept,
> > > because they are never recorded anywhere.  That’s normal for
> > > Java, which looks for named classes on the classpath, i.e. a list
> > > of jars.  It behaves very much like Python and its PYTHONPATH in
> > > this regard.
> > >
> > > The best we can do here is to propagate inputs.  The alternative
> > > is to try to be smart and record the effective runtime classpath,
> > > but that’s hard/impossible to get right.  
> >
> > OK - thank you for the explanation!  In light of that information, I
> > think that in the case of a package that uses the ant-build-system
> > (like java-asm), if we know for sure that an input is required at
> > runtime, we should make it a propagated input.  The installed
> > software still won't work without additional work on the part of
> > the user (e.g., the user needs to set the CLASSPATH when invoking
> > java, or use java's -cp option), but for now at least making the
> > input a propagated input will ensure that it gets installed
> > alongside the package which at runtime requires it, which is better
> > than nothing.
> >
> > Here's an updated patch that makes this change.  In addition, I
> > discovered that (1) the build succeeds and produces the same JAR
> > file even when I removed java-aqute-libg as an input, so I've
> > removed that, and (2) the build succeeds and produces the same JAR
> > file even when I use a dummy value for the biz.aQute.bnd.path Ant
> > property, so I did that to make it clear that it wasn't important
> > to the build.  What do you think?
> >
> > I think this is ok. I also noticed, that a dummy value would do,
> > but I had  
> no policy
> at hand about what to do in this case.
> 
> Actually I am not sure, that bnd is used runtime. How could we check
> that?

Try to run it when bnd is not in the CLASSPATH?

There's a method to get references to a dependency in java: you can put
it in the MANIFEST.MF file as:

Class-Path: /gnu/store/...

It's a space-separated list of jar files that have to be added to the
classpath. This could be done in a phase that runs just before the
build phase, like the phase that adds a Main-Class.

> 
> 
> > --
> > Chris
> >  

Message #37 received at 29896-done <at> debbugs.gnu.org (full text, mbox):

From: Chris Marusich <cmmarusich <at> gmail.com>
To: Gábor Boskovits <boskovits <at> gmail.com>, Ricardo Wurmus
 <rekado <at> elephly.net>, Julien Lepiller <julien <at> lepiller.eu>
Cc: 29896-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Sat, 20 Jan 2018 13:43:06 -0800

[Message part 1 (text/plain, inline)]

Gábor Boskovits <boskovits <at> gmail.com> writes:

> Actually I am not sure, that bnd is used runtime. How could we check that?

The only class in the java-asm source code that uses bnd seems to be
ModuleInfoBndPlugin.java.  I checked by grepping for imports that
mentioned the string "bnd".  This class is declared public, and it is
included in the output JAR, so it is technically possible for code that
depends on java-asm to use this class (and therefore java-aqute-bndlib)
at runtime, even though there might also be code that depends on
java-asm that does not use this class at runtime.  So it seems
reasonable to make it a propagated-input.  The only downside is that
java-aqute-bndlib is 125% larger than java-asm (1.8 MiB compared to 0.8
MiB).

I've committed this patch as d0e9ded713e06790aad4992de7c26d075d18b86d,
with the changes we agreed upon.  I've also added a copyright line for
both you and me gnu/packages/java.scm.

Julien Lepiller <julien <at> lepiller.eu> writes:

> There's a method to get references to a dependency in java: you can put
> it in the MANIFEST.MF file as:
>
> Class-Path: /gnu/store/...
>
> It's a space-separated list of jar files that have to be added to the
> classpath. This could be done in a phase that runs just before the
> build phase, like the phase that adds a Main-Class.

We've considered using this feature, but I don't know if anybody
followed through and tried it out.  Your help would be welcome!  Prior
discussions can be found here:

https://lists.gnu.org/archive/html/guix-devel/2017-04/msg00249.html
https://lists.gnu.org/archive/html/guix-devel/2017-05/msg00019.html

If you want to discuss this further, please start a new thread on
guix-devel <at> gnu.org.

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Chris Marusich <cmmarusich <at> gmail.com> writes:
>
>> The installed software still won't
>> work without additional work on the part of the user (e.g., the user
>> needs to set the CLASSPATH when invoking java, or use java's -cp
>> option), but for now at least making the input a propagated input will
>> ensure that it gets installed alongside the package which at runtime
>> requires it, which is better than nothing.
>
> This can be fixed by adding a search path specification for CLASSPATH to
> the icedtea packages.

I think that's a good idea!  I'll follow up with a separate patch later,
unless you beat me to it.

-- 
Chris

[signature.asc (application/pgp-signature, inline)]

Message #40 received at 29896-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: Gábor Boskovits <boskovits <at> gmail.com>,
 Leo Famulari <leo <at> famulari.name>, Julien Lepiller <julien <at> lepiller.eu>,
 29896-done <at> debbugs.gnu.org
Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Sun, 21 Jan 2018 14:52:36 +0100

> Julien Lepiller <julien <at> lepiller.eu> writes:
>
>> There's a method to get references to a dependency in java: you can put
>> it in the MANIFEST.MF file as:
>>
>> Class-Path: /gnu/store/...
>>
>> It's a space-separated list of jar files that have to be added to the
>> classpath. This could be done in a phase that runs just before the
>> build phase, like the phase that adds a Main-Class.
>
> We've considered using this feature, but I don't know if anybody
> followed through and tried it out.

It would only work for applications, not for libraries.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #43 received at 29896 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: Gábor Boskovits <boskovits <at> gmail.com>,
 29896 <at> debbugs.gnu.org
Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Fri, 19 Jan 2018 13:13:54 +0100

Chris Marusich <cmmarusich <at> gmail.com> writes:

> Gábor Boskovits <boskovits <at> gmail.com> writes:
>
>> Actually I did forget to check if it is used runtime.
>> It is used to build and OSGi bundle.
>> At first I tried to fake the dependency like for the ant tasks,
>> but I got compilation errors.
>
> If the new input is also required at runtime, then I'm not sure this
> package definition is correct.  I would normally expect a "runtime
> dependency" to be either retained as a reference in the output, or
> declared as a propagated-input (so that it gets installed alongside this
> package when this package is installed into a profile).  Perhaps I am
> missing some information here.
>
> I'm hoping Ricardo can comment on how this is intended to work for Java
> packages, since he originally added the ant-build-system.

The jars that the ant-build-system generates are uncompressed and thus
allow the scanner to find embedded store references.  The problem seems
to be that references to other *jars* are not kept, because they are
never recorded anywhere.  That’s normal for Java, which looks for named
classes on the classpath, i.e. a list of jars.  It behaves very much
like Python and its PYTHONPATH in this regard.

The best we can do here is to propagate inputs.  The alternative is to
try to be smart and record the effective runtime classpath, but that’s
hard/impossible to get right.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #46 received at 29896 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: Gábor Boskovits <boskovits <at> gmail.com>,
 29896 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Sat, 20 Jan 2018 12:29:50 +0100

Chris Marusich <cmmarusich <at> gmail.com> writes:

> The installed software still won't
> work without additional work on the part of the user (e.g., the user
> needs to set the CLASSPATH when invoking java, or use java's -cp
> option), but for now at least making the input a propagated input will
> ensure that it gets installed alongside the package which at runtime
> requires it, which is better than nothing.

This can be fixed by adding a search path specification for CLASSPATH to
the icedtea packages.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.