Subject: bug#29880: closed (Re: [bug#29880] [PATCH] gnu: grep: Add PCRE support.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 11 Jan 2018 21:51:02 +0000

Your bug report

#29880: [PATCH] gnu: grep: Add PCRE support.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
29880: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29880
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#29880] [PATCH] gnu: grep: Add PCRE support.
From: [email-masked] (Ludovic Courtès)
To: Roel Janssen <[email-masked]>
Cc: Oleg Pykhalov <[email-masked]>, [email-masked]
Date: Thu, 11 Jan 2018 22:50:12 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Roel Janssen <[email-masked]> skribis:

> Ludovic Courtès writes:

[...]

>> Alternately, what we could do is:
>>
>>   1. Keep ‘grep-final’ as it is right now (without PCRE support; this
>>      has never been a problem so far.)
>>
>>   2. Add PCRE to ‘grep’ itself (like Oleg did).
>>
>> Thoughts?
>
> Yes that seems fine to me.

Done in 20bf5fce7dbdc754a6c430abbeb50fb0662bda38.

Thanks!

Ludo'.

Subject: [PATCH] gnu: grep: Add PCRE support.
From: Oleg Pykhalov <[email-masked]>
To: [email-masked]
Date: Thu, 28 Dec 2017 22:18:05 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Guix,

This patch allows to grep with perl regular expression.

From db4fe96c7c6c0fcaa82e1131aba157c5d5e5f537 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <[email-masked]>
Date: Thu, 28 Dec 2017 22:12:13 +0300
Subject: [PATCH] gnu: grep: Add PCRE support.

* gnu/packages/base.scm (grep)[inputs]: New field.
---
 gnu/packages/base.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index 9cb628d8d..2b439e958 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -40,6 +40,7 @@
   #:use-module (gnu packages linux)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages hurd)
+  #:use-module (gnu packages pcre)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages gettext)
   #:use-module (guix utils)
@@ -92,6 +93,7 @@ command-line arguments, multiple languages, and so on.")
             (patches (search-patches "grep-timing-sensitive-test.patch"
                                      "grep-gnulib-lock.patch"))))
    (build-system gnu-build-system)
+   (inputs `(("pcre" ,pcre)))
    (native-inputs `(("perl" ,perl)))             ;some of the tests require it
    (arguments
     `(#:phases
-- 
2.15.1