GNU bug report logs - #29880
[PATCH] gnu: grep: Add PCRE support.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29880 in the body.
You can then email your comments to 29880 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: grep: Add PCRE support.
Date: Thu, 28 Dec 2017 22:18:05 +0300

[Message part 1 (text/plain, inline)]

Hello Guix,

This patch allows to grep with perl regular expression.

[0001-gnu-grep-Add-PCRE-support.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 29880 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 29880 <at> debbugs.gnu.org
Subject: Re: [bug#29880] [PATCH] gnu: grep: Add PCRE support.
Date: Mon, 08 Jan 2018 10:08:12 +0100

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> This patch allows to grep with perl regular expression.
>
> From db4fe96c7c6c0fcaa82e1131aba157c5d5e5f537 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Thu, 28 Dec 2017 22:12:13 +0300
> Subject: [PATCH] gnu: grep: Add PCRE support.
>
> * gnu/packages/base.scm (grep)[inputs]: New field.

This would be for the next ‘core-updates’.  Did you try a full rebuild?

I’m mildly wary of this change because PCRE is a non-trivial piece of
software that increases the attack surface, and we’d end up grafting
things potentially often.  For instance, right now I get:

  $ guix lint pcre
  gnu/packages/pcre.scm:77:2: pcre <at> 8.41: probably vulnerable to CVE-2017-11164

Would it make sense to instead have a separate “grep-pcre”?

What do people think?

Thanks,
Ludo’.

Message #11 received at 29880 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 29880 <at> debbugs.gnu.org
Subject: Re: [bug#29880] [PATCH] gnu: grep: Add PCRE support.
Date: Mon, 08 Jan 2018 17:28:53 +0100

Ludovic Courtès writes:

> Hi Oleg,
>
> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> This patch allows to grep with perl regular expression.
>>
>> From db4fe96c7c6c0fcaa82e1131aba157c5d5e5f537 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust <at> gmail.com>
>> Date: Thu, 28 Dec 2017 22:12:13 +0300
>> Subject: [PATCH] gnu: grep: Add PCRE support.
>>
>> * gnu/packages/base.scm (grep)[inputs]: New field.
>
> This would be for the next ‘core-updates’.  Did you try a full rebuild?
>
> I’m mildly wary of this change because PCRE is a non-trivial piece of
> software that increases the attack surface, and we’d end up grafting
> things potentially often.  For instance, right now I get:
>
>   $ guix lint pcre
>   gnu/packages/pcre.scm:77:2: pcre <at> 8.41: probably vulnerable to CVE-2017-11164
>
> Would it make sense to instead have a separate “grep-pcre”?
>
> What do people think?

I have been maintaining a separate package for grep with PCRE support
for the users on our cluster.  What I would like to add is that at least
Debian and RedHat enable PCRE in their grep versions.  So using Guix's
grep broke some scripts.

If compatibility with other GNU/Linux distributions counts for anything,
I'd say we should enable it.  I am in favor of enabling PCRE.

We could provide a separate version of grep without PCRE as a
grep-minimal.

Thanks for your time!

Kind regards,
Roel Janssen

Message #14 received at 29880 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 29880 <at> debbugs.gnu.org
Subject: Re: [bug#29880] [PATCH] gnu: grep: Add PCRE support.
Date: Tue, 09 Jan 2018 09:54:56 +0100

Hello,

Roel Janssen <roel <at> gnu.org> skribis:

> I have been maintaining a separate package for grep with PCRE support
> for the users on our cluster.  What I would like to add is that at least
> Debian and RedHat enable PCRE in their grep versions.  So using Guix's
> grep broke some scripts.
>
> If compatibility with other GNU/Linux distributions counts for anything,
> I'd say we should enable it.  I am in favor of enabling PCRE.

OK, that makes sense.

> We could provide a separate version of grep without PCRE as a
> grep-minimal.

Alternately, what we could do is:

  1. Keep ‘grep-final’ as it is right now (without PCRE support; this
     has never been a problem so far.)

  2. Add PCRE to ‘grep’ itself (like Oleg did).

Thoughts?

Ludo’.

Message #17 received at 29880 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 29880 <at> debbugs.gnu.org
Subject: Re: [bug#29880] [PATCH] gnu: grep: Add PCRE support.
Date: Tue, 09 Jan 2018 12:23:09 +0100

Ludovic Courtès writes:

> Hello,
>
> Roel Janssen <roel <at> gnu.org> skribis:
>
>> I have been maintaining a separate package for grep with PCRE support
>> for the users on our cluster.  What I would like to add is that at least
>> Debian and RedHat enable PCRE in their grep versions.  So using Guix's
>> grep broke some scripts.
>>
>> If compatibility with other GNU/Linux distributions counts for anything,
>> I'd say we should enable it.  I am in favor of enabling PCRE.
>
> OK, that makes sense.
>
>> We could provide a separate version of grep without PCRE as a
>> grep-minimal.
>
> Alternately, what we could do is:
>
>   1. Keep ‘grep-final’ as it is right now (without PCRE support; this
>      has never been a problem so far.)
>
>   2. Add PCRE to ‘grep’ itself (like Oleg did).
>
> Thoughts?

Yes that seems fine to me.

Kind regards,
Roel Janssen

Message #22 received at 29880-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 29880-done <at> debbugs.gnu.org
Subject: Re: [bug#29880] [PATCH] gnu: grep: Add PCRE support.
Date: Thu, 11 Jan 2018 22:50:12 +0100

Hi,

Roel Janssen <roel <at> gnu.org> skribis:

> Ludovic Courtès writes:

[...]

>> Alternately, what we could do is:
>>
>>   1. Keep ‘grep-final’ as it is right now (without PCRE support; this
>>      has never been a problem so far.)
>>
>>   2. Add PCRE to ‘grep’ itself (like Oleg did).
>>
>> Thoughts?
>
> Yes that seems fine to me.

Done in 20bf5fce7dbdc754a6c430abbeb50fb0662bda38.

Thanks!

Ludo'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.