From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 26 05:43:51 2017 Received: (at submit) by debbugs.gnu.org; 26 Dec 2017 10:43:51 +0000 Received: from localhost ([127.0.0.1]:52306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eTmi7-0007V5-CT for submit@debbugs.gnu.org; Tue, 26 Dec 2017 05:43:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eTmi5-0007Ut-3e for submit@debbugs.gnu.org; Tue, 26 Dec 2017 05:43:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eTmhy-00087m-O9 for submit@debbugs.gnu.org; Tue, 26 Dec 2017 05:43:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eTmhy-00087Y-KR for submit@debbugs.gnu.org; Tue, 26 Dec 2017 05:43:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eTmhx-0006gU-4y for bug-gnu-emacs@gnu.org; Tue, 26 Dec 2017 05:43:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eTmhu-00084w-1c for bug-gnu-emacs@gnu.org; Tue, 26 Dec 2017 05:43:41 -0500 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:38720) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eTmht-00084Z-Qz for bug-gnu-emacs@gnu.org; Tue, 26 Dec 2017 05:43:37 -0500 Received: by mail-wm0-x230.google.com with SMTP id 64so34411566wme.3 for ; Tue, 26 Dec 2017 02:43:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=YjdVH5DKmtjBbfiqJDmAfR5LXkMYmL7kuaiIQzuQ+Zw=; b=YeyA7jZET6KUk8Bm6ujm+mmcbvrH2L0aNVpESVzY9hhevIcJLA6yM5x5AlB/QD8470 nybgvrgmVVrgrgAVZh2zFvI5dtGeRR4IWlqin3UdZmEG9tydx7065I/2o3E2Ib7DxQuA uX1XflisA41CFhNnXQs0kLzLMP/T4fdI/K9yDOTkjyIFeOSO+dTbNzWytQgHY37dnUP7 hSJZAI2fdQrOJghvty3RJeUKZTQeTuS1DRU33oR9tV6wdCklrqBgTdFpb6k5E41c03OC EF0XwnX2Uj4nzN2NMqDDJ1EpAdkgdgkD4rtOc6mbJBM8Cvd2TSyVnThBAV3QhiFq6DA1 lW7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=YjdVH5DKmtjBbfiqJDmAfR5LXkMYmL7kuaiIQzuQ+Zw=; b=fDA1AurUuGhv2v+G1JSkX3P3cHR4V1aO8U6GHG3LSf8TsMnJv0cK5bJBfFeTJCn+aI zV/47XrBfHC+ybdwx0W4mnUsIBgEOjLoCk/W1iG8KImBzBhhrnYIPWji4oPrfNAyvo4i ohlhH+xXpsmL1RnxgII2hh/v45/e6SrOB2E91LRoahi3geqMEHmiMTXqR9YYyInDQFPd t9CjXaHg87VAKLxXahZCKGyyVHKOYMmAn6mKJNDOtOO+CIinadYL8iXQ0CQTyMaKQ8oE jVoT++7ZBOGpU4QuhWGnNVOCl8cUOHgE3ODD2ZZ9n8BTA8P5HixJnAYBS9NKV3GphYXF aXlA== X-Gm-Message-State: AKGB3mIhQ+wev+kg02O5UkmrLFzmwwhstKeKqmmvFZaLsopOvt+p2PLW 8NErZWbzuKMYpMv0OnJHFVGkvQ== X-Google-Smtp-Source: ACJfBovGlezD8QktZa6fsbk7sCkuunLZSjs8EIm7/ysyp7tz+bZBRyBd77cZk4tQEsGiwtuCpRabeQ== X-Received: by 10.28.92.146 with SMTP id q140mr22823471wmb.41.1514285016447; Tue, 26 Dec 2017 02:43:36 -0800 (PST) Received: from wer17 (192.183.3.93.rev.sfr.net. [93.3.183.192]) by smtp.gmail.com with ESMTPSA id z62sm17859097wrb.67.2017.12.26.02.43.35 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Dec 2017 02:43:35 -0800 (PST) User-agent: mu4e 0.9.18; emacs 25.3.1 From: Pierre Neidhardt To: bug-gnu-emacs@gnu.org Subject: 25.3; Eshell buffer editing gets slower as colored output grows Date: Tue, 26 Dec 2017 11:43:34 +0100 Message-ID: <87vagt6a7d.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) I originally reported this bug on Evil's issue tracker: https://github.com/emacs-evil/evil/issues/1006 The recipe with Evil is as follows: - Start Emacs. - `M-x eshell'. - Insert lots of colored text. On Linux, you can call `dmesg -L=always' a few times. - Go to normal state and press `x' wherever you can delete a character. It should be possible to reproduce without Evil, I just could not figure out a slow operation to replace the last step in the recipe. According to the Evil maintainer, the issue comes from markers left behind. In fact, if I run `clone-buffer', the cloned buffer does not suffer from this issue. I think `clone-buffer' does not copy markers. By the way, is there a way to scan for markers other than `buffer-has-markers-at'? Is there a way to remove them? In GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.26) of 2017-12-04 built on arojas Windowing system distributor 'The X.Org Foundation', version 11.0.11905000 System Description: Arch Linux Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix <#secure method=pgpmime mode=sign> -- Pierre Neidhardt You will gain money by an immoral action. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 31 21:08:06 2017 Received: (at 29854) by debbugs.gnu.org; 1 Jan 2018 02:08:06 +0000 Received: from localhost ([127.0.0.1]:59139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eVpWI-0003GZ-3d for submit@debbugs.gnu.org; Sun, 31 Dec 2017 21:08:06 -0500 Received: from mail-it0-f44.google.com ([209.85.214.44]:46653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eVpWG-0003G2-FR for 29854@debbugs.gnu.org; Sun, 31 Dec 2017 21:08:04 -0500 Received: by mail-it0-f44.google.com with SMTP id c16so11627759itc.5 for <29854@debbugs.gnu.org>; Sun, 31 Dec 2017 18:08:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=B/6vBDzY2z/FfrafNV4hXJ3oCetI2icJSug8JNWyHqo=; b=P10416oiLF6yX3PNE1JYI+ZlPuHQPwstRBRIKNVnnH3oP2d1EFpB3g1ljLFrkOvJHU PwDcbgq4vuTv/NkgIPB55PSCUvv4Q5qNSMPQHOqSt0EL3bNjJqOHe/bN07JJualrrMx/ cpYbNN+lWHYSZ4K/04I6xXPFBaXA28gz2Yhh0Rp55bIcmfro0vtlhc91F9NaPk2DJu+o rA237BjuPapnYNrxNMQ864g9WrERvPlNxNF0vy+oUrZM2YQkyqi2e+RKJtxN+SjECYOb PQpyz6iQtdAkYH8QDDPRyTlZ6TXrnTF+2dzdpjP6ue5TWBesKFEgt8M6JyJqNQ1zvUr+ Vj4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=B/6vBDzY2z/FfrafNV4hXJ3oCetI2icJSug8JNWyHqo=; b=RUUgO18ilYwHpbDZil54sF9A3e4CcIpTl/X2BctBJTT2lqllYippA/QsHT8PnkdhS1 kYQd7iy5Ss7VhWKjkv7SCxC0KiGRbcFMHlMQWG99n9kt9qIOf/1r2zfYzyNLlrvoWMig OaNjdLppI8RHsKv9en25ocXzShLWJO8O5hYv8zxV9C4JGtvCUEfa853fI3IEtsn5v9ox LNafXUgrHOkSLtXirpF0lsUFRiWRWg/soRLNdOEI8vlVHkLXo1cxOTDJeBIq7iHmiLlU W69ufcm7eKTjcJcFdq2kH40/bzmOwSSzNqxI86tQZsiAmO+vsseZtHn7iw/TQDdm2pJK jFYg== X-Gm-Message-State: AKGB3mKWrR7CMk8nqXjPHEwDUHzM69ehC7ERxAT1+n284vtI/l1cli8b erud7Z60dBDUbQ1SmDHKcIoC+g== X-Google-Smtp-Source: ACJfBos4bp/0o1GisvB0tUzC7O2V9lzVnHS60y2cZ5RoAC7iDBYf/DYNw/vVBjDDxghSFBD0c8HDkw== X-Received: by 10.36.249.134 with SMTP id l128mr55453799ith.12.1514772478786; Sun, 31 Dec 2017 18:07:58 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 140sm3983183itx.3.2017.12.31.18.07.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 31 Dec 2017 18:07:57 -0800 (PST) From: Noam Postavsky To: Pierre Neidhardt Subject: Re: bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows References: <87vagt6a7d.fsf@gmail.com> Date: Sun, 31 Dec 2017 21:07:55 -0500 In-Reply-To: <87vagt6a7d.fsf@gmail.com> (Pierre Neidhardt's message of "Tue, 26 Dec 2017 11:43:34 +0100") Message-ID: <87mv1ytjpg.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29854 Cc: 29854@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Pierre Neidhardt writes: > The recipe with Evil is as follows: > > - Start Emacs. > > - `M-x eshell'. > > - Insert lots of colored text. On Linux, you can call `dmesg -L=always' a few times. > > - Go to normal state and press `x' wherever you can delete a character. > > It should be possible to reproduce without Evil, I just could not figure > out a slow operation to replace the last step in the recipe. > > According to the Evil maintainer, the issue comes from markers left > behind. So does this fix it? --- i/lisp/ansi-color.el +++ w/lisp/ansi-color.el @@ -417,3 +417,7 @@ ansi-color-apply-on-region start-marker end-marker (ansi-color--find-face codes)) - (setq ansi-color-context-region (if codes (list codes))))))) + (setq ansi-color-context-region (if codes (list codes))))) + ;; Clean up our temporary markers. + (unless (eq start-marker (cadr ansi-color-context-region)) + (set-marker start-marker nil)) + (set-marker end-marker nil))) Also, I wonder if doing this would help also? (setq ansi-color-apply-face-function (lambda (beg end face) (when face (put-text-property beg end 'face face)))) That should make Emacs use text properties instead of overlays for the colored text. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 02 07:40:09 2018 Received: (at 29854) by debbugs.gnu.org; 2 Jan 2018 12:40:09 +0000 Received: from localhost ([127.0.0.1]:60582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWLrU-0004HL-Kz for submit@debbugs.gnu.org; Tue, 02 Jan 2018 07:40:09 -0500 Received: from mail-ot0-f181.google.com ([74.125.82.181]:35025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWLrS-0004Gn-8F for 29854@debbugs.gnu.org; Tue, 02 Jan 2018 07:40:06 -0500 Received: by mail-ot0-f181.google.com with SMTP id q5so21100946oth.2 for <29854@debbugs.gnu.org>; Tue, 02 Jan 2018 04:40:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=17ArDJth7CO7HQeA3ybZVQMETkWkZ5H55MEI1fa+iwk=; b=O4MntZ3GgJ31HmJN+O3pYVH6xl/wuAQgX5yP0iAIl+3JDD3qcY+inJqfPSL6AOqxxb qRPuXjYvBHDePsOI2KstF2N975R/tHiqz80tergcf/7n+IAE2k6F5NVO8fjHHDJ9xxuo 9WsVR88fResR+l1bcxSz7P35GkKC7Nmpe/v31koFIvV53NLyBEqRhy9/b21xP9UgtMXm mxnjN+QIkE2Nuo7BHDlwHucM1wZk/sboegd3/sX9ed70KuY6FeJSqC//889tEX/4K162 w9O8hBgPW76C0BT6YXYoZmyfY/YMz1aM7bZW+U/nl5vHCfCvoSMHjbrnnosNrlbTzaqN /Gfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=17ArDJth7CO7HQeA3ybZVQMETkWkZ5H55MEI1fa+iwk=; b=j3zJnXBmdGE7EbEyvWEBMOMHbaCssv7fYu1DcHlwsTPlTp51eZubRmNYiiPvqzbNZ2 ZcwAL21n9VX1LJeiCB+pZasx7WCi1cUS501fhKqfZf9m1Adxke5bnnCxS6N53Q6Orwto YOKngdRZEUs5jqXpZ+5xcACaUEwbh0X4s4X5SpSEUE61XasVAc0VyPiG51w/4KPrr1US 828Uo2He3EoT2kRc0ooootrYCYhVbJPBW8QcVNDMG6yLP1LBEkgvG3eSNTfdSzyZ/1FX piqJxJCigYk2jIVmORP/eaJmOKBsyUyNlVgdWKmnq4/SablyCETauvJFrBNXpu5c4TS7 kolg== X-Gm-Message-State: AKGB3mI5jNuQUX8+nu+Q8PYL7U9jpqUErB7gyEV34FDqRgAK/x8KBP5L p2TjZsqlOaKRXKfvFHE8UQDrD4wNoNyAgAJl5lw= X-Google-Smtp-Source: ACJfBot43nZu6pfBTxYKdWf9dN99/Q7xozpo4vMscdrqVV+fdsnyvSKgBE6G15syRulUMTk83SNRy/MGUF4x+q/f4Rw= X-Received: by 10.157.39.21 with SMTP id r21mr33001394ota.127.1514896800402; Tue, 02 Jan 2018 04:40:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.44.35 with HTTP; Tue, 2 Jan 2018 04:40:00 -0800 (PST) In-Reply-To: <87mv1ytjpg.fsf@users.sourceforge.net> References: <87vagt6a7d.fsf@gmail.com> <87mv1ytjpg.fsf@users.sourceforge.net> From: Pierre Neidhardt Date: Tue, 2 Jan 2018 13:40:00 +0100 Message-ID: Subject: Re: bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows To: Noam Postavsky Content-Type: multipart/alternative; boundary="001a113730c8a8d3670561ca659f" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29854 Cc: 29854@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --001a113730c8a8d3670561ca659f Content-Type: text/plain; charset="UTF-8" The patch does not seem to do it. Unless load order matters? The redifinition of `ansi-color-apply-face-function` works however, plus it comes at the bonus of making Eshell an order of magnitude faster! I haven't tested estensively yet, but it seems to be a much better default. On Mon, Jan 1, 2018 at 3:07 AM, Noam Postavsky < npostavs@users.sourceforge.net> wrote: > Pierre Neidhardt writes: > > > The recipe with Evil is as follows: > > > > - Start Emacs. > > > > - `M-x eshell'. > > > > - Insert lots of colored text. On Linux, you can call `dmesg -L=always' > a few times. > > > > - Go to normal state and press `x' wherever you can delete a character. > > > > It should be possible to reproduce without Evil, I just could not figure > > out a slow operation to replace the last step in the recipe. > > > > According to the Evil maintainer, the issue comes from markers left > > behind. > > So does this fix it? > > --- i/lisp/ansi-color.el > +++ w/lisp/ansi-color.el > @@ -417,3 +417,7 @@ ansi-color-apply-on-region > start-marker end-marker (ansi-color--find-face codes)) > - (setq ansi-color-context-region (if codes (list codes))))))) > + (setq ansi-color-context-region (if codes (list codes))))) > + ;; Clean up our temporary markers. > + (unless (eq start-marker (cadr ansi-color-context-region)) > + (set-marker start-marker nil)) > + (set-marker end-marker nil))) > > Also, I wonder if doing this would help also? > > (setq > ansi-color-apply-face-function > (lambda (beg end face) > (when face > (put-text-property beg end 'face face)))) > > That should make Emacs use text properties instead of overlays for the > colored text. > --001a113730c8a8d3670561ca659f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The patch does not seem to do it.=C2=A0 Unless load order = matters?

The redifinition of `ansi-color-apply-face-func= tion` works however, plus it comes at the bonus of making Eshell an order o= f magnitude faster!
I haven't tested estensively yet, but it = seems to be a much better default.
On Mon, Jan 1, 2018 at 3:07 AM, Noam Postavsky= <npostavs@users.sourceforge.net> wrote:
Pierre Neidhardt <ambrevar@gmail.com> writes:

> The recipe with Evil is as follows:
>
> - Start Emacs.
>
> - `M-x eshell'.
>
> - Insert lots of colored text. On Linux, you can call `dmesg -L=3Dalwa= ys' a few times.
>
> - Go to normal state and press `x' wherever you can delete a chara= cter.
>
> It should be possible to reproduce without Evil, I just could not figu= re
> out a slow operation to replace the last step in the recipe.
>
> According to the Evil maintainer, the issue comes from markers left > behind.

So does this fix it?

--- i/lisp/ansi-color.el
+++ w/lisp/ansi-color.el
@@ -417,3 +417,7 @@ ansi-color-apply-on-region
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0start-marker = end-marker (ansi-color--find-face codes))
-=C2=A0 =C2=A0 =C2=A0 =C2=A0(setq ansi-color-context-region (if codes (list= codes)))))))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(setq ansi-color-context-region (if codes (list= codes)))))
+=C2=A0 =C2=A0 ;; Clean up our temporary markers.
+=C2=A0 =C2=A0 (unless (eq start-marker (cadr ansi-color-context-region)) +=C2=A0 =C2=A0 =C2=A0 (set-marker start-marker nil))
+=C2=A0 =C2=A0 (set-marker end-marker nil)))

Also, I wonder if doing this would help also?

=C2=A0 =C2=A0 (setq
=C2=A0 =C2=A0 =C2=A0ansi-color-apply-face-function
=C2=A0 =C2=A0 =C2=A0(lambda (beg end face)
=C2=A0 =C2=A0 =C2=A0 =C2=A0(when face
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(put-text-property beg end 'face face= ))))

That should make Emacs use text properties instead of overlays for the
colored text.

--001a113730c8a8d3670561ca659f-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 02 08:51:01 2018 Received: (at 29854) by debbugs.gnu.org; 2 Jan 2018 13:51:01 +0000 Received: from localhost ([127.0.0.1]:60605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWMy5-0005sB-6I for submit@debbugs.gnu.org; Tue, 02 Jan 2018 08:51:01 -0500 Received: from mail-it0-f53.google.com ([209.85.214.53]:46715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWMy3-0005rx-6h for 29854@debbugs.gnu.org; Tue, 02 Jan 2018 08:50:59 -0500 Received: by mail-it0-f53.google.com with SMTP id c16so14638704itc.5 for <29854@debbugs.gnu.org>; Tue, 02 Jan 2018 05:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=xBvM9YW/K7uazyEOJU/ei0HQgxdZLbI6oME+v2Avjtk=; b=j9DAM6SU0/KgjTDCTjZFhzUZizYPofR8kYPYAUeOBwTkqI9mTuFs2eihS5d/Ffydje qRqVTEBBb0a5bw4Ic+Ck3wBCOEQ49Exv9K1YTFbm9q8TkzF885tFGVC+DUofGWsudiMP cLSyeLOXNF8sedV1Kj4UGb1M48+oaU4eBAQ2LZtD4wBfEiGIoks+QnZhFmI84plL7Rec BHcRRSXY7GvhroOuO0klpB9oRWG9aT9mXkylOuMmea92JJRVvVuC4B02r5HZNbO4Jwgj 7TO0E2YTZA4XIXxKMYr3ULznYqUxxibm2X8ITaQzWZWneVLCHPlC5ryJ0oTC3115svkF Mvrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=xBvM9YW/K7uazyEOJU/ei0HQgxdZLbI6oME+v2Avjtk=; b=ZFvAC/U6BSkbr0wNhbDFtLF4jyQcfOq2GtVzRxX6w+FInxhiwWfl8c/dz0tRdXKXpv lGVCVLa7qprW06NoGk2KqhF1rAEKMn3W32OgcrWIJ4KaD2VaFrZ6K6EBSTYL8VUsd2eU I6cvr+fld1URpwAlO6TijdF1zF8d0kjXdRz05DdDswUWKoOl1BVZOp3NErt9Ba1jLeER KBPo2aFj54y8wNg8u6UgmB1866b7daI2XqHd5RaHWf5hcgAwpXShEa5ESwID0eIqNXOM b8atwCci3leCJO1x9R0rjt8Qzc/1OPYRLZXR0QeqP+bv+5WBlnvg6JWntpl76Aj2+/U3 BAIg== X-Gm-Message-State: AKGB3mK6+g9X+SdjRXhoHDsFgfH94CTfVPTWpi0dTfVby5VD/JFz6KVV lN4HLR9URNGLvMnaFvDQk1Qihg== X-Google-Smtp-Source: ACJfBoslnGC1mGBdNQFRb+Sr5vAHgMYtk7x28PRt59VMU2Q5vVPVFAWvH5hwsGE2i6ngW0K5MLBWtA== X-Received: by 10.36.9.133 with SMTP id 127mr63524377itm.69.1514901053405; Tue, 02 Jan 2018 05:50:53 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 72sm4692552itg.0.2018.01.02.05.50.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jan 2018 05:50:52 -0800 (PST) From: Noam Postavsky To: Pierre Neidhardt Subject: Re: bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows References: <87vagt6a7d.fsf@gmail.com> <87mv1ytjpg.fsf@users.sourceforge.net> Date: Tue, 02 Jan 2018 08:50:51 -0500 In-Reply-To: (Pierre Neidhardt's message of "Tue, 2 Jan 2018 13:40:00 +0100") Message-ID: <87r2r8s72c.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 29854 Cc: 29854@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Pierre Neidhardt writes: > The patch does not seem to do it.=C2=A0 Unless load order matters? Load order should not matter. > The redifinition of `ansi-color-apply-face-function` works however, > plus it comes at the bonus of making Eshell an order of magnitude > faster! > I haven't tested estensively yet, but it seems to be a much better > default. Aha, maybe it's not a question of markers, but rather another case of Bug#26051 "overlays may make emacs very slow". (anyway, ansi-color-apply-to-region doesn't set markers per colour boundary; it's just 1 or 2 markers per call (eshell calls it once per ~4096 bytes)) The question is then whether there is some case where using overlays is necessary, or is it just a pessimization? For reference, I took the text property using definition from man.el (so it at least works for that case): (defun Man-fontify-manpage () [...] (let ((ansi-color-apply-face-function (lambda (beg end face) (when face (put-text-property beg end 'face face)))) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 03 06:46:40 2018 Received: (at 29854) by debbugs.gnu.org; 3 Jan 2018 11:46:40 +0000 Received: from localhost ([127.0.0.1]:33839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWhVH-0002FQ-PP for submit@debbugs.gnu.org; Wed, 03 Jan 2018 06:46:39 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWhVF-0002FB-Uq for 29854@debbugs.gnu.org; Wed, 03 Jan 2018 06:46:38 -0500 Received: by mail-wm0-f68.google.com with SMTP id b76so2241394wmg.1 for <29854@debbugs.gnu.org>; Wed, 03 Jan 2018 03:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=Om5nXWtSOr6+YzrQHEHUbihopprD0i0UfQUAGmUbSyU=; b=uSsDs39FVTfwib2hlLOIcmrBrTNNO7t13eusNZV0biyTfW88uQ4rigC1LoX5Ig0Jot yeB/d3xbCwmwKdkQG/oYGr5woc7k8z5e5IVuvfTyxz++MAWMtRcSHNBg7DCrBW2MtR3p B9wdEM4gk0trzSwEFD9kemoH3kQ3TtJcGKBbKYrCKIWPYEElS/OSuf3YOrdO/wqbFMdO /p/XwQGvWLzh+28MRT02EzawFr1UHHFrAU0FqZCxNgffl2KkRmrW8Rw0gwIhaVJlQvnU KVuTvaY0wLrPzdW2l62/+OgIrd0MTnWQ4LVQaD4eDG89GXGLuRb4u5AEjesKWIqfrfZ5 ykgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=Om5nXWtSOr6+YzrQHEHUbihopprD0i0UfQUAGmUbSyU=; b=duvxZCt4vSsGpuAyy/hW/7vrz9VwMwStjtTVFUz/ild4OssMXCGX8WeSkW3xfgRMya 4o9HOUbGGXJ2ElA9PgOuJAPnONF+Hs6N0P/n6xtYWAlnhXy2mvbB568XrF5OaCglqc1t /bqlPMu1lXoKt4BwML+BT9qigAW6aXgyah6GVOAQMAxlWpIKW99VFK/kKCdy3sKpiRzC 5pW/TDDGLzbpvSuItev4OisWe1uSEBFS9HIRpFyY+S6xGlmu1/J4c4HtzmromxVYnGDt hacOWolLFb6P6DFoZ3dnPtTzOwkyCquh3y8WRUkkcCKrkvzkJW0p0xNDc2nnvTMApGU3 70mA== X-Gm-Message-State: AKGB3mLmG6c1ykEuypwK41PDhFwiaebqQdXrDKyVkp0XODrp4vfNekJj fU3w/vfVb9pPFk5x67BoxNUrDrdOS6Q= X-Google-Smtp-Source: ACJfBoshji7j4l9u6YcFvHtWpgH/Jt/m+Zf1crCEL6Hv5CQvGCvbHdCcGS0bwl0C03u+5CmgE5MTdg== X-Received: by 10.80.136.124 with SMTP id c57mr2241028edc.191.1514979991876; Wed, 03 Jan 2018 03:46:31 -0800 (PST) Received: from wer17 ([2001:1c00:1503:bc00:226:c6ff:fe79:3936]) by smtp.gmail.com with ESMTPSA id x5sm627857eda.8.2018.01.03.03.46.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jan 2018 03:46:30 -0800 (PST) References: <87vagt6a7d.fsf@gmail.com> <87mv1ytjpg.fsf@users.sourceforge.net> <87r2r8s72c.fsf@users.sourceforge.net> User-agent: mu4e 0.9.18; emacs 25.3.1 From: Pierre Neidhardt To: Noam Postavsky Subject: Re: bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows In-reply-to: <87r2r8s72c.fsf@users.sourceforge.net> Date: Wed, 03 Jan 2018 12:46:26 +0100 Message-ID: <87tvw3cgh9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29854 Cc: 29854@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > The question is then whether there is some case where using overlays is > necessary, or is it just a pessimization? For reference, I took the > text property using definition from man.el (so it at least works for > that case): Any idea what the original intent was? I can't seem to see why an overlay would be needed for Eshell's output. =2D-=20 Pierre Neidhardt Abstainer, n.: A weak person who yields to the temptation of denying himself a pleasure. -- Ambrose Bierce, "The Devil's Dictionary" --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlpMwpIACgkQm9z0l6S7 zH+a/ggAl6VZuMEj7Hmg3DKu2RpNear5URFg7WYYBr2ENy6QJROKojDj/HJ4GOF7 BDeM2Bl/7NUXx4dhVSQ3maoaEgl/WNYCm1hUqElLEhsuNPt6ROl14wEbm7ZnGNeb BmnAS3DVSztHFLuNIzzrY4mo81UT1kQDuFamR9gFdQUjo/Pz0Bhyy2LV6WgilGFZ PfeoVw2l50d+gg0ob+Mwe5gt0Aff/ar5lHxYaaX8Km6r1pu+tqRzHrwrY/e5YrHz X58m2LeA9W8hvt+VSmR6c/RvFg3A0DlAy+R9aJHADNFMo1hQwvfplitrGi64GawI xMmZ4FQz7tn3NkMxzJELYhklccwZ3A== =vliw -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 03 08:34:04 2018 Received: (at 29854) by debbugs.gnu.org; 3 Jan 2018 13:34:05 +0000 Received: from localhost ([127.0.0.1]:33877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWjBE-0006nF-M1 for submit@debbugs.gnu.org; Wed, 03 Jan 2018 08:34:04 -0500 Received: from mail-io0-f179.google.com ([209.85.223.179]:45566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWjBC-0006ml-Gm for 29854@debbugs.gnu.org; Wed, 03 Jan 2018 08:34:03 -0500 Received: by mail-io0-f179.google.com with SMTP id e20so2065301iof.12 for <29854@debbugs.gnu.org>; Wed, 03 Jan 2018 05:34:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GHiCVY2yUxiqm8nTWhxL3Rx1cUY51O8qBZzwkiX7s6M=; b=ED9jr5X3yv2VI5VXh2fHYPoMhJEVNsFZNqtQc1qeMDpQ0Z1OuS7asJmK/BYw/aTRNl T4IeC/nxCHVT7ykLuK80Be6aDH68qkBnVT5q4ETHcTUxN2zSl68zLJ5/bohuIfKoC2ze HPmfQhXsjE8d2KF6EvP0PbEEt+M2JoqPi5ZCSxe9AjtwL8qzEk2VbG11RejdVPEsoA0R OK9Nue1Yy5o0b3MoLup7NqSyokWhoWYpq/CzUDjV+kQJtSZQZP5urQ/n3XeF6peb6GWf AH/Nr2Xjqtwrxtzxn90/LAxmJwdsIV3XaZ7rx/bcXUrMbMiV/1ovA5yQZjd69eg/qPZE WV0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=GHiCVY2yUxiqm8nTWhxL3Rx1cUY51O8qBZzwkiX7s6M=; b=Zs7e1sR0exvh9tikenry/foJ0v6aIZ/OEwkb4mQ8j+PNThgXB/e34lB2gNE0iMDGWU sEGnF7AlsGvqp2yhgr619AcnSFmTM2oSRx5lBEs3I0d4R2nV0yLjfEoSzDoJ3sRX61Iy i2ClALTfdzMrGZSowqJbKHF/fxH7l7uo5gLPaI0GfV/xUycRqzcG29tf4k6kRttJrGrd U89fnsy+ocT463ZnsU7Fag1ZTGRjgKpbBTW2+l2oebQa0OznGnK4bQ7t2tUG9zwBPi2u g3xbschh2Bf+usH9h6DkSUa2NVxNTUkMUSR2CiRVO+p0TyE+aLvJ4tNiM3LPsHvUVCWh ZxpQ== X-Gm-Message-State: AKGB3mKy87sEczyE0OxzbLZ0+3LIT5MZ00nbkOwBaTnPpnLWqRGNOH/Q 3g3M/iwKnNq5tIzBrwOL3lJRkg== X-Google-Smtp-Source: ACJfBotuf0lXcZJxIlyXQsWvp1Wtfcar8HX34b1aBEF1CMzTYjnI4HW6hlr1Lh/pAmN6novnLiDbMQ== X-Received: by 10.107.141.213 with SMTP id p204mr1392639iod.271.1514986436617; Wed, 03 Jan 2018 05:33:56 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o71sm775127itb.28.2018.01.03.05.33.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jan 2018 05:33:55 -0800 (PST) From: Noam Postavsky To: Pierre Neidhardt Subject: Re: bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows References: <87vagt6a7d.fsf@gmail.com> <87mv1ytjpg.fsf@users.sourceforge.net> <87r2r8s72c.fsf@users.sourceforge.net> <87tvw3cgh9.fsf@gmail.com> Date: Wed, 03 Jan 2018 08:33:53 -0500 In-Reply-To: <87tvw3cgh9.fsf@gmail.com> (Pierre Neidhardt's message of "Wed, 03 Jan 2018 12:46:26 +0100") Message-ID: <87incjrrr2.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29854 Cc: 29854@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Pierre Neidhardt writes: >> The question is then whether there is some case where using overlays is >> necessary, or is it just a pessimization? For reference, I took the >> text property using definition from man.el (so it at least works for >> that case): > > Any idea what the original intent was? > I can't seem to see why an overlay would be needed for Eshell's output. Hard to say. It might just be a case of going with ansi-color.el's default. ansi-color-apply-on-region was changed to use overlays in [1: 0e3c1e3ea6], but it's unclear why. The commit message just says (ansi-color-apply-on-region): Use extents or overlays instead of text-properties. [1: 0e3c1e3ea6]: 2001-01-09 11:38:28 +0000 (ansi-color-process-output): Use markers instead of positions for start and end of region.[...] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0e3c1e3ea6a27e20d0252661336afe9fc84b21f5 From debbugs-submit-bounces@debbugs.gnu.org Sat May 04 15:49:29 2019 Received: (at 29854) by debbugs.gnu.org; 4 May 2019 19:49:29 +0000 Received: from localhost ([127.0.0.1]:52360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN0f3-0000vV-Bz for submit@debbugs.gnu.org; Sat, 04 May 2019 15:49:29 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:43891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN0f1-0000vA-HO; Sat, 04 May 2019 15:49:28 -0400 Received: by mail-qt1-f195.google.com with SMTP id r3so672911qtp.10; Sat, 04 May 2019 12:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TUhgPmV6FsWRylyh0H5eJ1yfg5eARM480EGwQYLSzHM=; b=NQSY8IBPhWHpIV4rajxmgA4VnGQGnIQB/LFo8sTo2RSvXSPSP7OyDRlOKclmqi45IW mOsd8uXLkDq+v/fpD4ONTMHThZqhE534mA7vr9IxQ6gdlZJBLa+Ajl/QeJVEGeDGtoxQ YBwSQBd45bIQAmpGxUZLVWB5RDShk4ZQNNxjTQf/IisCwRWIT7sqpktowAbyn2hw3xzX +cyuLQWOi5dEaxUW4MadtSi3NGWMG/ivHqCBYf1U1elLK0HHudCVF+PTts0U5mTQqaJ6 045BYZmbyjUiMkUu8WlxYXbO60VesOlUBzc8pZzy+HcmZ/gk4ZnVwfUqBVSfQPXc/3YB WnXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TUhgPmV6FsWRylyh0H5eJ1yfg5eARM480EGwQYLSzHM=; b=oD0sHdpfsIMBDOnFSNB1KA2GKjNgPFpAq4bfko9Vjcb0DZthVajBXhvObdgJnUlHYL eHI8erzoFJ18OJfIS6yhR+JP4TwMqYUPgoFfJ6HyiZwyX6N9fJQ39e1NAl1qech2KFYz fy6kfyyyLKxCxZYelg+oVg8bsLsOtwocvM3zUJmLIKaAvqPHpAb8rkZ6DUxkisC/eMse rvzrygJyOpDx+U+71jSW8eligz4G6D89MPmNJ36RtYrU9QdMWalDu8Rdg3xdWO0i+/DC I7wMV4rKo6QiKfks46KWma7Mna1qb79myTB6Z2HRIWHergIKN2DiVE9ZbeDSef3s/Ar1 y38w== X-Gm-Message-State: APjAAAXF7MZNFZM3CkoaeBQ0oVcqhXC9JRg1UT25RPxvaRxEwGSforGg PlKcZ6L/3+KbAG+IZADunJXmj5pn X-Google-Smtp-Source: APXvYqzJjuH7Es6ZM7X7b7WyPkyKH1NTnaXLdqrLk8yWnE/77tmnJur7ArWT9ubNog0JceNz9SkywQ== X-Received: by 2002:a0c:9922:: with SMTP id h31mr14036919qvd.137.1556999361688; Sat, 04 May 2019 12:49:21 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n66sm3429413qkc.36.2019.05.04.12.49.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 May 2019 12:49:20 -0700 (PDT) From: Noam Postavsky To: Noam Postavsky Subject: Re: bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows References: <87vagt6a7d.fsf@gmail.com> <87mv1ytjpg.fsf@users.sourceforge.net> <87r2r8s72c.fsf@users.sourceforge.net> <87tvw3cgh9.fsf@gmail.com> <87incjrrr2.fsf@users.sourceforge.net> Date: Sat, 04 May 2019 15:49:19 -0400 In-Reply-To: <87incjrrr2.fsf@users.sourceforge.net> (Noam Postavsky's message of "Wed, 03 Jan 2018 08:33:53 -0500") Message-ID: <87sgtum24g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29854 Cc: 29854@debbugs.gnu.org, Pierre Neidhardt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 29854 fixed close 29854 27.1 quit Noam Postavsky writes: > Pierre Neidhardt writes: > >>> The question is then whether there is some case where using overlays is >>> necessary, or is it just a pessimization? For reference, I took the >>> text property using definition from man.el (so it at least works for >>> that case): >> >> Any idea what the original intent was? >> I can't seem to see why an overlay would be needed for Eshell's output. > > Hard to say. It might just be a case of going with ansi-color.el's > default. ansi-color-apply-on-region was changed to use overlays in [1: > 0e3c1e3ea6], but it's unclear why. The commit message just says > > (ansi-color-apply-on-region): Use extents or overlays instead of > text-properties. I've changed to use text properties (but font-lock-face rather than face) in master. We'll see if it causes trouble. 4fd9048e94 2019-05-04T15:33:20-04:00 "Avoid slow overlay ansi coloring in eshell (Bug#29854)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4fd9048e940d38364caf4abe9b209f9288c78544 From unknown Fri Jun 20 19:52:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Jun 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator