GNU bug report logs - #29842
27.0; `dired-change-marks': args should not be optional

Previous Next

Full log

Message #23 received at 29842 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 29842 <at> debbugs.gnu.org
Subject: Re: bug#29842: 27.0; `dired-change-marks': args should not be optional
Date: Sun, 19 Jan 2020 16:02:45 +0100

close 29842 28.1
thanks

Drew Adams <drew.adams <at> oracle.com> writes:

> Furthermore, the code should perhaps not just call
> `ding' if you hit RET.  Instead of this:
>
>  (if (or (eq old ?\r) (eq new ?\r))
>      (ding)
>   ...)
>
> it should perhaps do something like this:
>
>  (unless (char-displayable-p old)
>    (error "Not a displayable character: `%c'" old))
>  (unless (char-displayable-p new)
>    (error "Not a displayable character: `%c'" new))
>
> The current code predates the existence of
> `char-displayable-p'.
>
> (Yes, that's a different bug, but perhaps it can be
> taken care of in the context of this report.  If not,
> don't worry about it.)

Fixed on master in commit e5e31aab9b.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.