GNU bug report logs - #29842
27.0; `dired-change-marks': args should not be optional

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Sun, 24 Dec 2017 17:59:01 UTC

Severity: minor

Found in version 27.0

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Tino Calancha <tino.calancha <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 29842 <at> debbugs.gnu.org
Subject: bug#29842: 27.0; `dired-change-marks': args should not be optional
Date: Thu, 28 Dec 2017 22:18:06 +0900

Drew Adams <drew.adams <at> oracle.com> writes:

> Furthermore, the code should perhaps not just call
> `ding' if you hit RET.  Instead of this:
>
>  (if (or (eq old ?\r) (eq new ?\r))
>      (ding)
>   ...)
>
> it should perhaps do something like this:
>
>  (unless (char-displayable-p old)
>    (error "Not a displayable character: `%c'" old))
>  (unless (char-displayable-p new)
>    (error "Not a displayable character: `%c'" new))
>
> The current code predates the existence of
> `char-displayable-p'.
The more information the better; just a ding force you to read the
source code to know what was wrong.
Maybe `user-error' instead of `error'?
This bug report was last modified 5 years and 128 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.