From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 24 12:58:22 2017 Received: (at submit) by debbugs.gnu.org; 24 Dec 2017 17:58:22 +0000 Received: from localhost ([127.0.0.1]:50859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eTAXV-0004Hx-RD for submit@debbugs.gnu.org; Sun, 24 Dec 2017 12:58:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eTAXU-0004Hi-Fi for submit@debbugs.gnu.org; Sun, 24 Dec 2017 12:58:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eTAXO-0001Kf-4Y for submit@debbugs.gnu.org; Sun, 24 Dec 2017 12:58:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51101) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eTAXO-0001KC-03 for submit@debbugs.gnu.org; Sun, 24 Dec 2017 12:58:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eTAXM-0000r6-OX for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2017 12:58:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eTAXJ-0001G9-D3 for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2017 12:58:12 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:50042) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eTAXJ-0001ED-4j for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2017 12:58:09 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBOHvK5G141297 for ; Sun, 24 Dec 2017 17:58:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=luZkq3zMOTJYiVWhBjQOWu6VncouGgpEe6oiZ1/oeIc=; b=in4m5b7VQG6WgODIu2kDWPMqoq/qieC60syv0fTQG3jkMhoH11tpR1o8K/8GN1BJttVn 3Oelkv/hgdu46jy88CuVy5Kd29Udl5ZCRrVN+P9pDcGDWw3VMyKnNWONRFGEiklstFfT 00ZHofHyf7jBkWKEioVKQ4YZ38w5sEL3BSE48gTWwbTUGOzDjSIgYRA/HuBahZPADRL/ VzJJo6CL6pxUB6csCfSDjCzrcAv8QIKN+Dzi9e9e2uN8YaqgcK3/a8rKegZ2SX9MJNjM QI/kkfK/NH2pfSMoCQpgZIAS/COX/zs+jeip+vdBCUy0h2KtZZbQB9OmQA1qnBZystLP /A== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2f2gyu806q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 24 Dec 2017 17:58:06 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vBOHw5YG027553 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sun, 24 Dec 2017 17:58:06 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vBOHw313014208 for ; Sun, 24 Dec 2017 17:58:05 GMT MIME-Version: 1.0 Message-ID: Date: Sun, 24 Dec 2017 09:58:02 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 27.0; `dired-change-marks': args should not be optional X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4627.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8755 signatures=668650 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=758 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712240247 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. There is no use of this function in the Emacs Lisp sources that needs to have the args be optional. 2. If (dired-change-marks) is evaluated then you get an error: Debugger entered--Lisp error: (error "Format specifier doesn't match argument type")=20 format("\n%c" "nil") dired-change-marks() eval((dired-change-marks)) This bug is apparently quite old - it is present in Emacs 20, for example. In GNU Emacs 27.0.50 (build 4, x86_64-w64-mingw32) of 2017-12-21 Repository revision: b1cf262a79463f28164ea1c2ffee3c657ce02ea4 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install -C 'CFLAGS=3D-O2 -static -g3' host_alias=3Dx86_64-w64-mingw32 PKG_CONFIG_PATH=3D/mingw64/lib/pkgconfig' From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 24 13:31:04 2017 Received: (at 29842) by debbugs.gnu.org; 24 Dec 2017 18:31:04 +0000 Received: from localhost ([127.0.0.1]:50904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eTB3A-00059K-EP for submit@debbugs.gnu.org; Sun, 24 Dec 2017 13:31:04 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:39618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eTB38-00058p-KT for 29842@debbugs.gnu.org; Sun, 24 Dec 2017 13:31:02 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBOIUZHl067648 for <29842@debbugs.gnu.org>; Sun, 24 Dec 2017 18:30:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=RNAG8FAC+T8dVjV8kE1f3ta4qKM3YLYXpixlmm7knxg=; b=swMJfby6raRQ9wqwqMI+McahgSBMEGnwzDdcuHteH0UxQpyHqsilmm6IcFwVF4uxJBQE Iua56hVIYzDeK7mTXiAGkU/LP1OGeeCDs3Hz7zg1m+1nWwjYeu7kBDSlv/uVuNOPR6B4 oourrh7v7L/r2M04xPQy9Dm54Qr6av2Yw8W+Qv+iEJmbvGDIS5i1t6jk9EEquOGdHPZf On3YEUqzf0w7coPDu4duVBcaCM1D8V2UtYbF7RrW7BDyibL3SZ35RoOT++SJHdKDkpJD sQO9ALwIDVKxwjmX6+7XZMdvwKFs81cVdgj30SI7KdjEk2vQl8aeoCZm3+25gRj1/lJE BQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2f2hju8019-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <29842@debbugs.gnu.org>; Sun, 24 Dec 2017 18:30:56 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vBOIUu9J026168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for <29842@debbugs.gnu.org>; Sun, 24 Dec 2017 18:30:56 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vBOIUtOn026303 for <29842@debbugs.gnu.org>; Sun, 24 Dec 2017 18:30:56 GMT MIME-Version: 1.0 Message-ID: Date: Sun, 24 Dec 2017 10:30:54 -0800 (PST) From: Drew Adams To: 29842@debbugs.gnu.org Subject: RE: bug#29842: 27.0; `dired-change-marks': args should not be optional References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4627.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8755 signatures=668650 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=13 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=853 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712240254 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29842 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Furthermore, the code should perhaps not just call `ding' if you hit RET. Instead of this: (if (or (eq old ?\r) (eq new ?\r)) (ding) ...) it should perhaps do something like this: (unless (char-displayable-p old) (error "Not a displayable character: `%c'" old)) (unless (char-displayable-p new) (error "Not a displayable character: `%c'" new)) The current code predates the existence of `char-displayable-p'. (Yes, that's a different bug, but perhaps it can be taken care of in the context of this report. If not, don't worry about it.) From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 28 08:14:33 2017 Received: (at 29842) by debbugs.gnu.org; 28 Dec 2017 13:14:33 +0000 Received: from localhost ([127.0.0.1]:54603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eUY13-0003xK-3v for submit@debbugs.gnu.org; Thu, 28 Dec 2017 08:14:33 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:33667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eUY10-0003x7-8j for 29842@debbugs.gnu.org; Thu, 28 Dec 2017 08:14:31 -0500 Received: by mail-wm0-f52.google.com with SMTP id g130so1862469wme.0 for <29842@debbugs.gnu.org>; Thu, 28 Dec 2017 05:14:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yULPeV/+IMKFoZFEP5qYIYYN1zngyUtr0ewWPyxo3SQ=; b=KOzt62wwNoQXiwmYho5icXNLRRhFtaXdMrjdxUMvGwQDXwbizmq8hlLyP8Wn19cz5Q ucdICId9cU5yvbfo9Wj0vbvvU/8lMXTk9egHScfoib6UC+wEe7jjTaHcGNDl96rmyp/s q7DzJEP4y7/GtU2obo4oPQFueJY7wEaXXMeZca6blAb16HA0GaK17FBpyi8wzCxMg+SS h/6LqbMdi5blNaVQScg9gABaqoaO89ago4koC34+p5JqXpVLLdRTsaBv+JQFDMc0PU+x oGvcN2J4T+cKTMbXyMG+35XdIWiDFb24VeE2ukFCUoqStFZT3POaWVsfb2eYnJf9KYjL 73UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=yULPeV/+IMKFoZFEP5qYIYYN1zngyUtr0ewWPyxo3SQ=; b=hRd7PaaFLB57u12ZaMYy4LU68SkChjLJj8oP+9HQhnW73PjBInALUDXrEBJxlY49pl rw9d5d3ph0fniTcJm5pcCiVi0qhsaeTHAAWHQXHrMbjBMOCFUxFs/UGXPcgcliaj4oC4 o+g226BY6KxUsB9mtB9MVskWKIMa7vUouR5JEtBQheDrjB4/iyEIumvWoAiSCFWTsYaw b0nLK3gnk4dKdovgA9OaEb+uv9ObypdRdst2Amfw5+v/dvuyUYfKjA/o46idlnbTJ+iz lS9a7VC038R9wv8pdQPdT6bbW80+wplyyoPFNvIR4mC27SmYybkMPmeFUWpBqQSmrR0j P4Sg== X-Gm-Message-State: AKGB3mITGSaqwbRd7zFjfWTQZotlgUlmZPzU7EVIgYsiOqcJ0MgsL3DO pYYZRtaJWN1jCHMObQdK4Altjw== X-Google-Smtp-Source: ACJfBouV38eRAcNukwtkTn/hkftk9LhHLzKDoeJwPG2ZKmHwrv8F/2K336bnG1frZbCCxu1mpbGMgg== X-Received: by 10.28.137.5 with SMTP id l5mr27982092wmd.123.1514466864256; Thu, 28 Dec 2017 05:14:24 -0800 (PST) Received: from calancha-pc (228.red-83-40-68.dynamicip.rima-tde.net. [83.40.68.228]) by smtp.gmail.com with ESMTPSA id n74sm2478255wmi.1.2017.12.28.05.14.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Dec 2017 05:14:23 -0800 (PST) From: Tino Calancha To: Drew Adams Subject: Re: bug#29842: 27.0; `dired-change-marks': args should not be optional References: Date: Thu, 28 Dec 2017 22:14:22 +0900 In-Reply-To: (Drew Adams's message of "Sun, 24 Dec 2017 09:58:02 -0800 (PST)") Message-ID: <87y3ln6lld.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29842 Cc: 29842@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Drew Adams writes: > 1. There is no use of this function in the Emacs Lisp sources that needs > to have the args be optional. Yes, it has sense that the arguments be mandatory. > 2. If (dired-change-marks) is evaluated then you get an error: > > Debugger entered--Lisp error: (error "Format specifier doesn't match > argument type") > format("\n%c" "nil") > dired-change-marks() > eval((dired-change-marks)) Then the programmer would get the more intuitive 'Wrong number of arguments' error. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 28 08:18:15 2017 Received: (at 29842) by debbugs.gnu.org; 28 Dec 2017 13:18:15 +0000 Received: from localhost ([127.0.0.1]:54612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eUY4d-0005xG-JF for submit@debbugs.gnu.org; Thu, 28 Dec 2017 08:18:15 -0500 Received: from mail-wr0-f172.google.com ([209.85.128.172]:41253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eUY4c-0005x2-Db for 29842@debbugs.gnu.org; Thu, 28 Dec 2017 08:18:14 -0500 Received: by mail-wr0-f172.google.com with SMTP id p69so30345453wrb.8 for <29842@debbugs.gnu.org>; Thu, 28 Dec 2017 05:18:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Km9+g4qAfNv72A6eeOfuxVHDAaykU0qSCb0O9pvmm4E=; b=C3EIsN7tEGyp27/O7BajjJFHgFkH2sLzy+OOliFpEpq6ePfxFQxdwPlqAak+pEeW5x tsQGoe0t2+N1xWAIgUkhSkn4gAo1/4geyb6T4FehjXeT6Y2pvuDdO8gtcKkFqw1rqUUW hqZcZnGo0jgMAXt2wzFwqRRpPwacVXoJTPxsB657ll+HvzrqUcZZ3jRqfl/IWtoHQdtT cWjSUhFBQqOpTOLby/xjFR0osP20/gXn3tQ7EdAq0t/LIA+k69UKgE4+P15zz1rd21oT hnYBW/H42ItrvzDrVs1+UyDxA1PQbE7tF+xBRa3Uf17G6+TLo2RPKXiAMhtN7pYPYklh jtjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Km9+g4qAfNv72A6eeOfuxVHDAaykU0qSCb0O9pvmm4E=; b=GcIVpbg7G73vRnWyiHoecVEi9ezO9+nOq9viZdwXerCCEAVhGxvrRTMjNhnW9HivdN 3OzkCrvYCpYtdjqFZoo/fq/hci2VX7PT9vUoGCiwi+P4sCn+t8M5mnK+oU8wvbp+dffb CwGRmuAGGzU/S2TlfZYm5Dh2QsONYZ4DgW5UQDc0pjf1xNdRZcAGMU/86PAcU0d23dxS SfbU8YW3jq9PAuZjyZb02OS8ErkERIqQyJG0Duls516AxRjVJfPGt3/+ZtlF9QkvYM8o aqyxZcZwyYpmxHRmCl4rLLirQlbehU5B3/IlkByNU1uiJ4PZOhP5pGjeMb4PWuOsIvga Yg/Q== X-Gm-Message-State: AKGB3mKU1k8h3bIHN2XZJR80bv3djAuHT016eaj6jA9bo0xQyopcA9P1 ZyTDIQOYB032ISpjZUXB+BW0kA== X-Google-Smtp-Source: ACJfBouHOvf0C7PeLThbM7WewzeB8HMCI1HJIsmTs/JBa1tZN0RhCakpIIumRo8DumqUoAcDn1Vt6Q== X-Received: by 10.223.148.194 with SMTP id 60mr28004660wrr.39.1514467088619; Thu, 28 Dec 2017 05:18:08 -0800 (PST) Received: from calancha-pc (228.red-83-40-68.dynamicip.rima-tde.net. [83.40.68.228]) by smtp.gmail.com with ESMTPSA id o98sm94485779wrb.40.2017.12.28.05.18.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Dec 2017 05:18:07 -0800 (PST) From: Tino Calancha To: Drew Adams Subject: Re: bug#29842: 27.0; `dired-change-marks': args should not be optional References: Date: Thu, 28 Dec 2017 22:18:06 +0900 In-Reply-To: (Drew Adams's message of "Sun, 24 Dec 2017 10:30:54 -0800 (PST)") Message-ID: <87vagr6lf5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29842 Cc: 29842@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > Furthermore, the code should perhaps not just call > `ding' if you hit RET. Instead of this: > > (if (or (eq old ?\r) (eq new ?\r)) > (ding) > ...) > > it should perhaps do something like this: > > (unless (char-displayable-p old) > (error "Not a displayable character: `%c'" old)) > (unless (char-displayable-p new) > (error "Not a displayable character: `%c'" new)) > > The current code predates the existence of > `char-displayable-p'. The more information the better; just a ding force you to read the source code to know what was wrong. Maybe `user-error' instead of `error'? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 28 18:58:10 2017 Received: (at 29842) by debbugs.gnu.org; 28 Dec 2017 23:58:10 +0000 Received: from localhost ([127.0.0.1]:55592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eUi3t-0004az-UT for submit@debbugs.gnu.org; Thu, 28 Dec 2017 18:58:10 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:33250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eUi3r-0004al-RE for 29842@debbugs.gnu.org; Thu, 28 Dec 2017 18:58:08 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBSNw0rs070073; Thu, 28 Dec 2017 23:58:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=PvVyzKSHe+ozXAy2rNddTV4Qn4Cg/UTQ1xaJ7CAJBbI=; b=IZzpz2j78MkfGdNyesZAMgebqTxm606jcqI/1O88+j/ziVxYXXqPzgHMr0YSG8/Qv+cw XMyx9WE6pke3RMgrOaG1dWy5Zim3EwtNsU+D2YopCzhMpheaPgQUxaAzTvIxwgonSIHK zWGDr+a+SeEucXPSs/PEd7bDtjNDM4drF139b9gYkFHkhZRKQyKT68v3pRv4uBKwftfm nGIgvwr25tp45Yk5yEJwbJiemkZm1shRfV6PziAIoWax2J3XogVxD8DO/HRU6GfyLyeN TvWlnL564LaO/tDdPBNVyXL7+EFBt6aEHbUNKeLHOTPUR5sKFgqEOwBPOR/SFVm4ReJ0 pA== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2120.oracle.com with ESMTP id 2f4xj2sa87-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Dec 2017 23:58:00 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id vBSNvwXY024346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 28 Dec 2017 23:58:00 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vBSNvvW1030038; Thu, 28 Dec 2017 23:57:57 GMT MIME-Version: 1.0 Message-ID: <2bf77283-f9f7-41fe-8e23-0811139917f1@default> Date: Thu, 28 Dec 2017 15:57:55 -0800 (PST) From: Drew Adams To: Tino Calancha Subject: RE: bug#29842: 27.0; `dired-change-marks': args should not be optional References: <87vagr6lf5.fsf@gmail.com> In-Reply-To: <87vagr6lf5.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4627.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8758 signatures=668649 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=836 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712280330 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29842 Cc: 29842@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > The more information the better; just a ding force you to read the > source code to know what was wrong. > Maybe `user-error' instead of `error'? Yes `user-error' is appropriate here. Sorry, I always forget about its existence. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 19 09:46:08 2020 Received: (at 29842) by debbugs.gnu.org; 19 Jan 2020 14:46:09 +0000 Received: from localhost ([127.0.0.1]:42746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itBq4-0003Uk-2v for submit@debbugs.gnu.org; Sun, 19 Jan 2020 09:46:08 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:49638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itBpy-0003Tt-HC for 29842@debbugs.gnu.org; Sun, 19 Jan 2020 09:46:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AsmfhrIRcXTIrgalfjENeF5bkyLRC+8aPF2Rgdo8WIQ=; b=mmbGw2AZoNbm9TMVTgYs/jOSxv AaZR1IOmw15atxn7QjgR7JQhIQKoPvBo342GoCE/Hyy0e6gsFVeKwyyt98OF1w4ls4U+cJfYRyWEC I0CvpWGjAAw8RFthHB2KMTmbPOfrkcfVBAru6RFnlWcX6AhXZjGXcU5tkz2RQZUQxS4LlZ5Y4sQdM F1kwXOjm7AP6aLCOGzax21J6ZTpx3kIpLH/DgEkA7lROfuKOvZXDaAXZX9KFOd+p2GsInmOTVpJEa 98PJXrbI6pXSxkxXeQwvj6ZzxcpuI0CBDtbTFuDdca1xL89l8JYOIhgUuP4DrR5yfkQMhOpqJv1/4 MF22b/wA==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:53730 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1itBpo-001rYc-Nr; Sun, 19 Jan 2020 09:45:53 -0500 From: Stefan Kangas To: Drew Adams Subject: Re: bug#29842: 27.0; `dired-change-marks': args should not be optional In-Reply-To: (Drew Adams's message of "Sun, 24 Dec 2017 09:58:02 -0800 (PST)") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sun, 19 Jan 2020 15:45:50 +0100 Message-ID: <87ftgbv71d.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29842 Cc: 29842@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > 1. There is no use of this function in the Emacs Lisp sources that needs > to have the args be optional. > > 2. If (dired-change-marks) is evaluated then you get an error: > > Debugger entered--Lisp error: (error "Format specifier doesn't match > argument type") > format("\n%c" "nil") > dired-change-marks() > eval((dired-change-marks)) > > This bug is apparently quite old - it is present in Emacs 20, for > example. Fixed on master in commit 3d81d2326a. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 19 10:02:56 2020 Received: (at 29842) by debbugs.gnu.org; 19 Jan 2020 15:02:56 +0000 Received: from localhost ([127.0.0.1]:43721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itC6J-00048c-Nc for submit@debbugs.gnu.org; Sun, 19 Jan 2020 10:02:55 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:50884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itC6H-00048L-Ih; Sun, 19 Jan 2020 10:02:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bx8G0eOdcUbhrtDu/tVueRQ8Gmp/n5e8O3CK/8CiOsM=; b=gvZojAv2mfxFfi8lTjC2jVq+rq u7WeHca1C1mzBl4Xo+Rgp2+u6ObKf4zyoHTWoy+fmc0q4w6CHwJ+lwditlWOkEVxn6/P2cE3/j+ox szg/C/EHLclcyLI58XYwqCB6KSFBDW35306WRzTl5oQEEieMyOYWgAeDl/POZbDZT28MQRLIfJk/D KMHJJjL72bwadtEl/grpJv02w7EJvdEwNMhdPLVeB5KAiS3m2zI4QW/Xs1UXZjfAHAn78A6BUIFiy O/ZRrWWEvM7ZcIu6OpCtQ3HQGsZuJz5gkMqja/EoIf6J3BeDg+Vv45P7QwTUHsjQM6zkjKgft2W8G +V5zKABw==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:38616 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1itC6B-001v28-D9; Sun, 19 Jan 2020 10:02:47 -0500 From: Stefan Kangas To: Drew Adams Subject: Re: bug#29842: 27.0; `dired-change-marks': args should not be optional In-Reply-To: (Drew Adams's message of "Sun, 24 Dec 2017 10:30:54 -0800 (PST)") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sun, 19 Jan 2020 16:02:45 +0100 Message-ID: <87blqzv696.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29842 Cc: 29842@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 29842 28.1 thanks Drew Adams writes: > Furthermore, the code should perhaps not just call > `ding' if you hit RET. Instead of this: > > (if (or (eq old ?\r) (eq new ?\r)) > (ding) > ...) > > it should perhaps do something like this: > > (unless (char-displayable-p old) > (error "Not a displayable character: `%c'" old)) > (unless (char-displayable-p new) > (error "Not a displayable character: `%c'" new)) > > The current code predates the existence of > `char-displayable-p'. > > (Yes, that's a different bug, but perhaps it can be > taken care of in the context of this report. If not, > don't worry about it.) Fixed on master in commit e5e31aab9b. Best regards, Stefan Kangas From unknown Mon Jun 23 14:59:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 17 Feb 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator