GNU bug report logs - #29823
NS port tooltip colours

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29823 in the body.
You can then email your comments to 29823 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: bug-gnu-emacs <at> gnu.org
Subject: NS port tooltip colours
Date: Sat, 23 Dec 2017 11:21:29 +0000

[Message part 1 (text/plain, inline)]

The NS port doesn’t support customising tooltips as described in the
Emacs manual. I’ve attached a patch that allows you to customise the
background and foreground colours.

It may be better to try using the existing frame code to generate the
tooltips as they would then support all parameters, but I’m not sure
how to go about doing that.
-- 
Alan Third

[0001-Allow-setting-tooltip-colors-in-NS-port.patch (text/plain, attachment)]

Message #8 received at 29823 <at> debbugs.gnu.org (full text, mbox):

From: charles <at> aurox.ch (Charles A. Roelli)
To: Alan Third <alan <at> idiocy.org>
Cc: 29823 <at> debbugs.gnu.org
Subject: Re: bug#29823: NS port tooltip colours
Date: Thu, 04 Jan 2018 21:57:32 +0100

> Date: Sat, 23 Dec 2017 11:21:29 +0000
> From: Alan Third <alan <at> idiocy.org>
> 
> The NS port doesn’t support customising tooltips as described in the
> Emacs manual. I’ve attached a patch that allows you to customise the
> background and foreground colours.
> 
> It may be better to try using the existing frame code to generate the
> tooltips as they would then support all parameters, but I’m not sure
> how to go about doing that.
> -- 
> Alan Third

Looks good to me.  Thanks for adding this feature.

It looks like using the existing frame code to generate tooltips would
involve rewriting "x-show-tip" in nsfns.m to make it pop up a frame
instead of a native tooltip.  Could that not be done using the "child
frame" functionality (or some subset of it) that you've already added?

And by the way, do you know how this bug was tagged as "minor"?  It
seems like a lot of bugs get that designation, and it's not clear
whether the submitter chooses to do that or if it is somehow done
automatically.

Message #11 received at 29823 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: "Charles A. Roelli" <charles <at> aurox.ch>
Cc: 29823 <at> debbugs.gnu.org
Subject: Re: bug#29823: NS port tooltip colours
Date: Thu, 4 Jan 2018 21:21:45 +0000

On Thu, Jan 04, 2018 at 09:57:32PM +0100, Charles A. Roelli wrote:
> > Date: Sat, 23 Dec 2017 11:21:29 +0000
> > From: Alan Third <alan <at> idiocy.org>
> > 
> > The NS port doesn’t support customising tooltips as described in the
> > Emacs manual. I’ve attached a patch that allows you to customise the
> > background and foreground colours.
> > 
> > It may be better to try using the existing frame code to generate the
> > tooltips as they would then support all parameters, but I’m not sure
> > how to go about doing that.
> 
> Looks good to me.  Thanks for adding this feature.

Thanks.

> It looks like using the existing frame code to generate tooltips would
> involve rewriting "x-show-tip" in nsfns.m to make it pop up a frame
> instead of a native tooltip.  Could that not be done using the "child
> frame" functionality (or some subset of it) that you've already added?

Yeah. I assume it should also be possible to modify tooltip.el to use
undecorated frames instead of tooltips defined at the C level.

Perhaps there’s some advantage to using native tooltips, but the NS
port doesn’t use native tooltips anyway.

> And by the way, do you know how this bug was tagged as "minor"?  It
> seems like a lot of bugs get that designation, and it's not clear
> whether the submitter chooses to do that or if it is somehow done
> automatically.

I assume someone else set it, I certainly didn’t.
-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.