GNU bug report logs - #29820
[PATCH] services: cgit: Add more configuration fields.

Previous Next

Package: guix-patches;

Reported by: Oleg Pykhalov <go.wigust <at> gmail.com>

Date: Fri, 22 Dec 2017 22:35:01 UTC

Severity: normal

Tags: patch

Done: Oleg Pykhalov <go.wigust <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Clément Lassieur <clement <at> lassieur.org>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 29820 <at> debbugs.gnu.org
Subject: [bug#29820] [PATCH] services: cgit: Add more configuration fields.
Date: Tue, 26 Dec 2017 14:54:21 +0100
Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> +  (project-list
> +   (list '())
> +   "A list of subdirectories inside of @code{repository-directory}, relative
> +to it, that should loaded as Git repositories.")

I forgot one thing: 'project-list' is a file, not a list of strings.  I
agree it's weird that cgit's documentation doesn't say it's a file.  I
see two solutions:

1. Change the type to 'string', so that people can set a file name.

2. Use a list type that would transparently transform its values into a
   file in the store, with the generated cgitrc file pointing to it.

The second solution is better because the user won't need to create the
file.




This bug report was last modified 7 years and 137 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.