From unknown Sun Jun 22 04:29:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29803: [PATCH] Fix output alignment in find-dired Resent-From: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Dec 2017 16:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 29803@debbugs.gnu.org Cc: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15138737545351 (code B ref -1); Thu, 21 Dec 2017 16:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Dec 2017 16:29:14 +0000 Received: from localhost ([127.0.0.1]:46337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eS3ic-0001OE-8E for submit@debbugs.gnu.org; Thu, 21 Dec 2017 11:29:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRwqZ-0005Qf-Bb for submit@debbugs.gnu.org; Thu, 21 Dec 2017 04:09:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRwqQ-0007f3-D5 for submit@debbugs.gnu.org; Thu, 21 Dec 2017 04:08:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eRwqQ-0007ed-A4 for submit@debbugs.gnu.org; Thu, 21 Dec 2017 04:08:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRwqP-0000UN-Bm for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2017 04:08:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRwqK-0007Wg-EC for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2017 04:08:49 -0500 Received: from wirrsal.net ([188.68.36.149]:59332 helo=mail.wirrsal.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eRwqK-0007Uo-42 for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2017 04:08:44 -0500 Received: from localhost (i577A0CBB.versanet.de [87.122.12.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wirrsal.net (Postfix) with ESMTPSA id 73CB034A607; Thu, 21 Dec 2017 10:08:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wirrsal.net; s=wirrsal; t=1513847320; bh=R3XqmN51HoYDr64H+qkYDDzWywNd2kTuy/lj3vSaa1Q=; h=From:To:Cc:Subject:Date; b=a3pfcc7DE9KWfbQXl8N3piXmHkbCVfxAY9mZqL87zNDSnr3U607Ax9zNJIMdY5V53 jFXDFVwxtVwi1G8df6hoxCJmMtWi8gAGznGWN0f1307ZHORvVMLFHeUWzOAWcZNcV3 SuIsNc5dD1IEDFRd/xyk/ZvRUm177bn2K1l08Wlc= From: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Date: Thu, 21 Dec 2017 10:08:17 +0100 Message-Id: <20171221090817.32535-1-seb@wirrsal.net> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Mailman-Approved-At: Thu, 21 Dec 2017 11:29:13 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) * lisp/find-dired.el (find-dired-filter): Fix alignment of the file size column when the user is using human file sizes as per =E2=80=98find-ls-op= tion=E2=80=99. --- lisp/find-dired.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/find-dired.el b/lisp/find-dired.el index 3b0613b280..4501da991b 100644 --- a/lisp/find-dired.el +++ b/lisp/find-dired.el @@ -295,7 +295,7 @@ specifies what to use in place of \"-ls\" as the fina= l argument." (l-opt (and (consp find-ls-option) (string-match "l" (cdr find-ls-option)))) (ls-regexp (concat "^ +[^ \t\r\n]+\\( +[^ \t\r\n]+\\) +" - "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[0-9]+\\)"))) + "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[0-9]+[kMGT]?\\)"))) (goto-char beg) (insert string) (goto-char beg) --=20 2.15.1 From unknown Sun Jun 22 04:29:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29803: [PATCH] Fix output alignment in find-dired References: <20171221090817.32535-1-seb@wirrsal.net> In-Reply-To: <20171221090817.32535-1-seb@wirrsal.net> Resent-From: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Dec 2017 18:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 29803@debbugs.gnu.org Cc: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Received: via spool by 29803-submit@debbugs.gnu.org id=B29803.151387971621935 (code B ref 29803); Thu, 21 Dec 2017 18:09:02 +0000 Received: (at 29803) by debbugs.gnu.org; 21 Dec 2017 18:08:36 +0000 Received: from localhost ([127.0.0.1]:46418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eS5Gl-0005hh-99 for submit@debbugs.gnu.org; Thu, 21 Dec 2017 13:08:36 -0500 Received: from wirrsal.net ([188.68.36.149]:59156 helo=mail.wirrsal.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eS5Gj-0005hY-9U for 29803@debbugs.gnu.org; Thu, 21 Dec 2017 13:08:33 -0500 Received: from localhost (i577A0CBB.versanet.de [87.122.12.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wirrsal.net (Postfix) with ESMTPSA id 212D634A7DF; Thu, 21 Dec 2017 19:08:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wirrsal.net; s=wirrsal; t=1513879711; bh=CeaDv0QqTa7brEFl2iWAzEQ0qHXfOOoqdriiv5zzmXQ=; h=From:To:Cc:Subject:Date; b=kF39WpszwabL9x5c6tBk9UQC13sbnSEryPt3jMFnjDYn3K6esBLKzYQUwKtKuVSk9 9bHRrPYCAuRDwDj2ZT0W2hTvdG3g1flLBR3eg4ovo2BDNMi1rLolKwP+9cIe8KBoM8 Jd/BNo+ahwNgPhtQNUPVta6fQRpNPapYzkMNaSBA= From: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Date: Thu, 21 Dec 2017 19:08:11 +0100 Message-Id: <20171221180811.12831-1-seb@wirrsal.net> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * lisp/find-dired.el (find-dired-filter): Fix alignment of the file size column when the user is using human file sizes as per ‘find-ls-option’. --- lisp/find-dired.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/find-dired.el b/lisp/find-dired.el index 3b0613b280..0179860a60 100644 --- a/lisp/find-dired.el +++ b/lisp/find-dired.el @@ -295,7 +295,7 @@ specifies what to use in place of \"-ls\" as the final argument." (l-opt (and (consp find-ls-option) (string-match "l" (cdr find-ls-option)))) (ls-regexp (concat "^ +[^ \t\r\n]+\\( +[^ \t\r\n]+\\) +" - "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[0-9]+\\)"))) + "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[0-9.,]+[kMGT]?\\)"))) (goto-char beg) (insert string) (goto-char beg) -- 2.15.1 From unknown Sun Jun 22 04:29:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29803: [PATCH] Fix output alignment in find-dired Resent-From: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Dec 2017 18:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 29803@debbugs.gnu.org Cc: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Received: via spool by 29803-submit@debbugs.gnu.org id=B29803.151387995822284 (code B ref 29803); Thu, 21 Dec 2017 18:13:01 +0000 Received: (at 29803) by debbugs.gnu.org; 21 Dec 2017 18:12:38 +0000 Received: from localhost ([127.0.0.1]:46424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eS5Kg-0005nM-J4 for submit@debbugs.gnu.org; Thu, 21 Dec 2017 13:12:38 -0500 Received: from wirrsal.net ([188.68.36.149]:59172 helo=mail.wirrsal.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eS5Kf-0005nF-44 for 29803@debbugs.gnu.org; Thu, 21 Dec 2017 13:12:37 -0500 Received: from localhost (i577A0CBB.versanet.de [87.122.12.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wirrsal.net (Postfix) with ESMTPSA id 749D534A7F3; Thu, 21 Dec 2017 19:12:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wirrsal.net; s=wirrsal; t=1513879956; bh=4fRljAMJBcbWyLmxRiion8UjYm14MnQtozU2Optgd4Y=; h=References:From:To:Cc:Subject:In-reply-to:Date; b=CLg2/i0fEIK0+JBLPkqRF5vPLp1HzAhmbJVcxdh5Q7FjtSXClWCft7/ZcCj/mqHbw OYTe/9NWDmOFsas0AXW9J0+QjOjoGveIfgaq0cpbCzAkInaMs5N68TLdGB1SATvCo9 DjLzU8yfinip/wyuqgE1O32XILgs0csTZ/W+PL9c= References: <20171221180811.12831-1-seb@wirrsal.net> User-agent: mu4e 1.0-alpha2; emacs 25.3.1 From: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= In-reply-to: <20171221180811.12831-1-seb@wirrsal.net> Date: Thu, 21 Dec 2017 19:12:35 +0100 Message-ID: <87po78dk6k.fsf@wirrsal.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Sebastian Reuße writes: > * lisp/find-dired.el (find-dired-filter): Fix alignment of the file size > column when the user is using human file sizes as per ‘find-ls-option’. Sorry, forgot to amend an additional change from my working directory before mailing the patch. This supersedes the original patch. Kind regards, SR From unknown Sun Jun 22 04:29:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29803: [PATCH] Fix output alignment in find-dired Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Dec 2017 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Cc: 29803@debbugs.gnu.org, seb@wirrsal.net Reply-To: Eli Zaretskii Received: via spool by 29803-submit@debbugs.gnu.org id=B29803.151395402422745 (code B ref 29803); Fri, 22 Dec 2017 14:48:02 +0000 Received: (at 29803) by debbugs.gnu.org; 22 Dec 2017 14:47:04 +0000 Received: from localhost ([127.0.0.1]:47104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSObI-0005un-JY for submit@debbugs.gnu.org; Fri, 22 Dec 2017 09:47:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSObH-0005uK-Rd for 29803@debbugs.gnu.org; Fri, 22 Dec 2017 09:47:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eSObC-0002Bx-0p for 29803@debbugs.gnu.org; Fri, 22 Dec 2017 09:46:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSOb5-00025d-72; Fri, 22 Dec 2017 09:46:51 -0500 Received: from [176.228.60.248] (port=2142 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eSOb4-0001Iy-L0; Fri, 22 Dec 2017 09:46:51 -0500 Date: Fri, 22 Dec 2017 16:46:49 +0200 Message-Id: <83vagylt0m.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <20171221180811.12831-1-seb@wirrsal.net> (message from Sebastian =?UTF-8?Q?Reu=C3=9Fe?= on Thu, 21 Dec 2017 19:08:11 +0100) References: <20171221090817.32535-1-seb@wirrsal.net> <20171221180811.12831-1-seb@wirrsal.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Sebastian Reuße > Date: Thu, 21 Dec 2017 19:08:11 +0100 > Cc: Sebastian Reuße > > * lisp/find-dired.el (find-dired-filter): Fix alignment of the file size > column when the user is using human file sizes as per ‘find-ls-option’. Thanks. Could you please provide a minimum example to demonstrate the current code's mis-alignment and how your patch fixes that? From unknown Sun Jun 22 04:29:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29803: [PATCH] Fix output alignment in find-dired Resent-From: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Dec 2017 15:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 29803@debbugs.gnu.org Received: via spool by 29803-submit@debbugs.gnu.org id=B29803.151395625727537 (code B ref 29803); Fri, 22 Dec 2017 15:25:02 +0000 Received: (at 29803) by debbugs.gnu.org; 22 Dec 2017 15:24:17 +0000 Received: from localhost ([127.0.0.1]:48198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSPBJ-0007A5-Ih for submit@debbugs.gnu.org; Fri, 22 Dec 2017 10:24:17 -0500 Received: from wirrsal.net ([188.68.36.149]:44392 helo=mail.wirrsal.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSPBI-00079w-1y for 29803@debbugs.gnu.org; Fri, 22 Dec 2017 10:24:16 -0500 Received: from localhost (i577A0059.versanet.de [87.122.0.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wirrsal.net (Postfix) with ESMTPSA id B827834ABD3; Fri, 22 Dec 2017 16:24:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wirrsal.net; s=wirrsal; t=1513956254; bh=PlwqngwV3Zr5YwI1pJCgiPekrz3Zv7iuXBu/A9loHi0=; h=References:From:To:Cc:Subject:In-reply-to:Date; b=uaVEUvt6D8SMs+9f/nPcHogjBjIh8nPSqGn3rwypXrM8DU1QDGc3xjBwZQryNcn2h lU92TgNgeP/mVanuU4txCsT46NPvnMa67tNnROHE2m1cI3qkV+uEly74ZKGiK+0po/ 1K0HLTY/OV0XR/X+WqczS9KUZyLzHjHBFdttFSM0= References: <20171221090817.32535-1-seb@wirrsal.net> <20171221180811.12831-1-seb@wirrsal.net> <83vagylt0m.fsf@gnu.org> User-agent: mu4e 1.0-alpha2; emacs 25.3.1 From: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= In-reply-to: <83vagylt0m.fsf@gnu.org> Date: Fri, 22 Dec 2017 16:24:13 +0100 Message-ID: <87a7ya23c2.fsf@wirrsal.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello Eli, Eli Zaretskii writes: > Thanks. Could you please provide a minimum example to demonstrate the > current code's mis-alignment and how your patch fixes that? You can reproduce the alignment issue when using the example from the `find-ls-option` docs: (let ((find-ls-option '("-exec ls -ldh {} +" . "-ldh"))) (find-dired "/tmp" "-type f")) E.g., for me, this yields: -rw------- 1 seb users 226K 22. Dez 14:59 emacs-trustFuURayKH -rw------- 1 seb users 226K 22. Dez 14:59 emacs-trustI8LaIFbp -rw------- 1 seb users 156 22. Dez 14:58 serverauth.Zq2gEantga -r--r--r-- 1 seb users 11 22. Dez 14:58 .X0-lock find-dired uses a regex group to align the size column. This group currently does not include the size suffix, so when using human-formatted output, the remaining columns are misaligned. When we include the suffix in the capture group, we get the desired alignment: -rw------- 1 seb users 226K 22. Dez 14:59 emacs-trustFuURayKH -rw------- 1 seb users 226K 22. Dez 14:59 emacs-trustI8LaIFbp -rw------- 1 seb users 156 22. Dez 14:58 serverauth.Zq2gEantga -r--r--r-- 1 seb users 11 22. Dez 14:58 .X0-lock Actually, it now occurs to me that the suffix might vary in case, e.g. when using ‘--si’ output. I’d propose we instead have the group capture all consecutive non-whitespace (cf. superseding patch). This would then also cover the decimal and thousands separators. Kind regards, SR -- Insane cobra split the wood Trader of the lowland breed Call a jittney, drive away In the slipstream we will stay From unknown Sun Jun 22 04:29:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29803: [PATCH] Fix output alignment in find-dired References: <20171221090817.32535-1-seb@wirrsal.net> In-Reply-To: <20171221090817.32535-1-seb@wirrsal.net> Resent-From: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Dec 2017 15:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 29803@debbugs.gnu.org Cc: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Received: via spool by 29803-submit@debbugs.gnu.org id=B29803.151395627327564 (code B ref 29803); Fri, 22 Dec 2017 15:25:02 +0000 Received: (at 29803) by debbugs.gnu.org; 22 Dec 2017 15:24:33 +0000 Received: from localhost ([127.0.0.1]:48201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSPBY-0007AW-Qb for submit@debbugs.gnu.org; Fri, 22 Dec 2017 10:24:32 -0500 Received: from wirrsal.net ([188.68.36.149]:44396 helo=mail.wirrsal.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSPBX-0007AO-2U for 29803@debbugs.gnu.org; Fri, 22 Dec 2017 10:24:31 -0500 Received: from localhost (i577A0059.versanet.de [87.122.0.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wirrsal.net (Postfix) with ESMTPSA id 79DB834ABD5; Fri, 22 Dec 2017 16:24:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wirrsal.net; s=wirrsal; t=1513956270; bh=LAYhk0cwtASRFZfLIfX+cqb/mOSi4uGE77e3wUgpOuU=; h=From:To:Cc:Subject:Date; b=ZBEJrQMj0+XGxyz1uhqPmBWLMPMdRoTWGNGBm0j3DuNBo5urS2XMbVtsbq/jwK10P iKeAYMK0oqh1ocR4TmJiKKGEJExqLwO3+qr8m6LigT0cPBWF9VZk3uwlTI/J3yo+Ug 0ZBUG8Qc0AJHDfLLNMCQ24mLlYJ8/7hVm/0+5jQM= From: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Date: Fri, 22 Dec 2017 16:24:24 +0100 Message-Id: <20171222152424.17481-1-seb@wirrsal.net> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * lisp/find-dired.el (find-dired-filter): Fix alignment of the file size column when the user is using human file sizes as per ‘find-ls-option’. --- lisp/find-dired.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/find-dired.el b/lisp/find-dired.el index 3b0613b280..bf815d500d 100644 --- a/lisp/find-dired.el +++ b/lisp/find-dired.el @@ -295,7 +295,7 @@ specifies what to use in place of \"-ls\" as the final argument." (l-opt (and (consp find-ls-option) (string-match "l" (cdr find-ls-option)))) (ls-regexp (concat "^ +[^ \t\r\n]+\\( +[^ \t\r\n]+\\) +" - "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[0-9]+\\)"))) + "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[^[:space:]]+\\)"))) (goto-char beg) (insert string) (goto-char beg) -- 2.15.1 From unknown Sun Jun 22 04:29:21 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sebastian =?UTF-8?Q?Reu=C3=9Fe?= Subject: bug#29803: closed (Re: bug#29803: [PATCH] Fix output alignment in find-dired) Message-ID: References: <83373sfqbp.fsf@gnu.org> <20171221090817.32535-1-seb@wirrsal.net> X-Gnu-PR-Message: they-closed 29803 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 29803@debbugs.gnu.org Date: Sat, 30 Dec 2017 10:45:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1514630702-21132-1" This is a multi-part message in MIME format... ------------=_1514630702-21132-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29803: [PATCH] Fix output alignment in find-dired which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29803@debbugs.gnu.org. --=20 29803: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29803 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1514630702-21132-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29803-done) by debbugs.gnu.org; 30 Dec 2017 10:44:35 +0000 Received: from localhost ([127.0.0.1]:57216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eVEd1-0005Tn-EK for submit@debbugs.gnu.org; Sat, 30 Dec 2017 05:44:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eVEcz-0005TZ-TF for 29803-done@debbugs.gnu.org; Sat, 30 Dec 2017 05:44:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eVEcq-0003Xx-Np for 29803-done@debbugs.gnu.org; Sat, 30 Dec 2017 05:44:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eVEcq-0003Xp-KP; Sat, 30 Dec 2017 05:44:24 -0500 Received: from [176.228.60.248] (port=4697 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eVEcq-0006Am-1L; Sat, 30 Dec 2017 05:44:24 -0500 Date: Sat, 30 Dec 2017 12:44:10 +0200 Message-Id: <83373sfqbp.fsf@gnu.org> From: Eli Zaretskii To: Sebastian =?utf-8?Q?Reu=C3=9Fe?= In-reply-to: <20171222152424.17481-1-seb@wirrsal.net> (message from Sebastian =?utf-8?Q?Reu=C3=9Fe?= on Fri, 22 Dec 2017 16:24:24 +0100) Subject: Re: bug#29803: [PATCH] Fix output alignment in find-dired References: <20171221090817.32535-1-seb@wirrsal.net> <20171222152424.17481-1-seb@wirrsal.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29803-done Cc: 29803-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Sebastian Reuße > Date: Fri, 22 Dec 2017 16:24:24 +0100 > Cc: Sebastian Reuße > > * lisp/find-dired.el (find-dired-filter): Fix alignment of the file size > column when the user is using human file sizes as per ‘find-ls-option’. Thanks, pushed to the master branch. ------------=_1514630702-21132-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Dec 2017 16:29:14 +0000 Received: from localhost ([127.0.0.1]:46337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eS3ic-0001OE-8E for submit@debbugs.gnu.org; Thu, 21 Dec 2017 11:29:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRwqZ-0005Qf-Bb for submit@debbugs.gnu.org; Thu, 21 Dec 2017 04:09:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRwqQ-0007f3-D5 for submit@debbugs.gnu.org; Thu, 21 Dec 2017 04:08:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eRwqQ-0007ed-A4 for submit@debbugs.gnu.org; Thu, 21 Dec 2017 04:08:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRwqP-0000UN-Bm for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2017 04:08:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRwqK-0007Wg-EC for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2017 04:08:49 -0500 Received: from wirrsal.net ([188.68.36.149]:59332 helo=mail.wirrsal.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eRwqK-0007Uo-42 for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2017 04:08:44 -0500 Received: from localhost (i577A0CBB.versanet.de [87.122.12.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wirrsal.net (Postfix) with ESMTPSA id 73CB034A607; Thu, 21 Dec 2017 10:08:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wirrsal.net; s=wirrsal; t=1513847320; bh=R3XqmN51HoYDr64H+qkYDDzWywNd2kTuy/lj3vSaa1Q=; h=From:To:Cc:Subject:Date; b=a3pfcc7DE9KWfbQXl8N3piXmHkbCVfxAY9mZqL87zNDSnr3U607Ax9zNJIMdY5V53 jFXDFVwxtVwi1G8df6hoxCJmMtWi8gAGznGWN0f1307ZHORvVMLFHeUWzOAWcZNcV3 SuIsNc5dD1IEDFRd/xyk/ZvRUm177bn2K1l08Wlc= From: =?UTF-8?q?Sebastian=20Reu=C3=9Fe?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix output alignment in find-dired Date: Thu, 21 Dec 2017 10:08:17 +0100 Message-Id: <20171221090817.32535-1-seb@wirrsal.net> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 21 Dec 2017 11:29:13 -0500 Cc: =?UTF-8?q?Sebastian=20Reu=C3=9Fe?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) * lisp/find-dired.el (find-dired-filter): Fix alignment of the file size column when the user is using human file sizes as per =E2=80=98find-ls-op= tion=E2=80=99. --- lisp/find-dired.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/find-dired.el b/lisp/find-dired.el index 3b0613b280..4501da991b 100644 --- a/lisp/find-dired.el +++ b/lisp/find-dired.el @@ -295,7 +295,7 @@ specifies what to use in place of \"-ls\" as the fina= l argument." (l-opt (and (consp find-ls-option) (string-match "l" (cdr find-ls-option)))) (ls-regexp (concat "^ +[^ \t\r\n]+\\( +[^ \t\r\n]+\\) +" - "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[0-9]+\\)"))) + "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[0-9]+[kMGT]?\\)"))) (goto-char beg) (insert string) (goto-char beg) --=20 2.15.1 ------------=_1514630702-21132-1--