GNU bug report logs - #29799
24.5; cl-loop guard clause missing

Previous Next

Package: emacs;

Reported by: Tino Calancha <tino.calancha <at> gmail.com>

Date: Thu, 21 Dec 2017 09:39:02 UTC

Severity: normal

Tags: fixed

Found in version 24.5

Fixed in version 28.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #22 received at 29799-done <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: 29799-done <at> debbugs.gnu.org
Subject: Re: bug#29799: 24.5; cl-loop guard clause missing
Date: Mon, 08 Jan 2018 19:20:35 +0900
Noam Postavsky <npostavs <at> users.sourceforge.net> writes:

> Tino Calancha <tino.calancha <at> gmail.com> writes:
>
>>     Fix #Bug#29799
>>     
>>     * lisp/emacs-lisp/cl-macs.el (cl--loop-guard-cond): New variable.
>>     (cl--parse-loop-clause): Set it non-nil if the loop contains
>>     a for/as clause.
>>     (cl-loop): After update the loop variable, update other variables
>>     only if cl--loop-guard-cond is non-nil.
>>     
>>     * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-loop-for-as-equals-and):
>>     New test.
>
> Looks good, but please add some more info to the summary line.
Thank you very much.
Extended the commit message with more detailed explanations.

Fixed in master branch as commit 'cl-loop: Add missing guard condition'
(a0365437c9ee308ad7978e436631020f513b25e7).




This bug report was last modified 5 years and 19 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.