GNU bug report logs - #29756
25.2; Footnote-mode: recursive footnotes [PATCH included]

Previous Next

Full log

Message #17 received at 29756 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 29756 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#29756: 25.2;
 Footnote-mode: recursive footnotes [UPDATED PATCH]
Date: Mon, 24 Jun 2019 17:32:50 +0200

Boruch Baum <boruch_baum <at> gmx.com> writes:

> On 2017-12-22 16:19, Eli Zaretskii wrote:
>> Could you please rewrite the patch without using advice?  We generally
>> avoid using that in Emacs's own sources.
>
> Done, but in an organizationally messy manner. In parallel with this bug
> report, I had proposed a separate feature on the dev mailing list, and
> that snippet got swallowed into code Stefan Monnier is reviewing.

Is this patch still applicable or did it get solved in conjunction with
that separate feature?

Some minor notes on the patch:

+(defun Footnote--get-area-point-min (&optional arg)
+  "Return POINT of the beginning of the footnote area, being the
+start of the first footnote. If there is no footnote area,

The first line of a comment should be a complete sentence.

+       (let ((p (point)) min)
+        (goto-char (cdr (first footnote-text-marker-alist)))

The indentation seems off?  It's often useful to run the function
through `M-C-q' to get everything to be indented properly.

+         ; This `else' should never happen, and indicates an error, ie. footnotes
+         ; already exist and a footnote-section-tag is defined, but the section tag

There should be two semicolons for in-code comments on separate lines.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.