GNU bug report logs - #29753
[PATCH] Add grammalecte.

Previous Next

Package: guix-patches;

Reported by: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Date: Sun, 17 Dec 2017 10:51:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29753 in the body.
You can then email your comments to 29753 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#29753; Package guix-patches. (Sun, 17 Dec 2017 10:51:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 17 Dec 2017 10:51:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add grammalecte.
Date: Sun, 17 Dec 2017 11:49:41 +0100
[Message part 1 (text/plain, inline)]
Hello,

The following patch adds a french grammar checker.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738
[0001-gnu-Add-grammalecte.patch (text/x-diff, inline)]
From 6b687b4b89e8174fb2e55a9353a4b43d2019dffd Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Date: Sun, 17 Dec 2017 11:45:47 +0100
Subject: [PATCH] gnu: Add grammalecte.

* gnu/packages/dictionaries.scm (grammalecte): New variable.
---
 gnu/packages/dictionaries.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/dictionaries.scm b/gnu/packages/dictionaries.scm
index 062c29b66..593967705 100644
--- a/gnu/packages/dictionaries.scm
+++ b/gnu/packages/dictionaries.scm
@@ -23,6 +23,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages base)
   #:use-module (gnu packages curl)
@@ -206,6 +207,45 @@ It comes with a German-English dictionary with approximately 270,000 entries.")
     (home-page  "http://www-user.tu-chemnitz.de/~fri/ding/")
     (license gpl2+)))
 
+(define-public grammalecte
+  (package
+    (name "grammalecte")
+    (version "0.6.1")
+    (source
+     (origin
+       (method url-fetch/zipbomb)
+       (uri (string-append "https://www.dicollecte.org/grammalecte/zip/"
+                           "Grammalecte-fr-v" version ".zip"))
+       (sha256
+        (base32
+         "0bl342i7nqbg8swk3fxashg9liyp3jdnix59pndhy41cpm1xln4i"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-setup.py
+           ;; FIXME: "setup.py" contains a typo in 0.6.1 release. The
+           ;; issue was reported and fixed upstream
+           ;; (https://dicollecte.org/thread.php?prj=fr&t=674). This
+           ;; phase can be removed in next release.
+           (lambda _
+             (substitute* "setup.py"
+               (("server_options\\.") "grammalecte-server-options."))
+             #t)))))
+    (home-page "https://www.dicollecte.org")
+    (synopsis  "French spelling and grammar checker")
+    (description "Grammalecte is a grammar checker dedicated to the French
+language, derived from Lightproof.
+
+Grammalecte aims at helping to write a proper French without distracting users
+with false positives.  This grammar checker follows the principle: the less
+false positives, the better; if it can not know with a good chance if
+a dubious expression is wrong, it will keep silent.
+
+The package provides the command line interface, along with a server
+and a Python library.")
+    (license license:gpl3+)))
+
 (define-public translate-shell
   (package
     (name "translate-shell")
-- 
2.15.1


Information forwarded to guix-patches <at> gnu.org:
bug#29753; Package guix-patches. (Sun, 17 Dec 2017 16:59:01 GMT) Full text and rfc822 format available.

Message #8 received at 29753 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 29753 <at> debbugs.gnu.org
Subject: Re: [bug#29753] [PATCH] Add grammalecte.
Date: Sun, 17 Dec 2017 17:58:54 +0100
Heya,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

> From 6b687b4b89e8174fb2e55a9353a4b43d2019dffd Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
> Date: Sun, 17 Dec 2017 11:45:47 +0100
> Subject: [PATCH] gnu: Add grammalecte.
>
> * gnu/packages/dictionaries.scm (grammalecte): New variable.

[...]

> +    (home-page "https://www.dicollecte.org")
> +    (synopsis  "French spelling and grammar checker")
> +    (description "Grammalecte is a grammar checker dedicated to the French
> +language, derived from Lightproof.
> +
> +Grammalecte aims at helping to write a proper French without distracting users
> +with false positives.  This grammar checker follows the principle: the less
> +false positives, the better; if it can not know with a good chance if

s/can not/cannot/  :-)

Otherwise LGTM!

Do you know if there’s Emacs integration (Flyspell maybe?)?

Thank you,
Ludo’.




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Sun, 17 Dec 2017 18:04:01 GMT) Full text and rfc822 format available.

Notification sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
bug acknowledged by developer. (Sun, 17 Dec 2017 18:04:02 GMT) Full text and rfc822 format available.

Message #13 received at 29753-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 29753-done <at> debbugs.gnu.org
Subject: Re: [bug#29753] [PATCH] Add grammalecte.
Date: Sun, 17 Dec 2017 19:03:30 +0100
Hello,

ludo <at> gnu.org (Ludovic Courtès) writes:

>> +Grammalecte aims at helping to write a proper French without distracting users
>> +with false positives.  This grammar checker follows the principle: the less
>> +false positives, the better; if it can not know with a good chance if
>
> s/can not/cannot/  :-)

Fixed.

> Otherwise LGTM!

Pushed. Thank you.

> Do you know if there’s Emacs integration (Flyspell maybe?)?

There is one at <https://gitlab.com/geeklhem/flycheck-grammalecte>.
However, quoting its author: "This package is currently a quick
hack-around".

Regards,

-- 
Nicolas Goaziou                                                0x80A93738




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 15 Jan 2018 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 7 years and 220 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.