Subject: [bug#29741] [PATCH 2/2] gnu: services: web: Add service for httpd.

From: [email-masked] (Ludovic Courtès)
Date: Thu, 11 Jan 2018 10:46:13 +0100

Hi Chris!

Sorry for the delay.

Christopher Baines <[email-masked]> skribis:

> * gnu/services/web.scm (<httpd-module>,
>   <httpd-config-file>, <httpd-virtualhost>
>   <httpd-configuration>): New record types.
>   (%default-httpd-modules, %httpd-accounts,
>   httpd-service-type): New variables.
>   (httpd-shepherd-services, httpd-activation,
>   httpd-process-extensions): New procedures.
> * gnu/tests/web.scm (run-httpd-test): New procedure.
>   (%httpd-os, %tests-httpd): New variables.
> * doc/guix.texi (Web Services): Document the Apache HTTP Server.

[...]

> +The @code{(gnu services web)} module provides the Apache HTTP Server,
> +the nginx web server, and also a fastcgi wrapper daemon.
> +
> +@subsubheading Apache HTTP Server
> +
> +@deffn {Scheme Variable} httpd-service-type
> +Service type for the @uref{https://httpd.apache.org/,Apache HTTP}
> +server.  The value for this service type is a @code{https-configuration}
        ^
Maybe add “(@dfn{httpd})”.

Apart from this super-nitpicky comment, this LGTM!  :-)

Thank you,
Ludo’.