Subject: [bug#29733] Add virtaal (translation app)

From: [email-masked] (Ludovic Courtès)
Date: Wed, 07 Mar 2018 14:59:08 +0100

Hello Mark & Oleg,

In an attempt to make progress (it’s been 3 months already :-)), I
pushed the first two patches, taking Oleg’s comments into account:

  30e43e816 * gnu: python2-gobject@2: Update to 2.28.7
  eaa8292e4 * gnu: Add python-pycurl.

Mark, can you take a look at Oleg’s suggestions below?  We’re almost
there!

Thanks in advance,
Ludo’.

Oleg Pykhalov <[email-masked]> skribis:

>> From c36fde0cfda0d5f9830876abbff804504004451d Mon Sep 17 00:00:00 2001
>> From: Mark Meyer <[email-masked]>
>> Date: Fri, 15 Dec 2017 12:35:38 +0100
>> Subject: [PATCH] gnu: Add virtaal.
>>
>> * gnu/packages/text-editors.scm (virtaal): New public variable.
>> ---
>>  gnu/packages/text-editors.scm | 33 +++++++++++++++++++++++++++++++++
>>  1 file changed, 33 insertions(+)
>>
>> diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
>> index 44b42ce9b..773000ff4 100644
>> --- a/gnu/packages/text-editors.scm
>> +++ b/gnu/packages/text-editors.scm
>> @@ -6,6 +6,7 @@
>>  ;;; Copyright  2017 ng0 <[email-masked]>
>>  ;;; Copyright  2014 Taylan Ulrich Bayrl/Kammer <[email-masked]>
>>  ;;; Copyright  2017 Tobias Geerinckx-Rice <[email-masked]>
>> +;;; Copyright  2017 Mark Meyer <[email-masked]>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -29,6 +30,7 @@
>>    #:use-module (guix utils)
>>    #:use-module (guix build-system gnu)
>>    #:use-module (guix build-system glib-or-gtk)
>> +  #:use-module (guix build-system python)
>>    #:use-module ((guix licenses) #:prefix license:)
>>    #:use-module (gnu packages)
>>    #:use-module (gnu packages assembly)
>> @@ -41,11 +43,42 @@
>>    #:use-module (gnu packages lua)
>>    #:use-module (gnu packages ncurses)
>>    #:use-module (gnu packages pkg-config)
>> +  #:use-module (gnu packages python)
>> +  #:use-module (gnu packages python-web)
>>    #:use-module (gnu packages regex)
>>    #:use-module (gnu packages ruby)
>>    #:use-module (gnu packages terminals)
>>    #:use-module (gnu packages xml))
>>  
>> +(define-public virtaal
>> +  (package
>> +    (name "virtaal")
>> +    (version "0.7.1")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "mirror://sourceforge/translate/Virtaal/"
>> +                                  version "/virtaal-" version ".tar.bz2"))
>> +              (sha256
>> +               (base32
>> +                "0cyimjp3191qlmw6n0ipqdr9xr0cq4f6dqvz4rl9q31h6l3kywf9"))))
>> +    (build-system python-build-system)
>> +    (arguments
>> +     `(#:python ,python-2
>> +       #:use-setuptools? #f
>> +       #:tests? #f))
>
> Could you check tests in virtaal-0.7.1/virtaal/test/ please?
>
>> +    (propagated-inputs
>> +     `(("python2-pycurl" ,python2-pycurl)
>> +       ("python2-pygtk" ,python2-pygtk)
>> +       ("python2-lxml" ,python2-lxml)
>> +       ("python2-translate-toolkit" ,python2-translate-toolkit)
>> +       ("python2-simplejson" ,python2-simplejson)))
>> +    (synopsis "An editor for translation files")
>
> gnu/packages/text-editors.scm:75:14: [email-masked]: no article allowed at the beginning of the synopsis
>
>> +    (description
>> +     "Virtaal, a feature rich translation tool that allows you to focus on
>> +translation, without the tool getting in the way.")
>> +    (home-page "http://virtaal.translatehouse.org/")
>> +    (license license:gpl2)))
>> +
>>  (define-public vis
>>    (package
>>      (name "vis")
>
> Could't be it builded With Python 3?  I see in
> <https://github.com/translate/virtaal/blob/master/.travis.yml> that they
> use only python 2.7 and 2.7, but still?
>
> Thanks,
> Oleg.