From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 06:03:01 2017 Received: (at submit) by debbugs.gnu.org; 15 Dec 2017 11:03:01 +0000 Received: from localhost ([127.0.0.1]:34741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePnlc-0005JG-Lw for submit@debbugs.gnu.org; Fri, 15 Dec 2017 06:03:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePnla-0005Iz-MW for submit@debbugs.gnu.org; Fri, 15 Dec 2017 06:02:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePnlM-0000kx-3H for submit@debbugs.gnu.org; Fri, 15 Dec 2017 06:02:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41230) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ePnlL-0000kM-Vm for submit@debbugs.gnu.org; Fri, 15 Dec 2017 06:02:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePnlH-0002a4-Em for guix-patches@gnu.org; Fri, 15 Dec 2017 06:02:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePnlD-0000eP-CE for guix-patches@gnu.org; Fri, 15 Dec 2017 06:02:39 -0500 Received: from mx.kolabnow.com ([95.128.36.40]:36328) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ePnlD-0000cN-0c for guix-patches@gnu.org; Fri, 15 Dec 2017 06:02:35 -0500 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTP id A70EF1888 for ; Fri, 15 Dec 2017 12:02:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mykolab.com; h= message-id:subject:subject:from:from:date:date:content-type :content-type:mime-version:received:received:received; s= dkim20160331; t=1513335752; x=1513335774; bh=saB6eu4Q/K5MykFN9nF qrwKxZl2ipI4p+pYRaY+zC/U=; b=XRuMmGbcsh5wY8cB/mU+kEbMvaPkMl52Ute jJkjySlDZ4V02VpgxrmyLdI2D58kLb1Ib410cXWn/UcYhr6sxa6i110raA0LKfI5 /Vs6p5GJfCDMNGSg+shqDiBHulzKv61AwYxN462bfh7Ekmtqr8UyAfto+dlJUA43 e1JiE2W8xqPTW1koIo9hNix7xZ2nbhquwSsj4Z7gOR32L35GxumWQsyZJKN3BYv2 fTKenf6hBACHCLxTBTGuzoVellswOY8BEh5doWxqpbyUFoSSpt4CBXD2wg41zQ1G V+IFs4edxDeB4ygdAFndbE9QwjrjdUDYS7xkZvdGCe+XzkegP7XfnsQBsOaNmIKT piD5fwITdoa1UxNvXS6uyjxinCYp3hwBY1+XaMiu/DSADDpZ65NbXympbif0Wiaw LosW8VOWixd81lLUMTeu9rKHjoI6OhB4Rbho60igzQqoZK8tusx+UkZjewUqAh4+ NJM/UlVd4GMK1Tag5/Fl6PEZ+zLPTBSpPSuki+QF6w39KQb4SW8sYxQY/cyr3tSB 07h0k3Ej5fblFXFC8p7sHCWqLbDd2o+FB6HpsK+k2hSB7q2JNfTSycWf8vi05tn1 oDtSkgI5V5RRpq+uKhkSYNnmI84c0GignLgFXexpC9gv0Y2unn2OX+8N/QXOlkRV GB6tygVU= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YTWw9gZzpwDS for ; Fri, 15 Dec 2017 12:02:32 +0100 (CET) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id 0E6D51517 for ; Fri, 15 Dec 2017 12:02:32 +0100 (CET) Received: from int-subm001.mykolab.com (unknown [10.9.37.1]) by int-mx002.mykolab.com (Postfix) with ESMTPS id E7C9A2343 for ; Fri, 15 Dec 2017 12:02:31 +0100 (CET) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_ab04d4b952c09c47e082e4a6415d9e25" Date: Fri, 15 Dec 2017 12:02:31 +0100 From: Rutger Helling To: guix-patches@gnu.org Subject: [PATCH] gnu: virtualization: Add lookingglass. Message-ID: X-Sender: rhelling@mykolab.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=_ab04d4b952c09c47e082e4a6415d9e25 Content-Type: multipart/alternative; boundary="=_753a1a8a445e85421bce5be9bd8a304e" --=_753a1a8a445e85421bce5be9bd8a304e Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Hey Guix, this patch adds LookingGlass. --=_753a1a8a445e85421bce5be9bd8a304e Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8

Hey Guix,

this patch adds LookingGlass.

--=_753a1a8a445e85421bce5be9bd8a304e-- --=_ab04d4b952c09c47e082e4a6415d9e25 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-virtualization-Add-lookingglass.patch Content-Disposition: attachment; filename=0001-gnu-virtualization-Add-lookingglass.patch; size=2676 RnJvbSBjY2VhOWE2YzlkZDcxYWVhNWVmNWMwNzgwMmY3ZTM3NmE3Zjg2YTk2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSdXRnZXIgSGVsbGluZyA8cmhlbGxpbmdAbXlrb2xhYi5jb20+ CkRhdGU6IEZyaSwgMTUgRGVjIDIwMTcgMTE6NTg6MTAgKzAxMDAKU3ViamVjdDogW1BBVENIXSBn bnU6IHZpcnR1YWxpemF0aW9uOiBBZGQgbG9va2luZ2dsYXNzLgoKKiBnbnUvcGFja2FnZXMvdmly dHVhbGl6YXRpb24uc2NtIChsb29raW5nZ2xhc3MpOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3Bh Y2thZ2VzL3ZpcnR1YWxpemF0aW9uLnNjbSB8IDQxICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNDEgaW5zZXJ0aW9ucygrKQoKZGlmZiAt LWdpdCBhL2dudS9wYWNrYWdlcy92aXJ0dWFsaXphdGlvbi5zY20gYi9nbnUvcGFja2FnZXMvdmly dHVhbGl6YXRpb24uc2NtCmluZGV4IDg1NTYzZGRlNi4uZDM1MzFkYTY5IDEwMDY0NAotLS0gYS9n bnUvcGFja2FnZXMvdmlydHVhbGl6YXRpb24uc2NtCisrKyBiL2dudS9wYWNrYWdlcy92aXJ0dWFs aXphdGlvbi5zY20KQEAgLTM2LDYgKzM2LDcgQEAKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgZG5zKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBkb2Nib29rKQogICAjOnVzZS1t b2R1bGUgKGdudSBwYWNrYWdlcyBkb2N1bWVudGF0aW9uKQorICAjOnVzZS1tb2R1bGUgKGdudSBw YWNrYWdlcyBmb250dXRpbHMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGdsKQogICAj OnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBnbGliKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyBnbm9tZSkKQEAgLTcwOSwzICs3MTAsNDMgQEAgbWFpbmx5IGltcGxlbWVudGVkIGluIHVz ZXIgc3BhY2UuIikKIGluY3JlbWVudGFsIGJhY2t1cHMgb2YgcnVubmluZyBRRU1VIHZpcnR1YWwg bWFjaGluZXMgdmlhIFFNUCwgdGhlIFFFTVUKIE1hY2hpbmUgUHJvdG9jb2wuIikKICAgICAobGlj ZW5zZSBncGwzKykpKQorCisoZGVmaW5lLXB1YmxpYyBsb29raW5nZ2xhc3MKKyAgKHBhY2thZ2UK KyAgIChuYW1lICJsb29raW5nZ2xhc3MiKQorICAgKHZlcnNpb24gImE1IikKKyAgIChzb3VyY2UK KyAgICAob3JpZ2luCisgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAodXJpIChzdHJpbmct YXBwZW5kICJodHRwczovL2dpdGh1Yi5jb20vZ25pZi9Mb29raW5nR2xhc3MvYXJjaGl2ZS8iCisg ICAgICAgICAgICAgICAgICAgICAgICAgdmVyc2lvbiAiLnRhci5neiIpKQorICAgICAoZmlsZS1u YW1lIChzdHJpbmctYXBwZW5kIG5hbWUgIi0iIHZlcnNpb24pKQorICAgICAoc2hhMjU2CisgICAg ICAoYmFzZTMyCisgICAgICAgIjBscmI4MjE5MTRmcDI3eGFxMHNwd2hiYmxzc3o1NXBoaXlndmRs dmNya2lmYTEzOHY4cGYiKSkpKQorICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQor ICAgKGlucHV0cyBgKCgiZm9udGNvbmZpZyIgLGZvbnRjb25maWcpCisgICAgICAgICAgICAgKCJn bHUiICxnbHUpCisgICAgICAgICAgICAgKCJtZXNhIiAsbWVzYSkKKyAgICAgICAgICAgICAoIm9w ZW5zc2wiICxvcGVuc3NsKQorICAgICAgICAgICAgICgic2RsMiIgLHNkbDIpCisgICAgICAgICAg ICAgKCJzZGwyLXR0ZiIgLHNkbDItdHRmKQorICAgICAgICAgICAgICgic3BpY2UtcHJvdG9jb2wi ICxzcGljZS1wcm90b2NvbCkpKQorICAgKG5hdGl2ZS1pbnB1dHMgYCgoInBrZy1jb25maWciLCBw a2ctY29uZmlnKSkpCisgICAoYXJndW1lbnRzCisgICAgYCgjOnRlc3RzPyAjZiA7OyBObyB0ZXN0 cyBhcmUgYXZhaWxhYmxlLgorICAgICAgIzpwaGFzZXMgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJk LXBoYXNlcworICAgICAgICAgICAgICAgICAocmVwbGFjZSAnY29uZmlndXJlCisgICAgICAgICAg ICAgICAgICAgIChsYW1iZGEqICgjOmtleSBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAg ICAgICAgICAgICAgICAgICAgICAoY2hkaXIgImNsaWVudCIpKSkKKyAgICAgICAgICAgICAgICAg IChyZXBsYWNlICdpbnN0YWxsCisgICAgICAgICAgICAgICAgICAgIChsYW1iZGEqICgjOmtleSBv dXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAgICAgICAgICAgICAgICAobWtkaXIt cCAoc3RyaW5nLWFwcGVuZCAlb3V0cHV0ICIvYmluIikpCisgICAgICAgICAgICAgICAgICAgICAg KGNvcHktZmlsZSAiYmluL2xvb2tpbmctZ2xhc3MtY2xpZW50IiAoc3RyaW5nLWFwcGVuZAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJW91dHB1dCAiL2Jpbi9sb29raW5nLWdsYXNz LWNsaWVudCIpKSkpKSkpCisgICAoaG9tZS1wYWdlICJodHRwczovL2xvb2tpbmctZ2xhc3MuaG9z dGZpc3Npb24uY29tIikKKyAgIChzeW5vcHNpcyAiTG93LWxhdGVuY3kgS1ZNRlIgaW1wbGVtZW50 YXRpb24gZm9yIFFFTVUgZ3Vlc3RzIHdpdGggVkdBIFBDSQorcGFzc3Rocm91Z2giKQorICAgKGRl c2NyaXB0aW9uICJMb29raW5nR2xhc3MgaXMgYW4gZXh0cmVtZWx5IGxvdyBsYXRlbmN5IEtWTUZS IChLVk0gRnJhbWVSZWxheSkKK2ltcGxlbWVudGF0aW9uIGZvciBRRU1VIGd1ZXN0cyB3aXRoIFZH QSBQQ0kgUGFzc3Rocm91Z2guIikKKyAgIChsaWNlbnNlIGdwbDIpKSkKLS0gCjIuMTUuMQoK --=_ab04d4b952c09c47e082e4a6415d9e25-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 09:16:55 2017 Received: (at 29719) by debbugs.gnu.org; 15 Dec 2017 14:16:55 +0000 Received: from localhost ([127.0.0.1]:34849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePqnH-0005ET-AE for submit@debbugs.gnu.org; Fri, 15 Dec 2017 09:16:55 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:55339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePqnF-0005EM-Ms for 29719@debbugs.gnu.org; Fri, 15 Dec 2017 09:16:54 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 967F5F882; Fri, 15 Dec 2017 15:16:56 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4RFuBPmSdt-B; Fri, 15 Dec 2017 15:16:55 +0100 (CET) Received: from ribbon (unknown [193.50.110.249]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 8C18BC673; Fri, 15 Dec 2017 15:16:55 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Rutger Helling Subject: Re: [bug#29719] [PATCH] gnu: virtualization: Add lookingglass. References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Frimaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 15 Dec 2017 15:16:51 +0100 In-Reply-To: (Rutger Helling's message of "Fri, 15 Dec 2017 12:02:31 +0100") Message-ID: <87bmj0hy98.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29719 Cc: 29719@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello! Rutger Helling skribis: > From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep 17 00:00:00 2001 > From: Rutger Helling > Date: Fri, 15 Dec 2017 11:58:10 +0100 > Subject: [PATCH] gnu: virtualization: Add lookingglass. > > * gnu/packages/virtualization.scm (lookingglass): New variable. [...] > +(define-public lookingglass > + (package > + (name "lookingglass") Please run: ./etc/indent-code.el gnu/packages/virtualization.scm lookingglass > + (version "a5") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/gnif/LookingGlass/archive/" > + version ".tar.gz")) > + (file-name (string-append name "-" version)) > + (sha256 > + (base32 > + "0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf")))) > + (build-system gnu-build-system) > + (inputs `(("fontconfig" ,fontconfig) > + ("glu" ,glu) > + ("mesa" ,mesa) > + ("openssl" ,openssl) > + ("sdl2" ,sdl2) > + ("sdl2-ttf" ,sdl2-ttf) > + ("spice-protocol" ,spice-protocol))) > + (native-inputs `(("pkg-config", pkg-config))) > + (arguments > + `(#:tests? #f ;; No tests are available. > + #:phases (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (chdir "client"))) Return #t. > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (mkdir-p (string-append %output "/bin")) > + (copy-file "bin/looking-glass-client" (string-appe= nd > + %output "/bin/looking-glass-client"))))= ))) Same here. Use the =E2=80=98outputs=E2=80=99 argument instead of the =E2=80=98%output= =E2=80=99 global variable. Also, you can replace the mkdir-p/copy-file pair with just: (install-file "bin/looking-glass-client" (string-append (assoc-ref outputs "out") "/bin")) > + (home-page "https://looking-glass.hostfission.com") > + (synopsis "Low-latency KVMFR implementation for QEMU guests with VGA = PCI > +passthrough") > + (description "LookingGlass is an extremely low latency KVMFR (KVM Fra= meRelay) > +implementation for QEMU guests with VGA PCI Passthrough.") Could you shorten the synopsis and expound the description a little bit? :-) I find it hard to understand what this is about looking at this. > + (license gpl2))) AFAICS source file headers explicitly say =E2=80=9Cor any later version=E2= =80=9D, so this should be =E2=80=98gpl2+=E2=80=99. The rest LGTM. Could you send an updated patch? Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 10:06:02 2017 Received: (at 29719) by debbugs.gnu.org; 15 Dec 2017 15:06:02 +0000 Received: from localhost ([127.0.0.1]:35924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePrYn-0006Zy-JB for submit@debbugs.gnu.org; Fri, 15 Dec 2017 10:06:02 -0500 Received: from mx.kolabnow.com ([95.128.36.42]:56168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePrYl-0006Zj-Mj for 29719@debbugs.gnu.org; Fri, 15 Dec 2017 10:06:00 -0500 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id C75E61684; Fri, 15 Dec 2017 16:05:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mykolab.com; h= message-id:references:in-reply-to:subject:subject:from:from:date :date:content-type:content-type:mime-version:received:received :received; s=dkim20160331; t=1513350351; x=1513350373; bh=Oyg81F Ys6wd6cNUQrzPNiVebVQL/M2mw08vA3WB4bcM=; b=hhvxqDsMnK7pGLKPqVUee0 yfgb9JrMRf9kPwGFAhYnmEiwuRepJ6htC8gF09D83iEnuIKDW/J9fFKlQCHtMupq puvcpCuzzQN9zmjGAVvFawyr/f1raU78AllsDEX2gZDvJJN27RZYD+lzhkGp22Ew mvpSHPC9DzIgruw+7RNmnc1pRpyZClQzFjk+salKcG5l0k7Da+UKznfXdEqtahew vRqk9VJ9Jq9jXjYlKuNM1sB0owiilyuFH/s3++4sYxWxmWeX6/Hyzas3ACjL3q3u rcoXCg/NQagsRUXqyKeKi6Q5F2vhAm+M4sDMAyMPZGopUPSiEHIEEhPduVrKOufM 4xXCPkAjIhbYZpyRRPiw2FbcO1RT5lApujmX6uJ6znnjXnZbVkaAqDvINhMwLAQf 7jNbuo+jiE+beOShET7eqU/ifaYsxJqBlzv7w042wQEwLzXDqFgiiZijiKmTtxOR dFOr3vQyOl6mTw7N2ucJB+i0HIE9BWBwkn73R56kitvvIr311VOcmHEcIqXvv9Ak U670ZOWSoKHCX1ZTQkmFz49sY+0ybGSdUhA/z8/ci6i1yV2oznc6WPRbE7bfM6rC buOgVvXeSPw9t0nxauzG5YlI6dLIVG7nFcriAHOsTrx2e30fDHYhdJsLOUdkNkhW Sn41t4dxcsONBBM+LlHdc= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -0.998 X-Spam-Level: X-Spam-Status: No, score=-0.998 tagged_above=-10 required=4.5 tests=[ALL_TRUSTED=-1, AWL=-0.000, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mO5AJEVGNwVs; Fri, 15 Dec 2017 16:05:51 +0100 (CET) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id BEB4915C3; Fri, 15 Dec 2017 16:05:51 +0100 (CET) Received: from int-subm001.mykolab.com (unknown [10.9.37.1]) by int-mx001.mykolab.com (Postfix) with ESMTPS id A02C715C; Fri, 15 Dec 2017 16:05:51 +0100 (CET) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_6a10f202b9943e7c58586150033bc17e" Date: Fri, 15 Dec 2017 16:05:50 +0100 From: Rutger Helling To: ludo@gnu.org Subject: Re: [bug#29719] [PATCH] gnu: virtualization: Add lookingglass. In-Reply-To: <87bmj0hy98.fsf@gnu.org> References: <87bmj0hy98.fsf@gnu.org> Message-ID: <78341e76d8e762763e5c8c9b464ea9b7@mykolab.com> X-Sender: rhelling@mykolab.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29719 Cc: 29719@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=_6a10f202b9943e7c58586150033bc17e Content-Type: multipart/alternative; boundary="=_f0a05a1d85c6293ac7e410053e2a59c4" --=_f0a05a1d85c6293ac7e410053e2a59c4 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Thanks for reviewing! Here's an updated patch based on your feedback. On 2017-12-15 15:16, ludo@gnu.org wrote: > Hello! > > Rutger Helling skribis: > >> From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep 17 00:00:00 2001 >> From: Rutger Helling >> Date: Fri, 15 Dec 2017 11:58:10 +0100 >> Subject: [PATCH] gnu: virtualization: Add lookingglass. >> >> * gnu/packages/virtualization.scm (lookingglass): New variable. > > [...] > >> +(define-public lookingglass >> + (package >> + (name "lookingglass") > > Please run: > > ./etc/indent-code.el gnu/packages/virtualization.scm lookingglass > >> + (version "a5") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append "https://github.com/gnif/LookingGlass/archive/" >> + version ".tar.gz")) >> + (file-name (string-append name "-" version)) >> + (sha256 >> + (base32 >> + "0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf")))) >> + (build-system gnu-build-system) >> + (inputs `(("fontconfig" ,fontconfig) >> + ("glu" ,glu) >> + ("mesa" ,mesa) >> + ("openssl" ,openssl) >> + ("sdl2" ,sdl2) >> + ("sdl2-ttf" ,sdl2-ttf) >> + ("spice-protocol" ,spice-protocol))) >> + (native-inputs `(("pkg-config", pkg-config))) >> + (arguments >> + `(#:tests? #f ;; No tests are available. >> + #:phases (modify-phases %standard-phases >> + (replace 'configure >> + (lambda* (#:key outputs #:allow-other-keys) >> + (chdir "client"))) > > Return #t. > >> + (replace 'install >> + (lambda* (#:key outputs #:allow-other-keys) >> + (mkdir-p (string-append %output "/bin")) >> + (copy-file "bin/looking-glass-client" (string-append >> + %output "/bin/looking-glass-client"))))))) > > Same here. > > Use the 'outputs' argument instead of the '%output' global variable. > > Also, you can replace the mkdir-p/copy-file pair with just: > > (install-file "bin/looking-glass-client" > (string-append (assoc-ref outputs "out") "/bin")) > >> + (home-page "https://looking-glass.hostfission.com") >> + (synopsis "Low-latency KVMFR implementation for QEMU guests with VGA PCI >> +passthrough") >> + (description "LookingGlass is an extremely low latency KVMFR (KVM FrameRelay) >> +implementation for QEMU guests with VGA PCI Passthrough.") > > Could you shorten the synopsis and expound the description a little bit? > :-) I find it hard to understand what this is about looking at this. > >> + (license gpl2))) > > AFAICS source file headers explicitly say "or any later version", so > this should be 'gpl2+'. > > The rest LGTM. Could you send an updated patch? > > Thank you! > > Ludo'. --=_f0a05a1d85c6293ac7e410053e2a59c4 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8

Thanks for reviewing! Here's an updated patch based on your feedback.

On 2017-12-15 15:16, ludo@gnu.org wrote:

= Hello!

Rutger Helling <rhelling@mykolab.com> skribis:

From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep = 17 00:00:00 2001
From: Rutger Helling <rhelling@mykolab.com>
Date: Fri, 15 Dec 2017 11:5= 8:10 +0100
Subject: [PATCH] gnu: virtualization: Add lookingglass.
* gnu/packages/virtualization.scm (lookingglass): New variable= =2E

[...]

+(define-public lookingglass
+  (package +   (name "lookingglass")

Please run:

  ./etc/indent-code.el gnu/packag= es/virtualization.scm lookingglass

+   (version "a5")
+   (sour= ce
+    (origin
+     (metho= d url-fetch)
+     (uri (string-append "https://github.com/gnif/LookingGlass/archive/" +            &nb= sp;            = version ".tar.gz"))
+     (file-name (string-appe= nd name "-" version))
+     (sha256
+  = ;    (base32
+      &nbs= p;"0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf"))))
+  =  (build-system gnu-build-system)
+   (inputs `(("fontc= onfig" ,fontconfig)
+         = ;    ("glu" ,glu)
+      = ;       ("mesa" ,mesa)
+  &nb= sp;          ("openssl" ,= openssl)
+          &nbs= p;  ("sdl2" ,sdl2)
+       &n= bsp;     ("sdl2-ttf" ,sdl2-ttf)
+  &nbs= p;          ("spice-proto= col" ,spice-protocol)))
+   (native-inputs `(("pkg-config",= pkg-config)))
+   (arguments
+    `(#= :tests? #f ;; No tests are available.
+      = ;#:phases (modify-phases %standard-phases
+     &= nbsp;           (rep= lace 'configure
+         &nb= sp;          (lambda* (#:= key outputs #:allow-other-keys)
+       = ;            &n= bsp;  (chdir "client")))

Return #t.

+         &nbs= p;        (replace 'install
+=             &n= bsp;      (lambda* (#:key outputs #:allow-oth= er-keys)
+          &nbs= p;           (mkdir-= p (string-append %output "/bin"))
+      &nb= sp;            =    (copy-file "bin/looking-glass-client" (string-append
+             = ;            &n= bsp;       %output "/bin/looking-glass-c= lient")))))))

Same here.

Use the 'outputs' argument instead of the '%= output' global variable.

Also, you can replace the mkdir-p/cop= y-file pair with just:

  (install-file "bin/looking-= glass-client"
         &= nbsp;      (string-append (assoc-ref outputs = "out") "/bin"))

+   (home-page "https:/= /looking-glass.hostfission.com")
+   (synopsis "Low-lat= ency KVMFR implementation for QEMU guests with VGA PCI
+passthrough")=
+   (description "LookingGlass is an extremely low latency= KVMFR (KVM FrameRelay)
+implementation for QEMU guests with VGA PCI = Passthrough.")

Could you shorten the synopsis and expound the description a little = bit?
:-)  I find it hard to understand what this is about lookin= g at this.

+   (license gpl2)))

AFAICS source file headers explicitly say "or any later version", so=
this should be 'gpl2+'.

The rest LGTM.  Could you = send an updated patch?

Thank you!

Ludo'.


--=_f0a05a1d85c6293ac7e410053e2a59c4-- --=_6a10f202b9943e7c58586150033bc17e Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-virtualization-Add-lookingglass-v2.patch Content-Disposition: attachment; filename=0001-gnu-virtualization-Add-lookingglass-v2.patch; size=2783 RnJvbSAwMTUwMWVjZjA1Y2Y5NjJlZTkxMjljNTFiN2FmMTA4N2RlN2U0M2FlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSdXRnZXIgSGVsbGluZyA8cmhlbGxpbmdAbXlrb2xhYi5jb20+ CkRhdGU6IEZyaSwgMTUgRGVjIDIwMTcgMTY6MDE6MjggKzAxMDAKU3ViamVjdDogW1BBVENIXSBn bnU6IHZpcnR1YWxpemF0aW9uOiBBZGQgbG9va2luZ2dsYXNzLgoKKiBnbnUvcGFja2FnZXMvdmly dHVhbGl6YXRpb24uc2NtIChsb29raW5nZ2xhc3MpOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3Bh Y2thZ2VzL3ZpcnR1YWxpemF0aW9uLnNjbSB8IDQ0ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKQoKZGlmZiAt LWdpdCBhL2dudS9wYWNrYWdlcy92aXJ0dWFsaXphdGlvbi5zY20gYi9nbnUvcGFja2FnZXMvdmly dHVhbGl6YXRpb24uc2NtCmluZGV4IDg1NTYzZGRlNi4uODNhNThjMTdjIDEwMDY0NAotLS0gYS9n bnUvcGFja2FnZXMvdmlydHVhbGl6YXRpb24uc2NtCisrKyBiL2dudS9wYWNrYWdlcy92aXJ0dWFs aXphdGlvbi5zY20KQEAgLTM2LDYgKzM2LDcgQEAKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgZG5zKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBkb2Nib29rKQogICAjOnVzZS1t b2R1bGUgKGdudSBwYWNrYWdlcyBkb2N1bWVudGF0aW9uKQorICAjOnVzZS1tb2R1bGUgKGdudSBw YWNrYWdlcyBmb250dXRpbHMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGdsKQogICAj OnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBnbGliKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyBnbm9tZSkKQEAgLTcwOSwzICs3MTAsNDYgQEAgbWFpbmx5IGltcGxlbWVudGVkIGluIHVz ZXIgc3BhY2UuIikKIGluY3JlbWVudGFsIGJhY2t1cHMgb2YgcnVubmluZyBRRU1VIHZpcnR1YWwg bWFjaGluZXMgdmlhIFFNUCwgdGhlIFFFTVUKIE1hY2hpbmUgUHJvdG9jb2wuIikKICAgICAobGlj ZW5zZSBncGwzKykpKQorCisoZGVmaW5lLXB1YmxpYyBsb29raW5nZ2xhc3MKKyAgKHBhY2thZ2UK KyAgIChuYW1lICJsb29raW5nZ2xhc3MiKQorICAgKHZlcnNpb24gImE1IikKKyAgIChzb3VyY2UK KyAgICAob3JpZ2luCisgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAodXJpIChzdHJpbmct YXBwZW5kICJodHRwczovL2dpdGh1Yi5jb20vZ25pZi9Mb29raW5nR2xhc3MvYXJjaGl2ZS8iCisg ICAgICAgICAgICAgICAgICAgICAgICAgdmVyc2lvbiAiLnRhci5neiIpKQorICAgICAoZmlsZS1u YW1lIChzdHJpbmctYXBwZW5kIG5hbWUgIi0iIHZlcnNpb24pKQorICAgICAoc2hhMjU2CisgICAg ICAoYmFzZTMyCisgICAgICAgIjBscmI4MjE5MTRmcDI3eGFxMHNwd2hiYmxzc3o1NXBoaXlndmRs dmNya2lmYTEzOHY4cGYiKSkpKQorICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQor ICAgKGlucHV0cyBgKCgiZm9udGNvbmZpZyIgLGZvbnRjb25maWcpCisgICAgICAgICAgICAgKCJn bHUiICxnbHUpCisgICAgICAgICAgICAgKCJtZXNhIiAsbWVzYSkKKyAgICAgICAgICAgICAoIm9w ZW5zc2wiICxvcGVuc3NsKQorICAgICAgICAgICAgICgic2RsMiIgLHNkbDIpCisgICAgICAgICAg ICAgKCJzZGwyLXR0ZiIgLHNkbDItdHRmKQorICAgICAgICAgICAgICgic3BpY2UtcHJvdG9jb2wi ICxzcGljZS1wcm90b2NvbCkpKQorICAgKG5hdGl2ZS1pbnB1dHMgYCgoInBrZy1jb25maWciLCBw a2ctY29uZmlnKSkpCisgICAoYXJndW1lbnRzCisgICAgYCgjOnRlc3RzPyAjZiA7OyBObyB0ZXN0 cyBhcmUgYXZhaWxhYmxlLgorICAgICAgIzpwaGFzZXMgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJk LXBoYXNlcworICAgICAgICAgICAgICAgICAocmVwbGFjZSAnY29uZmlndXJlCisgICAgICAgICAg ICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAg ICAgICAgICAgICAgICAgICAgKGNoZGlyICJjbGllbnQiKQorICAgICAgICAgICAgICAgICAgICAg I3QpKQorICAgICAgICAgICAgICAgICAocmVwbGFjZSAnaW5zdGFsbAorICAgICAgICAgICAgICAg ICAgIChsYW1iZGEqICgjOmtleSBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAg ICAgICAgICAgICAgIChpbnN0YWxsLWZpbGUgImJpbi9sb29raW5nLWdsYXNzLWNsaWVudCIKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgKGFzc29jLXJl ZiBvdXRwdXRzICJvdXQiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiL2JpbiIpKQorICAgICAgICAgICAgICAgICAgICAgI3QpKSkpKQorICAgKGhv bWUtcGFnZSAiaHR0cHM6Ly9sb29raW5nLWdsYXNzLmhvc3RmaXNzaW9uLmNvbSIpCisgICAoc3lu b3BzaXMgIktWTSBGcmFtZSBSZWxheSAoS1ZNRlIpIGltcGxlbWVudGF0aW9uIikKKyAgIChkZXNj cmlwdGlvbiAiTG9va2luZyBHbGFzcyBhbGxvd3MgdGhlIHVzZSBvZiBhIEtWTSAoS2VybmVsLWJh c2VkIFZpcnR1YWwKK01hY2hpbmUpIGNvbmZpZ3VyZWQgZm9yIFZHQSBQQ0kgUGFzcy10aHJvdWdo IHdpdGhvdXQgYW4gYXR0YWNoZWQgcGh5c2ljYWwKK21vbml0b3IsIGtleWJvYXJkIG9yIG1vdXNl LiBJdCBkaXNwbGF5cyB0aGUgVk0ncyByZW5kZXJlZCBjb250ZW50cyBvbiB5b3VyIG1haW4KK21v bml0b3IvR1BVLiIpCisgICAobGljZW5zZSBncGwyKykpKQotLSAKMi4xNS4xCgo= --=_6a10f202b9943e7c58586150033bc17e-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 10:12:05 2017 Received: (at 29719) by debbugs.gnu.org; 15 Dec 2017 15:12:05 +0000 Received: from localhost ([127.0.0.1]:35928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePree-0006iL-MW for submit@debbugs.gnu.org; Fri, 15 Dec 2017 10:12:05 -0500 Received: from mx.kolabnow.com ([95.128.36.42]:56304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePreY-0006hl-LV for 29719@debbugs.gnu.org; Fri, 15 Dec 2017 10:11:59 -0500 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id 299321684; Fri, 15 Dec 2017 16:11:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mykolab.com; h= message-id:references:in-reply-to:subject:subject:from:from:date :date:content-type:content-type:mime-version:received:received :received; s=dkim20160331; t=1513350712; x=1513350734; bh=f0XWI2 8ZY8gfmacikLTqLXJB6iixhwkENrMzp26rH6E=; b=XgRs0xsTbTYdiu1zjwfsOT r2MBhM8jBQJWRrrnffCECroT2r53m+R6Lq/QkGFTmdKzCBa9Dq2F4mI5Sdl1wNGi aoRPjcwqOge8AXl0Lo3DrRGj55xOMeMB2JueN+s7NTRTA9RMGfli0hEWD599T5Bk SCBiTYQvKEs0I0bg4NqqmzyVXu5PwQUgwvUGpioMl2HjDVzth7YIwaUYgn8OLgZi wSwE6qhxIZ18kYRjfwDxJX7I+K89Vx2BawbiqQmj+SGKKCheNILeDvhFd1zWD9G5 hIGg2tbWrj+KeGTbubTkeyrQY1fWSU2kl+uiexOuNvUiEq97c30DQWedhIx7a3Tw MI3MtEr6VXJeU9ACyQTrssCXAmrfrtMCOqAGEi4omlJ53i0GqvEN22SW77R9X07V 5UzqTervZtCu9Woc2Z2LEkyZ10OewUxnsgAEc4HPVT4T1GtNjWk+zjiCW9Ybwti2 xPIDEGrBVFOz3nMOLl2Z/fqFCGgrgpDoylf+qtKGV7LifVVPsuINwIctWNmRVUvq qxhIW4GSIBWLc+YHjLl3HHig2YCqMMUhEKYRSobFhOc1yDce/52ACSUk+plIEDSw 8obIKGOpDM40FQNMKXnQkmLZsHQDezjQdruy7ajhYiR5nViNX1puwZGmO9svZ8md Ik/WPrRFsEP9vuDaAVvkI= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -0.998 X-Spam-Level: X-Spam-Status: No, score=-0.998 tagged_above=-10 required=4.5 tests=[ALL_TRUSTED=-1, AWL=-0.000, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nQnZbAHWTWiU; Fri, 15 Dec 2017 16:11:52 +0100 (CET) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id 5552512F2; Fri, 15 Dec 2017 16:11:52 +0100 (CET) Received: from int-subm001.mykolab.com (unknown [10.9.37.1]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 34649232C; Fri, 15 Dec 2017 16:11:52 +0100 (CET) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_4c0b20ece82a7ae101c6550fdd87c75f" Date: Fri, 15 Dec 2017 16:11:51 +0100 From: Rutger Helling To: ludo@gnu.org Subject: Re: [bug#29719] [PATCH] gnu: virtualization: Add lookingglass. In-Reply-To: <78341e76d8e762763e5c8c9b464ea9b7@mykolab.com> References: <87bmj0hy98.fsf@gnu.org> <78341e76d8e762763e5c8c9b464ea9b7@mykolab.com> Message-ID: <649e163286d9a0c40f551b22e502a03b@mykolab.com> X-Sender: rhelling@mykolab.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29719 Cc: 29719@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=_4c0b20ece82a7ae101c6550fdd87c75f Content-Type: multipart/alternative; boundary="=_8f9e9020add901be0412d437605aae14" --=_8f9e9020add901be0412d437605aae14 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Forgot to put two spaces in the lines for the description. Here's the proper patch, sorry about that. On 2017-12-15 16:05, Rutger Helling wrote: > Thanks for reviewing! Here's an updated patch based on your feedback. > > On 2017-12-15 15:16, ludo@gnu.org wrote: > Hello! > > Rutger Helling skribis: > > From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep 17 00:00:00 2001 > From: Rutger Helling > Date: Fri, 15 Dec 2017 11:58:10 +0100 > Subject: [PATCH] gnu: virtualization: Add lookingglass. > > * gnu/packages/virtualization.scm (lookingglass): New variable. > [...] > > +(define-public lookingglass > + (package > + (name "lookingglass") > Please run: > > ./etc/indent-code.el gnu/packages/virtualization.scm lookingglass > > + (version "a5") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/gnif/LookingGlass/archive/" > + version ".tar.gz")) > + (file-name (string-append name "-" version)) > + (sha256 > + (base32 > + "0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf")))) > + (build-system gnu-build-system) > + (inputs `(("fontconfig" ,fontconfig) > + ("glu" ,glu) > + ("mesa" ,mesa) > + ("openssl" ,openssl) > + ("sdl2" ,sdl2) > + ("sdl2-ttf" ,sdl2-ttf) > + ("spice-protocol" ,spice-protocol))) > + (native-inputs `(("pkg-config", pkg-config))) > + (arguments > + `(#:tests? #f ;; No tests are available. > + #:phases (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (chdir "client"))) > Return #t. > > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (mkdir-p (string-append %output "/bin")) > + (copy-file "bin/looking-glass-client" (string-append > + %output "/bin/looking-glass-client"))))))) > Same here. > > Use the 'outputs' argument instead of the '%output' global variable. > > Also, you can replace the mkdir-p/copy-file pair with just: > > (install-file "bin/looking-glass-client" > (string-append (assoc-ref outputs "out") "/bin")) > > + (home-page "https://looking-glass.hostfission.com") > + (synopsis "Low-latency KVMFR implementation for QEMU guests with VGA PCI > +passthrough") > + (description "LookingGlass is an extremely low latency KVMFR (KVM FrameRelay) > +implementation for QEMU guests with VGA PCI Passthrough.") > Could you shorten the synopsis and expound the description a little bit? > :-) I find it hard to understand what this is about looking at this. > > + (license gpl2))) > AFAICS source file headers explicitly say "or any later version", so > this should be 'gpl2+'. > > The rest LGTM. Could you send an updated patch? > > Thank you! > > Ludo'. --=_8f9e9020add901be0412d437605aae14 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8

Forgot to put two spaces in the lines for the description.
Here's t= he proper patch, sorry about that.

On 2017-12-15 16:05, Rutger Helling wrote:

Thanks for reviewing! Here's an updated patch based on your feedback.

On 2017-12-15 15:16, ludo@gnu.org wrote:

Hello!

Rutger Helling <rhelling@mykolab.com> skribis:

From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep 17 00:00:00 2= 001
From: Rutger Helling <= rhelling@mykolab.com>
Date: Fri, 15 Dec 2017 11:58:10 +0100 Subject: [PATCH] gnu: virtualization: Add lookingglass.

* = gnu/packages/virtualization.scm (lookingglass): New variable.

[...]

+(define-public lookingglass
+  (package
+  &= nbsp;(name "lookingglass")

Please run:

  ./etc/indent-code.el gnu/packag= es/virtualization.scm lookingglass

+   (version "a5")
+   (source
+ &n= bsp;  (origin
+     (method url-fetch)<= br /> +     (uri (string-append "https://github.com/gnif/LookingGlass/archive/"
+  &nb= sp;            =           version ".tar= =2Egz"))
+     (file-name (string-append name "-"= version))
+     (sha256
+   &nbs= p;  (base32
+       "0lrb8219= 14fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf"))))
+   (buil= d-system gnu-build-system)
+   (inputs `(("fontconfig" ,fon= tconfig)
+          &nbs= p;  ("glu" ,glu)
+       &nbs= p;     ("mesa" ,mesa)
+    &n= bsp;        ("openssl" ,openssl) +            &nb= sp;("sdl2" ,sdl2)
+         &= nbsp;   ("sdl2-ttf" ,sdl2-ttf)
+    &nb= sp;        ("spice-protocol" ,spice= -protocol)))
+   (native-inputs `(("pkg-config", pkg-config= )))
+   (arguments
+    `(#:tests? #f = ;; No tests are available.
+      #:phases (= modify-phases %standard-phases
+       =           (replace 'confi= gure
+           &n= bsp;        (lambda* (#:key outputs= #:allow-other-keys)
+        &nbs= p;            &= nbsp;(chdir "client")))

Return #t.

+            = ;      (replace 'install
+   =             &nb= sp;    (lambda* (#:key outputs #:allow-other-keys)
+             = ;         (mkdir-p (string-app= end %output "/bin"))
+        &nbs= p;            &= nbsp;(copy-file "bin/looking-glass-client" (string-append
+  &nb= sp;            =             &nb= sp;     %output "/bin/looking-glass-client")))))))=

Same here.

Use the 'outputs' argument instead of the '%= output' global variable.

Also, you can replace the mkdir-p/cop= y-file pair with just:

  (install-file "bin/looking-= glass-client"
         &= nbsp;      (string-append (assoc-ref outputs = "out") "/bin"))

+   (home-page "https://looking-glas= s.hostfission.com")
+   (synopsis "Low-latency KVMFR im= plementation for QEMU guests with VGA PCI
+passthrough")
+ &nbs= p; (description "LookingGlass is an extremely low latency KVMFR (KVM F= rameRelay)
+implementation for QEMU guests with VGA PCI Passthrough= =2E")

Could you shorten the synopsis and expound the description a little = bit?
:-)  I find it hard to understand what this is about lookin= g at this.

+   (license gpl2)))

AFAICS source file headers explicitly say "or any later version", so=
this should be 'gpl2+'.

The rest LGTM.  Could you = send an updated patch?

Thank you!

Ludo'.



--=_8f9e9020add901be0412d437605aae14-- --=_4c0b20ece82a7ae101c6550fdd87c75f Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-virtualization-Add-lookingglass-v3.patch Content-Disposition: attachment; filename=0001-gnu-virtualization-Add-lookingglass-v3.patch; size=2784 RnJvbSA0NzlkYjJmMTE4MzdhMTc1NTk4ZmNjMDRjYzA3YmVlMDMwZjE3ZmIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSdXRnZXIgSGVsbGluZyA8cmhlbGxpbmdAbXlrb2xhYi5jb20+ CkRhdGU6IEZyaSwgMTUgRGVjIDIwMTcgMTY6MDg6MzAgKzAxMDAKU3ViamVjdDogW1BBVENIXSBn bnU6IHZpcnR1YWxpemF0aW9uOiBBZGQgbG9va2luZ2dsYXNzLgoKKiBnbnUvcGFja2FnZXMvdmly dHVhbGl6YXRpb24uc2NtIChsb29raW5nZ2xhc3MpOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3Bh Y2thZ2VzL3ZpcnR1YWxpemF0aW9uLnNjbSB8IDQ0ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKQoKZGlmZiAt LWdpdCBhL2dudS9wYWNrYWdlcy92aXJ0dWFsaXphdGlvbi5zY20gYi9nbnUvcGFja2FnZXMvdmly dHVhbGl6YXRpb24uc2NtCmluZGV4IDg1NTYzZGRlNi4uMmZjZDllNWE3IDEwMDY0NAotLS0gYS9n bnUvcGFja2FnZXMvdmlydHVhbGl6YXRpb24uc2NtCisrKyBiL2dudS9wYWNrYWdlcy92aXJ0dWFs aXphdGlvbi5zY20KQEAgLTM2LDYgKzM2LDcgQEAKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgZG5zKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBkb2Nib29rKQogICAjOnVzZS1t b2R1bGUgKGdudSBwYWNrYWdlcyBkb2N1bWVudGF0aW9uKQorICAjOnVzZS1tb2R1bGUgKGdudSBw YWNrYWdlcyBmb250dXRpbHMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGdsKQogICAj OnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBnbGliKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyBnbm9tZSkKQEAgLTcwOSwzICs3MTAsNDYgQEAgbWFpbmx5IGltcGxlbWVudGVkIGluIHVz ZXIgc3BhY2UuIikKIGluY3JlbWVudGFsIGJhY2t1cHMgb2YgcnVubmluZyBRRU1VIHZpcnR1YWwg bWFjaGluZXMgdmlhIFFNUCwgdGhlIFFFTVUKIE1hY2hpbmUgUHJvdG9jb2wuIikKICAgICAobGlj ZW5zZSBncGwzKykpKQorCisoZGVmaW5lLXB1YmxpYyBsb29raW5nZ2xhc3MKKyAgKHBhY2thZ2UK KyAgIChuYW1lICJsb29raW5nZ2xhc3MiKQorICAgKHZlcnNpb24gImE1IikKKyAgIChzb3VyY2UK KyAgICAob3JpZ2luCisgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAodXJpIChzdHJpbmct YXBwZW5kICJodHRwczovL2dpdGh1Yi5jb20vZ25pZi9Mb29raW5nR2xhc3MvYXJjaGl2ZS8iCisg ICAgICAgICAgICAgICAgICAgICAgICAgdmVyc2lvbiAiLnRhci5neiIpKQorICAgICAoZmlsZS1u YW1lIChzdHJpbmctYXBwZW5kIG5hbWUgIi0iIHZlcnNpb24pKQorICAgICAoc2hhMjU2CisgICAg ICAoYmFzZTMyCisgICAgICAgIjBscmI4MjE5MTRmcDI3eGFxMHNwd2hiYmxzc3o1NXBoaXlndmRs dmNya2lmYTEzOHY4cGYiKSkpKQorICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQor ICAgKGlucHV0cyBgKCgiZm9udGNvbmZpZyIgLGZvbnRjb25maWcpCisgICAgICAgICAgICAgKCJn bHUiICxnbHUpCisgICAgICAgICAgICAgKCJtZXNhIiAsbWVzYSkKKyAgICAgICAgICAgICAoIm9w ZW5zc2wiICxvcGVuc3NsKQorICAgICAgICAgICAgICgic2RsMiIgLHNkbDIpCisgICAgICAgICAg ICAgKCJzZGwyLXR0ZiIgLHNkbDItdHRmKQorICAgICAgICAgICAgICgic3BpY2UtcHJvdG9jb2wi ICxzcGljZS1wcm90b2NvbCkpKQorICAgKG5hdGl2ZS1pbnB1dHMgYCgoInBrZy1jb25maWciLCBw a2ctY29uZmlnKSkpCisgICAoYXJndW1lbnRzCisgICAgYCgjOnRlc3RzPyAjZiA7OyBObyB0ZXN0 cyBhcmUgYXZhaWxhYmxlLgorICAgICAgIzpwaGFzZXMgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJk LXBoYXNlcworICAgICAgICAgICAgICAgICAocmVwbGFjZSAnY29uZmlndXJlCisgICAgICAgICAg ICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAg ICAgICAgICAgICAgICAgICAgKGNoZGlyICJjbGllbnQiKQorICAgICAgICAgICAgICAgICAgICAg I3QpKQorICAgICAgICAgICAgICAgICAocmVwbGFjZSAnaW5zdGFsbAorICAgICAgICAgICAgICAg ICAgIChsYW1iZGEqICgjOmtleSBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAg ICAgICAgICAgICAgIChpbnN0YWxsLWZpbGUgImJpbi9sb29raW5nLWdsYXNzLWNsaWVudCIKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgKGFzc29jLXJl ZiBvdXRwdXRzICJvdXQiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiL2JpbiIpKQorICAgICAgICAgICAgICAgICAgICAgI3QpKSkpKQorICAgKGhv bWUtcGFnZSAiaHR0cHM6Ly9sb29raW5nLWdsYXNzLmhvc3RmaXNzaW9uLmNvbSIpCisgICAoc3lu b3BzaXMgIktWTSBGcmFtZSBSZWxheSAoS1ZNRlIpIGltcGxlbWVudGF0aW9uIikKKyAgIChkZXNj cmlwdGlvbiAiTG9va2luZyBHbGFzcyBhbGxvd3MgdGhlIHVzZSBvZiBhIEtWTSAoS2VybmVsLWJh c2VkIFZpcnR1YWwKK01hY2hpbmUpIGNvbmZpZ3VyZWQgZm9yIFZHQSBQQ0kgUGFzcy10aHJvdWdo IHdpdGhvdXQgYW4gYXR0YWNoZWQgcGh5c2ljYWwKK21vbml0b3IsIGtleWJvYXJkIG9yIG1vdXNl LiAgSXQgZGlzcGxheXMgdGhlIFZNJ3MgcmVuZGVyZWQgY29udGVudHMgb24geW91ciBtYWluCitt b25pdG9yL0dQVS4iKQorICAgKGxpY2Vuc2UgZ3BsMispKSkKLS0gCjIuMTUuMQoK --=_4c0b20ece82a7ae101c6550fdd87c75f-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 10:39:30 2017 Received: (at 29719-done) by debbugs.gnu.org; 15 Dec 2017 15:39:30 +0000 Received: from localhost ([127.0.0.1]:35959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePs5A-0007Lv-Fa for submit@debbugs.gnu.org; Fri, 15 Dec 2017 10:39:30 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:55653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePs59-0007Ln-3H for 29719-done@debbugs.gnu.org; Fri, 15 Dec 2017 10:39:27 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 3D98510494; Fri, 15 Dec 2017 16:39:29 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fKyn6KGlGS8Q; Fri, 15 Dec 2017 16:39:28 +0100 (CET) Received: from ribbon (unknown [193.50.110.249]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DE85B10492; Fri, 15 Dec 2017 16:39:27 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Rutger Helling Subject: Re: [bug#29719] [PATCH] gnu: virtualization: Add lookingglass. References: <87bmj0hy98.fsf@gnu.org> <78341e76d8e762763e5c8c9b464ea9b7@mykolab.com> <649e163286d9a0c40f551b22e502a03b@mykolab.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Frimaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 15 Dec 2017 16:39:23 +0100 In-Reply-To: <649e163286d9a0c40f551b22e502a03b@mykolab.com> (Rutger Helling's message of "Fri, 15 Dec 2017 16:11:51 +0100") Message-ID: <876098gfv8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29719-done Cc: 29719-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Rutger Helling skribis: > From 479db2f11837a175598fcc04cc07bee030f17fb1 Mon Sep 17 00:00:00 2001 > From: Rutger Helling > Date: Fri, 15 Dec 2017 16:08:30 +0100 > Subject: [PATCH] gnu: virtualization: Add lookingglass. > > * gnu/packages/virtualization.scm (lookingglass): New variable. Applied, thanks! Ludo'. From unknown Tue Aug 19 21:03:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 13 Jan 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator