GNU bug report logs - #29712
26.0.90; Three emacs-26 elisp tests are failing on darwin

Previous Next

Full log

View this message in rfc822 format

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 29712 <at> debbugs.gnu.org
Subject: bug#29712: 26.0.90; Three emacs-26 elisp tests are failing on darwin
Date: Sat, 16 Dec 2017 16:42:18 +0000

On Sat, Dec 16, 2017 at 06:19:54PM +0200, Eli Zaretskii wrote:
> > Date: Sat, 16 Dec 2017 15:07:32 +0000
> > From: Alan Third <alan <at> idiocy.org>
> > Cc: 29712 <at> debbugs.gnu.org
> > 
> > > Does it help to bind file-name-coding-system to utf-8-hfs-unix in that
> > > test?
> > 
> > Yes, the test passes.
> 
> Then I think this is the right fix.
> 
> Maybe we should do that by default on Darwin, as it makes little sense
> to convert EOLs in file names?  Did the changeset in 83f0d60 on master
> did that for Darwin as well?

No, it’s set in ns-win.el:

modified   lisp/term/ns-win.el
@@ -354,7 +354,7 @@ ns-delete-working-text
   ;; Used prior to Emacs 25.
   (define-coding-system-alias 'utf-8-nfd 'utf-8-hfs)
 
-  (set-file-name-coding-system 'utf-8-hfs))
+  (set-file-name-coding-system 'utf-8-hfs-unix))
 
 ;;;; Inter-app communications support.
 
I made the change and everything looks ok; the other tests still pass.
I don’t know anything about coding systems, though, so I could be
missing something.

-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.