Package: guix-patches;
Reported by: Mark Meyer <mark <at> ofosos.org>
Date: Thu, 14 Dec 2017 00:20:02 UTC
Severity: normal
Done: Mark Meyer <mark <at> ofosos.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29703 in the body.
You can then email your comments to 29703 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
View this report as an mbox folder, status mbox, maintainer mbox
guix-patches <at> gnu.org:bug#29703; Package guix-patches.
(Thu, 14 Dec 2017 00:20:02 GMT) Full text and rfc822 format available.Mark Meyer <mark <at> ofosos.org>:guix-patches <at> gnu.org.
(Thu, 14 Dec 2017 00:20:02 GMT) Full text and rfc822 format available.Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
From: Mark Meyer <mark <at> ofosos.org> To: guix-patches <at> gnu.org Subject: Improve Krita Date: Thu, 14 Dec 2017 01:18:46 +0100
[Message part 1 (text/plain, inline)]
Hi, I'm currently testing several changes to Krita, I've broken stuff up into three commits/patches which are attached. These - add a dependency to vc (vectorize Krita) - enable OpenEXR - enable JPEG (via libjpeg-turbo) Cheers, Mark -- Mark Meyer mark <at> ofosos.org
[0003-gnu-krita-Add-OpenEXR-support.patch (text/x-patch, attachment)]
[0002-gnu-krita-Add-vc-to-native-inputs.patch (text/x-patch, attachment)]
[0001-gnu-krita-Add-libjpeg-turbo-to-inputs.patch (text/x-patch, attachment)]
guix-patches <at> gnu.org:bug#29703; Package guix-patches.
(Thu, 14 Dec 2017 00:42:01 GMT) Full text and rfc822 format available.Message #8 received at 29703 <at> debbugs.gnu.org (full text, mbox):
From: Mark Meyer <mark <at> ofosos.org> To: 29703 <at> debbugs.gnu.org Subject: Looks good Date: Thu, 14 Dec 2017 01:41:45 +0100
Ok, I built this changed version and it supports both OpenEXR and JPEG images. I can't easily test the vectorization. -- Mark Meyer mark <at> ofosos.org
guix-patches <at> gnu.org:bug#29703; Package guix-patches.
(Thu, 14 Dec 2017 11:56:02 GMT) Full text and rfc822 format available.Message #11 received at 29703 <at> debbugs.gnu.org (full text, mbox):
From: ng0 <ng0 <at> n0.is> To: Mark Meyer <mark <at> ofosos.org> Cc: 29703 <at> debbugs.gnu.org Subject: Re: [bug#29703] Improve Krita Date: Thu, 14 Dec 2017 11:55:31 +0000
[Message part 1 (text/plain, inline)]
Hi Mark,
Mark Meyer transcribed 5.4K bytes:
> Hi,
> I'm currently testing several changes to Krita, I've broken stuff up
> into three commits/patches which are attached.
>
> These
> - add a dependency to vc (vectorize Krita)
> - enable OpenEXR
> - enable JPEG (via libjpeg-turbo)
Thanks for the work on Krita.
I haven't tested them, but it looks good.
It would be okay to squash these commits into one, we've done this
in the past in similar cases (see `git log gnu/packages/gnunet.scm`
for libextractor for example).
> Cheers, Mark
>
> --
> Mark Meyer
> mark <at> ofosos.org
> From 8f631d21210af3c8ec35594f5a99e4259665a7c4 Mon Sep 17 00:00:00 2001
> From: Mark Meyer <mark <at> ofosos.org>
> Date: Thu, 14 Dec 2017 00:49:05 +0100
> Subject: [PATCH] * gnu: krita: Add OpenEXR support.
>
> ---
> gnu/packages/kde.scm | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
> index d74325c5d..89ad30ecd 100644
> --- a/gnu/packages/kde.scm
> +++ b/gnu/packages/kde.scm
> @@ -256,7 +256,10 @@ plugins, as well as code to create plugins, or complete applications.")
> (string-append "-DWITH_LibRaw="
> (assoc-ref %build-inputs "libraw"))
> (string-append "-DWITH_TIFF="
> - (assoc-ref %build-inputs "libtiff")))))
> + (assoc-ref %build-inputs "libtiff"))
> + (string-append "-DCMAKE_CXX_FLAGS=-I"
> + (assoc-ref %build-inputs "ilmbase")
> + "/include/OpenEXR"))))
> (native-inputs
> `(("curl" ,curl)
> ("eigen" ,eigen)
> @@ -298,7 +301,9 @@ plugins, as well as code to create plugins, or complete applications.")
> ("poppler-qt5" ,poppler-qt5)
> ("libraw" ,libraw)
> ("libtiff" ,libtiff)
> - ("perl" ,perl)))
> + ("perl" ,perl)
> + ("ilmbase" ,ilmbase)
> + ("openexr" ,openexr)))
> (home-page "https://krita.org")
> (synopsis "Digital painting application")
> (description
> --
> 2.15.0
>
> From adea158919123c732ea2a314133188a0c13929e5 Mon Sep 17 00:00:00 2001
> From: Mark Meyer <mark <at> ofosos.org>
> Date: Thu, 14 Dec 2017 00:36:26 +0100
> Subject: [PATCH] * gnu: krita: Add vc to native-inputs.
>
> ---
> gnu/packages/kde.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
> index e8f38b920..d74325c5d 100644
> --- a/gnu/packages/kde.scm
> +++ b/gnu/packages/kde.scm
> @@ -263,7 +263,8 @@ plugins, as well as code to create plugins, or complete applications.")
> ("extra-cmake-modules" ,extra-cmake-modules)
> ("gettext-minimal" ,gettext-minimal)
> ("kitemmodels" ,kitemmodels)
> - ("qwt" ,qwt)))
> + ("qwt" ,qwt)
> + ("vc" ,vc)))
> (inputs
> `(("qtbase" ,qtbase)
> ("qtdeclarative" ,qtdeclarative)
> --
> 2.15.0
>
> From 85e672fc58cad18177651f7e8c2af99e12475d88 Mon Sep 17 00:00:00 2001
> From: Mark Meyer <mark <at> ofosos.org>
> Date: Wed, 13 Dec 2017 23:49:09 +0100
> Subject: [PATCH] * gnu: krita: Add libjpeg-turbo to inputs.
>
> ---
> gnu/packages/kde.scm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
> index b5a3df2ca..e8f38b920 100644
> --- a/gnu/packages/kde.scm
> +++ b/gnu/packages/kde.scm
> @@ -287,6 +287,7 @@ plugins, as well as code to create plugins, or complete applications.")
> ("exiv2" ,exiv2)
> ("lcms" ,lcms)
> ("libpng" ,libpng)
> + ("libjpeg-turbo" ,libjpeg-turbo)
> ("zlib" ,zlib)
> ("libx11" ,libx11)
> ("libxcb" ,libxcb)
> --
> 2.15.0
>
--
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
WWW: https://n0.is
[signature.asc (application/pgp-signature, inline)]
guix-patches <at> gnu.org:bug#29703; Package guix-patches.
(Thu, 14 Dec 2017 14:03:01 GMT) Full text and rfc822 format available.Message #14 received at 29703 <at> debbugs.gnu.org (full text, mbox):
From: Mark Meyer <mark <at> ofosos.org> To: ng0 <ng0 <at> n0.is> Cc: 29703 <at> debbugs.gnu.org Subject: Re: [bug#29703] Improve Krita Date: Thu, 14 Dec 2017 15:02:51 +0100
[Message part 1 (text/plain, inline)]
Ok, see the following patch. This should also be aligned with the commit
message conventions.
On Thu, Dec 14, 2017, at 12:55, ng0 wrote:
> Hi Mark,
>
> Mark Meyer transcribed 5.4K bytes:
> > Hi,
> > I'm currently testing several changes to Krita, I've broken stuff up
> > into three commits/patches which are attached.
> >
> > These
> > - add a dependency to vc (vectorize Krita)
> > - enable OpenEXR
> > - enable JPEG (via libjpeg-turbo)
>
> Thanks for the work on Krita.
> I haven't tested them, but it looks good.
> It would be okay to squash these commits into one, we've done this
> in the past in similar cases (see `git log gnu/packages/gnunet.scm`
> for libextractor for example).
>
> > Cheers, Mark
> >
> > --
> > Mark Meyer
> > mark <at> ofosos.org
>
> > From 8f631d21210af3c8ec35594f5a99e4259665a7c4 Mon Sep 17 00:00:00 2001
> > From: Mark Meyer <mark <at> ofosos.org>
> > Date: Thu, 14 Dec 2017 00:49:05 +0100
> > Subject: [PATCH] * gnu: krita: Add OpenEXR support.
> >
> > ---
> > gnu/packages/kde.scm | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
> > index d74325c5d..89ad30ecd 100644
> > --- a/gnu/packages/kde.scm
> > +++ b/gnu/packages/kde.scm
> > @@ -256,7 +256,10 @@ plugins, as well as code to create plugins, or complete applications.")
> > (string-append "-DWITH_LibRaw="
> > (assoc-ref %build-inputs "libraw"))
> > (string-append "-DWITH_TIFF="
> > - (assoc-ref %build-inputs "libtiff")))))
> > + (assoc-ref %build-inputs "libtiff"))
> > + (string-append "-DCMAKE_CXX_FLAGS=-I"
> > + (assoc-ref %build-inputs "ilmbase")
> > + "/include/OpenEXR"))))
> > (native-inputs
> > `(("curl" ,curl)
> > ("eigen" ,eigen)
> > @@ -298,7 +301,9 @@ plugins, as well as code to create plugins, or complete applications.")
> > ("poppler-qt5" ,poppler-qt5)
> > ("libraw" ,libraw)
> > ("libtiff" ,libtiff)
> > - ("perl" ,perl)))
> > + ("perl" ,perl)
> > + ("ilmbase" ,ilmbase)
> > + ("openexr" ,openexr)))
> > (home-page "https://krita.org")
> > (synopsis "Digital painting application")
> > (description
> > --
> > 2.15.0
> >
>
> > From adea158919123c732ea2a314133188a0c13929e5 Mon Sep 17 00:00:00 2001
> > From: Mark Meyer <mark <at> ofosos.org>
> > Date: Thu, 14 Dec 2017 00:36:26 +0100
> > Subject: [PATCH] * gnu: krita: Add vc to native-inputs.
> >
> > ---
> > gnu/packages/kde.scm | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
> > index e8f38b920..d74325c5d 100644
> > --- a/gnu/packages/kde.scm
> > +++ b/gnu/packages/kde.scm
> > @@ -263,7 +263,8 @@ plugins, as well as code to create plugins, or complete applications.")
> > ("extra-cmake-modules" ,extra-cmake-modules)
> > ("gettext-minimal" ,gettext-minimal)
> > ("kitemmodels" ,kitemmodels)
> > - ("qwt" ,qwt)))
> > + ("qwt" ,qwt)
> > + ("vc" ,vc)))
> > (inputs
> > `(("qtbase" ,qtbase)
> > ("qtdeclarative" ,qtdeclarative)
> > --
> > 2.15.0
> >
>
> > From 85e672fc58cad18177651f7e8c2af99e12475d88 Mon Sep 17 00:00:00 2001
> > From: Mark Meyer <mark <at> ofosos.org>
> > Date: Wed, 13 Dec 2017 23:49:09 +0100
> > Subject: [PATCH] * gnu: krita: Add libjpeg-turbo to inputs.
> >
> > ---
> > gnu/packages/kde.scm | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
> > index b5a3df2ca..e8f38b920 100644
> > --- a/gnu/packages/kde.scm
> > +++ b/gnu/packages/kde.scm
> > @@ -287,6 +287,7 @@ plugins, as well as code to create plugins, or complete applications.")
> > ("exiv2" ,exiv2)
> > ("lcms" ,lcms)
> > ("libpng" ,libpng)
> > + ("libjpeg-turbo" ,libjpeg-turbo)
> > ("zlib" ,zlib)
> > ("libx11" ,libx11)
> > ("libxcb" ,libxcb)
> > --
> > 2.15.0
> >
>
>
> --
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
> WWW: https://n0.is
> Email had 1 attachment:
> + signature.asc
> 1k (application/pgp-signature)
--
Mark Meyer
mark <at> ofosos.org
[0001-gnu-krita-Enhance-krita.patch (text/x-patch, attachment)]
guix-patches <at> gnu.org:bug#29703; Package guix-patches.
(Thu, 14 Dec 2017 14:40:02 GMT) Full text and rfc822 format available.Message #17 received at 29703 <at> debbugs.gnu.org (full text, mbox):
From: ng0 <ng0 <at> n0.is> To: Mark Meyer <mark <at> ofosos.org> Cc: 29703 <at> debbugs.gnu.org, ng0 <ng0 <at> n0.is> Subject: Re: [bug#29703] Improve Krita Date: Thu, 14 Dec 2017 14:39:21 +0000
[Message part 1 (text/plain, inline)]
Hi,
we're almost there. It's just a couple of fixes that need to be applied:
Mark Meyer transcribed 7.7K bytes:
> Ok, see the following patch. This should also be aligned with the commit
> message conventions.
>
> On Thu, Dec 14, 2017, at 12:55, ng0 wrote:
> > Hi Mark,
> >
> > Mark Meyer transcribed 5.4K bytes:
> > > Hi,
> > > I'm currently testing several changes to Krita, I've broken stuff up
> > > into three commits/patches which are attached.
> > >
> > > These
> > > - add a dependency to vc (vectorize Krita)
> > > - enable OpenEXR
> > > - enable JPEG (via libjpeg-turbo)
> >
> > Thanks for the work on Krita.
> > I haven't tested them, but it looks good.
> > It would be okay to squash these commits into one, we've done this
> > in the past in similar cases (see `git log gnu/packages/gnunet.scm`
> > for libextractor for example).
> >
> > > Cheers, Mark
> From 158497a7bf1b5672018189101fa5448623cecb1b Mon Sep 17 00:00:00 2001
> From: Mark Meyer <mark <at> ofosos.org>
> Date: Wed, 13 Dec 2017 23:49:09 +0100
> Subject: [PATCH] gnu: krita: Enhance krita
>
> * gnu/packages/kde.scm (kirta)[inputs]: Add libjpeg-turbo to inputs.
> * gnu/packages/kde.scm (krita)[inputs]: Add vc to native-inputs.
> * gnu/packages/kde.scm (krita)[inputs]: Add OpenEXR support.
I would write:
gnu: krita: Enhance krita.
* gnu/packages/kde.scm (krita)[inputs]: Add 'libjpeg-turbo', 'ilmbase', 'openexr'.
(native-inputs): Add 'vc'.
(arguments)[configure-flags]: Add 'CMAKE_CXX_FLAGS' for ilmbase.
Or something like that. I'm not sure about the configure-flags wording.
I don't know Krita so I can't really review if your changes work. I'll
build it later tonight and see if it builds for me.
> ---
> gnu/packages/kde.scm | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
> index b5a3df2ca..89ad30ecd 100644
> --- a/gnu/packages/kde.scm
> +++ b/gnu/packages/kde.scm
> @@ -256,14 +256,18 @@ plugins, as well as code to create plugins, or complete applications.")
> (string-append "-DWITH_LibRaw="
> (assoc-ref %build-inputs "libraw"))
> (string-append "-DWITH_TIFF="
> - (assoc-ref %build-inputs "libtiff")))))
> + (assoc-ref %build-inputs "libtiff"))
> + (string-append "-DCMAKE_CXX_FLAGS=-I"
> + (assoc-ref %build-inputs "ilmbase")
> + "/include/OpenEXR"))))
> (native-inputs
> `(("curl" ,curl)
> ("eigen" ,eigen)
> ("extra-cmake-modules" ,extra-cmake-modules)
> ("gettext-minimal" ,gettext-minimal)
> ("kitemmodels" ,kitemmodels)
> - ("qwt" ,qwt)))
> + ("qwt" ,qwt)
> + ("vc" ,vc)))
> (inputs
> `(("qtbase" ,qtbase)
> ("qtdeclarative" ,qtdeclarative)
> @@ -287,6 +291,7 @@ plugins, as well as code to create plugins, or complete applications.")
> ("exiv2" ,exiv2)
> ("lcms" ,lcms)
> ("libpng" ,libpng)
> + ("libjpeg-turbo" ,libjpeg-turbo)
> ("zlib" ,zlib)
> ("libx11" ,libx11)
> ("libxcb" ,libxcb)
> @@ -296,7 +301,9 @@ plugins, as well as code to create plugins, or complete applications.")
> ("poppler-qt5" ,poppler-qt5)
> ("libraw" ,libraw)
> ("libtiff" ,libtiff)
> - ("perl" ,perl)))
> + ("perl" ,perl)
> + ("ilmbase" ,ilmbase)
> + ("openexr" ,openexr)))
> (home-page "https://krita.org")
> (synopsis "Digital painting application")
> (description
> --
> 2.15.0
>
--
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
WWW: https://n0.is
[signature.asc (application/pgp-signature, inline)]
guix-patches <at> gnu.org:bug#29703; Package guix-patches.
(Thu, 14 Dec 2017 15:13:02 GMT) Full text and rfc822 format available.Message #20 received at 29703 <at> debbugs.gnu.org (full text, mbox):
From: Mark Meyer <mark <at> ofosos.org> To: ng0 <ng0 <at> n0.is> Cc: 29703 <at> debbugs.gnu.org Subject: Re: [bug#29703] Improve Krita Date: Thu, 14 Dec 2017 16:12:20 +0100
[Message part 1 (text/plain, inline)]
Thanks for your patience, from the log of gnunet.scm I think it should
be somthing like the appended one.
Cheers, Mark
On Thu, Dec 14, 2017, at 15:39, ng0 wrote:
> Hi,
>
> we're almost there. It's just a couple of fixes that need to be applied:
>
> Mark Meyer transcribed 7.7K bytes:
> > Ok, see the following patch. This should also be aligned with the commit
> > message conventions.
> >
> > On Thu, Dec 14, 2017, at 12:55, ng0 wrote:
> > > Hi Mark,
> > >
> > > Mark Meyer transcribed 5.4K bytes:
> > > > Hi,
> > > > I'm currently testing several changes to Krita, I've broken stuff up
> > > > into three commits/patches which are attached.
> > > >
> > > > These
> > > > - add a dependency to vc (vectorize Krita)
> > > > - enable OpenEXR
> > > > - enable JPEG (via libjpeg-turbo)
> > >
> > > Thanks for the work on Krita.
> > > I haven't tested them, but it looks good.
> > > It would be okay to squash these commits into one, we've done this
> > > in the past in similar cases (see `git log gnu/packages/gnunet.scm`
> > > for libextractor for example).
> > >
> > > > Cheers, Mark
>
> > From 158497a7bf1b5672018189101fa5448623cecb1b Mon Sep 17 00:00:00 2001
> > From: Mark Meyer <mark <at> ofosos.org>
> > Date: Wed, 13 Dec 2017 23:49:09 +0100
> > Subject: [PATCH] gnu: krita: Enhance krita
> >
> > * gnu/packages/kde.scm (kirta)[inputs]: Add libjpeg-turbo to inputs.
> > * gnu/packages/kde.scm (krita)[inputs]: Add vc to native-inputs.
> > * gnu/packages/kde.scm (krita)[inputs]: Add OpenEXR support.
>
> I would write:
>
> gnu: krita: Enhance krita.
>
> * gnu/packages/kde.scm (krita)[inputs]: Add 'libjpeg-turbo', 'ilmbase',
> 'openexr'.
> (native-inputs): Add 'vc'.
> (arguments)[configure-flags]: Add 'CMAKE_CXX_FLAGS' for ilmbase.
>
>
>
> Or something like that. I'm not sure about the configure-flags wording.
> I don't know Krita so I can't really review if your changes work. I'll
> build it later tonight and see if it builds for me.
>
> > ---
> > gnu/packages/kde.scm | 13 ++++++++++---
> > 1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
> > index b5a3df2ca..89ad30ecd 100644
> > --- a/gnu/packages/kde.scm
> > +++ b/gnu/packages/kde.scm
> > @@ -256,14 +256,18 @@ plugins, as well as code to create plugins, or complete applications.")
> > (string-append "-DWITH_LibRaw="
> > (assoc-ref %build-inputs "libraw"))
> > (string-append "-DWITH_TIFF="
> > - (assoc-ref %build-inputs "libtiff")))))
> > + (assoc-ref %build-inputs "libtiff"))
> > + (string-append "-DCMAKE_CXX_FLAGS=-I"
> > + (assoc-ref %build-inputs "ilmbase")
> > + "/include/OpenEXR"))))
> > (native-inputs
> > `(("curl" ,curl)
> > ("eigen" ,eigen)
> > ("extra-cmake-modules" ,extra-cmake-modules)
> > ("gettext-minimal" ,gettext-minimal)
> > ("kitemmodels" ,kitemmodels)
> > - ("qwt" ,qwt)))
> > + ("qwt" ,qwt)
> > + ("vc" ,vc)))
> > (inputs
> > `(("qtbase" ,qtbase)
> > ("qtdeclarative" ,qtdeclarative)
> > @@ -287,6 +291,7 @@ plugins, as well as code to create plugins, or complete applications.")
> > ("exiv2" ,exiv2)
> > ("lcms" ,lcms)
> > ("libpng" ,libpng)
> > + ("libjpeg-turbo" ,libjpeg-turbo)
> > ("zlib" ,zlib)
> > ("libx11" ,libx11)
> > ("libxcb" ,libxcb)
> > @@ -296,7 +301,9 @@ plugins, as well as code to create plugins, or complete applications.")
> > ("poppler-qt5" ,poppler-qt5)
> > ("libraw" ,libraw)
> > ("libtiff" ,libtiff)
> > - ("perl" ,perl)))
> > + ("perl" ,perl)
> > + ("ilmbase" ,ilmbase)
> > + ("openexr" ,openexr)))
> > (home-page "https://krita.org")
> > (synopsis "Digital painting application")
> > (description
> > --
> > 2.15.0
> >
>
>
> --
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
> WWW: https://n0.is
> Email had 1 attachment:
> + signature.asc
> 1k (application/pgp-signature)
--
Mark Meyer
mark <at> ofosos.org
[0001-gnu-krita-Enhance-krita.patch (text/x-patch, attachment)]
guix-patches <at> gnu.org:bug#29703; Package guix-patches.
(Sat, 16 Dec 2017 21:54:02 GMT) Full text and rfc822 format available.Message #23 received at 29703 <at> debbugs.gnu.org (full text, mbox):
From: Kei Kebreau <kkebreau <at> posteo.net> To: Mark Meyer <mark <at> ofosos.org> Cc: 29703 <at> debbugs.gnu.org, ng0 <ng0 <at> n0.is> Subject: Re: [bug#29703] Improve Krita Date: Sat, 16 Dec 2017 16:53:24 -0500
[Message part 1 (text/plain, inline)]
Mark Meyer <mark <at> ofosos.org> writes:
> Thanks for your patience, from the log of gnunet.scm I think it should
> be somthing like the appended one.
>
> Cheers, Mark
>
> On Thu, Dec 14, 2017, at 15:39, ng0 wrote:
>> Hi,
>>
>> we're almost there. It's just a couple of fixes that need to be applied:
>>
>> Mark Meyer transcribed 7.7K bytes:
>> > Ok, see the following patch. This should also be aligned with the commit
>> > message conventions.
>> >
>> > On Thu, Dec 14, 2017, at 12:55, ng0 wrote:
>> > > Hi Mark,
>> > >
>> > > Mark Meyer transcribed 5.4K bytes:
>> > > > Hi,
>> > > > I'm currently testing several changes to Krita, I've broken stuff up
>> > > > into three commits/patches which are attached.
>> > > >
>> > > > These
>> > > > - add a dependency to vc (vectorize Krita)
>> > > > - enable OpenEXR
>> > > > - enable JPEG (via libjpeg-turbo)
>> > >
>> > > Thanks for the work on Krita.
>> > > I haven't tested them, but it looks good.
>> > > It would be okay to squash these commits into one, we've done this
>> > > in the past in similar cases (see `git log gnu/packages/gnunet.scm`
>> > > for libextractor for example).
>> > >
>> > > > Cheers, Mark
>>
>> > From 158497a7bf1b5672018189101fa5448623cecb1b Mon Sep 17 00:00:00 2001
>> > From: Mark Meyer <mark <at> ofosos.org>
>> > Date: Wed, 13 Dec 2017 23:49:09 +0100
>> > Subject: [PATCH] gnu: krita: Enhance krita
>> >
>> > * gnu/packages/kde.scm (kirta)[inputs]: Add libjpeg-turbo to inputs.
>> > * gnu/packages/kde.scm (krita)[inputs]: Add vc to native-inputs.
>> > * gnu/packages/kde.scm (krita)[inputs]: Add OpenEXR support.
>>
>> I would write:
>>
>> gnu: krita: Enhance krita.
>>
>> * gnu/packages/kde.scm (krita)[inputs]: Add 'libjpeg-turbo', 'ilmbase',
>> 'openexr'.
>> (native-inputs): Add 'vc'.
>> (arguments)[configure-flags]: Add 'CMAKE_CXX_FLAGS' for ilmbase.
>>
>>
>>
>> Or something like that. I'm not sure about the configure-flags wording.
>> I don't know Krita so I can't really review if your changes work. I'll
>> build it later tonight and see if it builds for me.
>>
>> > ---
>> > gnu/packages/kde.scm | 13 ++++++++++---
>> > 1 file changed, 10 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
>> > index b5a3df2ca..89ad30ecd 100644
>> > --- a/gnu/packages/kde.scm
>> > +++ b/gnu/packages/kde.scm
>> > @@ -256,14 +256,18 @@ plugins, as well as code to create plugins, or complete applications.")
>> > (string-append "-DWITH_LibRaw="
>> > (assoc-ref %build-inputs "libraw"))
>> > (string-append "-DWITH_TIFF="
>> > - (assoc-ref %build-inputs "libtiff")))))
>> > + (assoc-ref %build-inputs "libtiff"))
>> > + (string-append "-DCMAKE_CXX_FLAGS=-I"
>> > + (assoc-ref %build-inputs "ilmbase")
>> > + "/include/OpenEXR"))))
>> > (native-inputs
>> > `(("curl" ,curl)
>> > ("eigen" ,eigen)
>> > ("extra-cmake-modules" ,extra-cmake-modules)
>> > ("gettext-minimal" ,gettext-minimal)
>> > ("kitemmodels" ,kitemmodels)
>> > - ("qwt" ,qwt)))
>> > + ("qwt" ,qwt)
>> > + ("vc" ,vc)))
>> > (inputs
>> > `(("qtbase" ,qtbase)
>> > ("qtdeclarative" ,qtdeclarative)
>> > @@ -287,6 +291,7 @@ plugins, as well as code to create plugins, or complete applications.")
>> > ("exiv2" ,exiv2)
>> > ("lcms" ,lcms)
>> > ("libpng" ,libpng)
>> > + ("libjpeg-turbo" ,libjpeg-turbo)
>> > ("zlib" ,zlib)
>> > ("libx11" ,libx11)
>> > ("libxcb" ,libxcb)
>> > @@ -296,7 +301,9 @@ plugins, as well as code to create plugins, or complete applications.")
>> > ("poppler-qt5" ,poppler-qt5)
>> > ("libraw" ,libraw)
>> > ("libtiff" ,libtiff)
>> > - ("perl" ,perl)))
>> > + ("perl" ,perl)
>> > + ("ilmbase" ,ilmbase)
>> > + ("openexr" ,openexr)))
>> > (home-page "https://krita.org")
>> > (synopsis "Digital painting application")
>> > (description
>> > --
>> > 2.15.0
>> >
>>
>>
>> --
>> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
>> GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
>> WWW: https://n0.is
>> Email had 1 attachment:
>> + signature.asc
>> 1k (application/pgp-signature)
I made tiny changes to the commit log and pushed this to master; you can
close this bug.
Thanks for contributing,
Kei
[signature.asc (application/pgp-signature, inline)]
Mark Meyer <mark <at> ofosos.org>:Mark Meyer <mark <at> ofosos.org>:Message #28 received at 29703-done <at> debbugs.gnu.org (full text, mbox):
From: Mark Meyer <mark <at> ofosos.org> To: 29703-done <at> debbugs.gnu.org Subject: Fixed Date: Sun, 17 Dec 2017 00:19:44 +0100
Fixed. -- Mark Meyer mark <at> ofosos.org
Debbugs Internal Request <help-debbugs <at> gnu.org>
to internal_control <at> debbugs.gnu.org.
(Sun, 14 Jan 2018 12:24:05 GMT) Full text and rfc822 format available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.