From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 13 15:24:57 2017 Received: (at submit) by debbugs.gnu.org; 13 Dec 2017 20:24:57 +0000 Received: from localhost ([127.0.0.1]:60836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePDaK-0005AW-Sd for submit@debbugs.gnu.org; Wed, 13 Dec 2017 15:24:57 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:42610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePDaJ-0005AJ-AC for submit@debbugs.gnu.org; Wed, 13 Dec 2017 15:24:55 -0500 Received: by mail-wm0-f48.google.com with SMTP id b199so7456822wme.1 for ; Wed, 13 Dec 2017 12:24:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version; bh=0OQ8b6Ec0q/cwOPb/dy2J1y6NlnYz+jX82PJ4Kk+gwc=; b=UM3wcsgS1Ra1GZiMFPHRzy6VBTysMj6TT/5FjkyOmlvw10IeZxKAWVVxnSAzqJgpb0 vJVliJFhexy3UDOkV7nqlMqVkB9UcLnBfjFweT3Lgw+jsx5YnIyNuaIm0a7s8A6bXveI 96u9HtZ5SdWf12ZEituaNbuhGD0VP8JAgA1NemaLj2+cTsQjPGNLo+ZYweJXA5sdXVdv 85RrUN4FBJXq0Jo90QPLrJkmXlmDRqGggEkCstxfo4le14pVC/Ml21nG2hFycDpy4W+C ukWhPDvDobrU3IaOcB3jGGFfu8niC45U9y8ZlfXDnT/Hm5c6CIsiZdXk/QFX91BzWUKK qCqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=0OQ8b6Ec0q/cwOPb/dy2J1y6NlnYz+jX82PJ4Kk+gwc=; b=EREpnkI+FI4Y4Sir2qBSYz7GTmXQP24YtI9G08iX8SsyWAfLyViyLAR9CYmgBLMWiY iF+Gmd2xeQZ8ClpZZGC0h+yH9SwUJJFQe1n21ABxD2hH05iqizlWi/61md8AHcRmNQlC T3TwCIayGhk7BYYAbR+498/Sj17+Hm5u3rk+HDC9xAUBWsiGJ87+utsyrIGGStdExpYC gcAlfwWa6hEwE8vwWqPsiil6V5fBmp01SoZ+9eUgQB9aWJVOb/dqQk/USQ4gM7A68hEi w28pmJi21S2zJ+Jhatq4jQLxtcXxVExZIs2hKjLA91nnbmyz+/4pFQoz98V7/aGgOAEY iaBw== X-Gm-Message-State: AKGB3mJKMaG9MQUwnVTACzOtJhnKew7dZ7W0nndefT6Nr12Xaa/QqhrF uQ+fCUOxwWhx+JJaRw37ibwQNgt4 X-Google-Smtp-Source: ACJfBouw5oRpk6VMfz31Lt8UCKvnbBAo0C1OQFgJzyYKqLAjMeiYrsGL/dH94w0KSnpGcCEp9ougxg== X-Received: by 10.80.137.111 with SMTP id f44mr9285932edf.257.1513196689149; Wed, 13 Dec 2017 12:24:49 -0800 (PST) Received: from localhost ([213.233.148.16]) by smtp.gmail.com with ESMTPSA id d9sm2085847edb.18.2017.12.13.12.24.47 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Dec 2017 12:24:48 -0800 (PST) From: "Basil L. Contovounesios" To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) Subject: Reading summary keys from article changes window configuration X-Debbugs-Version: 5.13 X-Debbugs-Package: emacs,gnus Date: Wed, 13 Dec 2017 20:24:43 +0000 Message-ID: <87lgi6pe9g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From f615268be55ddfdfdc9c3c2f4f0a15ad6bafa183 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 13 Dec 2017 19:55:15 +0000 Subject: [PATCH] Do not pop to buffer for reading gnus summary keys [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [213.233.148.16 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.125.82.48 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.125.82.48 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From f615268be55ddfdfdc9c3c2f4f0a15ad6bafa183 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 13 Dec 2017 19:55:15 +0000 Subject: [PATCH] Do not pop to buffer for reading gnus summary keys [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [213.233.148.16 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.125.82.48 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.125.82.48 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Do-not-pop-to-buffer-for-reading-gnus-summary-keys.patch >From f615268be55ddfdfdc9c3c2f4f0a15ad6bafa183 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 13 Dec 2017 19:55:15 +0000 Subject: [PATCH] Do not pop to buffer for reading gnus summary keys * lisp/gnus/gnus-art.el (gnus-article-read-summary-keys): Lookup summary buffer keys from article buffer without affecting window configuration. --- lisp/gnus/gnus-art.el | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el index 6ee0d7b023..51e2a9a21f 100644 --- a/lisp/gnus/gnus-art.el +++ b/lisp/gnus/gnus-art.el @@ -6711,11 +6711,10 @@ gnus-article-read-summary-keys (member keys nosave-but-article) (member keys nosave-in-article)) (let (func) - (save-window-excursion - (pop-to-buffer gnus-article-current-summary) - ;; We disable the pick minor mode commands. - (let (gnus-pick-mode) - (setq func (key-binding keys t)))) + (with-current-buffer gnus-article-current-summary + ;; We disable the pick minor mode commands. + (let (gnus-pick-mode) + (setq func (key-binding keys t)))) (if (or (not func) (numberp func)) (ding) -- 2.15.1 --=-=-= Content-Type: text/plain Using Gnus with the user option pop-up-frames set to 'graphic-only, I observe the following behaviour: 1. Visit an article. 2. Make article window the sole window in its containing frame. 3. Type = (gnus-summary-expand-window). Expected result: The article's summary replaces the article in the frame's sole window. Actual result: The expected result plus an additional frame displaying the corresponding summary buffer. In other words, expanding the article window causes an extraneous frame to be created. I believe this is caused by a call to pop-to-buffer within save-window-excursion in the function gnus-article-read-summary-keys. Is the call to pop-to-buffer really necessary for the purpose of key lookup? Wouldn't changing the current buffer suffice, so as not to affect the window configuration in the first place? If so, please consider the attached patch which addresses this. The docstring of save-window-excursion even warns of the possibility of behaviour like the one I describe. The information gathered by gnus-bug follows my signature. Thanks, -- Basil Gnus v5.13 GNU Emacs 27.0.50 (build 9, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2017-12-05 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 13 23:46:09 2017 Received: (at 29696-done) by debbugs.gnu.org; 14 Dec 2017 04:46:09 +0000 Received: from localhost ([127.0.0.1]:32873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePLPN-0005Hn-1G for submit@debbugs.gnu.org; Wed, 13 Dec 2017 23:46:09 -0500 Received: from mail-hampton.hostforweb.net ([205.234.186.191]:47887 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePLPJ-0005Gy-9Y for 29696-done@debbugs.gnu.org; Wed, 13 Dec 2017 23:46:07 -0500 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) (envelope-from ) id 1ePLPA-003dN1-DY; Wed, 13 Dec 2017 22:45:57 -0600 Date: Thu, 14 Dec 2017 13:45:57 +0900 Message-ID: From: Katsumi Yamaoka To: Basil L. Contovounesios Subject: Re: bug#29696: Reading summary keys from article changes window configuration References: <87lgi6pe9g.fsf@gmail.com> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (i686-pc-cygwin) Cancel-Lock: sha1:iSAfQn4bI8/tLmluCxHGux0cN+s= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-1.5 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29696-done Cc: 29696-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, 13 Dec 2017 20:24:43 +0000, Basil L. Contovounesios wrote: > Using Gnus with the user option pop-up-frames set to 'graphic-only, I > observe the following behaviour: > 1. Visit an article. > 2. Make article window the sole window in its containing frame. > 3. Type = (gnus-summary-expand-window). > Expected result: The article's summary replaces the article in the > frame's sole window. > Actual result: The expected result plus an additional frame displaying > the corresponding summary buffer. In other words, expanding the article > window causes an extraneous frame to be created. Confirmed and applied your patch in the emacs-26 branch. Thanks. > I believe this is caused by a call to pop-to-buffer within > save-window-excursion in the function gnus-article-read-summary-keys. > Is the call to pop-to-buffer really necessary for the purpose of key > lookup? Wouldn't changing the current buffer suffice, so as not to > affect the window configuration in the first place? I agree, only changing the buffer is sufficient in that case. I don't know why pop-to-buffer is used, but it seems to be there from the beginning (it is as is in Red Gnus 0.01 of 1996). I guess it was beyond imagination that pop-to-buffer may raise a new frame when there is no frame visiting the buffer, and why this wasn't discovered so far is that those who set pop-up-frames to nin-nil normally are not so many. > If so, please consider the attached patch which addresses this. The > docstring of save-window-excursion even warns of the possibility of > behaviour like the one I describe. > The information gathered by gnus-bug follows my signature. > Thanks, From unknown Sun Aug 17 10:23:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Jan 2018 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator