GNU bug report logs - #29696
Reading summary keys from article changes window configuration

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29696 in the body.
You can then email your comments to 29696 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: Reading summary keys from article changes window configuration
Date: Wed, 13 Dec 2017 20:24:43 +0000

[0001-Do-not-pop-to-buffer-for-reading-gnus-summary-keys.patch (text/x-diff, attachment)]

[Message part 2 (text/plain, inline)]

Using Gnus with the user option pop-up-frames set to 'graphic-only, I
observe the following behaviour:

1. Visit an article.
2. Make article window the sole window in its containing frame.
3. Type = (gnus-summary-expand-window).

Expected result: The article's summary replaces the article in the
frame's sole window.

Actual result: The expected result plus an additional frame displaying
the corresponding summary buffer.  In other words, expanding the article
window causes an extraneous frame to be created.

I believe this is caused by a call to pop-to-buffer within
save-window-excursion in the function gnus-article-read-summary-keys.
Is the call to pop-to-buffer really necessary for the purpose of key
lookup?  Wouldn't changing the current buffer suffice, so as not to
affect the window configuration in the first place?

If so, please consider the attached patch which addresses this.  The
docstring of save-window-excursion even warns of the possibility of
behaviour like the one I describe.

The information gathered by gnus-bug follows my signature.

Thanks,

-- 
Basil

Gnus v5.13
GNU Emacs 27.0.50 (build 9, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2017-12-05

Message #10 received at 29696-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Basil L. Contovounesios <contovob <at> tcd.ie>
Cc: 29696-done <at> debbugs.gnu.org
Subject: Re: bug#29696: Reading summary keys from article changes window
 configuration
Date: Thu, 14 Dec 2017 13:45:57 +0900

On Wed, 13 Dec 2017 20:24:43 +0000, Basil L. Contovounesios wrote:
> Using Gnus with the user option pop-up-frames set to 'graphic-only, I
> observe the following behaviour:

> 1. Visit an article.
> 2. Make article window the sole window in its containing frame.
> 3. Type = (gnus-summary-expand-window).

> Expected result: The article's summary replaces the article in the
> frame's sole window.

> Actual result: The expected result plus an additional frame displaying
> the corresponding summary buffer.  In other words, expanding the article
> window causes an extraneous frame to be created.

Confirmed and applied your patch in the emacs-26 branch.  Thanks.

> I believe this is caused by a call to pop-to-buffer within
> save-window-excursion in the function gnus-article-read-summary-keys.
> Is the call to pop-to-buffer really necessary for the purpose of key
> lookup?  Wouldn't changing the current buffer suffice, so as not to
> affect the window configuration in the first place?

I agree, only changing the buffer is sufficient in that case.
I don't know why pop-to-buffer is used, but it seems to be there
from the beginning (it is as is in Red Gnus 0.01 of 1996).
I guess it was beyond imagination that pop-to-buffer may raise
a new frame when there is no frame visiting the buffer, and why
this wasn't discovered so far is that those who set pop-up-frames
to nin-nil normally are not so many.

> If so, please consider the attached patch which addresses this.  The
> docstring of save-window-excursion even warns of the possibility of
> behaviour like the one I describe.

> The information gathered by gnus-bug follows my signature.

> Thanks,

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.