GNU bug report logs - #29686
gnu: aspell: Do not ignore GuixOS system profile.

Previous Next

Package: guix;

Reported by: Oleg Pykhalov <go.wigust <at> gmail.com>

Date: Wed, 13 Dec 2017 06:44:02 UTC

Severity: normal

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#29686: closed (gnu: aspell: Do not ignore GuixOS system profile.)
Date: Thu, 14 Nov 2019 21:40:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 14 Nov 2019 22:39:41 +0100
with message-id <87h836m92a.fsf <at> gnu.org>
and subject line Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile.
has caused the debbugs.gnu.org bug report #29686,
regarding gnu: aspell: Do not ignore GuixOS system profile.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
29686: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29686
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: gnu: aspell: Do not ignore GuixOS system profile.
Date: Wed, 13 Dec 2017 09:43:19 +0300
[Message part 3 (text/plain, inline)]
Hello Guix,

Currently, if aspell is installed in GuixOS system profile and not in
user profile then aspell cannot find dictionaries.

(define-public aspell
  (package
    ;; …
    (arguments
     `(#:phases
       (modify-phases %standard-phases
         (add-after 'install 'wrap-aspell
           (lambda* (#:key outputs #:allow-other-keys)
             (let ((bin/aspell (string-append (assoc-ref outputs "out")
                                              "/bin/aspell")))
               (wrap-program bin/aspell
                 '("ASPELL_CONF" "" =
                   ("${ASPELL_CONF:-\"dict-dir ${GUIX_PROFILE:-$HOME/.guix-profile}/lib/aspell\"}")))))))))
    ;; …
    ))

I have a solution on top of existing wrapper, but what is a good way to
implement the following?

--8<---------------cut here---------------start------------->8---
LIB_ASPELL=lib/aspell
HOME_PROFILE=$HOME/.guix-profile
SYSTEM_PROFILE=/run/current-system/profile

if [ -z ${GUIX_PROFILE} ]; then
    if [ -d $HOME_PROFILE/$LIB_ASPELL ]; then
        GUIX_PROFILE=$HOME_PROFILE
    elif [ -d $SYSTEM_PROFILE/$LIB_ASPELL ]; then
        GUIX_PROFILE=$SYSTEM_PROFILE
    fi
fi

export ASPELL_CONF="${ASPELL_CONF:-"dict-dir ${GUIX_PROFILE}/lib/aspell"}"
--8<---------------cut here---------------end--------------->8---

Thanks,
Oleg.
[signature.asc (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 29686-done <at> debbugs.gnu.org
Subject: Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile.
Date: Thu, 14 Nov 2019 22:39:41 +0100
Hi,

Pierre Neidhardt <mail <at> ambrevar.xyz> skribis:

> Looks good to me, thanks for working on this!

Pushed as 4554d6b77e0f306a3dc33a8c1f68c9a302967a08 (core-updates).

Thank you!

Ludo’.


This bug report was last modified 5 years and 186 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.