From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 13 01:43:44 2017 Received: (at submit) by debbugs.gnu.org; 13 Dec 2017 06:43:44 +0000 Received: from localhost ([127.0.0.1]:59321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eP0lc-00036r-0b for submit@debbugs.gnu.org; Wed, 13 Dec 2017 01:43:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eP0la-00036Q-AN for submit@debbugs.gnu.org; Wed, 13 Dec 2017 01:43:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eP0lU-0005qn-AU for submit@debbugs.gnu.org; Wed, 13 Dec 2017 01:43:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36314) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eP0lU-0005qX-6V for submit@debbugs.gnu.org; Wed, 13 Dec 2017 01:43:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eP0lT-0008HY-6H for bug-guix@gnu.org; Wed, 13 Dec 2017 01:43:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eP0lQ-0005oU-M1 for bug-guix@gnu.org; Wed, 13 Dec 2017 01:43:35 -0500 Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:35345) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eP0lQ-0005nm-DX for bug-guix@gnu.org; Wed, 13 Dec 2017 01:43:32 -0500 Received: by mail-lf0-x234.google.com with SMTP id j124so1400841lfg.2 for ; Tue, 12 Dec 2017 22:43:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=cXj7XDkn0CUKd52vfzw8byMcx+sQbjKqX64gMFoLAJw=; b=jZafQLU2mptuisc9Qp/q46ZhQuaZOMZAHq7AhNQIkB/0nqiWnrLUiZTCWNgaQo8+ml TQkG0QTzZZTwU+96jSZq2430QiQKQc6Dw/kIlPBfz1UPFsANmx7pZgYKVLIu/qxDKmct ZCPwDT9//Ofz81vsVkagZ7ypT869V5v39c7BXKIAO3+bm0dEp0gYIA4UM96eRtAoKW7f uq2+V/4R7vCKGa1BNiNBjjfrav/IU50hv0eSUVRYTGLMWfz0tMDhaTu0MKtpgcNKumZh 3dAG5Hbti4aXfOHhm4TtrsJ0m6JGTs7ldtLBQbOKymnXEGpZsXEqb3Kw5GlOJH2i1xDe raBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=cXj7XDkn0CUKd52vfzw8byMcx+sQbjKqX64gMFoLAJw=; b=KwiatiQLZCShOwFwEWY0kF+lubNg+pJO9gUxRNxOZLzYRfWnbEiv0+tAsxaBJv8ipr k0jyMigCNj22IdXMX3XETaxuq6zKmtUoJyFlLN1uI7l40rz/YL3m2acbrzGo6e6eq4Ha E1dcLKrPYP6b0cfPkEEi8sE6Ey5YiEm1TA5Hx/mc377+G2VFln3ogiy09fVda76f10M5 Yj1Xnj0EJAQY1c439r2WAjXl0WozfUkMIb2tKIWSudG27/q3XtikOHaByeAAg/bG90EH 3Qjoo5HBzWBmjFg85Fx9jSvX9WAzq5KALsY2wjyzu4zjzvYXzJLCenAzFT8Dx24HgYii Rfug== X-Gm-Message-State: AKGB3mKAtG2+EVmQkCSgu8ipoXSUtjwEQRW/lytHsMzkZfBNnpYCRIgm hR0Uqndkk0LyG1SZJXo9MkWEeA== X-Google-Smtp-Source: ACJfBouGUyj0TOhl17JBlOJJB+/BJzOVKK3terXW3c8I9qNcOusihp3DGFQcTu01461totvMyVuXtQ== X-Received: by 10.25.181.193 with SMTP id g62mr764712lfk.43.1513147410640; Tue, 12 Dec 2017 22:43:30 -0800 (PST) Received: from magnolia (ppp91-122-81-8.pppoe.avangarddsl.ru. [91.122.81.8]) by smtp.gmail.com with ESMTPSA id o86sm162138lja.2.2017.12.12.22.43.29 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Dec 2017 22:43:29 -0800 (PST) From: Oleg Pykhalov To: bug-guix@gnu.org Subject: gnu: aspell: Do not ignore GuixOS system profile. Date: Wed, 13 Dec 2017 09:43:19 +0300 Message-ID: <87vahbgmbc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Guix, Currently, if aspell is installed in GuixOS system profile and not in user profile then aspell cannot find dictionaries. (define-public aspell (package ;; =E2=80=A6 (arguments `(#:phases (modify-phases %standard-phases (add-after 'install 'wrap-aspell (lambda* (#:key outputs #:allow-other-keys) (let ((bin/aspell (string-append (assoc-ref outputs "out") "/bin/aspell"))) (wrap-program bin/aspell '("ASPELL_CONF" "" =3D ("${ASPELL_CONF:-\"dict-dir ${GUIX_PROFILE:-$HOME/.guix-= profile}/lib/aspell\"}"))))))))) ;; =E2=80=A6 )) I have a solution on top of existing wrapper, but what is a good way to implement the following? =2D-8<---------------cut here---------------start------------->8--- LIB_ASPELL=3Dlib/aspell HOME_PROFILE=3D$HOME/.guix-profile SYSTEM_PROFILE=3D/run/current-system/profile if [ -z ${GUIX_PROFILE} ]; then if [ -d $HOME_PROFILE/$LIB_ASPELL ]; then GUIX_PROFILE=3D$HOME_PROFILE elif [ -d $SYSTEM_PROFILE/$LIB_ASPELL ]; then GUIX_PROFILE=3D$SYSTEM_PROFILE fi fi export ASPELL_CONF=3D"${ASPELL_CONF:-"dict-dir ${GUIX_PROFILE}/lib/aspell"}" =2D-8<---------------cut here---------------end--------------->8--- Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlowzAcACgkQckbhHGm3 lWlqvA//ROd2kxo67lWC3YquFA0DbiwzK9oAQFzkSrvfcGLkGLRPRQOh5aAvly0D /buDHRQmDm22vI85RxaX6yJDVozt6VoqhBADYHs9tsyOGIY+k/rNM1BT9T5yjQNV kphkIt0QLRomwHVVIiRJ352WYuIv7+njOp287zqewnH7xkeQkcNgnlX4E7v/s+O6 cKOHqc3DaCBEIWHl01KELTsqPsoUFhoQzS0fqn6Dqp+OWmemSP7+rn0nER8Dv4Ho lTjGcb8Ah4NG3bd/jFw8DgZx0D4Vpp+3YfQb9VhkSdaW4tzOLHxMDjd7hGMKcn+W rGKBaguXLt3TWNMI8uZF6zJP/d5LVUE/JtdTSHMGD8E11wwCruCYPG6pzIRqvVrz jhYb+lmWmHCaC7Oca3muhOzgCKx0lznpMGM27ISPA0g5D0dm3YCA3YLhnM1jX/Hk HWYnn5ussZKDNArKKi+5IGvYXnho4PUXyrWI+I09gwtvDBptMCRLUwhFTSzw75DC lG2GOOPICZQqZm/yYwredjG42QTyM42bLYuBTeG3LBO+N7zpjjjDiV4m6erCOPSb +oMr9uOpaTgyLF+GFLVjsEP8nMOduIAzX6Ge+TAstmplCtEWLNHpBV9DABxlmpTr WjFN/R7mBAfyTqjcsnMPYS2RcuyyM+BNeJz5Ih7vFLSUQAt/bxk= =wFiD -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 13 16:52:48 2017 Received: (at 29686) by debbugs.gnu.org; 13 Dec 2017 21:52:48 +0000 Received: from localhost ([127.0.0.1]:60872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePExM-0007Nd-Jo for submit@debbugs.gnu.org; Wed, 13 Dec 2017 16:52:48 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:49384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePExL-0007NV-B7 for 29686@debbugs.gnu.org; Wed, 13 Dec 2017 16:52:47 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id B56691027A; Wed, 13 Dec 2017 22:52:49 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sG80jSb82TJ0; Wed, 13 Dec 2017 22:52:49 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id AC0056E87; Wed, 13 Dec 2017 22:52:48 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Oleg Pykhalov Subject: Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile. References: <87vahbgmbc.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 Frimaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 13 Dec 2017 22:52:44 +0100 In-Reply-To: <87vahbgmbc.fsf@gmail.com> (Oleg Pykhalov's message of "Wed, 13 Dec 2017 09:43:19 +0300") Message-ID: <871sjygus3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29686 Cc: 29686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello, Oleg Pykhalov skribis: > Currently, if aspell is installed in GuixOS system profile and not in > user profile then aspell cannot find dictionaries. If you install both aspell and aspell-dict-* in the global profile, then ASPELL_DICT_DIR will point to /run/current-system/profile/lib/aspell instead of ~/.guix-profile/lib/aspell. Likewise: --8<---------------cut here---------------start------------->8--- $ guix environment --ad-hoc aspell aspell-dict-ru coreutils -C -- env | gre= p ASPELL [...] ASPELL_DICT_DIR=3D/gnu/store/hssihv9d5cq5hzh0kiwdwiv6qcrc921c-profile/lib/a= spell --8<---------------cut here---------------end--------------->8--- So I=E2=80=99m not sure we need a custom fix, do we? :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 20 08:14:20 2017 Received: (at 29686) by debbugs.gnu.org; 20 Dec 2017 13:14:20 +0000 Received: from localhost ([127.0.0.1]:43265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eReCR-000578-PN for submit@debbugs.gnu.org; Wed, 20 Dec 2017 08:14:19 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:45869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eReCQ-000571-Si for 29686@debbugs.gnu.org; Wed, 20 Dec 2017 08:14:19 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1CFBD6E87; Wed, 20 Dec 2017 14:14:22 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G_FOxp0ijbg2; Wed, 20 Dec 2017 14:14:21 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 1A7701056D; Wed, 20 Dec 2017 14:14:21 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Oleg Pykhalov Subject: Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile. References: <87vahbgmbc.fsf@gmail.com> <871sjygus3.fsf@gnu.org> Date: Wed, 20 Dec 2017 14:14:16 +0100 In-Reply-To: <871sjygus3.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 13 Dec 2017 22:52:44 +0100") Message-ID: <87a7ydy21j.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29686 Cc: 29686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Oleg, ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Oleg Pykhalov skribis: > >> Currently, if aspell is installed in GuixOS system profile and not in >> user profile then aspell cannot find dictionaries. > > If you install both aspell and aspell-dict-* in the global profile, then > ASPELL_DICT_DIR will point to /run/current-system/profile/lib/aspell > instead of ~/.guix-profile/lib/aspell. Likewise: > > $ guix environment --ad-hoc aspell aspell-dict-ru coreutils -C -- env | g= rep ASPELL > > [...] > > ASPELL_DICT_DIR=3D/gnu/store/hssihv9d5cq5hzh0kiwdwiv6qcrc921c-profile/lib= /aspell > > So I=E2=80=99m not sure we need a custom fix, do we? :-) Oleg, can we close this bug? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 20 09:47:33 2017 Received: (at 29686) by debbugs.gnu.org; 20 Dec 2017 14:47:33 +0000 Received: from localhost ([127.0.0.1]:43325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRfef-0003CP-Eb for submit@debbugs.gnu.org; Wed, 20 Dec 2017 09:47:33 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:36813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRfec-0003C9-6a for 29686@debbugs.gnu.org; Wed, 20 Dec 2017 09:47:30 -0500 Received: by mail-lf0-f45.google.com with SMTP id c19so4454322lfg.3 for <29686@debbugs.gnu.org>; Wed, 20 Dec 2017 06:47:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KwFzaiCT7AfOf/U4lx7+gVL7Zuf2R8qVBz9uQt0qVrQ=; b=bNFdQBT5uyubgmhsTmWNwipf9sUlk6t6DBvpp1g3bc2HThbeZHSGjBpOgxQqFpA8XU BARzlwYXp34LPYZ/wYyqLU/QvvQ6AeGfXGZC8S2qedw+Gxihyvax2cchqhxIrnFfRNQB 2rMHC81vNgICFU6owKEJzTS746ScEKw8yXMRnL804eHEHxHP0PAfMeSKgr7AXLvXVfOn U1MknDJqeINZIrVwuMOyOKH0c8V9JdyCC2rk51eHbXmt2jxzUEfsbO/b0t8abpflEWpA e6gVV4NL37N8IYTSARdQuGQnpKDkNphXhzjYeI3uDUMOr2J0kVMGmmlcRbO9DI3iVvDu N4xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KwFzaiCT7AfOf/U4lx7+gVL7Zuf2R8qVBz9uQt0qVrQ=; b=A7ub90gasBoeEywSLe124V13V92WJXRT/gIQoLRjTsiEFLlIwJwJjIWPXgoQLitccJ ndVsKOgFnagQNyvk7lctq/NBbk0bNFIZuFnuV0hOFdY8QyZq94QDfMHMl8XTKrLTwK6e qo+veSBtle4i5/jBzTnkjh5m4OvG2Twg+sedS9GYM7P7Auz1WgqhDGOQyhnERZWGcSrG Tn0xGx2uHc4YFOQD0mLiUOxGQx3aofcE/UE/hjckqF3DyfVMw3CxeYDH0SWXZb111pgN J08v6wpdxcy9nw5eRp712cD6hKbkqeX8f1Lmo6nDDn7+umIv0ZD/6pL2dY1O8m+o4mJo Hd2w== X-Gm-Message-State: AKGB3mIxg0KZ0EQ3GGS6Smy/frZHTO8n+iTCrowSikDkGorfFk2SJkbw Zf6reHyeL92DDfGo8hi/UGo+r3dW X-Google-Smtp-Source: ACJfBouZ0j48CA8dugtOKWyYWjF41SaO+6rjb52JU5ZTYEZR4f84v3sF+SnCpefXa7696wHWaU4BsA== X-Received: by 10.46.93.13 with SMTP id r13mr5045250ljb.102.1513781243737; Wed, 20 Dec 2017 06:47:23 -0800 (PST) Received: from magnolia ([178.71.224.245]) by smtp.gmail.com with ESMTPSA id v132sm3872752lfa.60.2017.12.20.06.47.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Dec 2017 06:47:22 -0800 (PST) From: Oleg Pykhalov To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile. References: <87vahbgmbc.fsf@gmail.com> <871sjygus3.fsf@gnu.org> <87a7ydy21j.fsf@gnu.org> Date: Wed, 20 Dec 2017 17:47:01 +0300 In-Reply-To: <87a7ydy21j.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 20 Dec 2017 14:14:16 +0100") Message-ID: <873745wj6i.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29686 Cc: 29686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Ludovic, Apologies for late reply. I thought how to reproduce it properly. ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>> Currently, if aspell is installed in GuixOS system profile and not in >>> user profile then aspell cannot find dictionaries. >> >> If you install both aspell and aspell-dict-* in the global profile, then >> ASPELL_DICT_DIR will point to /run/current-system/profile/lib/aspell >> instead of ~/.guix-profile/lib/aspell. Likewise: >> >> $ guix environment --ad-hoc aspell aspell-dict-ru coreutils -C -- >> env | grep ASPELL >> >> [...] >> >> ASPELL_DICT_DIR=3D/gnu/store/hssihv9d5cq5hzh0kiwdwiv6qcrc921c-profile/li= b/aspell >> >> So I=E2=80=99m not sure we need a custom fix, do we? :-) > > Oleg, can we close this bug? No, =2D-8<---------------cut here---------------start------------->8--- guix environment --ad-hoc aspell aspell-dict-ru coreutils -C -- aspell dicts =2D-8<---------------cut here---------------end--------------->8--- returns nothing, but need to return a list like en en-variant_0 en-variant_1 en-variant_2 en-w_accents en-wo_accents en_AU en_AU-variant_0 =E2=80=A6 Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlo6d+UACgkQckbhHGm3 lWnT3A/7B6DJk5ezhicmXK7GlRm2p7gF9Goae56V2iR+DiG9EN32NnRYa2kYEOHX WSU1syTEI1bHj4h2mkDlbMk3mGBwgiLzSHvoKVbCE772ZhIvVcNHUhJSZrF5sOn4 ixygCOksx61zTd0U6cGTuxfCWDX/gz/JcIEoplKbHrqhmZr/qXg3VVSEI5y7MoM1 onLpVEifDJEiNkYuqlwmur5DHml28dKpfjwJgH8yHw0+7cQJN0X1ntBlez4nDbbF WrJEd6IxLDavHHxecC6I0lI8008mURWpwYPBVfOApsaK6exLG/wTWzpuFYMMRuBg SJb73dSNe3pE7K3bi7n4lLTS62Jc47XlwQMP3Bd9tHOc38acSjvmQBIfpQKOPR5w 5JJjVNK9Qm7jOPTAmPocqASJosDmmMia1rpq4v6/xQmZtdulZTnZpQy+hODcVGFA SL/1HE+9C7SboVer5Xj1phom9OQTXzuscN+OEHNThGw9OQXoqBaJat26WaZPwJ4S aKYfr30a5t2a9d7YbYoijyUzd6yo8zn1BqFBIU2wCQwcvgBcrGFyfwuQeBcO+Lxw SZA9sHDT5EQhH63UuraF1G/lPmiMy3ISArXrqW/KsY4v6KkciFuxN0Q55Ayi5GSO 3fZeGhnzTJEdKre6v2AGaNRms0eC2imVP6LjTHmq/88wpkOuSoM= =U2CO -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 20 15:55:48 2017 Received: (at 29686) by debbugs.gnu.org; 20 Dec 2017 20:55:48 +0000 Received: from localhost ([127.0.0.1]:44842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRlP2-0000OP-Aw for submit@debbugs.gnu.org; Wed, 20 Dec 2017 15:55:48 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:47082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRlOz-0000OC-96 for 29686@debbugs.gnu.org; Wed, 20 Dec 2017 15:55:45 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 89A1C105D3; Wed, 20 Dec 2017 21:55:47 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5NN0QcCeplxw; Wed, 20 Dec 2017 21:55:46 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 95714FDDF; Wed, 20 Dec 2017 21:55:45 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Oleg Pykhalov Subject: Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile. References: <87vahbgmbc.fsf@gmail.com> <871sjygus3.fsf@gnu.org> <87a7ydy21j.fsf@gnu.org> <873745wj6i.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 Frimaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 20 Dec 2017 21:55:40 +0100 In-Reply-To: <873745wj6i.fsf@gmail.com> (Oleg Pykhalov's message of "Wed, 20 Dec 2017 17:47:01 +0300") Message-ID: <87h8slunjn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29686 Cc: 29686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Oleg, Oleg Pykhalov skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >>>> Currently, if aspell is installed in GuixOS system profile and not in >>>> user profile then aspell cannot find dictionaries. >>> >>> If you install both aspell and aspell-dict-* in the global profile, then >>> ASPELL_DICT_DIR will point to /run/current-system/profile/lib/aspell >>> instead of ~/.guix-profile/lib/aspell. Likewise: >>> >>> $ guix environment --ad-hoc aspell aspell-dict-ru coreutils -C -- >>> env | grep ASPELL >>> >>> [...] >>> >>> ASPELL_DICT_DIR=3D/gnu/store/hssihv9d5cq5hzh0kiwdwiv6qcrc921c-profile/l= ib/aspell >>> >>> So I=E2=80=99m not sure we need a custom fix, do we? :-) >> >> Oleg, can we close this bug? > > No, > > guix environment --ad-hoc aspell aspell-dict-ru coreutils -C -- aspell di= cts > > returns nothing, but need to return a list like > > en > en-variant_0 > en-variant_1 > en-variant_2 > en-w_accents > en-wo_accents > en_AU > en_AU-variant_0 > =E2=80=A6 Indeed. I have: --8<---------------cut here---------------start------------->8--- $ guix environment --ad-hoc aspell aspell-dict-ru -C -- aspell --config | g= rep -A3 dict-dir # dict-dir (string) # location of the main word list # default: <$ASPELL_DICT_DIR|home-dir/.guix-profile/lib/aspell> =3D /gnu/st= ore/b411b0fbwc85fjnf0h030gdkbv1qdmqh-profile/lib/aspell dict-dir /home/ludo/.guix-profile/lib/aspell # encoding (string) # encoding to expect data to be in -- # default: =3D /home/ludo/.guix-profile/lib/aspell/ # master (string) # base name of the main dictionary to use --8<---------------cut here---------------end--------------->8--- The value that shows up after the =E2=80=9C=3D=E2=80=9D sign is as expected= (it=E2=80=99s $ASPELL_DICT_DIR), but the value shown on the line below is not. Sounds like a problem in =E2=80=98aspell-dict-dir.patch=E2=80=99. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 09:04:32 2019 Received: (at 29686) by debbugs.gnu.org; 17 Oct 2019 13:04:33 +0000 Received: from localhost ([127.0.0.1]:47372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL5SC-0003vA-Iz for submit@debbugs.gnu.org; Thu, 17 Oct 2019 09:04:32 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:47131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL5SA-0003uz-I1 for 29686@debbugs.gnu.org; Thu, 17 Oct 2019 09:04:31 -0400 X-Originating-IP: 92.169.151.76 Received: from bababa (lfbn-1-4156-76.w92-169.abo.wanadoo.fr [92.169.151.76]) (Authenticated sender: pierre@atlas.engineer) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id B35254000A; Thu, 17 Oct 2019 13:04:28 +0000 (UTC) From: Pierre Neidhardt To: 29686@debbugs.gnu.org Subject: bug#29686: gnu: aspell: Do not ignore GuixOS system profile. Date: Thu, 17 Oct 2019 15:04:28 +0200 Message-ID: <87k193r09v.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I was hit by this as well, when installing dictionaries to the non-default profile. As Ludo pointed out: --88--- $ aspell config ... Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ambrevar.xyz] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.194 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.194 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 1.5 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 29686 Cc: Oleg Pykhalov , Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I was hit by this as well, when installing dictionaries to the non-default profile. As Ludo pointed out: =2D-8<---------------cut here---------------start------------->8--- $ aspell config ... # dict-dir (string) # location of the main word list # default: <$ASPELL_DICT_DIR|home-dir/.guix-profile/lib/aspell> =3D /home/a= mbrevar/.guix-extra-profiles/default/default/lib/aspell dict-dir /home/ambrevar/.guix-profile/lib/aspell ... =2D-8<---------------cut here---------------end--------------->8--- Something may be wrong with our patch: =2D-8<---------------cut here---------------start------------->8--- +#undef DICT_DIR +#define DICT_DIR "<$ASPELL_DICT_DIR|home-dir/.guix-profile/lib/aspell>" + =2D-8<---------------cut here---------------end--------------->8--- I had a quick glimpse at Aspell's source code but nothing obvious came out :p Maybe ask upstream? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl2oZtwACgkQm9z0l6S7 zH8SeQf/VjUsSPzz9XKwAQTNxPK3zeecI9r1gq1ynIfPop2tkSkFjGaAQhYf3wGP 4mBTudvNNG65pdFQMcPCpu/hR/CDkX/LCZiJP5rCW+dI4OnG2BsaIxIFh31TeWfb 4hrjPiF3LTe2OfF6AlpgKQgj8UwKnnRSHIpO6EWKF8yVQiJ86BpdwZe6EWhvorqr Ij4uRRX/CfUe9iT1aQEohZFQfhXqzq6W8Y9E1NBrg8whYPw67Puq2LHeG2piGqVO +kA1JXgKXve9K6XJ5ncTeFf6rTvyGQbUY1RFCYQ9lc34dRI1KCYIQ6y1fUlxNYOa hAsVtU++Xui/HHnTkQwSdaJPRxTeKA== =tD5c -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 26 07:02:40 2019 Received: (at 29686) by debbugs.gnu.org; 26 Oct 2019 11:02:40 +0000 Received: from localhost ([127.0.0.1]:39750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOJqC-0008Qr-2u for submit@debbugs.gnu.org; Sat, 26 Oct 2019 07:02:40 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:42897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOJq9-0008Qi-No for 29686@debbugs.gnu.org; Sat, 26 Oct 2019 07:02:38 -0400 X-Originating-IP: 92.169.151.76 Received: from bababa (lfbn-1-4156-76.w92-169.abo.wanadoo.fr [92.169.151.76]) (Authenticated sender: pierre@atlas.engineer) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 6244740004; Sat, 26 Oct 2019 11:02:35 +0000 (UTC) From: Pierre Neidhardt To: 29686@debbugs.gnu.org Subject: Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile. In-Reply-To: <87k193r09v.fsf@ambrevar.xyz> References: <87k193r09v.fsf@ambrevar.xyz> Date: Sat, 26 Oct 2019 13:02:34 +0200 Message-ID: <87k18rahx1.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 29686 Cc: Oleg Pykhalov , Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I just noticed that Nix has a different, possibly better approach to this in the attached patch. What do you think? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl20J8oACgkQm9z0l6S7 zH8WCwgAr49FbqIQj+am7Lr+DLCrjm0YrSSRIv9wb/7fhvSDsdHlvJ+2EXFM1qCo br2/AQXqwGfdVmIcAnoJ7B0VU90dHeFUWsX6A0WArxM9cyIreRlS/LGrlY09P65h iNeWir4qP8FhGbJtgi175HYkVw8i7TBphv9iG2ulzvlB9RLpq3hbpyBHMf6dQK7u K3NMfBZUwClmVDIdtIGoAhRz4woS7PRHZh/B2158sxDbo1oBrHZ4D19d+oK5ak4h wzIdYJ7KQEnLEy4Vec2s115bP7bT8kFISh8mggkjoVqSevn/PsszTKldlhL+4uOt UouZhCiQGCp9AkIlKigUP6wk1dKEJQ== =qF4y -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=data-dirs-from-nix-profiles.patch diff --git a/common/info.cpp b/common/info.cpp index 8291cc7..6216326 100644 --- a/common/info.cpp +++ b/common/info.cpp @@ -36,6 +36,7 @@ #include "strtonum.hpp" #include "lock.hpp" #include "string_map.hpp" +#include "file_util.hpp" #include "gettext.h" @@ -495,6 +496,25 @@ namespace acommon { lst.clear(); lst.add(config->retrieve("data-dir")); lst.add(config->retrieve("dict-dir")); + if (config->lookup("data-dir") == NULL && config->lookup("dict-dir") == NULL) { + const char* cprofiles = getenv("NIX_PROFILES"); + if (cprofiles != NULL) { + char* profiles = strdup(cprofiles); + char* profile = profiles; + char* end = profile; + while (*end != '\0') { + if (*end == ' ') { + *end = '\0'; + lst.add(add_possible_dir(profile, "lib/aspell")); + profile = ++end; + } else { + ++end; + } + } + lst.add(add_possible_dir(profile, "lib/aspell")); + free(profiles); + } + } } DictExt::DictExt(ModuleInfo * m, const char * e) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 27 18:31:54 2019 Received: (at 29686) by debbugs.gnu.org; 27 Oct 2019 22:31:55 +0000 Received: from localhost ([127.0.0.1]:43628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOr4k-0005hG-F4 for submit@debbugs.gnu.org; Sun, 27 Oct 2019 18:31:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOr4i-0005h1-VW for 29686@debbugs.gnu.org; Sun, 27 Oct 2019 18:31:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iOr4c-0005JQ-Vp; Sun, 27 Oct 2019 18:31:47 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46118 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iOr4b-0006ZA-AR; Sun, 27 Oct 2019 18:31:45 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Pierre Neidhardt Subject: Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile. References: <87k193r09v.fsf@ambrevar.xyz> <87k18rahx1.fsf@ambrevar.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 Brumaire an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 27 Oct 2019 23:31:43 +0100 In-Reply-To: <87k18rahx1.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Sat, 26 Oct 2019 13:02:34 +0200") Message-ID: <87h83thlbk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29686 Cc: Oleg Pykhalov , 29686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Pierre Neidhardt skribis: > I just noticed that Nix has a different, possibly better approach to > this in the attached patch. > > What do you think? I think that honoring an =E2=80=98ASPELL_DICT_DIR=E2=80=99 variable is more= generic than browsing a set of profiles (which ones?), especially with support for search paths as available in Guix. :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 03:42:19 2019 Received: (at 29686) by debbugs.gnu.org; 28 Oct 2019 07:42:19 +0000 Received: from localhost ([127.0.0.1]:43781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOzfP-0007JX-Gr for submit@debbugs.gnu.org; Mon, 28 Oct 2019 03:42:19 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:58133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOzfN-0007JP-Ax for 29686@debbugs.gnu.org; Mon, 28 Oct 2019 03:42:18 -0400 X-Originating-IP: 92.169.151.76 Received: from bababa (lfbn-1-4156-76.w92-169.abo.wanadoo.fr [92.169.151.76]) (Authenticated sender: pierre@atlas.engineer) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 573D440014; Mon, 28 Oct 2019 07:42:14 +0000 (UTC) From: Pierre Neidhardt To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile. In-Reply-To: <87h83thlbk.fsf@gnu.org> References: <87k193r09v.fsf@ambrevar.xyz> <87k18rahx1.fsf@ambrevar.xyz> <87h83thlbk.fsf@gnu.org> Date: Mon, 28 Oct 2019 08:42:13 +0100 Message-ID: <87a79lgvu2.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 29686 Cc: Oleg Pykhalov , 29686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > I think that honoring an =E2=80=98ASPELL_DICT_DIR=E2=80=99 variable is mo= re generic than > browsing a set of profiles (which ones?), especially with support for > search paths as available in Guix. :-) The Nix patch code could be modified to browse ASPELL_DICT_DIR, which isn't done at the moment in our package. =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl22m9UACgkQm9z0l6S7 zH+7qgf+KND8bh6CA1A3qHe33KUpDyp7gHhAeIKL4Ij+L1Uf2EhmbjhDQ9YfY0U4 RfLMF6u23Rqg5daE4BadWI14kKGgDeTBiI4HOxPJoLdzo3KvG2YbgujgLH4ay+i4 Ck65xoNGuzJWjIrF/SHYquiHuWgEQeegbNKPcKU4hhLFOjS6697sVbfDbYi3cP1x tGDD7hj8Z09iy3R6Iwu+pVcYiMkCNIyP4/zbKEGJFu+dl4wdBl4YQ6C9koNeCvYb aw/yn7KFL3dSCjF++73UULzLj0la0fpV9CZM3JH3afGhPZjxgqr2MceHorfYWEUf OUbO0rlIJYBVi03hJwgiPi574JHblg== =X9kr -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 13 12:51:55 2019 Received: (at 29686) by debbugs.gnu.org; 13 Nov 2019 17:51:55 +0000 Received: from localhost ([127.0.0.1]:60125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUwo6-0002Fi-Kg for submit@debbugs.gnu.org; Wed, 13 Nov 2019 12:51:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUwo4-0002FV-Gu for 29686@debbugs.gnu.org; Wed, 13 Nov 2019 12:51:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iUwny-000490-LG; Wed, 13 Nov 2019 12:51:46 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39498 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iUwny-0004vm-81; Wed, 13 Nov 2019 12:51:46 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Oleg Pykhalov Subject: Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile. References: <87vahbgmbc.fsf@gmail.com> <871sjygus3.fsf@gnu.org> <87a7ydy21j.fsf@gnu.org> <873745wj6i.fsf@gmail.com> <87h8slunjn.fsf@gnu.org> Date: Wed, 13 Nov 2019 18:51:43 +0100 In-Reply-To: <87h8slunjn.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 20 Dec 2017 21:55:40 +0100") Message-ID: <87v9rnmzps.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29686 Cc: 29686@debbugs.gnu.org, Pierre Neidhardt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Oleg & Pierre, ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Indeed. I have: > > $ guix environment --ad-hoc aspell aspell-dict-ru -C -- aspell --config |= grep -A3 dict-dir > # dict-dir (string) > # location of the main word list > # default: <$ASPELL_DICT_DIR|home-dir/.guix-profile/lib/aspell> =3D /gnu/= store/b411b0fbwc85fjnf0h030gdkbv1qdmqh-profile/lib/aspell > dict-dir /home/ludo/.guix-profile/lib/aspell > > # encoding (string) > # encoding to expect data to be in > -- > # default: =3D /home/ludo/.guix-profile/lib/aspell/ > > # master (string) > # base name of the main dictionary to use > > The value that shows up after the =E2=80=9C=3D=E2=80=9D sign is as expect= ed (it=E2=80=99s > $ASPELL_DICT_DIR), but the value shown on the line below is not. > > Sounds like a problem in =E2=80=98aspell-dict-dir.patch=E2=80=99. Actually the problem is the =E2=80=98wrap-aspell=E2=80=99 phase, which pred= ates =E2=80=98aspell-dict-dir.patch=E2=80=99 and is unnecessary in the presence = of this patch. In addition to removing the phase, the patch had to be adjusted so that it would actually adjust the right-hand size of =E2=80=98|=E2=80=99 for =E2= =80=98dict-dir=E2=80=99 (a bug that apparently went unnoticed, probably because the =E2=80=98wrap-aspe= ll=E2=80=99 phase was hiding it). With the patch below, I get: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix environment --ad-hoc aspell aspell-dict-ru -C -- aspe= ll --config |grep -A2 '^# dict-dir' # dict-dir (string) # location of the main word list # default: <$ASPELL_DICT_DIR|$HOME/.guix-profile/lib/aspell> =3D /gnu/store= /adfc4l73nw3ccai3h5im21wblmrhfy4z-profile/lib/aspell --8<---------------cut here---------------end--------------->8--- and: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix environment --ad-hoc aspell aspell-dict-ru -C -- aspe= ll dicts ru ru-ye ru-yeyo ru-yo --8<---------------cut here---------------end--------------->8--- =E2=80=A6 while still getting the intended result when running it outside = =E2=80=98guix environment=E2=80=99: --8<---------------cut here---------------start------------->8--- $ (unset ASPELL_DICT_DIR; ./pre-inst-env guix environment --ad-hoc aspell = -K -- aspell --config) |grep -A2 '^# dict-dir' # dict-dir (string) # location of the main word list # default: <$ASPELL_DICT_DIR|$HOME/.guix-profile/lib/aspell> =3D /home/ludo= /.guix-profile/lib/aspell $ (unset ASPELL_DICT_DIR; ./pre-inst-env guix environment --ad-hoc aspell = -K -- aspell dicts) |wc -l 58 $ (unset HOME; ./pre-inst-env guix environment --ad-hoc aspell -K -- aspel= l dicts) |wc -l 58 --8<---------------cut here---------------end--------------->8--- I=E2=80=99ll apply it on =E2=80=98core-updates=E2=80=99 if it=E2=80=99s fin= e with you. Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm index af38c149c2..a5d02a453d 100644 --- a/gnu/packages/aspell.scm +++ b/gnu/packages/aspell.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright =C2=A9 2013, 2014, 2015, 2017, 2018 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2013, 2014, 2015, 2017, 2018, 2019 Ludovic Court=C3= =A8s ;;; Copyright =C2=A9 2015, 2016 Alex Kost ;;; Copyright =C2=A9 2016 John Darrington ;;; Copyright =C2=A9 2016, 2017, 2019 Efraim Flashner @@ -65,14 +65,6 @@ (("\"filter-path(.*)DICT_DIR" _ middle) (string-append "\"filter-path" middle "\"" libdir "\""))) - #t))) - (add-after 'install 'wrap-aspell - (lambda* (#:key outputs #:allow-other-keys) - (let ((bin/aspell (string-append (assoc-ref outputs "out") - "/bin/aspell"))) - (wrap-program bin/aspell - '("ASPELL_CONF" "" =3D - ("${ASPELL_CONF:-\"dict-dir ${GUIX_PROFILE:-$HOME/.guix= -profile}/lib/aspell\"}"))) #t)))))) (inputs `(("perl" ,perl))) =20 diff --git a/gnu/packages/patches/aspell-default-dict-dir.patch b/gnu/packa= ges/patches/aspell-default-dict-dir.patch index 17a6ff606f..5f759a66d9 100644 --- a/gnu/packages/patches/aspell-default-dict-dir.patch +++ b/gnu/packages/patches/aspell-default-dict-dir.patch @@ -8,12 +8,34 @@ However it is necessary for applications that use libaspe= ll since =20 --- a/common/config.cpp +++ b/common/config.cpp +@@ -651,7 +651,20 @@ namespace acommon { + } else { // sep =3D=3D '|' + assert(replace[0] =3D=3D '$'); + const char * env =3D getenv(replace.c_str()+1); +- final_str +=3D env ? env : second; ++ if (env) { ++ final_str +=3D env; ++ } else if (second[0] =3D=3D '$') { ++ // Expand the right-hand side of '|', which starts with a ++ // reference to an environment variable. ++ auto slash =3D second.find('/'); ++ String variable =3D second.substr(1, slash - 1); ++ const char * env =3D getenv(variable.c_str()); ++ String value =3D env ? String(env) : ""; ++ value +=3D second.substr(slash, second.size() - slash); ++ final_str +=3D value; ++ } else { ++ final_str +=3D second; ++ } + } + replace =3D ""; + in_replace =3D false; @@ -1349,6 +1349,9 @@ namespace acommon { # define REPL ".aspell..prepl" #endif =20=20 +#undef DICT_DIR -+#define DICT_DIR "<$ASPELL_DICT_DIR|home-dir/.guix-profile/lib/aspell>" ++#define DICT_DIR "<$ASPELL_DICT_DIR|$HOME/.guix-profile/lib/aspell>" + static const KeyInfo config_keys[] =3D { // the description should be under 50 chars --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 14 06:22:52 2019 Received: (at 29686) by debbugs.gnu.org; 14 Nov 2019 11:22:52 +0000 Received: from localhost ([127.0.0.1]:32783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVDDA-0001zf-8D for submit@debbugs.gnu.org; Thu, 14 Nov 2019 06:22:52 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:52871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVDD7-0001zT-FZ for 29686@debbugs.gnu.org; Thu, 14 Nov 2019 06:22:50 -0500 X-Originating-IP: 92.169.151.76 Received: from bababa (lfbn-1-4156-76.w92-169.abo.wanadoo.fr [92.169.151.76]) (Authenticated sender: pierre@atlas.engineer) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 8BBDD60009; Thu, 14 Nov 2019 11:22:47 +0000 (UTC) From: Pierre Neidhardt To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Oleg Pykhalov Subject: Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile. In-Reply-To: <87v9rnmzps.fsf@gnu.org> References: <87vahbgmbc.fsf@gmail.com> <871sjygus3.fsf@gnu.org> <87a7ydy21j.fsf@gnu.org> <873745wj6i.fsf@gmail.com> <87h8slunjn.fsf@gnu.org> <87v9rnmzps.fsf@gnu.org> Date: Thu, 14 Nov 2019 12:22:44 +0100 Message-ID: <87eeyag0sb.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 29686 Cc: 29686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Looks good to me, thanks for working on this! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl3NOQQACgkQm9z0l6S7 zH8A2gf/Se/60jVCSlmGz1WVgKkhSbAFTtqyGMHgQpuzyYNVO1wYqMpZGHoF30nn R32Tu5OOkNiOUuTo6VFb97/WgF7Y+gDDSpmOb70G6UanOKXRLThpjsYjc30d+RzR /m9iiO16jb8fjmUVYiTFfLKtMgV1xr2DLUyYpu7rqOvEUPzmR/xMK64aeY+6uLcL gthMjvYj8aAfV2znjSuSM40z7dxCsoil4h09Q+usXkHGtfpRdCdRrBrnsDCYY+6V SGukcyE6miwhkQQAlQzVeI2AxCdN9U8zL35VVL97XNtYgkDyszeRse7ivFSa6FtT qWKmqAntO9wHWl3O2IG/HQx82B+Flg== =eO0E -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 14 16:39:53 2019 Received: (at 29686-done) by debbugs.gnu.org; 14 Nov 2019 21:39:53 +0000 Received: from localhost ([127.0.0.1]:35348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVMqG-0005d3-RU for submit@debbugs.gnu.org; Thu, 14 Nov 2019 16:39:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVMqD-0005cq-Vs for 29686-done@debbugs.gnu.org; Thu, 14 Nov 2019 16:39:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iVMq8-0005rq-LL; Thu, 14 Nov 2019 16:39:44 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=55460 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iVMq8-00064c-04; Thu, 14 Nov 2019 16:39:44 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Pierre Neidhardt Subject: Re: bug#29686: gnu: aspell: Do not ignore GuixOS system profile. References: <87vahbgmbc.fsf@gmail.com> <871sjygus3.fsf@gnu.org> <87a7ydy21j.fsf@gnu.org> <873745wj6i.fsf@gmail.com> <87h8slunjn.fsf@gnu.org> <87v9rnmzps.fsf@gnu.org> <87eeyag0sb.fsf@ambrevar.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 Brumaire an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 14 Nov 2019 22:39:41 +0100 In-Reply-To: <87eeyag0sb.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Thu, 14 Nov 2019 12:22:44 +0100") Message-ID: <87h836m92a.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29686-done Cc: Oleg Pykhalov , 29686-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Pierre Neidhardt skribis: > Looks good to me, thanks for working on this! Pushed as 4554d6b77e0f306a3dc33a8c1f68c9a302967a08 (core-updates). Thank you! Ludo=E2=80=99. From unknown Tue Jun 17 01:50:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 13 Dec 2019 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator