From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 11 17:02:46 2017 Received: (at submit) by debbugs.gnu.org; 11 Dec 2017 22:02:46 +0000 Received: from localhost ([127.0.0.1]:57376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOW9q-0007om-QH for submit@debbugs.gnu.org; Mon, 11 Dec 2017 17:02:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOVtV-0007Li-C8 for submit@debbugs.gnu.org; Mon, 11 Dec 2017 16:45:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOVtO-0006HN-Pk for submit@debbugs.gnu.org; Mon, 11 Dec 2017 16:45:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=5.0 tests=BAYES_50,FORGED_YAHOO_RCVD, FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56193) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eOVtO-0006Gq-Mc for submit@debbugs.gnu.org; Mon, 11 Dec 2017 16:45:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOVtN-0008PV-E5 for bug-grep@gnu.org; Mon, 11 Dec 2017 16:45:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOVtJ-00062h-DH for bug-grep@gnu.org; Mon, 11 Dec 2017 16:45:41 -0500 Received: from sonic307-7.consmr.mail.ir2.yahoo.com ([87.248.110.32]:35900) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOVtJ-0005yN-5G for bug-grep@gnu.org; Mon, 11 Dec 2017 16:45:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1513028734; bh=1mJbziOLuqbDCATzlNSYvMzm3QO1eT6W9LqWla34/Ps=; h=Subject:From:To:Cc:Date:From:Subject; b=LFsJ+O7NCBOG2MP7oJrd1LLPTIqZOzGGZzHkcMiNhv5Qfl6iP1VTCLI1tRYBWPdsYDOUoF/s/AC4W/URSleS8ZStVrWkCkz9J2ikFc8pA9IQ5AjDShII8KHGdAPdYG8bJhnPaop+XI9kwSflE2kQTSeTdl57bcaBJoGESqAluX/p1kCWAbD4kTePN/7mnGg/rR6dVERJs99TcCzp4GqkoA0GV0u84VcnqnG54FXxZidX1ItTr8VJ7nhp1py8I6O9Z8S8xYuqtS0yoCsx06HEURGhQIqIPec4hXVeCq7Q+dZKz5EbCQqPnPm+OWWpa1wYu0KEYQUKJmUvq5cXr2ph6w== X-YMail-OSG: NzbnboYVM1k8w06TssMf4QqvaNt1fvCzyunnltKWqLsPzehoPD9UxSFj7LwEJBy SFxK6G34TgNaK5dO9CnxkDcRzRYCoWcS9_VNHrhyI3UQtBJpXk9pg8y4fxtcHl0FdteMo_SFqatD abfCErh6.hp1awQ5LZNERyPduIzRds4TRVlavreU37Tt8OtdgNeKifPKodmxmIchu2B4dWc4pkmT pmq7NDekXTgthKEK.MZ9jLKGyoxcNMJyXas0fZJEc0DqJNuv2IeQeXgg_EbWHEoLzLSYHJH6jK8P Lueyv18jGct_ui3wMk9GLv9_6f78uEvKCLxGmjS7GDQYaVgmnghnENkDFAabKhWUxhdxLE87vnoU PhTD5hUEBGsfIeJzGUw0rgzAdHcDFPtV0I9Z9nwVKOof5SEin9SNbWxV.f.ME_.yazkvF4axjsXR CKUbVX5kmfSFbOYhumJyQHf.PR.3MKx.Xxgd1J.r_fRtoX6eZAw.95dfZYoOjVUAyTi99A0S9CXz v1XlwiUwFA5ga_Rq5aqnCV8lOiBIsMPslR0ZapdQZHw-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Mon, 11 Dec 2017 21:45:34 +0000 Received: from smtp159.mail.ir2.yahoo.com (EHLO pg-desktop) ([46.228.39.122]) by smtp409.mail.ir2.yahoo.com (JAMES SMTP Server ) with ESMTPA ID 1330388737; Mon, 11 Dec 2017 21:45:29 +0000 (UTC) Message-ID: <1513028725.3625.20.camel@yahoo.com> Subject: grep: Fatal problem with (big) file From: pg To: bug-grep@gnu.org Date: Mon, 11 Dec 2017 23:45:25 +0200 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 11 Dec 2017 17:02:40 -0500 Cc: toimitus@masinistit.com, webmaster@ubuntu.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! $ awk '/Volvo/' Tieliikenne5.0.csv | wc -l 266175 $ grep Volvo Tieliikenne5.0.csv | wc -l 1638 $ echo $? (after "grep =C2=A0Volvo Tieliikenne5.0.csv" only too) 0 $ ack Volvo Tieliikenne5.0.csv | wc -l 266175 The file contain 5 milj. lines. It is the vehicle DB dump of Finland: http://trafiopendata.97.fi/opendata/171009_Tieliikenne_5_0.zip $ uname -a Linux pg-desktop 4.10.0-40-generic #44~16.04.1-Ubuntu SMP Thu Nov 9 15:37:44 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Fatal error with =E2=80=9Dsmall=E2=80=9D file too: $ awk '/Volvo/' Tieliikenne5.0.csv > volvot.csv $ awk '/N3/'=C2=A0=C2=A0volvot.csv | wc -l 17822 $ grep N3 volvot.csv | wc -l 1701 $ wc -l volvot.csv=C2=A0 266175 volvot.csv BR pg PS: Ubuntu webmaster - pls put error rep adr into your system and fwd msg? PPS: toimitus - Kyll=C3=A4 m=C3=A4=C3=A4 ennen olen osannut grepata;-) PPPS: pointer error again? use perl or die! From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 11 18:36:52 2017 Received: (at 29668) by debbugs.gnu.org; 11 Dec 2017 23:36:52 +0000 Received: from localhost ([127.0.0.1]:57423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOXcy-0001wV-Dv for submit@debbugs.gnu.org; Mon, 11 Dec 2017 18:36:52 -0500 Received: from mailgw05.kcn.ne.jp ([61.86.7.212]:54107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOXcu-0001w5-C2 for 29668@debbugs.gnu.org; Mon, 11 Dec 2017 18:36:50 -0500 Received: from mxs01-s (mailgw1.kcn.ne.jp [61.86.15.233]) by mailgw05.kcn.ne.jp (Postfix) with ESMTP id 2391C8805D9 for <29668@debbugs.gnu.org>; Tue, 12 Dec 2017 08:36:41 +0900 (JST) X-matriXscan-loop-detect: 04718f115f1cdb93a03979b277bc8af447af9021 Received: from mail07.kcn.ne.jp ([61.86.6.186]) by mxs01-s with ESMTP; Tue, 12 Dec 2017 08:36:38 +0900 (JST) Received: from [10.120.1.101] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail07.kcn.ne.jp (Postfix) with ESMTPA id 8C071D50098; Tue, 12 Dec 2017 08:36:38 +0900 (JST) Date: Tue, 12 Dec 2017 08:36:36 +0900 From: Norihiro Tanaka To: pg Subject: Re: bug#29668: grep: Fatal problem with (big) file In-Reply-To: <1513028725.3625.20.camel@yahoo.com> References: <1513028725.3625.20.camel@yahoo.com> Message-Id: <20171212083636.F7EE.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.73 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29668 Cc: 29668@debbugs.gnu.org, toimitus@masinistit.com, webmaster@ubuntu.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Mon, 11 Dec 2017 23:45:25 +0200 pg wrote: > $ awk '/Volvo/' Tieliikenne5.0.csv | wc -l > 266175 > $ grep Volvo Tieliikenne5.0.csv | wc -l > 1638 > $ awk '/N3/' volvot.csv | wc -l > 17822 > $ grep N3 volvot.csv | wc -l > 1701 Perhaps, characters not to be able to recognize in your locale included in Tieliikenne 5.0.csv and volvot.csv are included. Try below. -- $ env LC_ALL=C grep 'Volvo' Tieliikenne\ 5.0.csv | wc -l 266175 or $ grep -a 'Volvo' Tieliikenne\ 5.0.csv | wc -l 266175 -- $ env LC_ALL=C grep N3 volvot.csv | wc -l 17822 or $ grep -a N3 volvot.csv | wc -l 17822 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 19:28:19 2017 Received: (at 29668) by debbugs.gnu.org; 13 Dec 2017 00:28:19 +0000 Received: from localhost ([127.0.0.1]:59102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOuuJ-000417-6B for submit@debbugs.gnu.org; Tue, 12 Dec 2017 19:28:19 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOuuH-00040s-Bf for 29668@debbugs.gnu.org; Tue, 12 Dec 2017 19:28:17 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 53E7516145D; Tue, 12 Dec 2017 16:28:10 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 00pbbW8BuJ_U; Tue, 12 Dec 2017 16:28:09 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9782316147B; Tue, 12 Dec 2017 16:28:09 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6JgvRZiZ-kof; Tue, 12 Dec 2017 16:28:09 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 7534116090B; Tue, 12 Dec 2017 16:28:09 -0800 (PST) Subject: Re: bug#29668: grep: Fatal problem with (big) file To: Norihiro Tanaka , pg References: <1513028725.3625.20.camel@yahoo.com> <20171212083636.F7EE.27F6AC2D@kcn.ne.jp> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <3b14dc5f-687f-3afb-2fb6-d1ccd7c176ab@cs.ucla.edu> Date: Tue, 12 Dec 2017 16:28:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171212083636.F7EE.27F6AC2D@kcn.ne.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29668 Cc: 29668@debbugs.gnu.org, toimitus@masinistit.com, webmaster@ubuntu.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 12/11/2017 03:36 PM, Norihiro Tanaka wrote: > Perhaps, characters not to be able to recognize in your locale included > in Tieliikenne 5.0.csv and volvot.csv are included. Yes, that's the problem. The original 'grep' output ended in "Binary file Tieliikenne5.0.csv matches" but the user didn't see that. Perhaps we should send that diagnostic to stderr as well. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 13 18:25:40 2017 Received: (at 29668) by debbugs.gnu.org; 13 Dec 2017 23:25:40 +0000 Received: from localhost ([127.0.0.1]:60984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePGPD-0003Gt-VZ for submit@debbugs.gnu.org; Wed, 13 Dec 2017 18:25:40 -0500 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:60035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePGPC-0003Gf-E2 for 29668@debbugs.gnu.org; Wed, 13 Dec 2017 18:25:39 -0500 Received: from mxs02-s (mailgw2.kcn.ne.jp [61.86.15.234]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id 570C6806ED for <29668@debbugs.gnu.org>; Thu, 14 Dec 2017 08:25:30 +0900 (JST) X-matriXscan-loop-detect: 5550e428710aa37f1643ea5a877f65b4aa216568 Received: from mail07.kcn.ne.jp ([61.86.6.186]) by mxs02-s with ESMTP; Thu, 14 Dec 2017 08:25:28 +0900 (JST) Received: from [10.120.1.101] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail07.kcn.ne.jp (Postfix) with ESMTPA id F3174D50098; Thu, 14 Dec 2017 08:25:27 +0900 (JST) Date: Thu, 14 Dec 2017 08:25:26 +0900 From: Norihiro Tanaka To: Paul Eggert Subject: Re: bug#29668: grep: Fatal problem with (big) file In-Reply-To: <3b14dc5f-687f-3afb-2fb6-d1ccd7c176ab@cs.ucla.edu> References: <20171212083636.F7EE.27F6AC2D@kcn.ne.jp> <3b14dc5f-687f-3afb-2fb6-d1ccd7c176ab@cs.ucla.edu> Message-Id: <20171214082525.532F.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.73 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29668 Cc: 29668@debbugs.gnu.org, toimitus@masinistit.com, webmaster@ubuntu.com, pg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, 12 Dec 2017 16:28:09 -0800 Paul Eggert wrote: > On 12/11/2017 03:36 PM, Norihiro Tanaka wrote: > > Perhaps, characters not to be able to recognize in your locale included > > in Tieliikenne 5.0.csv and volvot.csv are included. > > Yes, that's the problem. The original 'grep' output ended in "Binary file Tieliikenne5.0.csv matches" but the user didn't see that. Perhaps we should send that diagnostic to stderr as well. I don't seem that that's problem. the user pass output of grep to wc -l, so `Binary file ... matches' line is also counted by `wc' as one line. $ env LC_ALL=C grep 'Volvo' Tieliikenne\ 5.0.csv | wc -l 266175 $ env LC_ALL=en_US.utf8 grep 'Volvo' Tieliikenne\ 5.0.csv | wc -l 241264 $ env LC_ALL=en_US.utf8 grep 'Volvo' Tieliikenne\ 5.0.csv | tail -1 Binary file Tieliikenne 5.0.csv matches $ env LC_ALL=C grep N3 volvot.csv | wc -l 17822 $ env LC_ALL=en_US.utf8 grep N3 volvot.csv | wc -l 11741 $ env LC_ALL=en_US.utf8 grep N3 volvot.csv | tail -1 Binary file volvot.csv matches From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 13 19:04:09 2017 Received: (at 29668) by debbugs.gnu.org; 14 Dec 2017 00:04:09 +0000 Received: from localhost ([127.0.0.1]:32774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePH0S-0006A0-SN for submit@debbugs.gnu.org; Wed, 13 Dec 2017 19:04:09 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePH0O-00069T-NR for 29668@debbugs.gnu.org; Wed, 13 Dec 2017 19:04:05 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C068C1614AB; Wed, 13 Dec 2017 16:03:58 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0xQa4y-rB3qm; Wed, 13 Dec 2017 16:03:58 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0E2891614BA; Wed, 13 Dec 2017 16:03:58 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id V8UpKXJL2lJ8; Wed, 13 Dec 2017 16:03:57 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E32651614A9; Wed, 13 Dec 2017 16:03:57 -0800 (PST) Subject: Re: bug#29668: grep: Fatal problem with (big) file To: Norihiro Tanaka References: <20171212083636.F7EE.27F6AC2D@kcn.ne.jp> <3b14dc5f-687f-3afb-2fb6-d1ccd7c176ab@cs.ucla.edu> <20171214082525.532F.27F6AC2D@kcn.ne.jp> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Wed, 13 Dec 2017 16:03:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171214082525.532F.27F6AC2D@kcn.ne.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29668 Cc: 29668@debbugs.gnu.org, toimitus@masinistit.com, webmaster@ubuntu.com, pg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 12/13/2017 03:25 PM, Norihiro Tanaka wrote: > I don't seem that that's problem. the user pass output of grep to wc -l, > so `Binary file ... matches' line is also counted by `wc' as one line. The intent of 'grep PATTERN | wc -l' is to count the number of matches, like 'grep -c PATTERN' would. But it doesn't work that way here. E.g., on Fedora 27 with LANG=en_US.UTF-8: $ grep -c Volvo Tieliikenne5.0.csv 266175 $ grep Volvo Tieliikenne5.0.csv | wc -l 241264 $ grep Volvo Tieliikenne5.0.csv | tail -n 1 Binary file Tieliikenne5.0.csv matches If the "Binary file ... matches" line were sent to stdout instead of to stderr, the problem would be more obvious to the user: $ grep -c Volvo Tieliikenne5.0.csv 266175 $ grep Volvo Tieliikenne5.0.csv | wc -l Binary file Tieliikenne5.0.csv matches 241264 $ grep Volvo Tieliikenne5.0.csv | tail -n 1 Binary file Tieliikenne5.0.csv matches T;2017-09-29;75;01;;;19550000;;;;;1;1570;;3000;2595;1670;;01;2200;20.6;4;false;false;Volvo;;;;;01;;01;977;;;841;;5092946 I believe that in the past I've thought that the "Binary file" message should be sent to stdout, but these examples are a reasonably compelling reason to send them to stderr instead. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 19:26:11 2017 Received: (at 29668) by debbugs.gnu.org; 16 Dec 2017 00:26:11 +0000 Received: from localhost ([127.0.0.1]:36249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQ0It-0006Q9-4A for submit@debbugs.gnu.org; Fri, 15 Dec 2017 19:26:11 -0500 Received: from mailgw05.kcn.ne.jp ([61.86.7.212]:46706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQ0Iq-0006Pq-Uu for 29668@debbugs.gnu.org; Fri, 15 Dec 2017 19:26:09 -0500 Received: from mxs01-s (mailgw1.kcn.ne.jp [61.86.15.233]) by mailgw05.kcn.ne.jp (Postfix) with ESMTP id 8620D88065A for <29668@debbugs.gnu.org>; Sat, 16 Dec 2017 09:26:01 +0900 (JST) X-matriXscan-loop-detect: c148ae16da7cdffb07a81bb9404a5abc6cfff6f5 Received: from mail01.kcn.ne.jp ([61.86.6.180]) by mxs01-s with ESMTP; Sat, 16 Dec 2017 09:26:00 +0900 (JST) Received: from [10.120.1.101] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail01.kcn.ne.jp (Postfix) with ESMTPA id 1A9475A8260; Sat, 16 Dec 2017 09:26:00 +0900 (JST) Date: Sat, 16 Dec 2017 09:25:59 +0900 From: Norihiro Tanaka To: Paul Eggert Subject: Re: bug#29668: grep: Fatal problem with (big) file In-Reply-To: References: <20171214082525.532F.27F6AC2D@kcn.ne.jp> Message-Id: <20171216092558.1756.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.73 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29668 Cc: 29668@debbugs.gnu.org, toimitus@masinistit.com, webmaster@ubuntu.com, pg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Wed, 13 Dec 2017 16:03:57 -0800 Paul Eggert wrote: > On 12/13/2017 03:25 PM, Norihiro Tanaka wrote: > > I don't seem that that's problem. the user pass output of grep to wc -l, > > so `Binary file ... matches' line is also counted by `wc' as one line. > > The intent of 'grep PATTERN | wc -l' is to count the number of matches, like 'grep -c PATTERN' would. But it doesn't work that way here. E.g., on Fedora 27 with LANG=en_US.UTF-8: > > $ grep -c Volvo Tieliikenne5.0.csv > 266175 > $ grep Volvo Tieliikenne5.0.csv | wc -l > 241264 > $ grep Volvo Tieliikenne5.0.csv | tail -n 1 > Binary file Tieliikenne5.0.csv matches > > If the "Binary file ... matches" line were sent to stdout instead of to stderr, the problem would be more obvious to the user: > > $ grep -c Volvo Tieliikenne5.0.csv > 266175 > $ grep Volvo Tieliikenne5.0.csv | wc -l > Binary file Tieliikenne5.0.csv matches > 241264 > $ grep Volvo Tieliikenne5.0.csv | tail -n 1 > Binary file Tieliikenne5.0.csv matches > T;2017-09-29;75;01;;;19550000;;;;;1;1570;;3000;2595;1670;;01;2200;20.6;4;false;false;Volvo;;;;;01;;01;977;;;841;;5092946 > > I believe that in the past I've thought that the "Binary file" message should be sent to stdout, but these examples are a reasonably compelling reason to send them to stderr instead. In addition, the following problem can also occur. $ printf 'Binary file a.txt matches\n' >a.txt $ env LC_ALL=en_US.utf8 grep B a.txt Binary file a.txt matches $ printf '\xFFB\n' >a.txt $ env LC_ALL=en_US.utf8 grep B a.txt Binary file a.txt matches Both are same output. However, the former displays the contents of the matched line, OTOH the latter is not so. if "Binary file" is sent to stdout, a user can not distinguish whether a.txt is text file or a binary file without opening the file. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 03:54:55 2020 Received: (at 29668) by debbugs.gnu.org; 2 Jan 2020 08:54:55 +0000 Received: from localhost ([127.0.0.1]:38066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imwFr-00034k-3E for submit@debbugs.gnu.org; Thu, 02 Jan 2020 03:54:55 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imwFo-00034O-JI; Thu, 02 Jan 2020 03:54:53 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 81FB0160017; Thu, 2 Jan 2020 00:54:46 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id gcmiEcoIYOZE; Thu, 2 Jan 2020 00:54:45 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B12C2160054; Thu, 2 Jan 2020 00:54:45 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cpROGi6XhBC7; Thu, 2 Jan 2020 00:54:45 -0800 (PST) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 89B37160017; Thu, 2 Jan 2020 00:54:45 -0800 (PST) To: Jason Franklin From: Paul Eggert Subject: Re: Possible bug with handling -I option Organization: UCLA Computer Science Department Message-ID: <0987d409-b22c-5832-2ecc-bd23401b9cf7@cs.ucla.edu> Date: Thu, 2 Jan 2020 00:54:42 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29668 Cc: 33552@debbugs.gnu.org, 29668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jason, thanks for reporting this grep bug . It strikes me that this is related to another grep bug concerning the "Binary files ..." message. Although they're not the same bug, it's likely that fixing one will also entail fixing the other. So I'll add a message to both bug reports to this effect. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 14:46:14 2020 Received: (at 29668) by debbugs.gnu.org; 17 Sep 2020 18:46:15 +0000 Received: from localhost ([127.0.0.1]:39032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyv8-0007PB-Aw for submit@debbugs.gnu.org; Thu, 17 Sep 2020 14:46:14 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:55352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyv6-0007Ou-5N; Thu, 17 Sep 2020 14:46:14 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B26F3160085; Thu, 17 Sep 2020 11:46:05 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id JmX8nFUUONJV; Thu, 17 Sep 2020 11:46:04 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 339A71600B4; Thu, 17 Sep 2020 11:46:04 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cZVFj1wx3KXf; Thu, 17 Sep 2020 11:46:04 -0700 (PDT) Received: from [192.168.1.9] (cpe-75-82-69-226.socal.res.rr.com [75.82.69.226]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id DE8CC160085; Thu, 17 Sep 2020 11:46:03 -0700 (PDT) Subject: grep patches for "Binary file FOO matches" glitches From: Paul Eggert To: Jason Franklin References: <0987d409-b22c-5832-2ecc-bd23401b9cf7@cs.ucla.edu> Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDVlFRVEFRZ0FQ d0liQXdZTApDUWdIQXdJR0ZRZ0NDUW9MQkJZQ0F3RUNIZ0VDRjRBV0lRUitONUtwMkt6MzFq TzhGWWp0bCtrT1lxcCtOQVVDClh5Vzlsd1VKRks0THN3QUtDUkR0bCtrT1lxcCtOS05WRC85 SE1zSTE2MDZuMFV1VFhId0lUc3lPakFJOVNET1QKK0MzRFV2NnFsTTVCSDJuV0FNVGlJaXlB NXVnbHNKdjkzb2kydk50RmYvUS9tLzFjblpXZ25WbkV4a3lMSTRFTgpTZDF1QnZyMC9sQ1Nk UGxQME1nNkdXU3BYTXUreDB2ZFQwQWFaTk9URTBGblB1b2xkYzNYRDc2QzJxZzhzWC9pCmF4 WFRLSHk5UCtCbEFxL0NzNy9weERRMEV6U24wVVNaMkMwbDV2djRQTXBBL3BpY25TNks2MDlK dkRHYU9SbXcKWmVYSVpxUU5aVitaUXMrVVl0Vm9ndURUcWJ5M0lVWTFJOEJsWEhScHRhajlB TW40VW9oL0NxcFFsVm9qb3lXbApIcWFGbm5KQktlRjBodko5U0F5YWx3dXpBakc3dlFXMDdN WW5jYU9GbTB3b2lLYmc1SkxPOEY0U0JUSWt1TzBECkNmOW5MQWF5NlZzQjRyendkRWZSd2pQ TFlBbjdNUjNmdkhDRXpmcmtsZFRyYWlCTzFUMGllREs4MEk3c0xmNnAKTWVDWUkxOXBVbHgw L05STUdDZGRpRklRZGZ0aEtXWEdSUzVMQXM4andCZjhINkc1UFdpblByRUlhb21JUDIxaQp2 dWhRRDA3YllxOUlpSWRlbGpqVWRIY0dJMGkvQjRNNTZaYWE4RmYzOGluaU9sckRZQ21ZV1I0 ZENXWml1UWVaCjNPZ3FlUXM5YTZqVHZnZERHVm1SVnFZK2p6azhQbGFIZmNvazhST2hGY0hL a2NmaHVCaEwyNWhsUklzaFJET0UKc2tYcUt3bnpyYnFnYTNHWFpYZnNYQW9GYnpOaExkTHY5 QStMSkFZU2tYUDYvNXFkVHBFTFZHb3N5SDg4NFZkYgpCcGtHSTA0b1lWcXVsYmtDRFFSTWdI SmtBUkFBcG9YcnZ4UDNESWZqQ05PdFhVL1Bkd01TaEtkWC9SbFNzNVBmCnVuVjF3YktQOGhl clhIcnZRZEZWcUVDYVRTeG1saHpiazhYMFBrWTlnY1ZhVTJPNDlUM3FzT2QxY0hlRjUyWUYK R0V0MExoc0JlTWpnTlg1dVoxVjc2cjhneWVWbEZwV1diMFNJd0pVQkhyRFhleEY2N3VwZVJi MnZkSEJqWUROZQp5U24rMEI3Z0ZFcXZWbVp1K0xhZHVkRHA2a1FMamF0RnZIUUhVU0dOc2hC bmtrY2FUYmlJOVBzdDBHQ2MyYWl6Cm5CaVBQQTJXUXhBUGxQUmgzT0dUc241VEhBRG1ianFZ NkZFTUxhc1ZYOERTQ2JsTXZMd05lTy84U3h6aUJpZGgKcUxwSkNxZFFSV0hrdTVYeGdJa0dl S096NU9MRHZYSFdKeWFmckVZamprUzZBazZCNXo2c3ZLbGlDbFduakhRYwpqbFB6eW9GRmdL VEVmY3FEeENqNFJZMEQwRGd0RkQwTmZ5ZU9pZHJTQi9TelRlMmh3cnlRRTNycFNpcW8rMGNH CmR6aDR5QUhLWUorVXJYWjRwOTNaaGpHZktEMXhsck5ZRGxXeVc5UEdtYnZxRnVEbWlJQVFm OVdEL3d6RWZJQ2MKK0YrdURESSt1WWtSeFVGcDkyeWttZGhERUZnMXlqWXNVOGlHVTY5YUh5 dmhxMzZ6NHpjdHZicWhSTnpPV0IxYgpWSi9kSU1EdnNFeEdjWFFWRElUN3NETlh2MHdFM2pL U0twcDdOREcxb1hVWEwrMitTRjk5S2p5NzUzQWJRU0FtCkg2MTdmeUJOd2hKV3ZRWWcrbVV2 UHBpR090c2VzOUVYVUkzbFM0djBNRWFQRzQzZmxFczFVUisxcnBGUVdWSG8KMXkxT08rc0FF UUVBQVlrQ1BBUVlBUWdBSmdJYkRCWWhCSDQza3FuWXJQZldNN3dWaU8yWDZRNWlxbjQwQlFK ZgpKYjJ6QlFrVXJndlBBQW9KRU8yWDZRNWlxbjQwY25NUC8xN0NnVWtYVDlhSUpyaVBNOHdi Y2VZcmNsNytiZFlFCmY3OVNsd1NiYkhON1I0Q29JSkZPbE45Uy8zNHR5cEdWWXZwZ21DSkRZ RlRCeHlQTzkyaU1YRGdBNCtjV0h6dDUKVDFhWU85aHNLaGg3dkR0Sys2UHJvWkdjKzA4Z1VU WEhoYjk3aE1NUWhrbkpsbmZqcFNFQzllbTkwNkZVK0k5MwpUMWZUR3VwbkJhM2FXY0s4ak0w SmFCR2J5MmhHMVMzb2xhRExTVHRCSU5OQlltdnVXUjlNS09oaHFEcmxrNWN3CkZESkxoNU5y WHRlRVkwOFdBemNMekczcGtyWFBIa0ZlTVF0ZnFrMGpMZEdHdkdDM05DSWtxWXJkTGhpUnZH cHIKdTM4QzI2UkVuNWY0STB2R0UzVmZJWEhlOFRNQ05tUXV0MU50TXVVbXBESXkxYUx4R3p1 cHRVaG5PSk4vL3IrVgpqRFBvaTNMT3lTTllwaHFlL2RNdWJzZlVyNm9oUDQxbUtGODFGdXdJ NGFtcUp0cnFJTDJ5cWF4M2EwcWxmd0N4ClhmdGllcUpjdWVrWCtlQ1BEQ0tyWU1YUjBGWWd3 cEcySVRaVUd0ckVqRVNsRTZEc2N4NzM0SEtkcjVPUklvY0wKVVVLRU9HZWlVNkRHaEdGZGI1 VHd1MFNuK3UxbVVQRE4wTSsrQ2RNdkNsSUU4a2xvNEc5MUVPSW11MVVwYjh4YwpPUFF3eGgx andxU3JVNVF3b05tU1llZ1FTSExwSVV1ckZ6MWlRVWgxdnBQWHpLaW5rV0VxdjRJcUExY2lM K0x5CnlTdUxrcDdNc0pwVlJNYldKQ05XT09TYmFING9EQko1ZEhNR2MzNXg1bW9zQ2s5MFBY a251RkREc1lIZkRvNXMKbWY5bG82WVh4N045Cj0zTGFJCi0tLS0tRU5EIFBHUCBQVUJMSUMg S0VZIEJMT0NLLS0tLS0K Organization: UCLA Computer Science Department Message-ID: Date: Thu, 17 Sep 2020 11:46:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0987d409-b22c-5832-2ecc-bd23401b9cf7@cs.ucla.edu> Content-Type: multipart/mixed; boundary="------------EE43398AB95D7AB3BA0C9F95" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29668 Cc: 33552@debbugs.gnu.org, 29668@debbugs.gnu.org, pg , Jim Meyering , Norihiro Tanaka X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------EE43398AB95D7AB3BA0C9F95 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Attached are two related 'grep' patches, one prompted by Bug#33552 "Possible bug with handling -I option" and the other by Bug#29668 "grep: Fatal problem with (big) file". Although I'd normally install these on grep master, Jim has started the ball rolling on the next grep release so I'll cc this to him to see whether these patches can be squeezed in before the next release. --------------EE43398AB95D7AB3BA0C9F95 Content-Type: text/x-patch; charset=UTF-8; name="0001-Suppress-Binary-file-FOO-matches-if-I.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Suppress-Binary-file-FOO-matches-if-I.patch" >From a20242b5bbe9a31f990919159b8bc8c0a00450d1 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 17 Sep 2020 08:54:09 -0700 Subject: [PATCH 1/2] Suppress "Binary file FOO matches" if -I Problem reported by Jason Franklin (Bug#33552). * NEWS: Mention this. * src/grep.c (grep): Do not output "Binary file FOO matches" if -I. * tests/encoding-error: Add test for this bug. --- NEWS | 3 +++ src/grep.c | 5 +++-- tests/encoding-error | 9 +++++++++ 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index a0514d7..8a25eef 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,9 @@ GNU grep NEWS -*- outline -*- ** Bug fixes + grep -I no longer issues a spurious "Binary file FOO matches" line. + [Bug#33552 introduced in grep 2.23] + In UTF-8 locales, grep -w no longer ignores a multibyte word constituent just before what would otherwise be a word match. [Bug#43225 introduced in grep 2.28] diff --git a/src/grep.c b/src/grep.c index d058a76..8c84a0f 100644 --- a/src/grep.c +++ b/src/grep.c @@ -1641,8 +1641,9 @@ grep (int fd, struct stat const *st, bool *ineof) finish_grep: done_on_match = done_on_match_0; out_quiet = out_quiet_0; - if (!out_quiet && (encoding_error_output - || (0 <= nlines_first_null && nlines_first_null < nlines))) + if (binary_files == BINARY_BINARY_FILES && !out_quiet + && (encoding_error_output + || (0 <= nlines_first_null && nlines_first_null < nlines))) { printf_errno (_("Binary file %s matches\n"), input_filename ()); if (line_buffered) diff --git a/tests/encoding-error b/tests/encoding-error index ba78f91..53f77d4 100755 --- a/tests/encoding-error +++ b/tests/encoding-error @@ -28,6 +28,10 @@ grep '^P' in >out || fail=1 printf 'Binary file in matches\n' >exp || framework_failure_ compare exp out || fail=1 +grep -I '^P' in >out 2>err || fail=1 +compare /dev/null out || fail=1 +compare /dev/null err || fail=1 + grep '^J' in >out || fail=1 compare j out || fail=1 @@ -38,6 +42,11 @@ grep . in >out || fail=1 (cat a j && printf 'Binary file in matches\n') >exp || framework_failure_ compare exp out || fail=1 +grep -I . in >out 2>err || fail=1 +cat a j >exp || framework_failure_ +compare exp out || fail=1 +compare /dev/null err || fail=1 + grep -a . in >out || fail=1 compare in out -- 2.25.4 --------------EE43398AB95D7AB3BA0C9F95 Content-Type: text/x-patch; charset=UTF-8; name="0002-Send-Binary-file-FOO-matches-to-stderr.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0002-Send-Binary-file-FOO-matches-to-stderr.patch" >From 2d2d1bebbaafccc39c22de776fa71a4c3059cf26 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 17 Sep 2020 07:54:38 -0700 Subject: [PATCH 2/2] Send "Binary file FOO matches" to stderr * NEWS, doc/grep.texi: Mention this change (Bug#29668). * src/grep.c (grep): Send "Binary file FOO matches" to stderr instead of stdout. * tests/encoding-error, tests/invalid-multibyte-infloop: * tests/null-byte, tests/pcre-count, tests/surrogate-pair: * tests/symlink, tests/unibyte-binary: Adjust tests to match new behavior. In all cases this simplifies the tests, which is a good sign. --- NEWS | 8 ++++++++ doc/grep.texi | 3 ++- src/grep.c | 8 ++------ tests/encoding-error | 5 ++--- tests/invalid-multibyte-infloop | 4 +--- tests/null-byte | 2 +- tests/pcre-count | 5 ++--- tests/surrogate-pair | 9 ++++----- tests/symlink | 6 +----- tests/unibyte-binary | 2 +- 10 files changed, 24 insertions(+), 28 deletions(-) diff --git a/NEWS b/NEWS index 8a25eef..fd08663 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,14 @@ GNU grep NEWS -*- outline -*- ** Changes in behavior + The "Binary file FOO matches" message is now sent to standard error + and FOO is now quoted, to avoid confusion with ordinary output and + when file names contain spaces and the like. For example, commands + like 'grep PATTERN FILE | wc' no longer add 1 to the count of + matching text lines due to the presence of the message. Like other + stderr messages, the message is now omitted if the --no-messages + (-s) option is given. + The --files-without-match (-L) option has reverted to its behavior in grep 3.1 and earlier. That is, grep -L again succeeds when a line is selected, not when a file is listed. The behavior in grep diff --git a/doc/grep.texi b/doc/grep.texi index 02b1968..a680d39 100644 --- a/doc/grep.texi +++ b/doc/grep.texi @@ -1754,7 +1754,8 @@ to output lines even from files that appear to be binary, use the @option{-a} or @samp{--binary-files=text} option. To eliminate the ``Binary file matches'' messages, use the @option{-I} or -@samp{--binary-files=without-match} option. +@samp{--binary-files=without-match} option, +or the @option{-s} or @option{--no-messages} option. @item Why doesn't @samp{grep -lv} print non-matching file names? diff --git a/src/grep.c b/src/grep.c index 8c84a0f..0a0c71f 100644 --- a/src/grep.c +++ b/src/grep.c @@ -1641,14 +1641,10 @@ grep (int fd, struct stat const *st, bool *ineof) finish_grep: done_on_match = done_on_match_0; out_quiet = out_quiet_0; - if (binary_files == BINARY_BINARY_FILES && !out_quiet + if (binary_files == BINARY_BINARY_FILES && ! (out_quiet | suppress_errors) && (encoding_error_output || (0 <= nlines_first_null && nlines_first_null < nlines))) - { - printf_errno (_("Binary file %s matches\n"), input_filename ()); - if (line_buffered) - fflush_errno (); - } + error (0, 0, _("Binary file %s matches"), quote (input_filename ())); return nlines; } diff --git a/tests/encoding-error b/tests/encoding-error index 53f77d4..61d161a 100755 --- a/tests/encoding-error +++ b/tests/encoding-error @@ -25,8 +25,7 @@ grep '^A' in >out || fail=1 compare a out || fail=1 grep '^P' in >out || fail=1 -printf 'Binary file in matches\n' >exp || framework_failure_ -compare exp out || fail=1 +compare /dev/null out || fail=1 grep -I '^P' in >out 2>err || fail=1 compare /dev/null out || fail=1 @@ -39,7 +38,7 @@ returns_ 1 grep '^X' in >out || fail=1 compare /dev/null out || fail=1 grep . in >out || fail=1 -(cat a j && printf 'Binary file in matches\n') >exp || framework_failure_ +cat a j >exp || framework_failure_ compare exp out || fail=1 grep -I . in >out 2>err || fail=1 diff --git a/tests/invalid-multibyte-infloop b/tests/invalid-multibyte-infloop index 5b3bdfc..b4ad14b 100755 --- a/tests/invalid-multibyte-infloop +++ b/tests/invalid-multibyte-infloop @@ -24,12 +24,10 @@ else test $status -eq 2 fi || fail=1 -echo 'Binary file input matches' >binary-file-matches - LC_ALL=en_US.UTF-8 timeout 10 grep -F $(encode A) input > out status=$? if test $status -eq 0; then - compare binary-file-matches out + compare /dev/null out elif test $status -eq 1; then compare_dev_null_ /dev/null out else diff --git a/tests/null-byte b/tests/null-byte index f338883..c59f56b 100755 --- a/tests/null-byte +++ b/tests/null-byte @@ -56,7 +56,7 @@ echo xxx >exp || framework_failure_ grep xxx in >out || fail=1 compare exp out || fail=1 -printf '%s\n' xxx 'Binary file in matches' > exp || framework_failure_ +printf 'xxx\n' > exp || framework_failure_ grep -E 'xxx|z' in >out || fail=1 compare exp out || fail=1 diff --git a/tests/pcre-count b/tests/pcre-count index e4b55b7..e95ced8 100755 --- a/tests/pcre-count +++ b/tests/pcre-count @@ -17,10 +17,9 @@ printf 'a\n%032768d\nb\0\n%032768d\na\n' 0 0 > in || framework_failure_ # grep will discover that the input is a binary file sooner if the # page size is larger, so allow for either possible output. -printf 'a\nBinary file in matches\n' >exp1a || framework_failure_ -printf 'Binary file in matches\n' >exp1b || framework_failure_ +printf 'a\n' >exp1a || framework_failure_ LC_ALL=C grep -P 'a' in >out || fail=1 -compare exp1a out || compare exp1b out || fail=1 +compare exp1a out || compare /dev/null out || fail=1 printf '2\n' >exp2 || framework_failure_ LC_ALL=C grep -Pc 'a' in >out || fail=1 diff --git a/tests/surrogate-pair b/tests/surrogate-pair index d4f0c0b..7066cf4 100755 --- a/tests/surrogate-pair +++ b/tests/surrogate-pair @@ -25,10 +25,6 @@ fail=0 printf '\360\220\220\205\n' > in || framework_failure_ -# On platforms where wchar_t is only 16 bits, wchar_t cannot represent -# the character encoded in 'in', so accept that behavior too. -printf 'Binary file in matches\n' > out16 || framework_failure_ - LC_ALL=en_US.UTF-8 export LC_ALL @@ -41,7 +37,10 @@ compare /dev/null out || fail=1 # Also test whether a surrogate-pair in the search string works. for opt in '' -i -E -F -iE -iF; do grep --file=in $opt in > out 2>&1 || fail=1 - compare out in || compare out out16 || fail=1 + + # On platforms where wchar_t is only 16 bits, wchar_t cannot represent + # the character encoded in 'in', so accept that behavior too. + compare out in || compare /dev/null out || fail=1 done Exit $fail diff --git a/tests/symlink b/tests/symlink index 325d9e6..7a5d558 100755 --- a/tests/symlink +++ b/tests/symlink @@ -58,11 +58,7 @@ do printf "$exp" >exp || framework_failure_ - LC_ALL=C sort grepout >out-t || fail=1 - - # Ignore "Binary file d matches" on systems for which - # reading from a directory actually succeeds. - grep -v Binary out-t > out; case $? in 0|1) ;; *) fail=1;; esac + LC_ALL=C sort grepout >out || fail=1 compare exp out || fail=1 done diff --git a/tests/unibyte-binary b/tests/unibyte-binary index 6fcfd66..8ae0f0f 100755 --- a/tests/unibyte-binary +++ b/tests/unibyte-binary @@ -22,7 +22,7 @@ require_unibyte_locale fail=0 printf 'a\n\200\nb\n' >in || framework_failure_ -printf 'a\nBinary file in matches\n' >exp || framework_failure_ +printf 'a\n' >exp || framework_failure_ grep . in >out || fail=1 # In some unibyte locales, \200 is an encoding error; -- 2.25.4 --------------EE43398AB95D7AB3BA0C9F95-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 15:05:16 2020 Received: (at 29668) by debbugs.gnu.org; 17 Sep 2020 19:05:16 +0000 Received: from localhost ([127.0.0.1]:39096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIzDX-0001bl-Vx for submit@debbugs.gnu.org; Thu, 17 Sep 2020 15:05:16 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:50929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIzDV-0001bR-CE; Thu, 17 Sep 2020 15:05:14 -0400 Received: by mail-wm1-f42.google.com with SMTP id e17so2996882wme.0; Thu, 17 Sep 2020 12:05:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kowA4acRuq79SsiVkafhXuMtm2sugNtE5G6HzwaGdZs=; b=sygXPpTFnVO3htIXRMxFObELnBk9T75rxY1euL1OUSs1mqV1JwipDsROi2DzGUzOxw DCknKcZfxj8YYukjPGpzKlAuihrXw5Sp48Vr7T78KgWt8+qol939bziE8HfGkPCO0S+T s7tbzz9itYHWK4wmXVCcv6MVha4pB4NSVIHAgCVnXi54LtSvVKcpL7aPaNYdsSI18iZi FpznXx315POP6TI+4ZhmFYPG6KtQ2yrIxDtWsgVz82kdwnnUsX6VOlM2wHwvdG/ci+Nx beGxr440ATThIaABm4m3SVLsk5Pz8hpCAoHFl4AznDGGBibT0BLlvjVcZkeKCMkexvOk fGkw== X-Gm-Message-State: AOAM532BChiWpQQfmYy/9BizlxpFxZBZSjepjNoGkn6oO+O7df5l2705 wyBvfUt2KkOvwODHKCrJxukV7q9ti5x4usNmob8= X-Google-Smtp-Source: ABdhPJyu9lSSYXrMrPsIGz1W4xRXgKdrDgvOpXZLQ1181tCgT2Ssckq5mnlgVhajHi6rhuRpSVfReilO6CH3/gVDehQ= X-Received: by 2002:a1c:5f46:: with SMTP id t67mr11324641wmb.71.1600369507502; Thu, 17 Sep 2020 12:05:07 -0700 (PDT) MIME-Version: 1.0 References: <0987d409-b22c-5832-2ecc-bd23401b9cf7@cs.ucla.edu> In-Reply-To: From: Jim Meyering Date: Thu, 17 Sep 2020 12:04:55 -0700 Message-ID: Subject: Re: grep patches for "Binary file FOO matches" glitches To: Paul Eggert Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29668 Cc: 33552@debbugs.gnu.org, 29668@debbugs.gnu.org, pg , Norihiro Tanaka , Jason Franklin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Thu, Sep 17, 2020 at 11:46 AM Paul Eggert wrote: > Attached are two related 'grep' patches, one prompted by Bug#33552 "Possible bug > with handling -I option" and the other by Bug#29668 "grep: Fatal problem with > (big) file". Although I'd normally install these on grep master, Jim has started > the ball rolling on the next grep release so I'll cc this to him to see whether > these patches can be squeezed in before the next release. Nice! Thank you for resolving those. The first one did indeed simplify numerous tests. Both look fine and seem uncontroversial, so please go ahead and push them. I'll probably update to latest gnulib this evening and then make a new snapshot. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 22:59:10 2020 Received: (at 29668) by debbugs.gnu.org; 18 Sep 2020 02:59:10 +0000 Received: from localhost ([127.0.0.1]:40238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ6c9-0004zf-Oc for submit@debbugs.gnu.org; Thu, 17 Sep 2020 22:59:10 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ6c6-0004z7-VY; Thu, 17 Sep 2020 22:59:08 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F3074160089; Thu, 17 Sep 2020 19:58:59 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id zvr2BhZQyilN; Thu, 17 Sep 2020 19:58:58 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CADED1600F4; Thu, 17 Sep 2020 19:58:58 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id O_YZ_AN9f8Rh; Thu, 17 Sep 2020 19:58:58 -0700 (PDT) Received: from [192.168.1.9] (cpe-75-82-69-226.socal.res.rr.com [75.82.69.226]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 91DF4160089; Thu, 17 Sep 2020 19:58:58 -0700 (PDT) Subject: Re: bug#29668: grep patches for "Binary file FOO matches" glitches To: Jim Meyering References: <0987d409-b22c-5832-2ecc-bd23401b9cf7@cs.ucla.edu> From: Paul Eggert Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDVlFRVEFRZ0FQ d0liQXdZTApDUWdIQXdJR0ZRZ0NDUW9MQkJZQ0F3RUNIZ0VDRjRBV0lRUitONUtwMkt6MzFq TzhGWWp0bCtrT1lxcCtOQVVDClh5Vzlsd1VKRks0THN3QUtDUkR0bCtrT1lxcCtOS05WRC85 SE1zSTE2MDZuMFV1VFhId0lUc3lPakFJOVNET1QKK0MzRFV2NnFsTTVCSDJuV0FNVGlJaXlB NXVnbHNKdjkzb2kydk50RmYvUS9tLzFjblpXZ25WbkV4a3lMSTRFTgpTZDF1QnZyMC9sQ1Nk UGxQME1nNkdXU3BYTXUreDB2ZFQwQWFaTk9URTBGblB1b2xkYzNYRDc2QzJxZzhzWC9pCmF4 WFRLSHk5UCtCbEFxL0NzNy9weERRMEV6U24wVVNaMkMwbDV2djRQTXBBL3BpY25TNks2MDlK dkRHYU9SbXcKWmVYSVpxUU5aVitaUXMrVVl0Vm9ndURUcWJ5M0lVWTFJOEJsWEhScHRhajlB TW40VW9oL0NxcFFsVm9qb3lXbApIcWFGbm5KQktlRjBodko5U0F5YWx3dXpBakc3dlFXMDdN WW5jYU9GbTB3b2lLYmc1SkxPOEY0U0JUSWt1TzBECkNmOW5MQWF5NlZzQjRyendkRWZSd2pQ TFlBbjdNUjNmdkhDRXpmcmtsZFRyYWlCTzFUMGllREs4MEk3c0xmNnAKTWVDWUkxOXBVbHgw L05STUdDZGRpRklRZGZ0aEtXWEdSUzVMQXM4andCZjhINkc1UFdpblByRUlhb21JUDIxaQp2 dWhRRDA3YllxOUlpSWRlbGpqVWRIY0dJMGkvQjRNNTZaYWE4RmYzOGluaU9sckRZQ21ZV1I0 ZENXWml1UWVaCjNPZ3FlUXM5YTZqVHZnZERHVm1SVnFZK2p6azhQbGFIZmNvazhST2hGY0hL a2NmaHVCaEwyNWhsUklzaFJET0UKc2tYcUt3bnpyYnFnYTNHWFpYZnNYQW9GYnpOaExkTHY5 QStMSkFZU2tYUDYvNXFkVHBFTFZHb3N5SDg4NFZkYgpCcGtHSTA0b1lWcXVsYmtDRFFSTWdI SmtBUkFBcG9YcnZ4UDNESWZqQ05PdFhVL1Bkd01TaEtkWC9SbFNzNVBmCnVuVjF3YktQOGhl clhIcnZRZEZWcUVDYVRTeG1saHpiazhYMFBrWTlnY1ZhVTJPNDlUM3FzT2QxY0hlRjUyWUYK R0V0MExoc0JlTWpnTlg1dVoxVjc2cjhneWVWbEZwV1diMFNJd0pVQkhyRFhleEY2N3VwZVJi MnZkSEJqWUROZQp5U24rMEI3Z0ZFcXZWbVp1K0xhZHVkRHA2a1FMamF0RnZIUUhVU0dOc2hC bmtrY2FUYmlJOVBzdDBHQ2MyYWl6Cm5CaVBQQTJXUXhBUGxQUmgzT0dUc241VEhBRG1ianFZ NkZFTUxhc1ZYOERTQ2JsTXZMd05lTy84U3h6aUJpZGgKcUxwSkNxZFFSV0hrdTVYeGdJa0dl S096NU9MRHZYSFdKeWFmckVZamprUzZBazZCNXo2c3ZLbGlDbFduakhRYwpqbFB6eW9GRmdL VEVmY3FEeENqNFJZMEQwRGd0RkQwTmZ5ZU9pZHJTQi9TelRlMmh3cnlRRTNycFNpcW8rMGNH CmR6aDR5QUhLWUorVXJYWjRwOTNaaGpHZktEMXhsck5ZRGxXeVc5UEdtYnZxRnVEbWlJQVFm OVdEL3d6RWZJQ2MKK0YrdURESSt1WWtSeFVGcDkyeWttZGhERUZnMXlqWXNVOGlHVTY5YUh5 dmhxMzZ6NHpjdHZicWhSTnpPV0IxYgpWSi9kSU1EdnNFeEdjWFFWRElUN3NETlh2MHdFM2pL U0twcDdOREcxb1hVWEwrMitTRjk5S2p5NzUzQWJRU0FtCkg2MTdmeUJOd2hKV3ZRWWcrbVV2 UHBpR090c2VzOUVYVUkzbFM0djBNRWFQRzQzZmxFczFVUisxcnBGUVdWSG8KMXkxT08rc0FF UUVBQVlrQ1BBUVlBUWdBSmdJYkRCWWhCSDQza3FuWXJQZldNN3dWaU8yWDZRNWlxbjQwQlFK ZgpKYjJ6QlFrVXJndlBBQW9KRU8yWDZRNWlxbjQwY25NUC8xN0NnVWtYVDlhSUpyaVBNOHdi Y2VZcmNsNytiZFlFCmY3OVNsd1NiYkhON1I0Q29JSkZPbE45Uy8zNHR5cEdWWXZwZ21DSkRZ RlRCeHlQTzkyaU1YRGdBNCtjV0h6dDUKVDFhWU85aHNLaGg3dkR0Sys2UHJvWkdjKzA4Z1VU WEhoYjk3aE1NUWhrbkpsbmZqcFNFQzllbTkwNkZVK0k5MwpUMWZUR3VwbkJhM2FXY0s4ak0w SmFCR2J5MmhHMVMzb2xhRExTVHRCSU5OQlltdnVXUjlNS09oaHFEcmxrNWN3CkZESkxoNU5y WHRlRVkwOFdBemNMekczcGtyWFBIa0ZlTVF0ZnFrMGpMZEdHdkdDM05DSWtxWXJkTGhpUnZH cHIKdTM4QzI2UkVuNWY0STB2R0UzVmZJWEhlOFRNQ05tUXV0MU50TXVVbXBESXkxYUx4R3p1 cHRVaG5PSk4vL3IrVgpqRFBvaTNMT3lTTllwaHFlL2RNdWJzZlVyNm9oUDQxbUtGODFGdXdJ NGFtcUp0cnFJTDJ5cWF4M2EwcWxmd0N4ClhmdGllcUpjdWVrWCtlQ1BEQ0tyWU1YUjBGWWd3 cEcySVRaVUd0ckVqRVNsRTZEc2N4NzM0SEtkcjVPUklvY0wKVVVLRU9HZWlVNkRHaEdGZGI1 VHd1MFNuK3UxbVVQRE4wTSsrQ2RNdkNsSUU4a2xvNEc5MUVPSW11MVVwYjh4YwpPUFF3eGgx andxU3JVNVF3b05tU1llZ1FTSExwSVV1ckZ6MWlRVWgxdnBQWHpLaW5rV0VxdjRJcUExY2lM K0x5CnlTdUxrcDdNc0pwVlJNYldKQ05XT09TYmFING9EQko1ZEhNR2MzNXg1bW9zQ2s5MFBY a251RkREc1lIZkRvNXMKbWY5bG82WVh4N045Cj0zTGFJCi0tLS0tRU5EIFBHUCBQVUJMSUMg S0VZIEJMT0NLLS0tLS0K Organization: UCLA Computer Science Department Message-ID: <435bd7ad-744d-f3d8-bc8c-aaa770f8605d@cs.ucla.edu> Date: Thu, 17 Sep 2020 19:58:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------69EC9C5ECDF0F0B0E52EA05C" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29668 Cc: 33552@debbugs.gnu.org, 29668@debbugs.gnu.org, pg , Jason Franklin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------69EC9C5ECDF0F0B0E52EA05C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 9/17/20 3:03 PM, Jim Meyering wrote: > The alternative is to change that "B" to a "b", which should be fine, > now that it's only emitted to stderr. Makes sense. NEWS should be updated accordingly - but when I looked into doing that I came up with the attached more-elaborate patch, which changes this new diagnostic and two other unusual-format diagnostics, so that they use the same "grep: FILENAME: MESSAGE" form that grep uses everywhere else. Whaddya think? --------------69EC9C5ECDF0F0B0E52EA05C Content-Type: text/x-patch; charset=UTF-8; name="0001-grep-be-more-consistent-about-diagnostic-format.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-grep-be-more-consistent-about-diagnostic-format.patch" >From 28c5ff1eee695d3cfa9e72a9f07ac9380bdc4ada Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 17 Sep 2020 19:54:14 -0700 Subject: [PATCH] grep: be more consistent about diagnostic format * NEWS: Mention this. * bootstrap.conf (gnulib_modules): Remove 'quote'. * src/grep.c: Do not include quote.h. (grep, grepdirent, grepdesc): Put the three unusual diagnostics into the same "grep: FOO: message" form that grep uses elsewhere. * tests/binary-file-matches, tests/in-eq-out-infloop: Adjust tests to match new diagnostic format. --- NEWS | 12 +++++++++--- bootstrap.conf | 1 - src/grep.c | 9 +++------ tests/binary-file-matches | 2 +- tests/in-eq-out-infloop | 4 ++-- 5 files changed, 15 insertions(+), 13 deletions(-) diff --git a/NEWS b/NEWS index fd08663..79b9db0 100644 --- a/NEWS +++ b/NEWS @@ -4,14 +4,20 @@ GNU grep NEWS -*- outline -*- ** Changes in behavior - The "Binary file FOO matches" message is now sent to standard error - and FOO is now quoted, to avoid confusion with ordinary output and - when file names contain spaces and the like. For example, commands + The message that a binary file matches is now sent to standard error + and the message has been reworded from "Binary file FOO matches" to + "grep: FOO: binary file matches", to avoid confusion with ordinary + output or when file names contain spaces and the like, and to be + more consistent with other diagnostics. For example, commands like 'grep PATTERN FILE | wc' no longer add 1 to the count of matching text lines due to the presence of the message. Like other stderr messages, the message is now omitted if the --no-messages (-s) option is given. + Two other stderr messages now use the typical form too. They are + now "grep: FOO: warning: recursive directory loop" and "grep: FOO: + input file is also the output". + The --files-without-match (-L) option has reverted to its behavior in grep 3.1 and earlier. That is, grep -L again succeeds when a line is selected, not when a file is listed. The behavior in grep diff --git a/bootstrap.conf b/bootstrap.conf index 4268623..54c0359 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -72,7 +72,6 @@ obstack openat-safer perl propername -quote rawmemchr readme-release realloc-gnu diff --git a/src/grep.c b/src/grep.c index 614f203..ba6b15d 100644 --- a/src/grep.c +++ b/src/grep.c @@ -45,7 +45,6 @@ #include "hash.h" #include "intprops.h" #include "propername.h" -#include "quote.h" #include "safe-read.h" #include "search.h" #include "c-strcase.h" @@ -1644,7 +1643,7 @@ grep (int fd, struct stat const *st, bool *ineof) if (binary_files == BINARY_BINARY_FILES && ! (out_quiet | suppress_errors) && (encoding_error_output || (0 <= nlines_first_null && nlines_first_null < nlines))) - error (0, 0, _("binary file %s matches"), quote (input_filename ())); + error (0, 0, _("%s: binary file matches"), input_filename ()); return nlines; } @@ -1682,8 +1681,7 @@ grepdirent (FTS *fts, FTSENT *ent, bool command_line) case FTS_DC: if (!suppress_errors) - error (0, 0, _("warning: %s: %s"), filename, - _("recursive directory loop")); + error (0, 0, _("%s: warning: recursive directory loop"), filename); return true; case FTS_DNR: @@ -1903,8 +1901,7 @@ grepdesc (int desc, bool command_line) && S_ISREG (st.st_mode) && SAME_INODE (st, out_stat)) { if (! suppress_errors) - error (0, 0, _("input file %s is also the output"), - quote (input_filename ())); + error (0, 0, _("%s: input file is also the output"), input_filename ()); errseen = true; goto closeout; } diff --git a/tests/binary-file-matches b/tests/binary-file-matches index 75c23bc..da18f9d 100755 --- a/tests/binary-file-matches +++ b/tests/binary-file-matches @@ -11,7 +11,7 @@ fail=0 -echo "grep: binary file '(standard input)' matches" > exp \ +echo "grep: (standard input): binary file matches" > exp \ || framework_failure_ printf 'a\0' | grep a > out 2> err || fail=1 diff --git a/tests/in-eq-out-infloop b/tests/in-eq-out-infloop index c6d5968..11ba904 100755 --- a/tests/in-eq-out-infloop +++ b/tests/in-eq-out-infloop @@ -17,13 +17,13 @@ echo "$v" > out || framework_failure_ for arg in out - ''; do # Accommodate both 'out' and '(standard input)', as well as # the multi-byte quoting we see on OS/X-based systems. - echo grep: input file ... is also the output > err.exp || framework_failure_ + echo grep: ...: input file is also the output > err.exp || framework_failure_ # Require an exit status of 2. # grep-2.8 and earlier would infloop with $arg = out. # grep-2.10 and earlier would infloop with $arg = - or $arg = ''. timeout 10 grep 0 $arg < out >> out 2> err; st=$?; test $st = 2 || fail=1 - sed 's/file .* is/file ... is/' err > k && mv k err + sed 's/grep: .*: /grep: ...: /' err > k && mv k err # Normalize the diagnostic prefix from e.g., "/mnt/dir/grep: " to "grep: " sed 's/^[^:]*: /grep: /' err > k && mv k err compare err.exp err || fail=1 -- 2.17.1 --------------69EC9C5ECDF0F0B0E52EA05C-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 10:06:11 2020 Received: (at 29668) by debbugs.gnu.org; 18 Sep 2020 14:06:12 +0000 Received: from localhost ([127.0.0.1]:43884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJH1f-0000Vq-Lx for submit@debbugs.gnu.org; Fri, 18 Sep 2020 10:06:11 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:42417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJH1a-0000V6-0x; Fri, 18 Sep 2020 10:06:08 -0400 Received: by mail-wr1-f42.google.com with SMTP id c18so5753814wrm.9; Fri, 18 Sep 2020 07:06:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Om+izEg7W90iurtLfwOcNE7N33x70Gzrac4vdnhugxI=; b=tpFo4QiDQUUAkEL+YKiCAay4Xh27ZPhkZkTvmxBy5hQVHDH9k26JFbmCZetIzGL2RK XFa9VXWoA0BO5KfAzcIfzQeKttQ+cYNP99f3CG9c7WPEbwmg038Jl4tmXKY2+yCHxIQl xEQzG4HEqvvY297Vfov7XUFpB7jpN/Is9sGmmeVKF4B7c2wHffg0l12yayAljlK/Ck8X ey541oCfjJ+f5yRLgmollp3KjOBiCsid6Bn7JKoeZJuXoXrnQoNQ2ExVdIIgf4vNTTYq chjX60Iv842ItKnsqtfOPf+Qerj1PJO3EFT4UpcgCzIrnhF3I7UpIyZgIWKhLm82KJaA zzbw== X-Gm-Message-State: AOAM531sACnCq/swX0sJTIofyn9lEXud+JzR4xRLn3lkX59DF7fHbHdz 4Pi/NUq2Vi4PFBMmemp58rLhLuPV7V52hLUHRDA= X-Google-Smtp-Source: ABdhPJwSKbIP9oYqjk/m5lX+nhhky2v5BGSJca2wkzvZpw8FZNmw8f/pkTd7YBubXB19MPB568NL/AHVFc4Pas/H4GM= X-Received: by 2002:adf:9e43:: with SMTP id v3mr38909030wre.306.1600437960242; Fri, 18 Sep 2020 07:06:00 -0700 (PDT) MIME-Version: 1.0 References: <0987d409-b22c-5832-2ecc-bd23401b9cf7@cs.ucla.edu> <435bd7ad-744d-f3d8-bc8c-aaa770f8605d@cs.ucla.edu> In-Reply-To: <435bd7ad-744d-f3d8-bc8c-aaa770f8605d@cs.ucla.edu> From: Jim Meyering Date: Fri, 18 Sep 2020 07:05:48 -0700 Message-ID: Subject: Re: bug#29668: grep patches for "Binary file FOO matches" glitches To: Paul Eggert Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29668 Cc: 33552@debbugs.gnu.org, 29668@debbugs.gnu.org, pg , Jason Franklin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Thu, Sep 17, 2020 at 7:59 PM Paul Eggert wrote: > On 9/17/20 3:03 PM, Jim Meyering wrote: > > The alternative is to change that "B" to a "b", which should be fine, > > now that it's only emitted to stderr. > > Makes sense. > > NEWS should be updated accordingly - but when I looked into doing that I came up > with the attached more-elaborate patch, which changes this new diagnostic and > two other unusual-format diagnostics, so that they use the same "grep: FILENAME: > MESSAGE" form that grep uses everywhere else. Whaddya think? Nice. Dropping the quote module (even if negligible size delta) is a fine side effect. You're welcome to push that. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 21 13:55:11 2020 Received: (at 29668-done) by debbugs.gnu.org; 21 Sep 2020 17:55:11 +0000 Received: from localhost ([127.0.0.1]:56123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKQ1u-0003oO-RX for submit@debbugs.gnu.org; Mon, 21 Sep 2020 13:55:11 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:32968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKQ1s-0003nx-TD; Mon, 21 Sep 2020 13:55:10 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4C6BE1600F1; Mon, 21 Sep 2020 10:55:02 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id m9PB3WK5OpER; Mon, 21 Sep 2020 10:55:01 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A27A61600EF; Mon, 21 Sep 2020 10:55:01 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id H0qZ2vahqg7a; Mon, 21 Sep 2020 10:55:01 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6C46F1600F1; Mon, 21 Sep 2020 10:55:01 -0700 (PDT) Subject: Re: bug#33552: grep patches for "Binary file FOO matches" glitches To: Jim Meyering References: <0987d409-b22c-5832-2ecc-bd23401b9cf7@cs.ucla.edu> From: Paul Eggert Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDVlFRVEFRZ0FQ d0liQXdZTApDUWdIQXdJR0ZRZ0NDUW9MQkJZQ0F3RUNIZ0VDRjRBV0lRUitONUtwMkt6MzFq TzhGWWp0bCtrT1lxcCtOQVVDClh5Vzlsd1VKRks0THN3QUtDUkR0bCtrT1lxcCtOS05WRC85 SE1zSTE2MDZuMFV1VFhId0lUc3lPakFJOVNET1QKK0MzRFV2NnFsTTVCSDJuV0FNVGlJaXlB NXVnbHNKdjkzb2kydk50RmYvUS9tLzFjblpXZ25WbkV4a3lMSTRFTgpTZDF1QnZyMC9sQ1Nk UGxQME1nNkdXU3BYTXUreDB2ZFQwQWFaTk9URTBGblB1b2xkYzNYRDc2QzJxZzhzWC9pCmF4 WFRLSHk5UCtCbEFxL0NzNy9weERRMEV6U24wVVNaMkMwbDV2djRQTXBBL3BpY25TNks2MDlK dkRHYU9SbXcKWmVYSVpxUU5aVitaUXMrVVl0Vm9ndURUcWJ5M0lVWTFJOEJsWEhScHRhajlB TW40VW9oL0NxcFFsVm9qb3lXbApIcWFGbm5KQktlRjBodko5U0F5YWx3dXpBakc3dlFXMDdN WW5jYU9GbTB3b2lLYmc1SkxPOEY0U0JUSWt1TzBECkNmOW5MQWF5NlZzQjRyendkRWZSd2pQ TFlBbjdNUjNmdkhDRXpmcmtsZFRyYWlCTzFUMGllREs4MEk3c0xmNnAKTWVDWUkxOXBVbHgw L05STUdDZGRpRklRZGZ0aEtXWEdSUzVMQXM4andCZjhINkc1UFdpblByRUlhb21JUDIxaQp2 dWhRRDA3YllxOUlpSWRlbGpqVWRIY0dJMGkvQjRNNTZaYWE4RmYzOGluaU9sckRZQ21ZV1I0 ZENXWml1UWVaCjNPZ3FlUXM5YTZqVHZnZERHVm1SVnFZK2p6azhQbGFIZmNvazhST2hGY0hL a2NmaHVCaEwyNWhsUklzaFJET0UKc2tYcUt3bnpyYnFnYTNHWFpYZnNYQW9GYnpOaExkTHY5 QStMSkFZU2tYUDYvNXFkVHBFTFZHb3N5SDg4NFZkYgpCcGtHSTA0b1lWcXVsYmtDRFFSTWdI SmtBUkFBcG9YcnZ4UDNESWZqQ05PdFhVL1Bkd01TaEtkWC9SbFNzNVBmCnVuVjF3YktQOGhl clhIcnZRZEZWcUVDYVRTeG1saHpiazhYMFBrWTlnY1ZhVTJPNDlUM3FzT2QxY0hlRjUyWUYK R0V0MExoc0JlTWpnTlg1dVoxVjc2cjhneWVWbEZwV1diMFNJd0pVQkhyRFhleEY2N3VwZVJi MnZkSEJqWUROZQp5U24rMEI3Z0ZFcXZWbVp1K0xhZHVkRHA2a1FMamF0RnZIUUhVU0dOc2hC bmtrY2FUYmlJOVBzdDBHQ2MyYWl6Cm5CaVBQQTJXUXhBUGxQUmgzT0dUc241VEhBRG1ianFZ NkZFTUxhc1ZYOERTQ2JsTXZMd05lTy84U3h6aUJpZGgKcUxwSkNxZFFSV0hrdTVYeGdJa0dl S096NU9MRHZYSFdKeWFmckVZamprUzZBazZCNXo2c3ZLbGlDbFduakhRYwpqbFB6eW9GRmdL VEVmY3FEeENqNFJZMEQwRGd0RkQwTmZ5ZU9pZHJTQi9TelRlMmh3cnlRRTNycFNpcW8rMGNH CmR6aDR5QUhLWUorVXJYWjRwOTNaaGpHZktEMXhsck5ZRGxXeVc5UEdtYnZxRnVEbWlJQVFm OVdEL3d6RWZJQ2MKK0YrdURESSt1WWtSeFVGcDkyeWttZGhERUZnMXlqWXNVOGlHVTY5YUh5 dmhxMzZ6NHpjdHZicWhSTnpPV0IxYgpWSi9kSU1EdnNFeEdjWFFWRElUN3NETlh2MHdFM2pL U0twcDdOREcxb1hVWEwrMitTRjk5S2p5NzUzQWJRU0FtCkg2MTdmeUJOd2hKV3ZRWWcrbVV2 UHBpR090c2VzOUVYVUkzbFM0djBNRWFQRzQzZmxFczFVUisxcnBGUVdWSG8KMXkxT08rc0FF UUVBQVlrQ1BBUVlBUWdBSmdJYkRCWWhCSDQza3FuWXJQZldNN3dWaU8yWDZRNWlxbjQwQlFK ZgpKYjJ6QlFrVXJndlBBQW9KRU8yWDZRNWlxbjQwY25NUC8xN0NnVWtYVDlhSUpyaVBNOHdi Y2VZcmNsNytiZFlFCmY3OVNsd1NiYkhON1I0Q29JSkZPbE45Uy8zNHR5cEdWWXZwZ21DSkRZ RlRCeHlQTzkyaU1YRGdBNCtjV0h6dDUKVDFhWU85aHNLaGg3dkR0Sys2UHJvWkdjKzA4Z1VU WEhoYjk3aE1NUWhrbkpsbmZqcFNFQzllbTkwNkZVK0k5MwpUMWZUR3VwbkJhM2FXY0s4ak0w SmFCR2J5MmhHMVMzb2xhRExTVHRCSU5OQlltdnVXUjlNS09oaHFEcmxrNWN3CkZESkxoNU5y WHRlRVkwOFdBemNMekczcGtyWFBIa0ZlTVF0ZnFrMGpMZEdHdkdDM05DSWtxWXJkTGhpUnZH cHIKdTM4QzI2UkVuNWY0STB2R0UzVmZJWEhlOFRNQ05tUXV0MU50TXVVbXBESXkxYUx4R3p1 cHRVaG5PSk4vL3IrVgpqRFBvaTNMT3lTTllwaHFlL2RNdWJzZlVyNm9oUDQxbUtGODFGdXdJ NGFtcUp0cnFJTDJ5cWF4M2EwcWxmd0N4ClhmdGllcUpjdWVrWCtlQ1BEQ0tyWU1YUjBGWWd3 cEcySVRaVUd0ckVqRVNsRTZEc2N4NzM0SEtkcjVPUklvY0wKVVVLRU9HZWlVNkRHaEdGZGI1 VHd1MFNuK3UxbVVQRE4wTSsrQ2RNdkNsSUU4a2xvNEc5MUVPSW11MVVwYjh4YwpPUFF3eGgx andxU3JVNVF3b05tU1llZ1FTSExwSVV1ckZ6MWlRVWgxdnBQWHpLaW5rV0VxdjRJcUExY2lM K0x5CnlTdUxrcDdNc0pwVlJNYldKQ05XT09TYmFING9EQko1ZEhNR2MzNXg1bW9zQ2s5MFBY a251RkREc1lIZkRvNXMKbWY5bG82WVh4N045Cj0zTGFJCi0tLS0tRU5EIFBHUCBQVUJMSUMg S0VZIEJMT0NLLS0tLS0K Organization: UCLA Computer Science Department Message-ID: <410e50ee-0a62-efd5-ad38-c4ef13739cd3@cs.ucla.edu> Date: Mon, 21 Sep 2020 10:54:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29668-done Cc: 29668-done@debbugs.gnu.org, 33552-done@debbugs.gnu.org, pg , Jason Franklin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 9/17/20 12:04 PM, Jim Meyering wrote: > please go ahead and push them. As that's been done and the bug fixes are now installed, I'm closing both bug reports. From unknown Sat Jun 14 19:46:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Oct 2020 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator