From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 10 10:42:56 2017 Received: (at submit) by debbugs.gnu.org; 10 Dec 2017 15:42:56 +0000 Received: from localhost ([127.0.0.1]:55514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eO3km-0007QD-Jm for submit@debbugs.gnu.org; Sun, 10 Dec 2017 10:42:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eO3kj-0007Py-BK for submit@debbugs.gnu.org; Sun, 10 Dec 2017 10:42:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eO3kd-0002MM-87 for submit@debbugs.gnu.org; Sun, 10 Dec 2017 10:42:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eO3kd-0002MG-43 for submit@debbugs.gnu.org; Sun, 10 Dec 2017 10:42:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eO3kb-0007A8-UH for guix-patches@gnu.org; Sun, 10 Dec 2017 10:42:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eO3kX-0002I0-1v for guix-patches@gnu.org; Sun, 10 Dec 2017 10:42:45 -0500 Received: from mx2.dlut.edu.cn ([202.118.66.81]:55552 helo=dlut.edu.cn) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eO3kW-0002Eg-E9 for guix-patches@gnu.org; Sun, 10 Dec 2017 10:42:41 -0500 Received: from localhost (unknown [119.112.169.212]) by mx2 (Coremail) with SMTP id UUJ2ygCXLfrmVS1aJkMtAA--.24497S2; Sun, 10 Dec 2017 23:42:30 +0800 (CST) Date: Sun, 10 Dec 2017 23:42:30 +0800 From: "Z. Ren" To: guix-patches@gnu.org Subject: [PATCH] skalibs reproducible issue (reopen) Message-ID: <20171210154045.GB30811@air> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0XMZdl/q8hSSmFeD" Content-Disposition: inline User-Agent: Mutt/1.6.0 (2016-04-01) X-CM-TRANSID: UUJ2ygCXLfrmVS1aJkMtAA--.24497S2 X-Coremail-Antispam: 1UD129KBjvdXoWruFy3JFy8GFyDCFWxKryxuFg_yoWfuwc_Za 4rt34DX3y8KayUtanrCrW5ArnxKa1vv3WrC3yrWasIv34rJr47uF4rGF1SqF1vyrWxAF47 KF4jvrs7u3W5WjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAU7a7-sFnT 9fnUUIcSsGvfJTRUUUb7xYjsxI4VWkKwAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z2 80aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487M2AExVA0xI801c8C 04v7Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUtVWrXwAv7VC2z2 80aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxAIw28IcxkI 7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxV Cjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUJVWUXwCIc40Y0x0EwIxGrwCI42IY 6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6x AIw20EY4v20xvaj40_Zr0_Wr1UMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07bFzuAUUUUU= X-CM-SenderInfo: h2uh0qhgox3hxhgxhubq/1tbiAQAKAlPExin3VwAAsR X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --0XMZdl/q8hSSmFeD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi! Previously, we submitted a patch that intended to fix the unreproducible issue of the package skalibs (#28017). Unfortunately, the patch we submitted only partially fixed the issues, i.e,. for the .a file (lib/skalibs/libskarnet.a). However, the .so file (lib/libskarnet.so) is still non-deterministic. After investigation, we find that in the Makefile, 'sort' should be applied associated with 'wildcard', rather than with only ALL_SRCS. To validate the fix, we applied "guix build --check --no-grafts --rounds=2 skalibs" with the patched skarnet.scm, over three PCs (with guix 316fd29f9b6b0941367f54f431ef99695b16a9e5), and checked the sha256sum of the built files. Under our testing setup, the attached patch fixes the issues for the .a/.so files for skalibs. Hope the patch is correct this time, and sorry that the previous submitted patch failed to resolve all the unreproducible issues. Regards, Ren --0XMZdl/q8hSSmFeD Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-fix-the-unreproducible-issue-for-skalibs.patch" >From 36e35a72942a561028f93e6905cab7729a0d1f12 Mon Sep 17 00:00:00 2001 From: Z. Ren Date: Sun, 10 Dec 2017 22:23:32 +0800 Subject: [PATCH] fix the unreproducible issue for skalibs --- gnu/packages/skarnet.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/skarnet.scm b/gnu/packages/skarnet.scm index 5a46b0db6..ce6fdc709 100644 --- a/gnu/packages/skarnet.scm +++ b/gnu/packages/skarnet.scm @@ -47,8 +47,8 @@ ;; Sort source files deterministically so that the *.a ;; and *.so files are reproducible. (substitute* "Makefile" - (("\\$\\(ALL_SRCS:%.c=%.o\\)") - "$(sort $(ALL_SRCS:%.c=%.o))")) + (("\\$\\(wildcard src/lib\\*/\\*.c\\)") + "$(sort $(wildcard src/lib*/*.c))")) #t))))) (home-page "http://skarnet.org/software/skalibs/") (synopsis "Platform abstraction libraries for skarnet.org software") -- 2.11.0 --0XMZdl/q8hSSmFeD-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 11 11:08:46 2017 Received: (at 29646-done) by debbugs.gnu.org; 11 Dec 2017 16:08:46 +0000 Received: from localhost ([127.0.0.1]:57065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOQdJ-00036f-TM for submit@debbugs.gnu.org; Mon, 11 Dec 2017 11:08:46 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:39786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOQdF-00036T-EZ for 29646-done@debbugs.gnu.org; Mon, 11 Dec 2017 11:08:44 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 4A87C10446; Mon, 11 Dec 2017 17:08:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VwzVLifFYc3M; Mon, 11 Dec 2017 17:08:39 +0100 (CET) Received: from ribbon (unknown [193.50.110.104]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 05173FD5F; Mon, 11 Dec 2017 17:08:38 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: "Z. Ren" Subject: Re: [bug#29646] [PATCH] skalibs reproducible issue (reopen) References: <20171210154045.GB30811@air> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 21 Frimaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 11 Dec 2017 17:08:35 +0100 In-Reply-To: <20171210154045.GB30811@air> (Z. Ren's message of "Sun, 10 Dec 2017 23:42:30 +0800") Message-ID: <87lgi9xn5o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29646-done Cc: 29646-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello, "Z. Ren" skribis: > Previously, we submitted a patch that intended to fix the unreproducible = issue of the package skalibs (#28017). Unfortunately, the patch we submitte= d only partially fixed the issues, i.e,. for the .a file (lib/skalibs/libsk= arnet.a). However, the .so file (lib/libskarnet.so) is still non-determinis= tic. > > After investigation, we find that in the Makefile, 'sort' should be appli= ed associated with 'wildcard', rather than with only ALL_SRCS.=20 > > To validate the fix, we applied "guix build --check --no-grafts --rounds= =3D2 skalibs" with the patched skarnet.scm, over three PCs (with guix 316fd= 29f9b6b0941367f54f431ef99695b16a9e5), and checked the sha256sum of the buil= t files. Under our testing setup, the attached patch fixes the issues for t= he .a/.so files for skalibs. Hope the patch is correct this time, and sorry= that the previous submitted patch failed to resolve all the unreproducible= issues. I confirm that it builds reproducibly on my laptop with --rounds=3D2 (a weaker test that what you did!). > From 36e35a72942a561028f93e6905cab7729a0d1f12 Mon Sep 17 00:00:00 2001 > From: Z. Ren > Date: Sun, 10 Dec 2017 22:23:32 +0800 > Subject: [PATCH] fix the unreproducible issue for skalibs > > --- > gnu/packages/skarnet.scm | 4 ++-- I adjusted the commit log and committed. Thank you! Ludo=E2=80=99. From unknown Sun Jun 22 20:58:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 Jan 2018 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator