GNU bug report logs - #29646
[PATCH] skalibs reproducible issue (reopen)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29646 in the body.
You can then email your comments to 29646 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Z. Ren" <zren <at> dlut.edu.cn>
To: guix-patches <at> gnu.org
Subject: [PATCH] skalibs reproducible issue (reopen)
Date: Sun, 10 Dec 2017 23:42:30 +0800

[Message part 1 (text/plain, inline)]

Hi!
Previously, we submitted a patch that intended to fix the unreproducible issue of the package skalibs (#28017). Unfortunately, the patch we submitted only partially fixed the issues, i.e,. for the .a file (lib/skalibs/libskarnet.a). However, the .so file (lib/libskarnet.so) is still non-deterministic.

After investigation, we find that in the Makefile, 'sort' should be applied associated with 'wildcard', rather than with only ALL_SRCS. 

To validate the fix, we applied "guix build --check --no-grafts --rounds=2 skalibs" with the patched skarnet.scm, over three PCs (with guix 316fd29f9b6b0941367f54f431ef99695b16a9e5), and checked the sha256sum of the built files. Under our testing setup, the attached patch fixes the issues for the .a/.so files for skalibs. Hope the patch is correct this time, and sorry that the previous submitted patch failed to resolve all the unreproducible issues.

Regards,
Ren

[0001-fix-the-unreproducible-issue-for-skalibs.patch (text/x-diff, attachment)]

Message #10 received at 29646-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: "Z. Ren" <zren <at> dlut.edu.cn>
Cc: 29646-done <at> debbugs.gnu.org
Subject: Re: [bug#29646] [PATCH] skalibs reproducible issue (reopen)
Date: Mon, 11 Dec 2017 17:08:35 +0100

Hello,

"Z. Ren" <zren <at> dlut.edu.cn> skribis:

> Previously, we submitted a patch that intended to fix the unreproducible issue of the package skalibs (#28017). Unfortunately, the patch we submitted only partially fixed the issues, i.e,. for the .a file (lib/skalibs/libskarnet.a). However, the .so file (lib/libskarnet.so) is still non-deterministic.
>
> After investigation, we find that in the Makefile, 'sort' should be applied associated with 'wildcard', rather than with only ALL_SRCS. 
>
> To validate the fix, we applied "guix build --check --no-grafts --rounds=2 skalibs" with the patched skarnet.scm, over three PCs (with guix 316fd29f9b6b0941367f54f431ef99695b16a9e5), and checked the sha256sum of the built files. Under our testing setup, the attached patch fixes the issues for the .a/.so files for skalibs. Hope the patch is correct this time, and sorry that the previous submitted patch failed to resolve all the unreproducible issues.

I confirm that it builds reproducibly on my laptop with --rounds=2 (a
weaker test that what you did!).

> From 36e35a72942a561028f93e6905cab7729a0d1f12 Mon Sep 17 00:00:00 2001
> From: Z. Ren <zren <at> dlut.edu.cn>
> Date: Sun, 10 Dec 2017 22:23:32 +0800
> Subject: [PATCH] fix the unreproducible issue for skalibs
>
> ---
>  gnu/packages/skarnet.scm | 4 ++--

I adjusted the commit log and committed.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.