GNU bug report logs - #29628
services: nginx: Replace 'http-port' and 'https-port' with 'listen'.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Clément Lassieur <clement <at> lassieur.org>
Subject: bug#29628: closed (Re: [bug#29628] [PATCH] services: nginx:
 Replace 'http-port' and 'https-port' with 'listen'.)
Date: Mon, 18 Dec 2017 11:07:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#29628: services: nginx: Replace 'http-port' and 'https-port' with 'listen'.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 29628 <at> debbugs.gnu.org.

-- 
29628: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29628
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Clément Lassieur <clement <at> lassieur.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 29628-done <at> debbugs.gnu.org
Subject: Re: [bug#29628] [PATCH] services: nginx: Replace 'http-port' and
 'https-port' with 'listen'.
Date: Mon, 18 Dec 2017 12:06:43 +0100

Christopher Baines <mail <at> cbaines.net> writes:

> Clément Lassieur <clement <at> lassieur.org> writes:
>
>> * doc/guix.texi (Web Services, Version Control Services): Update accordingly.
>> * gnu/services/certbot.scm (certbot-nginx-server-configurations): Likewise.
>> * gnu/services/version-control.scm (%cgit-configuration-nginx): Likewise.
>> * gnu/services/web.scm (<nginx-server-configuration>,
>> emit-nginx-server-config): Likewise.
>> * gnu/tests/version-control.scm (%cgit-configuration-nginx,
>> %git-nginx-configuration): Likewise.
>> * gnu/tests/web.scm (%nginx-servers): Likewise.
>
> This looks good to me. Unfortunately this conflicts with some changes I
> made to the nginx service, so it would be good if you could send an
> updated patch.
>
> I think an extra use of the old configuration might have also appeared
> in the docs/services as well.

I updated it and pushed it.  Thank you for reviewing!

Clément

[Message part 3 (message/rfc822, inline)]

From: Clément Lassieur <clement <at> lassieur.org>
To: guix-patches <at> gnu.org
Subject: services: nginx: Replace 'http-port' and 'https-port' with 'listen'.
Date: Sat, 09 Dec 2017 19:41:19 +0100

This patch allows to set several 'listen' directives, each of them being
a string.

See http://nginx.org/en/docs/http/ngx_http_core_module.html#listen.

It may break user configurations.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.