From unknown Sat Aug 09 20:35:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#29624 <29624@debbugs.gnu.org> To: bug#29624 <29624@debbugs.gnu.org> Subject: Status: EasyTAG Reply-To: bug#29624 <29624@debbugs.gnu.org> Date: Sun, 10 Aug 2025 03:35:29 +0000 retitle 29624 EasyTAG reassign 29624 guix-patches submitter 29624 Pierre Langlois severity 29624 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 08:44:15 2017 Received: (at submit) by debbugs.gnu.org; 9 Dec 2017 13:44:15 +0000 Received: from localhost ([127.0.0.1]:53214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNfQF-0008Sd-TM for submit@debbugs.gnu.org; Sat, 09 Dec 2017 08:44:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNfQE-0008S0-0e for submit@debbugs.gnu.org; Sat, 09 Dec 2017 08:44:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNfQ7-0003TV-78 for submit@debbugs.gnu.org; Sat, 09 Dec 2017 08:44:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53393) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eNfQ7-0003TH-2o for submit@debbugs.gnu.org; Sat, 09 Dec 2017 08:43:59 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNfQ5-0005fS-6f for guix-patches@gnu.org; Sat, 09 Dec 2017 08:43:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNfQ1-0003Po-Ui for guix-patches@gnu.org; Sat, 09 Dec 2017 08:43:57 -0500 Received: from mout.gmx.net ([212.227.15.15]:61177) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eNfQ1-0003Oi-HM for guix-patches@gnu.org; Sat, 09 Dec 2017 08:43:53 -0500 Received: from labiere ([80.229.147.137]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0LztHH-1f91DI0DRr-0152b1 for ; Sat, 09 Dec 2017 14:43:51 +0100 From: Pierre Langlois To: guix-patches@gnu.org Subject: EasyTAG Date: Sat, 09 Dec 2017 13:43:44 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:xPMetGRMXD8zbFWGZoXzF+QGMtrPZ3YY0VkgyJGzXkUwvxx9hNp KDSbLBVc2e/Ukd5PkD2p618SEuYaYraAOwDC8fvWr/9KoP2WBHJI3F6v15639xocGiaA7oR dcAVPowGErRnV4BibWrKNk07+W7Q9AmszTDRso7UZKWfS4jytITV6NGlzEEOgxlZA0RdKA4 nVPPxqwKhegLLt4v8ZdPg== X-UI-Out-Filterresults: notjunk:1;V01:K0:ECY+oP2Tofs=:Dea4sfYTljvmrlIVpsyjcO jwwNd2cjpbtNWsuGOb2UF/P6W6jPnX3mz0FzubY3P6xXZvALY/fQPk6XDt640oNnEhMfG0+/H C5oqwrTa3Zw/QdEhgnsQFCz2KYSu88pULnusN2d0oGXQUvHc0xUM/ST+u+3TLzj0A3hy0dSzW sxT24Yy4/BSZ++3M37FsSiT2A+CL8qwBLVmrwqhrrj7v9MBTQUVqG8HJCAVI9m04rBmzODTGZ 0Ko7N0h7O96k2phB/qz+gusgfeW1J8wBCuROvsst9ITh4BgB0QyyoQyTCK1cvIIZN5sgFEuo1 Rp/BSdcotaLLZgIRey82LW4ZUwLnlCsKivx+G1PIRLxw10QozHAiarZTHyCiWBpomsfJ4Is+f 74Apx9lSzF0NNl3Igf8jWpXFbDAoKnA/F4bwNNTwBPRMgGRpSh5OEFR4sPQDIJARHL8YXGeEi vHFIkpbafstOrhuKJCgEqy8vEjwvQ9+zbHr+W5X/Z6kEm+hNCITeXNpPqeMdW0Q4YnglmJuHf /LAiRLMCxmT7U3GuM1fpnGbQMizB4ZPTt0QNj3SHqrpmBgvwhnVmg/6ZU1KbYwaTCFfYr0j/R l6NNbSO0WKzIAzKRKe41zcR1E8CA28bP6DtDuuX4WCi4h8NqiC39dCXwnVVGHjGrDy9T5Xy+1 5gGhmkZkNXOQNd+l69lCJw+kjjXpQaCuRkZUj6BqJmB92Jra0kj1km4CMYMb6gn++LRjgc//J xSM5N75UEjIQIkJhE77Qu666MjD2pwlwGAlhXzEZJ1oAGXNYoUlSjQUzlpuvP5uv+QWoVFnR+ N410/yQdexSr4RtyIIh6MEIgOtPOXtjszARuFPziKuzyxs7i8A= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.9 (/) --=-=-= Content-Type: text/plain Hello Guix! Here are a couple of patches adding the EasyTAG gnome package https://wiki.gnome.org/Apps/EasyTAG. EasyTAG depends on the libid3tag library and tries to find it using pkg-config. I thought it'd be a good idea for the library to provide a .pc file instead of manually telling EasyTAG where it is. It allows cleaning up dependent packages a little, namely audacity and gmtp, what do you think? Thanks! Pierre --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-libid3tag-Create-a-pkg-config-file.patch Content-Transfer-Encoding: quoted-printable >From 8cd2b22517e04030970bb33abd980577c15c3f01 Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Sat, 9 Dec 2017 13:05:21 +0000 Subject: [PATCH 1/2] gnu: libid3tag: Create a pkg-config file. Cleanup packages depending on libid3tag by allowing pkg-config to find it automatically. * gnu/package/mp3.scm (libid3tag)[arguments]: Add a create-pkg-config-file phase. * gnu/package/audio.scm (audacity)[arguments]: Do not ID3TAG_CFLAGS and ID3TAG_LIBS environment variables. * gnu/package/libusb.scm (gmtp)[arguments]: Remove. --- gnu/packages/audio.scm | 10 ++++------ gnu/packages/libusb.scm | 8 +------- gnu/packages/mp3.scm | 22 ++++++++++++++++++++++ 3 files changed, 27 insertions(+), 13 deletions(-) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 4f6e4a409..2273f4606 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -9,6 +9,7 @@ ;;; Copyright =C2=A9 2016 ng0 ;;; Copyright =C2=A9 2016 Lukas Gradl ;;; Copyright =C2=A9 2016 Tobias Geerinckx-Rice +;;; Copyright =C2=A9 2017 Pierre Langlois ;;; ;;; This file is part of GNU Guix. ;;; @@ -345,8 +346,7 @@ engineers, musicians, soundtrack editors and composers.= ") ("which" ,which))) (arguments `(#:configure-flags - (let ((libid3tag (assoc-ref %build-inputs "libid3tag")) - (libmad (assoc-ref %build-inputs "libmad")) + (let ((libmad (assoc-ref %build-inputs "libmad")) (portmidi (assoc-ref %build-inputs "portmidi"))) (list ;; Loading FFmpeg dynamically is problematic. @@ -357,10 +357,8 @@ engineers, musicians, soundtrack editors and composers= .") '("x64_64" "i686")) '() '("--enable-sse=3Dno")) - ;; portmidi, libid3tag and libmad provide no .pc files, so - ;; pkg-config fails to find them. Force their inclusion. - (string-append "ID3TAG_CFLAGS=3D-I" libid3tag "/include") - (string-append "ID3TAG_LIBS=3D-L" libid3tag "/lib -lid3tag -lz") + ;; portmidi and libmad provide no .pc files, so pkg-config fails= to + ;; find them. Force their inclusion. (string-append "LIBMAD_CFLAGS=3D-I" libmad "/include") (string-append "LIBMAD_LIBS=3D-L" libmad "/lib -lmad") (string-append "PORTMIDI_CFLAGS=3D-I" portmidi "/include") diff --git a/gnu/packages/libusb.scm b/gnu/packages/libusb.scm index 31c7dfa44..94c611b2f 100644 --- a/gnu/packages/libusb.scm +++ b/gnu/packages/libusb.scm @@ -6,6 +6,7 @@ ;;; Copyright =C2=A9 2016 Efraim Flashner ;;; Copyright =C2=A9 2016 Theodoros Foradis ;;; Copyright =C2=A9 2017 Jonathan Brielmaier +;;; Copyright =C2=A9 2017 Pierre Langlois ;;; ;;; This file is part of GNU Guix. ;;; @@ -295,13 +296,6 @@ proposed for standardization.") (base32 "0fyi3pdl2g57vr0p46ip2wwzyap3l0by7iqaqygv0yxfcs79l6xj")))) (build-system glib-or-gtk-build-system) - (arguments - '(#:configure-flags - (let ((libid3tag (assoc-ref %build-inputs "libid3tag"))) - (list - ;; libid3tag provides no .pc file, so pkg-config fails to find t= hem. - (string-append "ID3TAG_CFLAGS=3D-I" libid3tag "/include") - (string-append "ID3TAG_LIBS=3D-L" libid3tag "/lib -lid3tag -lz")= )))) (inputs `(("gtk+" ,gtk+) ("flac" ,flac) diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index fbb924ba5..dd40fc59f 100644 --- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -99,6 +99,28 @@ This package contains the library.") "0lb1w883dc46dajbdvnia5870brl5lvnlk7g7y58y9wpg5p4znk3")))) (build-system gnu-build-system) (inputs `(("zlib" ,zlib))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'install 'create-pkg-config-file + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (pkgconfig-path (string-append out "/lib/pkgconfig"))) + (mkdir-p pkgconfig-path) + (with-output-to-file + (string-append pkgconfig-path "/id3tag.pc") + (lambda _ + (format #t + "prefix=3D~@*~a~@ + exec_prefix=3D${prefix}/bin~@ + libdir=3D${prefix}/lib~@ + includedir=3D${prefix}/include~@ + Name: ID3TAG~@ + Description: libid3tag - ID3 tag manipulation libra= ry~@ + Version: ~1@*~a~@ + Libs: -L${libdir} -lid3tag -lz~@ + Cflags: -I${includedir}~%" + out ,version))))))))) (synopsis "Library for reading ID3 tags") (description "Libid3tag is a library for reading ID3 tags, both ID3v1 and the vario= us --=20 2.15.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-gnu-Add-Easytag.patch >From bcabaa9b2c8d30d2fe1d8148068452667cd9e4c0 Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Sat, 9 Dec 2017 13:05:28 +0000 Subject: [PATCH 2/2] gnu: Add Easytag. * gnu/packages/music.scm (easytag): New variable. --- gnu/packages/music.scm | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 1aabe814b..d30c9b5de 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -40,6 +40,7 @@ #:use-module (guix build-system cmake) #:use-module (guix build-system python) #:use-module (guix build-system scons) + #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system waf) #:use-module (gnu packages) #:use-module (gnu packages algebra) @@ -469,6 +470,55 @@ background while you work.") enable professional yet simple and intuitive pattern-based drum programming.") (license license:gpl2+))) +(define-public easytag + (package + (name "easytag") + (version "2.4.3") + (source (origin + (method url-fetch) + (uri (string-append "mirror://gnome/sources/easytag/2.4/easytag-" + version ".tar.xz")) + (sha256 + (base32 + "1mbxnqrw1fwcgraa1bgik25vdzvf97vma5pzknbwbqq5ly9fwlgw")))) + (build-system glib-or-gtk-build-system) + (native-inputs + `(("desktop-file-utils" ,desktop-file-utils) + ("glib" ,glib "bin") + ("intltool" ,intltool) + ("itstool" ,itstool) + ("pkg-config" ,pkg-config) + ("xmllint" ,libxml2))) + (inputs + `(("flac" ,flac) + ("gtk+" ,gtk+) + ("id3lib" ,id3lib) + ("libid3tag" ,libid3tag) + ("libvorbis" ,libvorbis) + ("opusfile" ,opusfile) + ("speex" ,speex) + ("taglib" ,taglib) + ("wavpack" ,wavpack) + ("yelp" ,yelp))) + (arguments + '(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-makefile + (lambda _ + (substitute* "Makefile.in" + ;; The Makefile generates a test-desktop-file-validate.sh + ;; script with /bin/sh hard-coded. + (("/bin/sh") (which "sh")) + ;; Don't create 'icon-theme.cache'. + (("gtk-update-icon-cache") "true"))))))) + (home-page "https://wiki.gnome.org/Apps/EasyTAG") + (synopsis "Simple application for viewing and editing tags in audio files") + (description + "EasyTAG is an application for viewing and editing tags in audio files. +It supports MP3, MP2, MP4/AAC, FLAC, Ogg Opus, Ogg Speex, Ogg Vorbis, +MusePack, Monkey's Audio, and WavPack files.") + (license license:gpl2+))) + (define-public extempore (package (name "extempore") -- 2.15.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 11 10:49:28 2017 Received: (at 29624) by debbugs.gnu.org; 11 Dec 2017 15:49:28 +0000 Received: from localhost ([127.0.0.1]:56992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOQKd-0002Us-V6 for submit@debbugs.gnu.org; Mon, 11 Dec 2017 10:49:28 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:39696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOQKc-0002Uj-5S for 29624@debbugs.gnu.org; Mon, 11 Dec 2017 10:49:26 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 36AA610335; Mon, 11 Dec 2017 16:49:28 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H8ZpbAJp6SLc; Mon, 11 Dec 2017 16:49:27 +0100 (CET) Received: from ribbon (unknown [193.50.110.104]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 58A1BF7E0; Mon, 11 Dec 2017 16:49:27 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Pierre Langlois Subject: Re: [bug#29624] EasyTAG References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 21 Frimaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 11 Dec 2017 16:49:23 +0100 In-Reply-To: (Pierre Langlois's message of "Sat, 09 Dec 2017 13:43:44 +0000") Message-ID: <87o9n5z2m4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29624 Cc: 29624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello Pierre, Pierre Langlois skribis: > EasyTAG depends on the libid3tag library and tries to find it using > pkg-config. I thought it'd be a good idea for the library to provide a > .pc file instead of manually telling EasyTAG where it is. It allows > cleaning up dependent packages a little, namely audacity and gmtp, what > do you think? I think it=E2=80=99s a good patch for upstream, but not for distros. As I = see it, the risk is that people hacking on Guix would come to rely on the availability of a .pc file, and that code will break on other distros. Likewise, the build process of other packages is subtly affected. So I=E2=80=99m reluctant to making such changes in Guix proper, but I do ag= ree that it=E2=80=99s a good idea for upstream to adopt. WDYT? Does the EasyTag patch need to be adjusted? (I wanted to test but there=E2=80=99s currently no webkit-gtk substitute so=E2=80=A6) Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 14 17:38:06 2017 Received: (at 29624) by debbugs.gnu.org; 14 Dec 2017 22:38:07 +0000 Received: from localhost ([127.0.0.1]:34281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePc8k-0001Ni-Mr for submit@debbugs.gnu.org; Thu, 14 Dec 2017 17:38:06 -0500 Received: from mout.gmx.net ([212.227.15.19]:55914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePc8j-0001NF-M1 for 29624@debbugs.gnu.org; Thu, 14 Dec 2017 17:38:06 -0500 Received: from labiere ([80.229.147.137]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0MXr3H-1eUiP327ct-00WqSd; Thu, 14 Dec 2017 23:37:58 +0100 References: <87o9n5z2m4.fsf@gnu.org> User-agent: mu4e 0.9.19; emacs 25.3.1 From: Pierre Langlois To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#29624] EasyTAG In-reply-to: <87o9n5z2m4.fsf@gnu.org> Date: Thu, 14 Dec 2017 22:37:57 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:wSaiD+VRd6IjLxAEeBWaRd+HNbOSn8xamalwmeqSoioeCf8W48o DNyWuaf9e1KjMGrLn7jfzxzWtDBjzDh7V38lvK4cX3Z6P1sDpQe/2AQPIyk0GNZpHpLKJwr Z57TbLwzE0jMLTL3teAUfhVQZ6j+n4OTFpZv4irPzDaP0kPRTmaqxTMH0N5ZeXF6lq70t0L QLkeWiIl6fxwZjDvt7sPg== X-UI-Out-Filterresults: notjunk:1;V01:K0:PJtRiXDIyWg=:FdACGuX8DhN42igF7aknXy ojdRmzojdg3eRN3VHsgfGTK+RvQzc507pFasnIlzHh8AItjktQVDc0FIT0OIgrkPZt95AecZy UpPwDqOEmzOTGIz/orSHCeLFSHVVSdl3qBunpaHDOauxEtaoIOb8qMJnkmY0A/R8DCKvieKyn qqNw0e/MIs02OcMG0kWxJ6I1JvEtbtEp5LPpz5fQTh/2gpWybwuCb39H/5tMEfU+zElcQk/Xk XBSOKvWZTMCtiHqP0ZpAZAyBu1s1kefk/RlPVAHGfysAJYI23Ek8bZGMYcit/qolypwnYc3gg XElhHqT8XsuYTt3WQ32gjhsY/rleAnQkAVICM+xdYTXKF8Rs05mk9M0TVghajXyi1wHpDSEsb Jh3xePhI+M+U8+/oxbEjDKoJ0DbWekYNSXSEcBrb4uR4hy3DTeshjr5U6voTE0xgJ24JcSBO8 fmZg8g4VqrPQEFzbZDNvecRLAkjztoJrkDqQTFPwjW3y9S8YxgdupkTwFoerfCpJpNtZD3QU+ D4ldX46UrJtYopXud7ALcyMNptNrSexmxk2y55GwkVZmVr4DdIBn9jOSaaKlFlggP48X4VfcN lygVFqspxtVa4w8y22bt0TtM5TZFs09ICP3Bw5b8hyEmOR121Nl+6XaMg+8CCOmgbukvGwXpB PhdyQvyMAO4+/cqBtK9fXSk7Q2jHsuXSkq7AKie7+H/7TlBZZkU25W0iz346m+DmeDBc3xQZz +Jm1wyxU2avfHsZP9n0WmD2oL7OfvBkM5twIxMgu715CxTHybL3MBmb8bja3qfmz3XfBb+nHq Y6DBdX5LAlHGTs6J3quwzJgEA7ztQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29624 Cc: 29624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hi Ludovic, Thanks for taking a look! Ludovic Courtès writes: > Hello Pierre, > > Pierre Langlois skribis: > >> EasyTAG depends on the libid3tag library and tries to find it using >> pkg-config. I thought it'd be a good idea for the library to provide a >> .pc file instead of manually telling EasyTAG where it is. It allows >> cleaning up dependent packages a little, namely audacity and gmtp, what >> do you think? > > I think it’s a good patch for upstream, but not for distros. As I see > it, the risk is that people hacking on Guix would come to rely on the > availability of a .pc file, and that code will break on other distros. > Likewise, the build process of other packages is subtly affected. > > So I’m reluctant to making such changes in Guix proper, but I do agree > that it’s a good idea for upstream to adopt. > > WDYT? Sure, sounds reasonable! I'm unsure I'll have time to chase upstream however. In the meantime, see the attached patch to get around the issue with libid3tag. I'm afraid I couldn't find a way to make the configure script work without pkg-config. I got as far as patching it to think libid3tag was found, but then I couldn't find how to set CFLAGS and LDFLAGS to include libid3tag. It appears using pkg-config for some dependencies but not others is tricky here. So in the end, I settled with creating a temporary local .pc file. It feels like a bit of a hack but I thought it would be the most future-proof option, WDYT? > > Does the EasyTag patch need to be adjusted? (I wanted to test but > there’s currently no webkit-gtk substitute so…) > > Thanks, > Ludo’. Thanks, Pierre --=-=-= Content-Type: message/external-body; name="/home/pierre/code/guix/0001-gnu-Add-Easytag.patch"; access-type=local-file Content-Type: text/x-patch Content-ID: Content-Transfer-Encoding: binary --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 14 17:42:41 2017 Received: (at 29624) by debbugs.gnu.org; 14 Dec 2017 22:42:41 +0000 Received: from localhost ([127.0.0.1]:34287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePcDB-0001U0-9L for submit@debbugs.gnu.org; Thu, 14 Dec 2017 17:42:41 -0500 Received: from mout.gmx.net ([212.227.15.18]:62094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePcD8-0001Tn-Fd for 29624@debbugs.gnu.org; Thu, 14 Dec 2017 17:42:40 -0500 Received: from labiere ([80.229.147.137]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0MQiB3-1ebsH72NwL-00U5JX; Thu, 14 Dec 2017 23:42:32 +0100 References: <87o9n5z2m4.fsf@gnu.org> User-agent: mu4e 0.9.19; emacs 25.3.1 From: Pierre Langlois To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#29624] EasyTAG In-reply-to: Date: Thu, 14 Dec 2017 22:42:31 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:EFxRH+SS3UfjiKCJFNcT1lB3vnOMpImQYnBz7DhxlZnhMm6kTa/ i3PuTAJApxKd/VCOgtKeagPsvq8UiSj4TKANos6VmQraj2PEOvxPwV1N/gynnuD3xj0Vv2h r5iFYyboDrVpW2SMthVFqvtMZWjxDLJtLh723KBxUl01rvDMoNsvyhKExv7d9b1cmGxe54b UtrDk0qWvsNsLBxaIpq2g== X-UI-Out-Filterresults: notjunk:1;V01:K0:Zk+2opGyJAw=:nIdO8H5uFJBYzzbXy3oYQh PiPFQzPGrfTPtt4j3ei0sfmAj7SN0+G3bV0GlKaubN0iQkSqv66uxiQws3tQ70Ngg5BxX3ZhN BdDxjsbsJOToZTPpkR5pdA/efafUH6CrOGB2xRX3yrKO+SHtKwip0nR39d82WtqXuDxaOLZdh 0hR7euSHS6CGQ4ogzvpylQLhGY+WXN78gxk3b+mIHTnwn08HUIkP+ggrBLAXS9Jtb6XsXvsMj GgMN+V5L0B1ArwL5mcyduAPoTjp5Dkp1FgCuUS1WMYlI7LgbKaZLOgjou5s10NiZBf0oU4hSK Kd/OPhooLkGR9+SZOJ4G0vbFXOvFw4JeDPbnrSgqT5m1bLVjAFLpIDkAlQVGlpdYnaAt53iJv iAOC/dBWfft5u45ucqc7ts+om0BfMsOKFauw9I51gz15yZmO4MoFcrf+4qN1/8hA3/jod+tAo +jMceWZhtsdOYP0dTszk51/Rui3ZXe2jXJps4dT2jtHTk8WGUHuaBF2WNTMOu2VsvUNp+tEGW 4LESfRW5a/TxxT71DOQWBmoKvcRG2/yU+Eqz+sEgVBEomgPPgDoNECpBXUD+LhbmsBF32OT8T fExqLu5vlCFqie5pq0gtLj2BMnZwqgLP2Hd1gK8+CM5ED+yMVvBBnZlR66dju4Rh5waKtEc4S LiEEQE/wF4umjW9dHnx0hgtWXtR8X5WPL7OQ3iJK1zVWiYcLMjw8X3HzEMORhvs9fZdE9XssQ mmAQRPH1FTp3NmUuG19ehq7kV0eu4ihCVut8i5JmRbRSWQjyiVbYO4nIuUVy663r8csXD0xFk 7lajmoRBE5elCJwj9gM3cVtxy+1Nw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29624 Cc: 29624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Aaaaand here's the patch! --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-Easytag.patch >From fbe4e6d3cd25806a8acd350caf19778f20dedf2b Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Sat, 9 Dec 2017 13:05:28 +0000 Subject: [PATCH] gnu: Add Easytag. * gnu/packages/music.scm (easytag): New variable. --- gnu/packages/music.scm | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 1aabe814b..fc6026d79 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -40,6 +40,7 @@ #:use-module (guix build-system cmake) #:use-module (guix build-system python) #:use-module (guix build-system scons) + #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system waf) #:use-module (gnu packages) #:use-module (gnu packages algebra) @@ -469,6 +470,75 @@ background while you work.") enable professional yet simple and intuitive pattern-based drum programming.") (license license:gpl2+))) +(define-public easytag + (package + (name "easytag") + (version "2.4.3") + (source (origin + (method url-fetch) + (uri (string-append "mirror://gnome/sources/easytag/2.4/easytag-" + version ".tar.xz")) + (sha256 + (base32 + "1mbxnqrw1fwcgraa1bgik25vdzvf97vma5pzknbwbqq5ly9fwlgw")))) + (build-system glib-or-gtk-build-system) + (native-inputs + `(("desktop-file-utils" ,desktop-file-utils) + ("glib" ,glib "bin") + ("intltool" ,intltool) + ("itstool" ,itstool) + ("pkg-config" ,pkg-config) + ("xmllint" ,libxml2))) + (inputs + `(("flac" ,flac) + ("gtk+" ,gtk+) + ("id3lib" ,id3lib) + ("libid3tag" ,libid3tag) + ("libvorbis" ,libvorbis) + ("opusfile" ,opusfile) + ("speex" ,speex) + ("taglib" ,taglib) + ("wavpack" ,wavpack) + ("yelp" ,yelp))) + (arguments + '(#:phases + (modify-phases %standard-phases + (add-before 'configure 'configure-libid3tag + (lambda* (#:key inputs #:allow-other-keys) + ;; libid3tag does not provide a .pc file and EasyTAG's configure + ;; script healivy relies on pkg-config. Providing a temporary + ;; local .pc file is easier than patching the configure script. + (let* ((libid3tag (assoc-ref inputs "libid3tag"))) + (mkdir-p "pkgconfig") + (with-output-to-file + "pkgconfig/id3tag.pc" + (lambda _ + (format #t + "prefix=~@*~a~@ + libdir=${prefix}/lib~@ + includedir=${prefix}/include~@ + Libs: -L${libdir} -lid3tag -lz~@ + Cflags: -I${includedir}~%" + libid3tag))) + (setenv "PKG_CONFIG_PATH" + (string-append (getenv "PKG_CONFIG_PATH") + ":" (getcwd) "/pkgconfig"))))) + (add-after 'unpack 'patch-makefile + (lambda _ + (substitute* "Makefile.in" + ;; The Makefile generates a test-desktop-file-validate.sh + ;; script with /bin/sh hard-coded. + (("/bin/sh") (which "sh")) + ;; Don't create 'icon-theme.cache'. + (("gtk-update-icon-cache") "true"))))))) + (home-page "https://wiki.gnome.org/Apps/EasyTAG") + (synopsis "Simple application for viewing and editing tags in audio files") + (description + "EasyTAG is an application for viewing and editing tags in audio files. +It supports MP3, MP2, MP4/AAC, FLAC, Ogg Opus, Ogg Speex, Ogg Vorbis, +MusePack, Monkey's Audio, and WavPack files.") + (license license:gpl2+))) + (define-public extempore (package (name "extempore") -- 2.15.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 05:32:16 2017 Received: (at 29624-done) by debbugs.gnu.org; 15 Dec 2017 10:32:16 +0000 Received: from localhost ([127.0.0.1]:34688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePnHs-0004VN-8E for submit@debbugs.gnu.org; Fri, 15 Dec 2017 05:32:16 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:54576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePnHq-0004VF-RI for 29624-done@debbugs.gnu.org; Fri, 15 Dec 2017 05:32:15 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C878A102CA; Fri, 15 Dec 2017 11:32:17 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nOwpMUTeYJnF; Fri, 15 Dec 2017 11:32:17 +0100 (CET) Received: from ribbon (unknown [193.50.110.249]) by hera.aquilenet.fr (Postfix) with ESMTPSA id E3FF1102C1; Fri, 15 Dec 2017 11:32:16 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Pierre Langlois Subject: Re: [bug#29624] EasyTAG References: <87o9n5z2m4.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Frimaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 15 Dec 2017 11:32:13 +0100 In-Reply-To: (Pierre Langlois's message of "Thu, 14 Dec 2017 22:42:31 +0000") Message-ID: <878te4l1si.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29624-done Cc: 29624-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Pierre Langlois skribis: > From fbe4e6d3cd25806a8acd350caf19778f20dedf2b Mon Sep 17 00:00:00 2001 > From: Pierre Langlois > Date: Sat, 9 Dec 2017 13:05:28 +0000 > Subject: [PATCH] gnu: Add Easytag. > > * gnu/packages/music.scm (easytag): New variable. Perfect. Applied, thanks! Ludo=E2=80=99. From unknown Sat Aug 09 20:35:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 12 Jan 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator