GNU bug report logs - #29624
EasyTAG

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29624 in the body.
You can then email your comments to 29624 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: guix-patches <at> gnu.org
Subject: EasyTAG
Date: Sat, 09 Dec 2017 13:43:44 +0000

[Message part 1 (text/plain, inline)]

Hello Guix!

Here are a couple of patches adding the EasyTAG gnome package
https://wiki.gnome.org/Apps/EasyTAG.

EasyTAG depends on the libid3tag library and tries to find it using
pkg-config. I thought it'd be a good idea for the library to provide a
.pc file instead of manually telling EasyTAG where it is. It allows
cleaning up dependent packages a little, namely audacity and gmtp, what
do you think?

Thanks!
Pierre

[0001-gnu-libid3tag-Create-a-pkg-config-file.patch (text/x-patch, attachment)]

[0002-gnu-Add-Easytag.patch (text/x-patch, attachment)]

Message #8 received at 29624 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 29624 <at> debbugs.gnu.org
Subject: Re: [bug#29624] EasyTAG
Date: Mon, 11 Dec 2017 16:49:23 +0100

Hello Pierre,

Pierre Langlois <pierre.langlois <at> gmx.com> skribis:

> EasyTAG depends on the libid3tag library and tries to find it using
> pkg-config. I thought it'd be a good idea for the library to provide a
> .pc file instead of manually telling EasyTAG where it is. It allows
> cleaning up dependent packages a little, namely audacity and gmtp, what
> do you think?

I think it’s a good patch for upstream, but not for distros.  As I see
it, the risk is that people hacking on Guix would come to rely on the
availability of a .pc file, and that code will break on other distros.
Likewise, the build process of other packages is subtly affected.

So I’m reluctant to making such changes in Guix proper, but I do agree
that it’s a good idea for upstream to adopt.

WDYT?

Does the EasyTag patch need to be adjusted?  (I wanted to test but
there’s currently no webkit-gtk substitute so…)

Thanks,
Ludo’.

Message #11 received at 29624 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29624 <at> debbugs.gnu.org
Subject: Re: [bug#29624] EasyTAG
Date: Thu, 14 Dec 2017 22:37:57 +0000

[Message part 1 (text/plain, inline)]

Hi Ludovic,

Thanks for taking a look!

Ludovic Courtès writes:

> Hello Pierre,
>
> Pierre Langlois <pierre.langlois <at> gmx.com> skribis:
>
>> EasyTAG depends on the libid3tag library and tries to find it using
>> pkg-config. I thought it'd be a good idea for the library to provide a
>> .pc file instead of manually telling EasyTAG where it is. It allows
>> cleaning up dependent packages a little, namely audacity and gmtp, what
>> do you think?
>
> I think it’s a good patch for upstream, but not for distros.  As I see
> it, the risk is that people hacking on Guix would come to rely on the
> availability of a .pc file, and that code will break on other distros.
> Likewise, the build process of other packages is subtly affected.
>
> So I’m reluctant to making such changes in Guix proper, but I do agree
> that it’s a good idea for upstream to adopt.
>
> WDYT?

Sure, sounds reasonable! I'm unsure I'll have time to chase upstream
however. In the meantime, see the attached patch to get around the issue
with libid3tag.

I'm afraid I couldn't find a way to make the configure script work
without pkg-config. I got as far as patching it to think libid3tag was
found, but then I couldn't find how to set CFLAGS and LDFLAGS to include
libid3tag. It appears using pkg-config for some dependencies but not
others is tricky here.

So in the end, I settled with creating a temporary local .pc file. It
feels like a bit of a hack but I thought it would be the most
future-proof option, WDYT?

>
> Does the EasyTag patch need to be adjusted?  (I wanted to test but
> there’s currently no webkit-gtk substitute so…)
>
> Thanks,
> Ludo’.

Thanks,
Pierre

[/home/pierre/code/guix/0001-gnu-Add-Easytag.patch (message/external-body, inline)]

[Message part 3 (text/x-patch, inline)]

Message #14 received at 29624 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29624 <at> debbugs.gnu.org
Subject: Re: [bug#29624] EasyTAG
Date: Thu, 14 Dec 2017 22:42:31 +0000

[Message part 1 (text/plain, inline)]

Aaaaand here's the patch!

[0001-gnu-Add-Easytag.patch (text/x-patch, attachment)]

Message #19 received at 29624-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 29624-done <at> debbugs.gnu.org
Subject: Re: [bug#29624] EasyTAG
Date: Fri, 15 Dec 2017 11:32:13 +0100

Pierre Langlois <pierre.langlois <at> gmx.com> skribis:

> From fbe4e6d3cd25806a8acd350caf19778f20dedf2b Mon Sep 17 00:00:00 2001
> From: Pierre Langlois <pierre.langlois <at> gmx.com>
> Date: Sat, 9 Dec 2017 13:05:28 +0000
> Subject: [PATCH] gnu: Add Easytag.
>
> * gnu/packages/music.scm (easytag): New variable.

Perfect.  Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.