From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 08 16:54:03 2017 Received: (at submit) by debbugs.gnu.org; 8 Dec 2017 21:54:03 +0000 Received: from localhost ([127.0.0.1]:52957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNQao-00083P-UQ for submit@debbugs.gnu.org; Fri, 08 Dec 2017 16:54:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNQBj-0007Sk-Qe for submit@debbugs.gnu.org; Fri, 08 Dec 2017 16:28:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNQBd-0004Js-Q2 for submit@debbugs.gnu.org; Fri, 08 Dec 2017 16:28:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58891) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eNQBd-0004Je-MS for submit@debbugs.gnu.org; Fri, 08 Dec 2017 16:28:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNQBc-00067J-Lr for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2017 16:28:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNQBb-0004JA-Qi for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2017 16:28:00 -0500 Received: from mail-ot0-x235.google.com ([2607:f8b0:4003:c0f::235]:42346) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eNQBb-0004J4-MC for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2017 16:27:59 -0500 Received: by mail-ot0-x235.google.com with SMTP id i1so10252093oth.9 for ; Fri, 08 Dec 2017 13:27:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=c27PiuazCCyHouvuih3XtjuClgcx6/TJ6Ud72KCGeGI=; b=g5QC0UKaKBII25IdqPlcMetYRNLI5bT+TOyDm3HvnN4MqC9nQktQb8iNwA3XxgRs23 PnDWC+ElX+fFbcxTnTMZ27glEGzZpHR4Rtxg1MHonXElWooNA8UHWndxjfQYwdbKs7BH TQS5oX1Q0LyINIfjD/e34oCxYWszfI4LWQZswkaUeSNIFFsHfiNaTEd+yO+91nKUFbgB jd8g3zNADO02XkksEeEMYAqWvF/5ttdFklOUe3hyL/NRwLVpVwCpHitvHlZYTNfffsdw eIUTOlu3UmXrZntLhWLf5+zYVRuYzDPn1Ch/9kG7NAQcyhQbu27rDJfAxtPv9sruqXeF IeFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=c27PiuazCCyHouvuih3XtjuClgcx6/TJ6Ud72KCGeGI=; b=DJBSrueVQmWKJa9oTvMs7DpBNUGQ0liwmjZQn1qEGdtnDAFVJS+sJVWTYB8PQOGp8Y w5VS11QX7nWccjVZl1lBEQ50PAgjfS4RVzgXQMAp1RKKo7oYOXqwAbwksFjA89wNE24p 1Yh+KbyaGo4BU+aq8lduhQAX1zuKvmSkYUR4fhrb5AZBaMSNkmupMQL3elCvffd3BSzl EqDJbnbc6svyZHvjz6/dQnWi1Sc+ge2ybli59Ki3VTHjSvK3b9l64kcO8MlfudqP1XfR Ogd4Vs+/WjCLuDZELJsMSet5CRXu2dlBwgiZN3tybDVKZdrFffXTNCCJWXo0BrsaFp2I 9LWw== X-Gm-Message-State: AKGB3mI0Y8koaJk8AD7P29nzwS7uSBa1tgTWLFsROuhihF8a5F1NDIMI pz3/ZHUwMw5wp58MdiPRYSsPxKWQIqXE7lbyLZ+dCg== X-Google-Smtp-Source: AGs4zMbn50sXg03UI6yGdUcccqHxcnc1W3qkP+NsL5EJj7M8kVdxmGYh5nDVRsDxLjCKP2uAqTLh83a7Mj7Usvp3Jt4= X-Received: by 10.157.83.38 with SMTP id g38mr7377490oth.340.1512768478730; Fri, 08 Dec 2017 13:27:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.71.212 with HTTP; Fri, 8 Dec 2017 13:27:58 -0800 (PST) In-Reply-To: References: From: Ray Date: Fri, 8 Dec 2017 13:27:58 -0800 Message-ID: Subject: Fwd: [xref.el] Add `xref-find-references` to `xref-prompt-for-identifier` To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 08 Dec 2017 16:54:02 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Currently, xref-find-references prompts for the identifier to look up, because it is not listed in xref-prompt-for-identifier: (defcustom xref-prompt-for-identifier '(not xref-find-definitions xref-find-definitions-other-window xref-find-definitions-other-frame) It will be much core convenient to add xref-find-references in the list. Many language servers now support finding references. lsp-mode is a clinet implementation for Emacs and there is some work to make it into Emacs. https://github.com/emacs-lsp/lsp-mode/issues/83 The typical usage of lsp-mode is to put point at some identifier and hit a shortcut (by default M-?) to trigger xref-find-references. The prompt is in many cases undesired. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 10:25:34 2017 Received: (at 29619) by debbugs.gnu.org; 9 Dec 2017 15:25:34 +0000 Received: from localhost ([127.0.0.1]:53984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNh0P-0002UB-Rl for submit@debbugs.gnu.org; Sat, 09 Dec 2017 10:25:34 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:39534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNh0N-0002Tx-UR for 29619@debbugs.gnu.org; Sat, 09 Dec 2017 10:25:32 -0500 Received: by mail-wm0-f54.google.com with SMTP id i11so7314842wmf.4 for <29619@debbugs.gnu.org>; Sat, 09 Dec 2017 07:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HD1Iq2DSnx1WIymoyzpvrfQBaCHxg4WyX20Xp2/HKnw=; b=q1nvUQUz0b02im2sF6IuSrkm9hIPRhQISQ4nB8OmjqKQu7T88WNCbsor70pLzHc53s 4W9mFuteSPdb7kG6t7quuV1ktGMY+4ONaGXs0IZ+qQBt2G3MmLvM3WQJkNhF7Hgc3rBo pgy9/ocFDhUiP9CgxQibE95Z5lbvsF9WLm4RFaJ71A8+/Sf/hsUnGN2nZWEx+aa+T3SP NrSI9H3sto9KIWXuIHeaxmeFWUk/+21avnvAbmlidpAXGUszQJSj5Hd5rAzKrw0z/zAY 3r1/lZmAeKRax30m31ThRyIPeFjHeCBHNLWVz927Vv4Izu+/PA9Y4JCHscK9MzZEFJvi FYbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HD1Iq2DSnx1WIymoyzpvrfQBaCHxg4WyX20Xp2/HKnw=; b=NyudrToEfjAL5pxA0wBL6rTuDd7dxNnMeTmPjshz1BNIWbvs69CmGqu0s0xCx1U0LH kiE7sYotC6/NbAPLwHEh3Y/uqpreDnrxpv9rm5WS6rlOFeS1Xco9qtX/+bWEZLh1LUiW Iv/9qWhWqZsO23/4l0/oVQRqQBH0M1AkwZQQb+ziJDERnVj1jIg8742Mnh8wGIhxwyb1 nfTQOXYanxEzzc5lG7luS09xQ55lAT02/DdmOWwma4O5AnsBYpTK+YHxBH4rnaYQ1T86 wIJfSzwttBuq6W8JBfTdJnEJeKYsto3kKoA35+snhJX9FIpOWGxHNTEmNGYUjoIvJcUs btAA== X-Gm-Message-State: AKGB3mIf5XdV4qG/0G9O4s0ZFtAnJ4zX2pJS+ngnVqfA4if/JXPOYUXp VLYxTIsM+eyngnqnweX2HNpjB6Pf X-Google-Smtp-Source: AGs4zMbBEA8idxDV+NvhclNfd3Dkx2LpBylMfBqsyZXDMGgId8uJW8N1hyMnaBOhLn6vawzDXZVpXQ== X-Received: by 10.28.127.22 with SMTP id a22mr6350820wmd.12.1512833125948; Sat, 09 Dec 2017 07:25:25 -0800 (PST) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id l6sm10622366wre.53.2017.12.09.07.25.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Dec 2017 07:25:25 -0800 (PST) Subject: Re: bug#29619: Fwd: [xref.el] Add `xref-find-references` to `xref-prompt-for-identifier` To: Ray , 29619@debbugs.gnu.org References: From: Dmitry Gutov Message-ID: Date: Sat, 9 Dec 2017 17:25:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Thunderbird/58.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29619 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 12/8/17 11:27 PM, Ray wrote: > Currently, xref-find-references prompts for the identifier to look up, > because it is not listed in xref-prompt-for-identifier: > > (defcustom xref-prompt-for-identifier '(not xref-find-definitions > xref-find-definitions-other-window > xref-find-definitions-other-frame) > > It will be much core convenient to add xref-find-references in the list. We've discussed it before, and for now have settled on this list of non-prompting functions. But thank you for your report. We may change the default if more people feel the same. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 12:52:08 2017 Received: (at 29619) by debbugs.gnu.org; 9 Dec 2017 17:52:08 +0000 Received: from localhost ([127.0.0.1]:54067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNjIG-0005pR-JF for submit@debbugs.gnu.org; Sat, 09 Dec 2017 12:52:08 -0500 Received: from mail-oi0-f50.google.com ([209.85.218.50]:34491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNjIE-0005ox-NR for 29619@debbugs.gnu.org; Sat, 09 Dec 2017 12:52:07 -0500 Received: by mail-oi0-f50.google.com with SMTP id u193so9170901oie.1 for <29619@debbugs.gnu.org>; Sat, 09 Dec 2017 09:52:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZX9bk5s7yA0kGlyA+c6d7SY1MvlT9f3GyEjrr5T8iTk=; b=kmFfR4jvmrebs+k5+QlmD++Pv2H1d5rY2B+731J60bPPP/HU13MB+Xq9Xq0L7w3Rm3 pWpT7KdOodm4S8q3nUXNtzUM+9DtfqT8WAp2C/YvZIaOaFT2Kef1VPMxChKYG4nmg6yZ 2K4L6XaUlss1IPnIzRnwMz61mKXYtpj0XVx46tfgBziQW48gvF2op7uYKm2ZWkbHd3d5 /n6yujdhmaogL/w7XZGKmABzrB33ExrqRrV2tV0upxwGrW21+JyBF9syVI2VH/0ZYhtk /6LHxz0tngD3Liw5ITqBvlvgkwbfVN5Tk/shsq7CxdNs2pKnh/1P72Si8rKJsEHiYnR5 llvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZX9bk5s7yA0kGlyA+c6d7SY1MvlT9f3GyEjrr5T8iTk=; b=YfzR5kY5/5UtQFMB+Z7FgmHg+ikenvqvhE7YhPipK089zK/g+6nEswy/Y1KprktNA6 Yngy1KxdNxBUoh2Bzsg9Jc9wG1gWhJCaH/QMznzOJTBV+c9Ikom8npSA/UbkeY3Z5qKX s3q8yzCY+bHRgoMX+UuL+BZvaNCxMq/R/ABuEgOMmDN2EDej55HgIVrkNfwLTYVS3Cz2 1Uu+z0CNCMF20oiPUcteDIioGwlCWBKxNSsy0iWmSmDlcMwb9L30E4a1L3kW0kCL47gG bUUwuhd4rvIe/bV8AGiWtm9wRacB/cGlGBBnjV6Vwi6HdlpXWBGdnKZ+vT+EKm3PcVFi QyrA== X-Gm-Message-State: AKGB3mLu3QZKpgwuOQltH22XyAWuRWMsN24vjvtu9Juri8Ca1Kh/WV3/ L4PYUk/5cZQA3aMB7Cyx0PMopHSKDzcOLM7mQOM= X-Google-Smtp-Source: AGs4zMZS68hLbJ122io0US2Ctl3ueBds3smQL/teOrRKHTm+YkLm+yLvyekY+MpvwPuOKj0juzt3gyxGlccF2BJJx/o= X-Received: by 10.202.223.70 with SMTP id w67mr14619469oig.229.1512841920732; Sat, 09 Dec 2017 09:52:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.71.212 with HTTP; Sat, 9 Dec 2017 09:52:00 -0800 (PST) In-Reply-To: References: From: Ray Date: Sat, 9 Dec 2017 09:52:00 -0800 Message-ID: Subject: Re: bug#29619: Fwd: [xref.el] Add `xref-find-references` to `xref-prompt-for-identifier` To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29619 Cc: 29619@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Thanks for being open to change the default if more people feel the same. With the xref system people use drifting from tag based (ctags,etags,GNU GLOBAL,cscope,...) tools to Language Server Protocol (cquery, rls, ...), a single identifier without position has become insufficient to describe the one the user wants to look up. For example, a local variable/struct/lambda `foo` may exist in different functions. I'm using a C++ language server called cquery. This is what I get (for the argument `identifier`) when I hit the key bound to `xref-find-definitions`: #("QueryDatabase" 0 13 (fontified t ref-params (:textDocument (:uri "file:///home/maskray/Dev/Util/cquery/src/query_utils.h") :position (:line 11 :character 54) :context (:includeDeclaration :json-false)) def-params (:textDocument (:uri "file:///home/maskray/Dev/Util/cquery/src/query_utils.h") :position (:line 11 :character 54)))) Here the text properties are more useful than the identifier itself, because LSP uses position instead of identifier to sending requests to the language server. https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#textdocumentpositionparams This is my 2 cents. I am totally fine to live with the current default `xref-prompt-for-identifier` because I can customize it. On Sat, Dec 9, 2017 at 7:25 AM, Dmitry Gutov wrote: > On 12/8/17 11:27 PM, Ray wrote: >> >> Currently, xref-find-references prompts for the identifier to look up, >> because it is not listed in xref-prompt-for-identifier: >> >> (defcustom xref-prompt-for-identifier '(not xref-find-definitions >> >> xref-find-definitions-other-window >> >> xref-find-definitions-other-frame) >> >> It will be much core convenient to add xref-find-references in the list. > > > We've discussed it before, and for now have settled on this list of > non-prompting functions. > > But thank you for your report. We may change the default if more people feel > the same. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 15:52:35 2017 Received: (at control) by debbugs.gnu.org; 9 Dec 2017 20:52:35 +0000 Received: from localhost ([127.0.0.1]:54163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNm6t-0001WM-3q for submit@debbugs.gnu.org; Sat, 09 Dec 2017 15:52:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNm6r-0001W9-Fo for control@debbugs.gnu.org; Sat, 09 Dec 2017 15:52:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNm6l-0006xR-KJ for control@debbugs.gnu.org; Sat, 09 Dec 2017 15:52:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNm6l-0006xG-HC for control@debbugs.gnu.org; Sat, 09 Dec 2017 15:52:27 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eNm6l-0000zB-9A for control@debbugs.gnu.org; Sat, 09 Dec 2017 15:52:27 -0500 Subject: control message for bug 29619 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sat, 09 Dec 2017 15:52:27 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) severity 29619 wishlist tag 29619 wontfix From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 10 11:58:08 2017 Received: (at 29619) by debbugs.gnu.org; 10 Dec 2017 16:58:08 +0000 Received: from localhost ([127.0.0.1]:55535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eO4vX-0000e4-Tj for submit@debbugs.gnu.org; Sun, 10 Dec 2017 11:58:08 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eO4vW-0000da-CY for 29619@debbugs.gnu.org; Sun, 10 Dec 2017 11:58:06 -0500 Received: by mail-wm0-f47.google.com with SMTP id b76so10311349wmg.1 for <29619@debbugs.gnu.org>; Sun, 10 Dec 2017 08:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Dwz0bqXhHDMdG43bqz3ZlrdmyVaK6WHiHMrmdU3Hqpw=; b=SMpipXJL7n6YR5E5+kvTaXOk0QWjgPhk34zesqWaPKBF8smC5MbCRxcQZdGxay7F6z +EZpxJZD/OPDIL9co+Vy1Wy5FkVBwXDv9c+sJOlm5mPNr76TuikEweavlK8RXJ6eUWSv MPrGDHecPdDNBpAB8Q6hiCjPafevVQ00a2rOrPuEwVPAgHB4enPkZN9QONV1PqfUh6gM 8pbTjp4lC4z2e/k4wKxjMpjS4jvbT1A61Kw92V7LMXYhA4cNP7fsJrHfOg/8++hx9rPw 8EsXhwa3qOQUpqBnimF6P7a84rvrPik8A4yNL4uvZrY3CcMtk5XndjoMBPutU0q0jHjb dZpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dwz0bqXhHDMdG43bqz3ZlrdmyVaK6WHiHMrmdU3Hqpw=; b=cU6UEXLw0yzb6XQqVBdRiFtzRD0NUzBrGinuA41xtEfIQcTGchoOi5Vn+rL7yXOvQ3 crvnkFGijQhYjtIdv22MkWVdfdCGcPOQL1PoW42OaMzFHaw6dMOi6E1EN2I6Qoac11ur Dvk8f5V1YKfHEThjRBTf6vGhqYOzB2cYC+gaeNH1+GP4DblmkRnMHTgF5AF6DDDRRcPv W6kjnw+awg0dhOhCcaqVs/iGKTuVHy/FDT7BESQ2wdVBZ9viqSXbjG1CuQd8ZCIYGFPX XEUvTkCkJJDuxO/7sdByYbpzIJavlxsLHimyEuyOujFAmkqYwanF6zYC0dGB5O2iguMs MXug== X-Gm-Message-State: AKGB3mKC6/Ro9FMeMKKvFnZwY7D1b0NYkGOkoXrltloprSLcoiM0vJon 8m5fNMnxp5pcRmI40nCyzTbWd+CC X-Google-Smtp-Source: ACJfBovgClkoQvvhZWylWAJqAJslHBMEdGHr191s7Cjej9aQ+vVEUIHbhmqtJjqLrGu+xUh03ZLKMA== X-Received: by 10.28.131.73 with SMTP id f70mr7012963wmd.153.1512925080257; Sun, 10 Dec 2017 08:58:00 -0800 (PST) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id f90sm7121294wmh.12.2017.12.10.08.57.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Dec 2017 08:57:59 -0800 (PST) Subject: Re: bug#29619: Fwd: [xref.el] Add `xref-find-references` to `xref-prompt-for-identifier` To: Ray References: From: Dmitry Gutov Message-ID: <0e97609a-eefc-6e0d-ce2b-6c69651d9990@yandex.ru> Date: Sun, 10 Dec 2017 18:57:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Thunderbird/58.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29619 Cc: 29619@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 12/9/17 7:52 PM, Ray wrote: > Thanks for being open to change the default if more people feel the same. > > With the xref system people use drifting from tag based > (ctags,etags,GNU GLOBAL,cscope,...) tools to Language Server Protocol > (cquery, rls, ...), > a single identifier without position has become insufficient to > describe the one the user wants to look up. For example, a local > variable/struct/lambda `foo` may exist > in different functions. That's fine, actually, and as designed. As long as the different global identifiers can be represented uniquely as strings (but using text properties for e.g. a local variable at point is good too). > I'm using a C++ language server called cquery. This is what I get (for > the argument `identifier`) when I hit the key bound to > `xref-find-definitions`: > > #("QueryDatabase" 0 13 (fontified t ref-params (:textDocument (:uri > "file:///home/maskray/Dev/Util/cquery/src/query_utils.h") :position > (:line 11 :character 54) :context (:includeDeclaration :json-false)) > def-params (:textDocument (:uri > "file:///home/maskray/Dev/Util/cquery/src/query_utils.h") :position > (:line 11 :character 54)))) > > Here the text properties are more useful than the identifier itself, > because LSP uses position instead of identifier to sending requests to > the language server. > https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#textdocumentpositionparams So it doesn't actually let you choose? Only supports the identifier at point? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 11 02:23:39 2017 Received: (at 29619) by debbugs.gnu.org; 11 Dec 2017 07:23:39 +0000 Received: from localhost ([127.0.0.1]:55974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOIR9-0002Hb-3l for submit@debbugs.gnu.org; Mon, 11 Dec 2017 02:23:39 -0500 Received: from mail-pg0-f47.google.com ([74.125.83.47]:36668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOIR6-0002HM-5K for 29619@debbugs.gnu.org; Mon, 11 Dec 2017 02:23:37 -0500 Received: by mail-pg0-f47.google.com with SMTP id k134so10350007pga.3 for <29619@debbugs.gnu.org>; Sun, 10 Dec 2017 23:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uTh2q/5wAhrCDXj75zlNmMrxmppgmJX+GmTnxru0oio=; b=bZ854hgAQdzdmHz48ScYLlj8IzKWL3JLJyV6vg1xksseJIzxcuM8H6rP28NWpv1XCG afVWFzx9NTyiNmPXmzPEL439QnYcpy1X9SmUQDHZVi1q7b0rP3NRV+frbHMjY8UQf7+S un0cv70j3kiC32yM4xooC+/bcmyUJA75d3W1NvSpwbcUP+REoF/XSqVa8iuZojHW2fUe yt2O3GRS1Ki3jW6+5+Q99wOHsr3v/jGp/wtYWVXTj2thwZ09KslKZYCne9fTMjZQDpbO Xas8mncWk217i+rPtF1VEfXMD8hOEEAkym0SiiPxFLUr25Swb2719/f6VZ5sorAXmqcI HqHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uTh2q/5wAhrCDXj75zlNmMrxmppgmJX+GmTnxru0oio=; b=QQC5bN9yftcdcsLke9o/TuysiXUjAoM5woB+a6T0nCavX6Lk5aUgUJUUhoQMNLmEA5 gOpxtrFnmtF8nTvDjrTGJPYb3XPfF7uldYudztZt54C1XyRqurwZIddJy40K9DPAJaSh H+poUyJ5UPhIWNBFBocmFSf8NzgUprsCJR/n9Ndb+zjG8Rnn7SqgjBwMfORus3widUJB BqaEbX8VMIVyMXulsLSTuowX1LCjzhpVwDEFjeCtnd+7mDZag2HAbLWQTdx+KFOnxfY4 3HJyC4cNoBUzUZkWeQtf1VIBBM9eOjCB+j0K5hJs3Xu9NfPT/7yOAWPp/FriQZIMc5r2 4VHw== X-Gm-Message-State: AKGB3mKK+pWsIKnHBaQzqn3tYxm/uzXRfD80h9oUO/evZR5k5VmWT3UP lJETphqHJHQNRfpBShvoY9I= X-Google-Smtp-Source: AGs4zMYIaAI0aYYBxCJR4jvBJ4LM4N2ENaGPPlengDHYYeEMilz+XbDhONcpTwnjCAMWcOaA3RF24g== X-Received: by 10.98.58.29 with SMTP id h29mr6430850pfa.121.1512977009855; Sun, 10 Dec 2017 23:23:29 -0800 (PST) Received: from localhost (c-24-130-65-8.hsd1.ca.comcast.net. [24.130.65.8]) by smtp.gmail.com with ESMTPSA id a87sm26293122pfg.159.2017.12.10.23.23.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Dec 2017 23:23:29 -0800 (PST) Date: Sun, 10 Dec 2017 23:18:54 -0800 From: Fangrui Song To: Dmitry Gutov Subject: Re: bug#29619: Fwd: [xref.el] Add `xref-find-references` to `xref-prompt-for-identifier` Message-ID: <20171211071854.qfrignlnlj57yzgl@hacking> References: <0e97609a-eefc-6e0d-ce2b-6c69651d9990@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <0e97609a-eefc-6e0d-ce2b-6c69651d9990@yandex.ru> X-PGP-Key: http://maskray.me/pubkey.asc User-Agent: NeoMutt/20170714-126-deb55f (1.8.3) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29619 Cc: 29619@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 2017-12-10, Dmitry Gutov wrote: >On 12/9/17 7:52 PM, Ray wrote: >>Thanks for being open to change the default if more people feel the same. >> >>With the xref system people use drifting from tag based >>(ctags,etags,GNU GLOBAL,cscope,...) tools to Language Server Protocol >>(cquery, rls, ...), >>a single identifier without position has become insufficient to >>describe the one the user wants to look up. For example, a local >>variable/struct/lambda `foo` may exist >>in different functions. > >That's fine, actually, and as designed. As long as the different >global identifiers can be represented uniquely as strings (but using >text properties for e.g. a local variable at point is good too). >>I'm using a C++ language server called cquery. This is what I get (for >>the argument `identifier`) when I hit the key bound to >>`xref-find-definitions`: >> >>#("QueryDatabase" 0 13 (fontified t ref-params (:textDocument (:uri >>"file:///home/maskray/Dev/Util/cquery/src/query_utils.h") :position >>(:line 11 :character 54) :context (:includeDeclaration :json-false)) >>def-params (:textDocument (:uri >>"file:///home/maskray/Dev/Util/cquery/src/query_utils.h") :position >>(:line 11 :character 54)))) >> >>Here the text properties are more useful than the identifier itself, >>because LSP uses position instead of identifier to sending requests to >>the language server. >>https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#textdocumentpositionparams > >So it doesn't actually let you choose? Only supports the identifier at >point? The identifier (if chosen from xref prompt) is ignored by Language Server Protocol and only the position information is what matters. According to https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#textDocument_references When the user wants to find a reference of an identifier, information of the following interface is sent to language servers. interface ReferenceParams extends TextDocumentPositionParams { context: ReferenceContext } TextDocumentPositionParams is the interesting one: interface TextDocumentPositionParams { textDocument: TextDocumentIdentifier; /// wrapper of filename position: Position; /// line, column; see, no identifier is used } lsp-mode provides a backend of xref generic functions. Here is how xref-find-references is implemented in lsp-mode: https://github.com/emacs-lsp/lsp-mode/blob/master/lsp-methods.el#L1425 (cl-defmethod xref-backend-references ((_backend (eql xref-lsp)) identifier) (let* ((properties (text-properties-at 0 identifier)) (params (plist-get properties 'ref-params)) (refs (lsp--send-request (lsp--make-request "textDocument/references" (or params (lsp--make-reference-params)))))) (lsp--locations-to-xref-items refs))) The `identifier` text itself is ignored and only the text properties (which encode position information) are used. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 11 05:38:42 2017 Received: (at 29619) by debbugs.gnu.org; 11 Dec 2017 10:38:42 +0000 Received: from localhost ([127.0.0.1]:56065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOLTu-00076g-FO for submit@debbugs.gnu.org; Mon, 11 Dec 2017 05:38:42 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOLTs-00076T-Hy for 29619@debbugs.gnu.org; Mon, 11 Dec 2017 05:38:40 -0500 Received: by mail-wm0-f41.google.com with SMTP id 64so13120409wme.3 for <29619@debbugs.gnu.org>; Mon, 11 Dec 2017 02:38:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=O2JMGFuifJ2RENsxvcqXSsu1T7Y4/Q+RTfVx9dJxKes=; b=RC3HiWDjZwK8ynR5agdlnLxKm5HsdguR9L1I0zLTTXt3YmRKo7aiFauqf2rMIQliBG 6ewMLjU0N6ZGd9tVfByXwtuVIVJPzpe0cSnpskZ9MzYVR/5vsabmsf8sROFUSkTYmQg/ 0JdoVicIWXRCcxD0La8q07bcj8kvEQbEc2iWdUdtDSX3KBFHGNf7JsXM+tW7ZZ7oVmWq F7gHP7pT3olLRCHaAtmVLGHAbSGIDz/YRz4GV6zqhqeJ/u51HA0fXMuvJjuWTQMqKkSX WWLwfIERShfK2NG2Oirh/SnqJGSrf4LIW+wuKXeUIVTRD2MEW846JLUGbWACQn5nRc0h 3KJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O2JMGFuifJ2RENsxvcqXSsu1T7Y4/Q+RTfVx9dJxKes=; b=h7rKdhDfjwizg3nJuQKYY8BeQJ0LKT9LYPBPcJUmMS0vvOyLFjYHoqPPN2gEXPCUmI FQgo+6XwxnMEK459lOn0qlnJdcPDi7B+kU9bng3aIebpeMmZrgwmjRC77mgorfiSvkf8 hJIuTDBhiU8aY9anAv9WSRd9SOVIDw5AaLs6Xu5pYbCMBtw8998Td5Oa2v6mzlMFRZCF MRcOk4rQs/MQELmdEaK1YhU0IHq1gnsNwOFb+30CAV83kQcRGU95XHnxc63yCJz06awO ZQ+8QljjGOEfc6BcSS/WDS+aufGQn2zXx7B9vYD1/iI0YYKM4LPKmLh3bNp/YDDQbN3r TN7w== X-Gm-Message-State: AKGB3mK+uEHZuIzDNb6pHXxlUu2Qnamb5tx92FXzJNbnXruYAhJBOYP3 4MWxxfNJdAeS/24elJkw8Q6YQx0L X-Google-Smtp-Source: ACJfBovZCmw1FQU78ZUAaDWpjlbqmf7Vq7cY94HOpHZtjnSLP+1x1dVuDaW4dmopvQWYSQsHyTpz5Q== X-Received: by 10.80.208.26 with SMTP id j26mr469149edf.109.1512988714528; Mon, 11 Dec 2017 02:38:34 -0800 (PST) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id j3sm6242052edh.55.2017.12.11.02.38.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2017 02:38:33 -0800 (PST) Subject: Re: bug#29619: Fwd: [xref.el] Add `xref-find-references` to `xref-prompt-for-identifier` To: Fangrui Song References: <0e97609a-eefc-6e0d-ce2b-6c69651d9990@yandex.ru> <20171211071854.qfrignlnlj57yzgl@hacking> From: Dmitry Gutov Message-ID: <7e523f9c-6b80-edeb-1982-33f156e3d8f4@yandex.ru> Date: Mon, 11 Dec 2017 12:38:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Thunderbird/58.0 MIME-Version: 1.0 In-Reply-To: <20171211071854.qfrignlnlj57yzgl@hacking> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29619 Cc: 29619@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 12/11/17 9:18 AM, Fangrui Song wrote: > The identifier (if chosen from xref prompt) is ignored by Language > Server Protocol and only the position information is what matters. The value is not ignored. Only its text properties are used, but that's fine. Looking at xref-backend-identifier-completion-table, it allows navigation to all (?) symbols in the "document", so the xref API seems to be used as intended. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 21 20:22:43 2018 Received: (at 29619) by debbugs.gnu.org; 22 Jan 2018 01:22:43 +0000 Received: from localhost ([127.0.0.1]:37538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edQot-0007uV-B4 for submit@debbugs.gnu.org; Sun, 21 Jan 2018 20:22:43 -0500 Received: from mail-eopbgr20139.outbound.protection.outlook.com ([40.107.2.139]:30501 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edNya-000300-IS for 29619@debbugs.gnu.org; Sun, 21 Jan 2018 17:20:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epitechfr.onmicrosoft.com; s=selector1-epitech-eu; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3gkVIRm1qi/irxOocFzfYfse0deF7CHSd0qkTEzpFyM=; b=ma62/f9IqQlBzl4QcwNzLNHMG+k4yjunCAQdWjWd8hJ8y9jk+ODSeUc5ShAqYGve01U1CVlfef/WEzgNsBamSMgOZvRQc9hE8nVGWG97GOzlKPzbIjGGAZC7ffJG2CUOelZnoU/ljiIfI+3B2s783hC+vO6W6H4Z5OqXOhQlL/U= Received: from HE1PR02MB1195.eurprd02.prod.outlook.com (10.163.173.153) by HE1PR02MB1194.eurprd02.prod.outlook.com (10.163.173.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Sun, 21 Jan 2018 22:20:24 +0000 Received: from HE1PR02MB1195.eurprd02.prod.outlook.com ([fe80::c5ca:d774:c190:b66c]) by HE1PR02MB1195.eurprd02.prod.outlook.com ([fe80::c5ca:d774:c190:b66c%13]) with mapi id 15.20.0428.019; Sun, 21 Jan 2018 22:20:24 +0000 From: guillaume papin To: "29619@debbugs.gnu.org" <29619@debbugs.gnu.org>, "dgutov@yandex.ru" Subject: Re: bug#29619: Fwd: [xref.el] Add `xref-find-references` to `xref-prompt-for-identifier` Thread-Topic: bug#29619: Fwd: [xref.el] Add `xref-find-references` to `xref-prompt-for-identifier` Thread-Index: AQHTkwSVlkEqS4CZ0EWN1q73fKutNA== Date: Sun, 21 Jan 2018 22:20:24 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=guillaume.papin@epitech.eu; x-originating-ip: [85.68.71.246] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR02MB1194; 7:KM7mBYztj/W9DJ4pUlRbNhbgfPsEKJIIvyOdEVLM6SmnbMnZdqIxXmbznnXQLnjd0ntZDYpJE8gF4jfLaH3HJ9pFO4Br2+hJR7El4ACF9CIHtYlCdn5gjwylevaTt5rf8SZXjDitfrfXmMtdmgMi+5O9uDl+nTBSNRuBPrIU4w1SiaCRvuEn1zzHtZzJaYfStJX/R21eR9EJ4OCLKWfWag8RAIa3+pxhwEpQqrYIP61PtEe6Jcp+0IFhSUo43LFV x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 4befc3de-0923-4f1f-3198-08d5611d2ace x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:HE1PR02MB1194; x-ms-traffictypediagnostic: HE1PR02MB1194: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(93006095)(93001095)(3002001)(10201501046)(6041288)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR02MB1194; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR02MB1194; x-forefront-prvs: 0559FB9674 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(366004)(376002)(39850400004)(396003)(39380400002)(189003)(199004)(53546011)(229853002)(68736007)(3846002)(6116002)(102836004)(6506007)(7696005)(786003)(6436002)(66066001)(55016002)(26005)(86152003)(230783001)(9686003)(2900100001)(97736004)(8936002)(99286004)(74482002)(8676002)(305945005)(53936002)(81166006)(81156014)(7736002)(2906002)(86362001)(33656002)(74316002)(478600001)(5250100002)(110136005)(39060400002)(2501003)(4326008)(14454004)(3280700002)(105586002)(316002)(25786009)(5660300001)(106356001)(3660700001)(6246003)(345774005)(81973001); DIR:OUT; SFP:1102; SCL:1; SRVR:HE1PR02MB1194; H:HE1PR02MB1195.eurprd02.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: epitech.eu does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8yp7ezCzxaluuHAsGP2Db9l/iM9FEm3Bq3qJIvpLsV/8NdZ/eklZ8XdI6kd8MQBWkl6LadpRuyJSA8Wrx5laEw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epitech.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 4befc3de-0923-4f1f-3198-08d5611d2ace X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2018 22:20:24.0707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 901cb4ca-b862-4029-9306-e5cd0f6d9f86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR02MB1194 X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 29619 X-Mailman-Approved-At: Sun, 21 Jan 2018 20:22:41 -0500 Cc: "emacsray@gmail.com" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2017/12/09 5:25 PM, Dmitry Gutov wrote: > On 12/8/17 11:27 PM, Ray wrote: > > Currently, xref-find-references prompts for the identifier to look up, > > because it is not listed in xref-prompt-for-identifier: > >=A0 > > (defcustom xref-prompt-for-identifier '(not xref-find-definitions > >=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 xref-find-definitions-other-window > >=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 xref-find-definitions-other-frame) > >=A0 > > It will be much core convenient to add xref-find-references in the list= . >=A0 > We've discussed it before, and for now have settled on this list of=A0 > non-prompting functions. >=A0 > But thank you for your report. We may change the default if more people= =A0 > feel the same. Just wanted to chime in to say that I feel the same as Ray. The commands already have related keybindings, M-. and M-?. I would find it more intuitive, if they also had similar behaviors.= From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 23 17:01:32 2019 Received: (at control) by debbugs.gnu.org; 23 Sep 2019 21:01:32 +0000 Received: from localhost ([127.0.0.1]:37169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCVSe-0007tS-4I for submit@debbugs.gnu.org; Mon, 23 Sep 2019 17:01:32 -0400 Received: from quimby.gnus.org ([80.91.231.51]:45448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCVSc-0007tK-NM for control@debbugs.gnu.org; Mon, 23 Sep 2019 17:01:31 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCVSZ-0003a4-8H for control@debbugs.gnu.org; Mon, 23 Sep 2019 23:01:29 +0200 Date: Mon, 23 Sep 2019 23:01:26 +0200 Message-Id: <875zliwwux.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #29619 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 29619 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 29619 quit From unknown Sat Aug 16 16:06:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 22 Oct 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator